* [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
@ 2019-04-03 6:22 Aditya Swarup
2019-04-03 7:01 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3) Patchwork
` (14 more replies)
0 siblings, 15 replies; 29+ messages in thread
From: Aditya Swarup @ 2019-04-03 6:22 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
From: Clinton Taylor <Clinton.A.Taylor@intel.com>
v2: Fix commit msg to reflect why issue occurs(Jani)
Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
doesn't work correctly using xrandr max bpc property. When we
connect a monitor which supports deep color, the highest deep color
setting is selected; which sets GCP_COLOR_INDICATION. When we change
the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
doesn't allow the switch back to 8 bit color.
v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
Drop the changes in intel_hdmi_compute_config as desired_bpp
is needed to change values for pipe_bpp based on bw_constrained flag.
v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
---
I tested the patch and there is still a bug in setting 10 bit deep
color mode. I am unable to set 10 bit color from xrandr from 12 bit
deep color or 8 bit.
drivers/gpu/drm/i915/intel_hdmi.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 5ccb305a6e1c..d550653ad29f 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -962,8 +962,12 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
crtc_state->infoframes.enable |=
intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
- /* Indicate color depth whenever the sink supports deep color */
- if (hdmi_sink_is_deep_color(conn_state))
+ /* Indicate color depth whenever the sink supports deep color
+ * Also, 8bpc + color depth indication is no longer supported
+ * for HSW+ platforms.
+ * */
+ if (hdmi_sink_is_deep_color(conn_state) &&
+ crtc_state->pipe_bpp > 24)
crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
/* Enable default_phase whenever the display mode is suitably aligned */
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 29+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
@ 2019-04-03 7:01 ` Patchwork
2019-04-03 7:33 ` ✓ Fi.CI.BAT: success " Patchwork
` (13 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-03 7:01 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3)
URL : https://patchwork.freedesktop.org/series/58912/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
464216adb294 drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
-:47: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#47: FILE: drivers/gpu/drm/i915/intel_hdmi.c:968:
+ * */
total: 0 errors, 1 warnings, 0 checks, 14 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
2019-04-03 7:01 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3) Patchwork
@ 2019-04-03 7:33 ` Patchwork
2019-04-03 20:44 ` ✓ Fi.CI.IGT: " Patchwork
` (12 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-03 7:33 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3)
URL : https://patchwork.freedesktop.org/series/58912/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5860 -> Patchwork_12669
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58912/revisions/3/mbox/
Known issues
------------
Here are the changes found in Patchwork_12669 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_workarounds@basic-read:
- fi-snb-2600: NOTRUN -> SKIP [fdo#109271] +57
* igt@i915_selftest@live_contexts:
- fi-icl-y: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-snb-2600: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@vga-edid-read:
- fi-hsw-4770r: NOTRUN -> SKIP [fdo#109271] +45
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] +1
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_module_load@reload:
- fi-icl-y: INCOMPLETE [fdo#107713] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: INCOMPLETE [fdo#108569] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
Participating hosts (46 -> 41)
------------------------------
Additional (2): fi-hsw-4770r fi-snb-2600
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-kbl-guc fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5860 -> Patchwork_12669
CI_DRM_5860: 837ba3cd997b59e53903ba29f4fe65c81f86f1e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4923: 6285eec4f3b8f21833d9d2d852883569d6551822 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12669: 464216adb29404090c53b7f8f39e2c511eb4e3dd @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
464216adb294 drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12669/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
2019-04-03 7:01 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3) Patchwork
2019-04-03 7:33 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-04-03 20:44 ` Patchwork
2019-04-04 20:37 ` [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Ville Syrjälä
` (11 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-03 20:44 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3)
URL : https://patchwork.freedesktop.org/series/58912/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5860_full -> Patchwork_12669_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12669_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-clear:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_ctx_param@set-priority-not-supported:
- shard-iclb: NOTRUN -> SKIP [fdo#109314]
* igt@gem_exec_parallel@bsd2-fds:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +16
* igt@gem_stolen@stolen-clear:
- shard-iclb: NOTRUN -> SKIP [fdo#109277] +3
* igt@gem_userptr_blits@coherency-unsync:
- shard-iclb: NOTRUN -> SKIP [fdo#109290] +1
* igt@i915_pm_backlight@fade_with_suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107847]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> SKIP [fdo#109506]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_pm_rpm@pm-tiling:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]
* igt@i915_pm_rpm@reg-read-ioctl:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#107807] +1
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> SKIP [fdo#109288]
* igt@kms_atomic_transition@6x-modeset-transitions-fencing:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-hang-newfb-render-e:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +7
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +12
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +4
* igt@kms_color@pipe-b-degamma:
- shard-iclb: NOTRUN -> FAIL [fdo#104782]
* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> SKIP [fdo#109300]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-512x512-onscreen:
- shard-iclb: NOTRUN -> SKIP [fdo#109279] +1
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +6
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-iclb: PASS -> FAIL [fdo#103355]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: PASS -> FAIL [fdo#102670]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +24
* igt@kms_flip@flip-vs-suspend:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#109507]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +101
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +111
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +5
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +23
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#106978]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- shard-iclb: PASS -> FAIL [fdo#109247] +1
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: NOTRUN -> FAIL [fdo#109247] +1
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +21
* igt@kms_lease@cursor_implicit_plane:
- shard-skl: NOTRUN -> FAIL [fdo#110278]
* igt@kms_lease@setcrtc_implicit_plane:
- shard-iclb: NOTRUN -> FAIL [fdo#110281]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +13
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_psr@primary_mmap_cpu:
- shard-iclb: NOTRUN -> FAIL [fdo#107383] / [fdo#110215] +1
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> SKIP [fdo#109441] +3
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_psr@sprite_mmap_gtt:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +1
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_tv_load_detect@load-detect:
- shard-iclb: NOTRUN -> SKIP [fdo#109309]
* igt@kms_vrr@flip-basic:
- shard-iclb: NOTRUN -> SKIP [fdo#109502]
* igt@prime_nv_pcopy@test3_3:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +3
#### Possible fixes ####
* igt@gem_create@create-clear:
- shard-iclb: INCOMPLETE [fdo#109100] -> PASS
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-iclb: INCOMPLETE [fdo#109801] -> PASS
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: SKIP [fdo#109271] -> PASS
* igt@i915_pm_rpm@gem-mmap-cpu:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-iclb: FAIL [fdo#103355] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: FAIL [fdo#105363] -> PASS
* igt@kms_flip@flip-vs-suspend:
- shard-iclb: INCOMPLETE [fdo#109507] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- shard-iclb: FAIL [fdo#103167] -> PASS +6
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-iclb: FAIL [fdo#109247] -> PASS +15
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: FAIL [fdo#108145] -> PASS
* igt@kms_psr@cursor_render:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +2
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109288]: https://bugs.freedesktop.org/show_bug.cgi?id=109288
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-hsw
Build changes
-------------
* Linux: CI_DRM_5860 -> Patchwork_12669
CI_DRM_5860: 837ba3cd997b59e53903ba29f4fe65c81f86f1e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4923: 6285eec4f3b8f21833d9d2d852883569d6551822 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12669: 464216adb29404090c53b7f8f39e2c511eb4e3dd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12669/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (2 preceding siblings ...)
2019-04-03 20:44 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-04-04 20:37 ` Ville Syrjälä
2019-04-04 20:40 ` Ville Syrjälä
` (10 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Ville Syrjälä @ 2019-04-04 20:37 UTC (permalink / raw)
To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx
On Tue, Apr 02, 2019 at 11:22:22PM -0700, Aditya Swarup wrote:
> From: Clinton Taylor <Clinton.A.Taylor@intel.com>
>
> v2: Fix commit msg to reflect why issue occurs(Jani)
> Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>
> Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> doesn't work correctly using xrandr max bpc property. When we
> connect a monitor which supports deep color, the highest deep color
> setting is selected; which sets GCP_COLOR_INDICATION. When we change
> the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> doesn't allow the switch back to 8 bit color.
>
> v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>
> Drop the changes in intel_hdmi_compute_config as desired_bpp
> is needed to change values for pipe_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> ---
> I tested the patch and there is still a bug in setting 10 bit deep
> color mode. I am unable to set 10 bit color from xrandr from 12 bit
> deep color or 8 bit.
Hmm. Does
@@ -2161,7 +2161,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
return false;
- if (crtc_state->pipe_bpp <= 8*3)
+ if (crtc_state->pipe_bpp < bpc*3)
return false;
if (!crtc_state->has_hdmi_sink)
help?
> drivers/gpu/drm/i915/intel_hdmi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 5ccb305a6e1c..d550653ad29f 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -962,8 +962,12 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>
> - /* Indicate color depth whenever the sink supports deep color */
> - if (hdmi_sink_is_deep_color(conn_state))
> + /* Indicate color depth whenever the sink supports deep color
> + * Also, 8bpc + color depth indication is no longer supported
> + * for HSW+ platforms.
> + * */
> + if (hdmi_sink_is_deep_color(conn_state) &&
> + crtc_state->pipe_bpp > 24)
> crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
>
> /* Enable default_phase whenever the display mode is suitably aligned */
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (3 preceding siblings ...)
2019-04-04 20:37 ` [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Ville Syrjälä
@ 2019-04-04 20:40 ` Ville Syrjälä
2019-04-05 5:55 ` [PATCH v6] " Aditya Swarup
` (9 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Ville Syrjälä @ 2019-04-04 20:40 UTC (permalink / raw)
To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx
On Tue, Apr 02, 2019 at 11:22:22PM -0700, Aditya Swarup wrote:
> From: Clinton Taylor <Clinton.A.Taylor@intel.com>
>
> v2: Fix commit msg to reflect why issue occurs(Jani)
> Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>
> Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> doesn't work correctly using xrandr max bpc property. When we
> connect a monitor which supports deep color, the highest deep color
> setting is selected; which sets GCP_COLOR_INDICATION. When we change
> the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> doesn't allow the switch back to 8 bit color.
>
> v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>
> Drop the changes in intel_hdmi_compute_config as desired_bpp
> is needed to change values for pipe_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> ---
> I tested the patch and there is still a bug in setting 10 bit deep
> color mode. I am unable to set 10 bit color from xrandr from 12 bit
> deep color or 8 bit.
> drivers/gpu/drm/i915/intel_hdmi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 5ccb305a6e1c..d550653ad29f 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -962,8 +962,12 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>
> - /* Indicate color depth whenever the sink supports deep color */
> - if (hdmi_sink_is_deep_color(conn_state))
> + /* Indicate color depth whenever the sink supports deep color
> + * Also, 8bpc + color depth indication is no longer supported
> + * for HSW+ platforms.
> + * */
Comment formatting is off. It should be
/*
* blah
*/
> + if (hdmi_sink_is_deep_color(conn_state) &&
> + crtc_state->pipe_bpp > 24)
I think this would fit on one line?
With those adjusted this is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
>
> /* Enable default_phase whenever the display mode is suitably aligned */
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v6] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (4 preceding siblings ...)
2019-04-04 20:40 ` Ville Syrjälä
@ 2019-04-05 5:55 ` Aditya Swarup
2019-04-05 16:34 ` Clinton Taylor
2019-04-05 6:46 ` ✗ Fi.CI.BAT: failure for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4) Patchwork
` (8 subsequent siblings)
14 siblings, 1 reply; 29+ messages in thread
From: Aditya Swarup @ 2019-04-05 5:55 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
From: Clinton Taylor <Clinton.A.Taylor@intel.com>
v2: Fix commit msg to reflect why issue occurs(Jani)
Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
doesn't work correctly using xrandr max bpc property. When we
connect a monitor which supports deep color, the highest deep color
setting is selected; which sets GCP_COLOR_INDICATION. When we change
the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
doesn't allow the switch back to 8 bit color.
v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
Drop the changes in intel_hdmi_compute_config as desired_bpp
is needed to change values for pipe_bpp based on bw_constrained flag.
v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
v6: Fix comment formatting (Ville)
Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 5ccb305a6e1c..f2c0aba4371b 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
crtc_state->infoframes.enable |=
intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
- /* Indicate color depth whenever the sink supports deep color */
- if (hdmi_sink_is_deep_color(conn_state))
+ /* Indicate color depth whenever the sink supports deep color
+ * Also, 8bpc + color depth indication is no longer supported
+ * for HSW+ platforms.
+ */
+ if (hdmi_sink_is_deep_color(conn_state) && crtc_state->pipe_bpp > 24)
crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
/* Enable default_phase whenever the display mode is suitably aligned */
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 29+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (5 preceding siblings ...)
2019-04-05 5:55 ` [PATCH v6] " Aditya Swarup
@ 2019-04-05 6:46 ` Patchwork
2019-04-05 20:49 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (7 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-05 6:46 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4)
URL : https://patchwork.freedesktop.org/series/58912/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5877 -> Patchwork_12690
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12690 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_12690, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58912/revisions/4/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12690:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_basic@basic-blt:
- fi-icl-y: PASS -> INCOMPLETE
#### Warnings ####
* igt@gem_exec_basic@basic-bsd2:
- fi-icl-u2: SKIP [fdo#109276] -> INCOMPLETE
Known issues
------------
Here are the changes found in Patchwork_12690 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_chamelium@dp-hpd-fast:
- fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +41
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_psr@primary_mmap_gtt:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +27
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS
* igt@i915_selftest@live_uncore:
- fi-ivb-3770: DMESG-FAIL [fdo#110210] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u3}: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (48 -> 43)
------------------------------
Additional (2): fi-skl-6700k2 fi-bsw-n3050
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-gdg-551
Build changes
-------------
* Linux: CI_DRM_5877 -> Patchwork_12690
CI_DRM_5877: 03f3a57c6df4ef469bd9f528bb9e0201ddd0ee14 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4929: 8770e24fe4008404da769c16b7edac6142225ad7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12690: 60d5140f5e4b20070ba719039aeb11d18c158079 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
60d5140f5e4b drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12690/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-05 5:55 ` [PATCH v6] " Aditya Swarup
@ 2019-04-05 16:34 ` Clinton Taylor
2019-04-08 16:49 ` Ville Syrjälä
0 siblings, 1 reply; 29+ messages in thread
From: Clinton Taylor @ 2019-04-05 16:34 UTC (permalink / raw)
To: Aditya Swarup, intel-gfx; +Cc: Jani Nikula
What happened to the reset of the patch?
-Clint
On 4/4/19 10:55 PM, Aditya Swarup wrote:
> From: Clinton Taylor <Clinton.A.Taylor@intel.com>
>
> v2: Fix commit msg to reflect why issue occurs(Jani)
> Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>
> Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> doesn't work correctly using xrandr max bpc property. When we
> connect a monitor which supports deep color, the highest deep color
> setting is selected; which sets GCP_COLOR_INDICATION. When we change
> the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> doesn't allow the switch back to 8 bit color.
>
> v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>
> Drop the changes in intel_hdmi_compute_config as desired_bpp
> is needed to change values for pipe_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> v6: Fix comment formatting (Ville)
>
> Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 5ccb305a6e1c..f2c0aba4371b 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>
> - /* Indicate color depth whenever the sink supports deep color */
> - if (hdmi_sink_is_deep_color(conn_state))
> + /* Indicate color depth whenever the sink supports deep color
> + * Also, 8bpc + color depth indication is no longer supported
> + * for HSW+ platforms.
> + */
> + if (hdmi_sink_is_deep_color(conn_state) && crtc_state->pipe_bpp > 24)
> crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
>
> /* Enable default_phase whenever the display mode is suitably aligned */
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (6 preceding siblings ...)
2019-04-05 6:46 ` ✗ Fi.CI.BAT: failure for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4) Patchwork
@ 2019-04-05 20:49 ` Aditya Swarup
2019-04-05 22:29 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev5) Patchwork
` (6 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Aditya Swarup @ 2019-04-05 20:49 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
From: Clinton Taylor <Clinton.A.Taylor@intel.com>
v2: Fix commit msg to reflect why issue occurs(Jani)
Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
doesn't work correctly using xrandr max bpc property. When we
connect a monitor which supports deep color, the highest deep color
setting is selected; which sets GCP_COLOR_INDICATION. When we change
the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
doesn't allow the switch back to 8 bit color.
v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
Drop the changes in intel_hdmi_compute_config as desired_bpp
is needed to change values for pipe_bpp based on bw_constrained flag.
v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
v6: Fix comment formatting (Ville)
v7: Add reviewed by Ville
Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Reviewed by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 5ccb305a6e1c..f2c0aba4371b 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
crtc_state->infoframes.enable |=
intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
- /* Indicate color depth whenever the sink supports deep color */
- if (hdmi_sink_is_deep_color(conn_state))
+ /* Indicate color depth whenever the sink supports deep color
+ * Also, 8bpc + color depth indication is no longer supported
+ * for HSW+ platforms.
+ */
+ if (hdmi_sink_is_deep_color(conn_state) && crtc_state->pipe_bpp > 24)
crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
/* Enable default_phase whenever the display mode is suitably aligned */
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 29+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev5)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (7 preceding siblings ...)
2019-04-05 20:49 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
@ 2019-04-05 22:29 ` Patchwork
2019-04-06 3:36 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (5 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-05 22:29 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev5)
URL : https://patchwork.freedesktop.org/series/58912/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5882 -> Patchwork_12710
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58912/revisions/5/mbox/
Known issues
------------
Here are the changes found in Patchwork_12710 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: DMESG-WARN [fdo#105541] -> PASS
- {fi-icl-u3}: DMESG-WARN [fdo#107724] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-y: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (50 -> 42)
------------------------------
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-bxt-dsi fi-bsw-n3050 fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5882 -> Patchwork_12710
CI_DRM_5882: 012535789c9c890854cd1e0fb926f44931a82a63 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12710: 5a0b649c0c1b986d96001391067ca956101a4de1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5a0b649c0c1b drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12710/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (8 preceding siblings ...)
2019-04-05 22:29 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev5) Patchwork
@ 2019-04-06 3:36 ` Aditya Swarup
2019-04-17 9:57 ` Jani Nikula
` (2 more replies)
2019-04-06 4:08 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev6) Patchwork
` (4 subsequent siblings)
14 siblings, 3 replies; 29+ messages in thread
From: Aditya Swarup @ 2019-04-06 3:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
From: Clinton Taylor <Clinton.A.Taylor@intel.com>
v2: Fix commit msg to reflect why issue occurs(Jani)
Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
doesn't work correctly using xrandr max bpc property. When we
connect a monitor which supports deep color, the highest deep color
setting is selected; which sets GCP_COLOR_INDICATION. When we change
the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
doesn't allow the switch back to 8 bit color.
v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
Drop the changes in intel_hdmi_compute_config as desired_bpp
is needed to change values for pipe_bpp based on bw_constrained flag.
v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
v6: Fix comment formatting (Ville)
v7: Add reviewed by Ville
Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 5ccb305a6e1c..f2c0aba4371b 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
crtc_state->infoframes.enable |=
intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
- /* Indicate color depth whenever the sink supports deep color */
- if (hdmi_sink_is_deep_color(conn_state))
+ /* Indicate color depth whenever the sink supports deep color
+ * Also, 8bpc + color depth indication is no longer supported
+ * for HSW+ platforms.
+ */
+ if (hdmi_sink_is_deep_color(conn_state) && crtc_state->pipe_bpp > 24)
crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
/* Enable default_phase whenever the display mode is suitably aligned */
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 29+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev6)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (9 preceding siblings ...)
2019-04-06 3:36 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
@ 2019-04-06 4:08 ` Patchwork
2019-04-07 3:42 ` ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-06 4:08 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev6)
URL : https://patchwork.freedesktop.org/series/58912/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5882 -> Patchwork_12714
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58912/revisions/6/mbox/
Known issues
------------
Here are the changes found in Patchwork_12714 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: DMESG-WARN [fdo#105541] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (50 -> 43)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-bdw-samus fi-skl-6600u
Build changes
-------------
* Linux: CI_DRM_5882 -> Patchwork_12714
CI_DRM_5882: 012535789c9c890854cd1e0fb926f44931a82a63 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12714: 7cd65eb92748876c63482c2e2af23e347c22f6c8 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7cd65eb92748 drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12714/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev6)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (10 preceding siblings ...)
2019-04-06 4:08 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev6) Patchwork
@ 2019-04-07 3:42 ` Patchwork
2019-04-26 1:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7) Patchwork
` (2 subsequent siblings)
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-07 3:42 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev6)
URL : https://patchwork.freedesktop.org/series/58912/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5882_full -> Patchwork_12714_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12714_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@bsd1:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +115
* igt@gem_tiled_fence_blits@normal:
- shard-iclb: PASS -> TIMEOUT [fdo#109673]
* igt@i915_selftest@live_workarounds:
- shard-iclb: PASS -> DMESG-FAIL [fdo#108954]
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +12
* igt@kms_atomic_transition@3x-modeset-transitions-fencing:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +19
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#110222] +1
* igt@kms_fbcon_fbt@fbc:
- shard-iclb: PASS -> DMESG-WARN [fdo#109593]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-render:
- shard-skl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
- shard-iclb: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-render:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-iclb: PASS -> FAIL [fdo#109247] +17
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +77
* igt@kms_lease@setcrtc_implicit_plane:
- shard-skl: NOTRUN -> FAIL [fdo#110281]
* igt@kms_panel_fitting@legacy:
- shard-skl: NOTRUN -> FAIL [fdo#105456]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_psr@dpms:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +1
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: PASS -> SKIP [fdo#109441] +4
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@runner@aborted:
- shard-iclb: NOTRUN -> FAIL [fdo#109593]
#### Possible fixes ####
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-iclb: FAIL [fdo#103375] -> PASS +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#106509] / [fdo#107409] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: FAIL [fdo#103167] -> PASS +6
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-pwrite:
- shard-iclb: FAIL [fdo#105682] / [fdo#109247] -> PASS
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#109247] -> PASS +18
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS +1
* igt@kms_psr@psr2_dpms:
- shard-iclb: SKIP [fdo#109441] -> PASS +1
* igt@kms_psr@sprite_mmap_cpu:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +1
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@perf@polling:
- shard-iclb: FAIL [fdo#108587] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- shard-iclb: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: SKIP [fdo#109349] -> FAIL [fdo#110270]
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105456]: https://bugs.freedesktop.org/show_bug.cgi?id=105456
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108587]: https://bugs.freedesktop.org/show_bug.cgi?id=108587
[fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110270]: https://bugs.freedesktop.org/show_bug.cgi?id=110270
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-hsw
Build changes
-------------
* Linux: CI_DRM_5882 -> Patchwork_12714
CI_DRM_5882: 012535789c9c890854cd1e0fb926f44931a82a63 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12714: 7cd65eb92748876c63482c2e2af23e347c22f6c8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12714/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-05 16:34 ` Clinton Taylor
@ 2019-04-08 16:49 ` Ville Syrjälä
0 siblings, 0 replies; 29+ messages in thread
From: Ville Syrjälä @ 2019-04-08 16:49 UTC (permalink / raw)
To: Clinton Taylor; +Cc: Jani Nikula, intel-gfx
On Fri, Apr 05, 2019 at 09:34:42AM -0700, Clinton Taylor wrote:
> What happened to the reset of the patch?
It should have been a separate patch. Also I think this [1] oneliner
might be all we need.
[1] https://lists.freedesktop.org/archives/intel-gfx/2019-April/194708.html
>
> -Clint
>
>
> On 4/4/19 10:55 PM, Aditya Swarup wrote:
> > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> >
> > v2: Fix commit msg to reflect why issue occurs(Jani)
> > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> >
> > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > doesn't work correctly using xrandr max bpc property. When we
> > connect a monitor which supports deep color, the highest deep color
> > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > doesn't allow the switch back to 8 bit color.
> >
> > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> >
> > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > is needed to change values for pipe_bpp based on bw_constrained flag.
> >
> > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> >
> > v6: Fix comment formatting (Ville)
> >
> > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index 5ccb305a6e1c..f2c0aba4371b 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > crtc_state->infoframes.enable |=
> > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> >
> > - /* Indicate color depth whenever the sink supports deep color */
> > - if (hdmi_sink_is_deep_color(conn_state))
> > + /* Indicate color depth whenever the sink supports deep color
> > + * Also, 8bpc + color depth indication is no longer supported
> > + * for HSW+ platforms.
> > + */
> > + if (hdmi_sink_is_deep_color(conn_state) && crtc_state->pipe_bpp > 24)
> > crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> >
> > /* Enable default_phase whenever the display mode is suitably aligned */
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-06 3:36 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
@ 2019-04-17 9:57 ` Jani Nikula
2019-04-25 20:44 ` Aditya Swarup
2019-04-26 1:19 ` [PATCH v8] " Aditya Swarup
2 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2019-04-17 9:57 UTC (permalink / raw)
To: Aditya Swarup, intel-gfx
On Fri, 05 Apr 2019, Aditya Swarup <aditya.swarup@intel.com> wrote:
> From: Clinton Taylor <Clinton.A.Taylor@intel.com>
>
> v2: Fix commit msg to reflect why issue occurs(Jani)
> Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>
> Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> doesn't work correctly using xrandr max bpc property. When we
> connect a monitor which supports deep color, the highest deep color
> setting is selected; which sets GCP_COLOR_INDICATION. When we change
> the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> doesn't allow the switch back to 8 bit color.
>
> v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>
> Drop the changes in intel_hdmi_compute_config as desired_bpp
> is needed to change values for pipe_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> v6: Fix comment formatting (Ville)
>
> v7: Add reviewed by Ville
>
> Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 5ccb305a6e1c..f2c0aba4371b 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>
> - /* Indicate color depth whenever the sink supports deep color */
> - if (hdmi_sink_is_deep_color(conn_state))
> + /* Indicate color depth whenever the sink supports deep color
> + * Also, 8bpc + color depth indication is no longer supported
> + * for HSW+ platforms.
> + */
Frankly the comment confuses me as the condition has nothing to do with
HSW+ and applies for pre-HSW as well. And the "whenever" in the first
line is no longer true.
I do understand the point here, we don't need to use color indication
when we're not using deep color anyway, and moreover this combo isn't
supported on HSW+.
The final question is, under what circumstances would we use pipe_bpp >
24 when the sink does *not* support bpc > 8?
IOW, could we simply use
if (crtc_state->pipe_bpp > 24)
here?
BR,
Jani.
> + if (hdmi_sink_is_deep_color(conn_state) && crtc_state->pipe_bpp > 24)
> crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
>
> /* Enable default_phase whenever the display mode is suitably aligned */
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-06 3:36 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
2019-04-17 9:57 ` Jani Nikula
@ 2019-04-25 20:44 ` Aditya Swarup
2019-04-26 10:12 ` Ville Syrjälä
2019-04-26 1:19 ` [PATCH v8] " Aditya Swarup
2 siblings, 1 reply; 29+ messages in thread
From: Aditya Swarup @ 2019-04-25 20:44 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Apr 17, 2019 at 12:57:44PM +0300, Jani Nikula wrote:
> On Fri, 05 Apr 2019, Aditya Swarup <aditya.swarup@intel.com> wrote:
> > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> >
> > v2: Fix commit msg to reflect why issue occurs(Jani)
> > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> >
> > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > doesn't work correctly using xrandr max bpc property. When we
> > connect a monitor which supports deep color, the highest deep color
> > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > doesn't allow the switch back to 8 bit color.
> >
> > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> >
> > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > is needed to change values for pipe_bpp based on bw_constrained flag.
> >
> > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> >
> > v6: Fix comment formatting (Ville)
> >
> > v7: Add reviewed by Ville
> >
> > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index 5ccb305a6e1c..f2c0aba4371b 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > crtc_state->infoframes.enable |=
> > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> >
> > - /* Indicate color depth whenever the sink supports deep color */
> > - if (hdmi_sink_is_deep_color(conn_state))
> > + /* Indicate color depth whenever the sink supports deep color
> > + * Also, 8bpc + color depth indication is no longer supported
> > + * for HSW+ platforms.
> > + */
>
> Frankly the comment confuses me as the condition has nothing to do with
> HSW+ and applies for pre-HSW as well. And the "whenever" in the first
> line is no longer true.
You are correct, Clint and me spent time investigating this Spec/HW
monstrosity for the correct conditions required for sending
GCP_COLOR_INDICATION.
>
> I do understand the point here, we don't need to use color indication
> when we're not using deep color anyway, and moreover this combo isn't
> supported on HSW+.
>
> The final question is, under what circumstances would we use pipe_bpp >
> 24 when the sink does *not* support bpc > 8?
>
> IOW, could we simply use
>
> if (crtc_state->pipe_bpp > 24)
>
> here?
No we do need the check for sink, as that is the real check for
determining whether sink supports deep color or not. For some platforms,
we do send GCP_COLOR_INDICATION even for 8 bpc when the sink supports
deep color. This will be clear with the next version of the patch.
>
>
> BR,
> Jani.
>
>
> > + if (hdmi_sink_is_deep_color(conn_state) && crtc_state->pipe_bpp > 24)
> > crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> >
> > /* Enable default_phase whenever the display mode is suitably aligned */
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-06 3:36 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
2019-04-17 9:57 ` Jani Nikula
2019-04-25 20:44 ` Aditya Swarup
@ 2019-04-26 1:19 ` Aditya Swarup
2019-04-26 10:14 ` Ville Syrjälä
` (2 more replies)
2 siblings, 3 replies; 29+ messages in thread
From: Aditya Swarup @ 2019-04-26 1:19 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
From: Clinton Taylor <Clinton.A.Taylor@intel.com>
v2: Fix commit msg to reflect why issue occurs(Jani)
Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
doesn't work correctly using xrandr max bpc property. When we
connect a monitor which supports deep color, the highest deep color
setting is selected; which sets GCP_COLOR_INDICATION. When we change
the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
doesn't allow the switch back to 8 bit color.
v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
Drop the changes in intel_hdmi_compute_config as desired_bpp
is needed to change values for pipe_bpp based on bw_constrained flag.
v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
v6: Fix comment formatting (Ville)
v7: Add reviewed by Ville
v8: Set GCP_COLOR_INDICATION based on spec:
For Gen 7.5 or later platforms, indicate color depth only for deep
color modes. Bspec: 8135,7751,50524
Pre DDI platforms, indicate color depth if deep color is supported
by sink. Bspec: 7854
Exception: CHERRYVIEW behaves like Pre DDI platforms.
Bspec: 15975
Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
to not set 12 bit deep color for every modeset. This fixes the issue
where 12 bit color was selected even when user selected 10 bit.(Ville)
Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index e1005d7b75fd..620bc89e2120 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -973,9 +973,18 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
crtc_state->infoframes.enable |=
intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
- /* Indicate color depth whenever the sink supports deep color */
- if (hdmi_sink_is_deep_color(conn_state))
- crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
+ /* Indicate color depth whenever the sink supports deep color:
+ * For Gen 7.5 or later platforms, indicate color depth only for deep
+ * color modes.
+ * Pre DDI platforms, indicate color depth if deep color is supported
+ * by sink.
+ * Exception: CHERRYVIEW behaves like Pre DDI platforms.
+ */
+ if (hdmi_sink_is_deep_color(conn_state)) {
+ if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
+ crtc_state->pipe_bpp > 24)
+ crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
+ }
/* Enable default_phase whenever the display mode is suitably aligned */
if (gcp_default_phase_possible(crtc_state->pipe_bpp,
@@ -2172,7 +2181,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
return false;
- if (crtc_state->pipe_bpp <= 8*3)
+ if (crtc_state->pipe_bpp < bpc*3)
return false;
if (!crtc_state->has_hdmi_sink)
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 29+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (11 preceding siblings ...)
2019-04-07 3:42 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-04-26 1:33 ` Patchwork
2019-04-26 1:52 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-26 12:13 ` ✗ Fi.CI.IGT: failure " Patchwork
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-26 1:33 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7)
URL : https://patchwork.freedesktop.org/series/58912/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
40c9882274e6 drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
-:46: WARNING:BAD_SIGN_OFF: 'Co-developed-by:' is the preferred signature form
#46:
Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
-:47: WARNING:BAD_SIGN_OFF: 'Co-developed-by:' is the preferred signature form
#47:
Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
-:74: ERROR:SPACING: space required before the open parenthesis '('
#74: FILE: drivers/gpu/drm/i915/intel_hdmi.c:984:
+ if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
-:86: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#86: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2184:
+ if (crtc_state->pipe_bpp < bpc*3)
^
total: 1 errors, 2 warnings, 1 checks, 29 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (12 preceding siblings ...)
2019-04-26 1:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7) Patchwork
@ 2019-04-26 1:52 ` Patchwork
2019-04-26 12:13 ` ✗ Fi.CI.IGT: failure " Patchwork
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-26 1:52 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7)
URL : https://patchwork.freedesktop.org/series/58912/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6001 -> Patchwork_12881
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58912/revisions/7/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12881:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_chamelium@dp-hpd-fast:
- {fi-icl-u2}: NOTRUN -> [FAIL][1] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/fi-icl-u2/igt@kms_chamelium@dp-hpd-fast.html
Known issues
------------
Here are the changes found in Patchwork_12881 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][2] -> [DMESG-FAIL][3] ([fdo#110235 ])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][4] ([fdo#107718]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [DMESG-FAIL][6] ([fdo#110235 ]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (33 -> 31)
------------------------------
Additional (5): fi-byt-j1900 fi-icl-u2 fi-bwr-2160 fi-kbl-8809g fi-kbl-r
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-apl-guc fi-ctg-p8600 fi-kbl-x1275 fi-byt-n2820
Build changes
-------------
* Linux: CI_DRM_6001 -> Patchwork_12881
CI_DRM_6001: 38cc4dfe85f58f942f0943551dd8fec3d67735dd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12881: 40c9882274e68bced82fe8a7fa8568043aa69842 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
40c9882274e6 drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-25 20:44 ` Aditya Swarup
@ 2019-04-26 10:12 ` Ville Syrjälä
2019-04-26 18:25 ` Aditya Swarup
0 siblings, 1 reply; 29+ messages in thread
From: Ville Syrjälä @ 2019-04-26 10:12 UTC (permalink / raw)
To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx
On Thu, Apr 25, 2019 at 01:44:37PM -0700, Aditya Swarup wrote:
> On Wed, Apr 17, 2019 at 12:57:44PM +0300, Jani Nikula wrote:
> > On Fri, 05 Apr 2019, Aditya Swarup <aditya.swarup@intel.com> wrote:
> > > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > >
> > > v2: Fix commit msg to reflect why issue occurs(Jani)
> > > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> > >
> > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > > doesn't work correctly using xrandr max bpc property. When we
> > > connect a monitor which supports deep color, the highest deep color
> > > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > > doesn't allow the switch back to 8 bit color.
> > >
> > > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> > >
> > > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > > is needed to change values for pipe_bpp based on bw_constrained flag.
> > >
> > > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> > >
> > > v6: Fix comment formatting (Ville)
> > >
> > > v7: Add reviewed by Ville
> > >
> > > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > > index 5ccb305a6e1c..f2c0aba4371b 100644
> > > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > > @@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > > crtc_state->infoframes.enable |=
> > > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> > >
> > > - /* Indicate color depth whenever the sink supports deep color */
> > > - if (hdmi_sink_is_deep_color(conn_state))
> > > + /* Indicate color depth whenever the sink supports deep color
> > > + * Also, 8bpc + color depth indication is no longer supported
> > > + * for HSW+ platforms.
> > > + */
> >
> > Frankly the comment confuses me as the condition has nothing to do with
> > HSW+ and applies for pre-HSW as well. And the "whenever" in the first
> > line is no longer true.
>
> You are correct, Clint and me spent time investigating this Spec/HW
> monstrosity for the correct conditions required for sending
> GCP_COLOR_INDICATION.
>
> >
> > I do understand the point here, we don't need to use color indication
> > when we're not using deep color anyway, and moreover this combo isn't
> > supported on HSW+.
> >
> > The final question is, under what circumstances would we use pipe_bpp >
> > 24 when the sink does *not* support bpc > 8?
> >
> > IOW, could we simply use
> >
> > if (crtc_state->pipe_bpp > 24)
> >
> > here?
> No we do need the check for sink, as that is the real check for
> determining whether sink supports deep color or not. For some platforms,
> we do send GCP_COLOR_INDICATION even for 8 bpc when the sink supports
> deep color. This will be clear with the next version of the patch.
I think Jani is right. pipe_bpp will not be > 24 unless the sink support
deep color.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-26 1:19 ` [PATCH v8] " Aditya Swarup
@ 2019-04-26 10:14 ` Ville Syrjälä
2019-04-26 18:22 ` Aditya Swarup
2019-04-29 8:56 ` Jani Nikula
2 siblings, 0 replies; 29+ messages in thread
From: Ville Syrjälä @ 2019-04-26 10:14 UTC (permalink / raw)
To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx
On Thu, Apr 25, 2019 at 06:19:50PM -0700, Aditya Swarup wrote:
> From: Clinton Taylor <Clinton.A.Taylor@intel.com>
>
> v2: Fix commit msg to reflect why issue occurs(Jani)
> Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>
> Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> doesn't work correctly using xrandr max bpc property. When we
> connect a monitor which supports deep color, the highest deep color
> setting is selected; which sets GCP_COLOR_INDICATION. When we change
> the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> doesn't allow the switch back to 8 bit color.
>
> v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>
> Drop the changes in intel_hdmi_compute_config as desired_bpp
> is needed to change values for pipe_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> v6: Fix comment formatting (Ville)
>
> v7: Add reviewed by Ville
>
> v8: Set GCP_COLOR_INDICATION based on spec:
> For Gen 7.5 or later platforms, indicate color depth only for deep
> color modes. Bspec: 8135,7751,50524
>
> Pre DDI platforms, indicate color depth if deep color is supported
> by sink. Bspec: 7854
>
> Exception: CHERRYVIEW behaves like Pre DDI platforms.
> Bspec: 15975
>
> Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> to not set 12 bit deep color for every modeset. This fixes the issue
> where 12 bit color was selected even when user selected 10 bit.(Ville)
>
> Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
> Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index e1005d7b75fd..620bc89e2120 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -973,9 +973,18 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>
> - /* Indicate color depth whenever the sink supports deep color */
> - if (hdmi_sink_is_deep_color(conn_state))
> - crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> + /* Indicate color depth whenever the sink supports deep color:
> + * For Gen 7.5 or later platforms, indicate color depth only for deep
> + * color modes.
> + * Pre DDI platforms, indicate color depth if deep color is supported
> + * by sink.
> + * Exception: CHERRYVIEW behaves like Pre DDI platforms.
> + */
> + if (hdmi_sink_is_deep_color(conn_state)) {
> + if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
> + crtc_state->pipe_bpp > 24)
I prefer the earlier version. Less special casing.
> + crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> + }
>
> /* Enable default_phase whenever the display mode is suitably aligned */
> if (gcp_default_phase_possible(crtc_state->pipe_bpp,
> @@ -2172,7 +2181,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
> if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
> return false;
>
> - if (crtc_state->pipe_bpp <= 8*3)
> + if (crtc_state->pipe_bpp < bpc*3)
This should be a separate patch.
> return false;
>
> if (!crtc_state->has_hdmi_sink)
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7)
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
` (13 preceding siblings ...)
2019-04-26 1:52 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-04-26 12:13 ` Patchwork
14 siblings, 0 replies; 29+ messages in thread
From: Patchwork @ 2019-04-26 12:13 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7)
URL : https://patchwork.freedesktop.org/series/58912/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6001_full -> Patchwork_12881_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12881_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_12881_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12881_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_persistent_relocs@forked-thrashing:
- shard-skl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl4/igt@gem_persistent_relocs@forked-thrashing.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl8/igt@gem_persistent_relocs@forked-thrashing.html
Known issues
------------
Here are the changes found in Patchwork_12881_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][3] -> [INCOMPLETE][4] ([fdo#103665])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-kbl7/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-kbl5/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +7 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-apl3/igt@gem_workarounds@suspend-resume.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-apl2/igt@gem_workarounds@suspend-resume.html
* igt@i915_pm_backlight@fade_with_suspend:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([fdo#104108] / [fdo#107773])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl10/igt@i915_pm_backlight@fade_with_suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl8/igt@i915_pm_backlight@fade_with_suspend.html
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-skl: [PASS][9] -> [FAIL][10] ([fdo#103232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl2/igt@kms_cursor_crc@cursor-128x128-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl2/igt@kms_cursor_crc@cursor-128x128-suspend.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [PASS][11] -> [FAIL][12] ([fdo#106509] / [fdo#107409])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-glk9/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-glk1/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#103184])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-apl: [PASS][15] -> [FAIL][16] ([fdo#102887] / [fdo#105363])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-apl7/igt@kms_flip@flip-vs-expired-vblank.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-apl1/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103167]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: [DMESG-WARN][21] ([fdo#108686]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-apl5/igt@gem_tiled_swapping@non-threaded.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-apl8/igt@gem_tiled_swapping@non-threaded.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-apl: [INCOMPLETE][23] ([fdo#103927]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-apl8/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
- shard-skl: [FAIL][25] ([fdo#103184] / [fdo#108472]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl6/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl3/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
- shard-skl: [FAIL][27] ([fdo#103184]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl3/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-apl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-skl: [FAIL][31] ([fdo#108040]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-skl: [FAIL][33] ([fdo#103167]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-skl: [INCOMPLETE][35] -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl3/igt@kms_plane@pixel-format-pipe-c-planes-source-clamping.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl9/igt@kms_plane@pixel-format-pipe-c-planes-source-clamping.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][37] ([fdo#108145]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format:
- shard-glk: [SKIP][39] ([fdo#109271] / [fdo#109278]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6001/shard-glk7/igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/shard-glk9/igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format.html
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (9 -> 7)
------------------------------
Missing (2): shard-hsw shard-iclb
Build changes
-------------
* Linux: CI_DRM_6001 -> Patchwork_12881
CI_DRM_6001: 38cc4dfe85f58f942f0943551dd8fec3d67735dd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12881: 40c9882274e68bced82fe8a7fa8568043aa69842 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12881/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-26 1:19 ` [PATCH v8] " Aditya Swarup
2019-04-26 10:14 ` Ville Syrjälä
@ 2019-04-26 18:22 ` Aditya Swarup
2019-04-26 18:41 ` Ville Syrjälä
2019-04-29 8:56 ` Jani Nikula
2 siblings, 1 reply; 29+ messages in thread
From: Aditya Swarup @ 2019-04-26 18:22 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
On Fri, Apr 26, 2019 at 01:14:44PM +0300, Ville Syrjälä wrote:
> On Thu, Apr 25, 2019 at 06:19:50PM -0700, Aditya Swarup wrote:
> > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> >
> > v2: Fix commit msg to reflect why issue occurs(Jani)
> > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> >
> > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > doesn't work correctly using xrandr max bpc property. When we
> > connect a monitor which supports deep color, the highest deep color
> > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > doesn't allow the switch back to 8 bit color.
> >
> > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> >
> > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > is needed to change values for pipe_bpp based on bw_constrained flag.
> >
> > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> >
> > v6: Fix comment formatting (Ville)
> >
> > v7: Add reviewed by Ville
> >
> > v8: Set GCP_COLOR_INDICATION based on spec:
> > For Gen 7.5 or later platforms, indicate color depth only for deep
> > color modes. Bspec: 8135,7751,50524
> >
> > Pre DDI platforms, indicate color depth if deep color is supported
> > by sink. Bspec: 7854
> >
> > Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > Bspec: 15975
> >
> > Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> > to not set 12 bit deep color for every modeset. This fixes the issue
> > where 12 bit color was selected even when user selected 10 bit.(Ville)
> >
> > Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
> > Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++----
> > 1 file changed, 13 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index e1005d7b75fd..620bc89e2120 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -973,9 +973,18 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > crtc_state->infoframes.enable |=
> > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> >
> > - /* Indicate color depth whenever the sink supports deep color */
> > - if (hdmi_sink_is_deep_color(conn_state))
> > - crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > + /* Indicate color depth whenever the sink supports deep color:
> > + * For Gen 7.5 or later platforms, indicate color depth only for deep
> > + * color modes.
> > + * Pre DDI platforms, indicate color depth if deep color is supported
> > + * by sink.
> > + * Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > + */
> > + if (hdmi_sink_is_deep_color(conn_state)) {
> > + if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
> > + crtc_state->pipe_bpp > 24)
>
> I prefer the earlier version. Less special casing.
Then we won't be following spec for pre DDI platforms and CHV. These
conditions are required according to Bspec pages mentioned in the commit
message.
Also, hdmi_sink_is_deep_color check is required for pre DDI platforms,
since we send GCP_COLOR_INDICATION for 24 bit color as long as display
supports deep color.
>
> > + crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > + }
> >
> > /* Enable default_phase whenever the display mode is suitably aligned */
> > if (gcp_default_phase_possible(crtc_state->pipe_bpp,
> > @@ -2172,7 +2181,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
> > if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
> > return false;
> >
> > - if (crtc_state->pipe_bpp <= 8*3)
> > + if (crtc_state->pipe_bpp < bpc*3)
>
> This should be a separate patch.
I will create a new patch for this.
>
> > return false;
> >
> > if (!crtc_state->has_hdmi_sink)
> > --
> > 2.17.1
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-26 10:12 ` Ville Syrjälä
@ 2019-04-26 18:25 ` Aditya Swarup
0 siblings, 0 replies; 29+ messages in thread
From: Aditya Swarup @ 2019-04-26 18:25 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
On Fri, Apr 26, 2019 at 01:12:58PM +0300, Ville Syrjälä wrote:
> On Thu, Apr 25, 2019 at 01:44:37PM -0700, Aditya Swarup wrote:
> > On Wed, Apr 17, 2019 at 12:57:44PM +0300, Jani Nikula wrote:
> > > On Fri, 05 Apr 2019, Aditya Swarup <aditya.swarup@intel.com> wrote:
> > > > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > >
> > > > v2: Fix commit msg to reflect why issue occurs(Jani)
> > > > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> > > >
> > > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > > > doesn't work correctly using xrandr max bpc property. When we
> > > > connect a monitor which supports deep color, the highest deep color
> > > > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > > > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > > > doesn't allow the switch back to 8 bit color.
> > > >
> > > > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > > > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> > > >
> > > > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > > > is needed to change values for pipe_bpp based on bw_constrained flag.
> > > >
> > > > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> > > >
> > > > v6: Fix comment formatting (Ville)
> > > >
> > > > v7: Add reviewed by Ville
> > > >
> > > > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/intel_hdmi.c | 7 +++++--
> > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > > > index 5ccb305a6e1c..f2c0aba4371b 100644
> > > > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > > > @@ -962,8 +962,11 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > > > crtc_state->infoframes.enable |=
> > > > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> > > >
> > > > - /* Indicate color depth whenever the sink supports deep color */
> > > > - if (hdmi_sink_is_deep_color(conn_state))
> > > > + /* Indicate color depth whenever the sink supports deep color
> > > > + * Also, 8bpc + color depth indication is no longer supported
> > > > + * for HSW+ platforms.
> > > > + */
> > >
> > > Frankly the comment confuses me as the condition has nothing to do with
> > > HSW+ and applies for pre-HSW as well. And the "whenever" in the first
> > > line is no longer true.
> >
> > You are correct, Clint and me spent time investigating this Spec/HW
> > monstrosity for the correct conditions required for sending
> > GCP_COLOR_INDICATION.
> >
> > >
> > > I do understand the point here, we don't need to use color indication
> > > when we're not using deep color anyway, and moreover this combo isn't
> > > supported on HSW+.
> > >
> > > The final question is, under what circumstances would we use pipe_bpp >
> > > 24 when the sink does *not* support bpc > 8?
> > >
> > > IOW, could we simply use
> > >
> > > if (crtc_state->pipe_bpp > 24)
> > >
> > > here?
> > No we do need the check for sink, as that is the real check for
> > determining whether sink supports deep color or not. For some platforms,
> > we do send GCP_COLOR_INDICATION even for 8 bpc when the sink supports
> > deep color. This will be clear with the next version of the patch.
>
> I think Jani is right. pipe_bpp will not be > 24 unless the sink support
> deep color.
I have described why we need the check for sink on the next revision of
the patch.
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-26 18:22 ` Aditya Swarup
@ 2019-04-26 18:41 ` Ville Syrjälä
2019-04-26 18:53 ` Aditya Swarup
0 siblings, 1 reply; 29+ messages in thread
From: Ville Syrjälä @ 2019-04-26 18:41 UTC (permalink / raw)
To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx
On Fri, Apr 26, 2019 at 11:22:02AM -0700, Aditya Swarup wrote:
> On Fri, Apr 26, 2019 at 01:14:44PM +0300, Ville Syrjälä wrote:
> > On Thu, Apr 25, 2019 at 06:19:50PM -0700, Aditya Swarup wrote:
> > > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > >
> > > v2: Fix commit msg to reflect why issue occurs(Jani)
> > > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> > >
> > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > > doesn't work correctly using xrandr max bpc property. When we
> > > connect a monitor which supports deep color, the highest deep color
> > > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > > doesn't allow the switch back to 8 bit color.
> > >
> > > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> > >
> > > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > > is needed to change values for pipe_bpp based on bw_constrained flag.
> > >
> > > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> > >
> > > v6: Fix comment formatting (Ville)
> > >
> > > v7: Add reviewed by Ville
> > >
> > > v8: Set GCP_COLOR_INDICATION based on spec:
> > > For Gen 7.5 or later platforms, indicate color depth only for deep
> > > color modes. Bspec: 8135,7751,50524
> > >
> > > Pre DDI platforms, indicate color depth if deep color is supported
> > > by sink. Bspec: 7854
> > >
> > > Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > > Bspec: 15975
> > >
> > > Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> > > to not set 12 bit deep color for every modeset. This fixes the issue
> > > where 12 bit color was selected even when user selected 10 bit.(Ville)
> > >
> > > Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
> > > Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++----
> > > 1 file changed, 13 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > > index e1005d7b75fd..620bc89e2120 100644
> > > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > > @@ -973,9 +973,18 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > > crtc_state->infoframes.enable |=
> > > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> > >
> > > - /* Indicate color depth whenever the sink supports deep color */
> > > - if (hdmi_sink_is_deep_color(conn_state))
> > > - crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > > + /* Indicate color depth whenever the sink supports deep color:
> > > + * For Gen 7.5 or later platforms, indicate color depth only for deep
> > > + * color modes.
> > > + * Pre DDI platforms, indicate color depth if deep color is supported
> > > + * by sink.
> > > + * Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > > + */
> > > + if (hdmi_sink_is_deep_color(conn_state)) {
> > > + if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
> > > + crtc_state->pipe_bpp > 24)
> >
> > I prefer the earlier version. Less special casing.
> Then we won't be following spec for pre DDI platforms and CHV. These
> conditions are required according to Bspec pages mentioned in the commit
> message.
>
> Also, hdmi_sink_is_deep_color check is required for pre DDI platforms,
> since we send GCP_COLOR_INDICATION for 24 bit color as long as display
> supports deep color.
We don't have to send it for 24bpp even if the old hw supports doing so.
Well, the HDMI spec does say
"Once a Source sends a GCP with non-zero CD to a sink, it should
continue sending GCPs with non-zero CD at least once per video
field even if reverting to 24-bit color, as long as the Sink
continues to support Deep Color."
so I guess we should maybe send it? But maybe that only applies if
we would swich the color deph without a full modeset (can't really
see how that would work in the first place considering the symbol
clock needs to be adjusted too).
Anyways, I think it's better to just stick to a uniform behaviour
across all platforms here.
> >
> > > + crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > > + }
> > >
> > > /* Enable default_phase whenever the display mode is suitably aligned */
> > > if (gcp_default_phase_possible(crtc_state->pipe_bpp,
> > > @@ -2172,7 +2181,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
> > > if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
> > > return false;
> > >
> > > - if (crtc_state->pipe_bpp <= 8*3)
> > > + if (crtc_state->pipe_bpp < bpc*3)
> >
> > This should be a separate patch.
> I will create a new patch for this.
> >
> > > return false;
> > >
> > > if (!crtc_state->has_hdmi_sink)
> > > --
> > > 2.17.1
> >
> > --
> > Ville Syrjälä
> > Intel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-26 18:41 ` Ville Syrjälä
@ 2019-04-26 18:53 ` Aditya Swarup
2019-04-26 19:06 ` Ville Syrjälä
0 siblings, 1 reply; 29+ messages in thread
From: Aditya Swarup @ 2019-04-26 18:53 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
On Fri, Apr 26, 2019 at 09:41:06PM +0300, Ville Syrjälä wrote:
> On Fri, Apr 26, 2019 at 11:22:02AM -0700, Aditya Swarup wrote:
> > On Fri, Apr 26, 2019 at 01:14:44PM +0300, Ville Syrjälä wrote:
> > > On Thu, Apr 25, 2019 at 06:19:50PM -0700, Aditya Swarup wrote:
> > > > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > >
> > > > v2: Fix commit msg to reflect why issue occurs(Jani)
> > > > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> > > >
> > > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > > > doesn't work correctly using xrandr max bpc property. When we
> > > > connect a monitor which supports deep color, the highest deep color
> > > > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > > > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > > > doesn't allow the switch back to 8 bit color.
> > > >
> > > > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > > > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> > > >
> > > > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > > > is needed to change values for pipe_bpp based on bw_constrained flag.
> > > >
> > > > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> > > >
> > > > v6: Fix comment formatting (Ville)
> > > >
> > > > v7: Add reviewed by Ville
> > > >
> > > > v8: Set GCP_COLOR_INDICATION based on spec:
> > > > For Gen 7.5 or later platforms, indicate color depth only for deep
> > > > color modes. Bspec: 8135,7751,50524
> > > >
> > > > Pre DDI platforms, indicate color depth if deep color is supported
> > > > by sink. Bspec: 7854
> > > >
> > > > Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > > > Bspec: 15975
> > > >
> > > > Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> > > > to not set 12 bit deep color for every modeset. This fixes the issue
> > > > where 12 bit color was selected even when user selected 10 bit.(Ville)
> > > >
> > > > Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
> > > > Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++----
> > > > 1 file changed, 13 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > > > index e1005d7b75fd..620bc89e2120 100644
> > > > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > > > @@ -973,9 +973,18 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > > > crtc_state->infoframes.enable |=
> > > > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> > > >
> > > > - /* Indicate color depth whenever the sink supports deep color */
> > > > - if (hdmi_sink_is_deep_color(conn_state))
> > > > - crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > > > + /* Indicate color depth whenever the sink supports deep color:
> > > > + * For Gen 7.5 or later platforms, indicate color depth only for deep
> > > > + * color modes.
> > > > + * Pre DDI platforms, indicate color depth if deep color is supported
> > > > + * by sink.
> > > > + * Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > > > + */
> > > > + if (hdmi_sink_is_deep_color(conn_state)) {
> > > > + if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
> > > > + crtc_state->pipe_bpp > 24)
> > >
> > > I prefer the earlier version. Less special casing.
> > Then we won't be following spec for pre DDI platforms and CHV. These
> > conditions are required according to Bspec pages mentioned in the commit
> > message.
> >
> > Also, hdmi_sink_is_deep_color check is required for pre DDI platforms,
> > since we send GCP_COLOR_INDICATION for 24 bit color as long as display
> > supports deep color.
>
> We don't have to send it for 24bpp even if the old hw supports doing so.
>
> Well, the HDMI spec does say
> "Once a Source sends a GCP with non-zero CD to a sink, it should
> continue sending GCPs with non-zero CD at least once per video
> field even if reverting to 24-bit color, as long as the Sink
> continues to support Deep Color."
>
> so I guess we should maybe send it? But maybe that only applies if
> we would swich the color deph without a full modeset (can't really
> see how that would work in the first place considering the symbol
> clock needs to be adjusted too).
>
> Anyways, I think it's better to just stick to a uniform behaviour
> across all platforms here.
I don't have any problems with that but according to
Bspec: 7854
"This bit must be set when in deep color mode. It may optionally be
set for 24-bit mode. It must be set if the sink attached to the
transcoder can receive GCP data."
The only thing that concerns me is that the spec says it "must" be set
if transcoder can receive GCP data.
If you still feel that it is not necessary, then I will remove the
platform checks.
>
> > >
> > > > + crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > > > + }
> > > >
> > > > /* Enable default_phase whenever the display mode is suitably aligned */
> > > > if (gcp_default_phase_possible(crtc_state->pipe_bpp,
> > > > @@ -2172,7 +2181,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
> > > > if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
> > > > return false;
> > > >
> > > > - if (crtc_state->pipe_bpp <= 8*3)
> > > > + if (crtc_state->pipe_bpp < bpc*3)
> > >
> > > This should be a separate patch.
> > I will create a new patch for this.
> > >
> > > > return false;
> > > >
> > > > if (!crtc_state->has_hdmi_sink)
> > > > --
> > > > 2.17.1
> > >
> > > --
> > > Ville Syrjälä
> > > Intel
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-26 18:53 ` Aditya Swarup
@ 2019-04-26 19:06 ` Ville Syrjälä
0 siblings, 0 replies; 29+ messages in thread
From: Ville Syrjälä @ 2019-04-26 19:06 UTC (permalink / raw)
To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx
On Fri, Apr 26, 2019 at 11:53:54AM -0700, Aditya Swarup wrote:
> On Fri, Apr 26, 2019 at 09:41:06PM +0300, Ville Syrjälä wrote:
> > On Fri, Apr 26, 2019 at 11:22:02AM -0700, Aditya Swarup wrote:
> > > On Fri, Apr 26, 2019 at 01:14:44PM +0300, Ville Syrjälä wrote:
> > > > On Thu, Apr 25, 2019 at 06:19:50PM -0700, Aditya Swarup wrote:
> > > > > From: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > > >
> > > > > v2: Fix commit msg to reflect why issue occurs(Jani)
> > > > > Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
> > > > >
> > > > > Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> > > > > doesn't work correctly using xrandr max bpc property. When we
> > > > > connect a monitor which supports deep color, the highest deep color
> > > > > setting is selected; which sets GCP_COLOR_INDICATION. When we change
> > > > > the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> > > > > doesn't allow the switch back to 8 bit color.
> > > > >
> > > > > v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> > > > > Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
> > > > >
> > > > > Drop the changes in intel_hdmi_compute_config as desired_bpp
> > > > > is needed to change values for pipe_bpp based on bw_constrained flag.
> > > > >
> > > > > v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
> > > > >
> > > > > v6: Fix comment formatting (Ville)
> > > > >
> > > > > v7: Add reviewed by Ville
> > > > >
> > > > > v8: Set GCP_COLOR_INDICATION based on spec:
> > > > > For Gen 7.5 or later platforms, indicate color depth only for deep
> > > > > color modes. Bspec: 8135,7751,50524
> > > > >
> > > > > Pre DDI platforms, indicate color depth if deep color is supported
> > > > > by sink. Bspec: 7854
> > > > >
> > > > > Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > > > > Bspec: 15975
> > > > >
> > > > > Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> > > > > to not set 12 bit deep color for every modeset. This fixes the issue
> > > > > where 12 bit color was selected even when user selected 10 bit.(Ville)
> > > > >
> > > > > Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
> > > > > Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> > > > > Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> > > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > > > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++----
> > > > > 1 file changed, 13 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > > > > index e1005d7b75fd..620bc89e2120 100644
> > > > > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > > > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > > > > @@ -973,9 +973,18 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> > > > > crtc_state->infoframes.enable |=
> > > > > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
> > > > >
> > > > > - /* Indicate color depth whenever the sink supports deep color */
> > > > > - if (hdmi_sink_is_deep_color(conn_state))
> > > > > - crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > > > > + /* Indicate color depth whenever the sink supports deep color:
> > > > > + * For Gen 7.5 or later platforms, indicate color depth only for deep
> > > > > + * color modes.
> > > > > + * Pre DDI platforms, indicate color depth if deep color is supported
> > > > > + * by sink.
> > > > > + * Exception: CHERRYVIEW behaves like Pre DDI platforms.
> > > > > + */
> > > > > + if (hdmi_sink_is_deep_color(conn_state)) {
> > > > > + if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
> > > > > + crtc_state->pipe_bpp > 24)
> > > >
> > > > I prefer the earlier version. Less special casing.
> > > Then we won't be following spec for pre DDI platforms and CHV. These
> > > conditions are required according to Bspec pages mentioned in the commit
> > > message.
> > >
> > > Also, hdmi_sink_is_deep_color check is required for pre DDI platforms,
> > > since we send GCP_COLOR_INDICATION for 24 bit color as long as display
> > > supports deep color.
> >
> > We don't have to send it for 24bpp even if the old hw supports doing so.
> >
> > Well, the HDMI spec does say
> > "Once a Source sends a GCP with non-zero CD to a sink, it should
> > continue sending GCPs with non-zero CD at least once per video
> > field even if reverting to 24-bit color, as long as the Sink
> > continues to support Deep Color."
> >
> > so I guess we should maybe send it? But maybe that only applies if
> > we would swich the color deph without a full modeset (can't really
> > see how that would work in the first place considering the symbol
> > clock needs to be adjusted too).
> >
> > Anyways, I think it's better to just stick to a uniform behaviour
> > across all platforms here.
>
> I don't have any problems with that but according to
>
> Bspec: 7854
>
> "This bit must be set when in deep color mode. It may optionally be
> set for 24-bit mode. It must be set if the sink attached to the
> transcoder can receive GCP data."
>
> The only thing that concerns me is that the spec says it "must" be set
> if transcoder can receive GCP data.
That note is contradicting itself so clearly it can't be trusted.
>
> If you still feel that it is not necessary, then I will remove the
> platform checks.
We can't set it on hsw+ anyway, so someone definitely came to
the conclusion that it's not needed.
>
> >
> > > >
> > > > > + crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> > > > > + }
> > > > >
> > > > > /* Enable default_phase whenever the display mode is suitably aligned */
> > > > > if (gcp_default_phase_possible(crtc_state->pipe_bpp,
> > > > > @@ -2172,7 +2181,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
> > > > > if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
> > > > > return false;
> > > > >
> > > > > - if (crtc_state->pipe_bpp <= 8*3)
> > > > > + if (crtc_state->pipe_bpp < bpc*3)
> > > >
> > > > This should be a separate patch.
> > > I will create a new patch for this.
> > > >
> > > > > return false;
> > > > >
> > > > > if (!crtc_state->has_hdmi_sink)
> > > > > --
> > > > > 2.17.1
> > > >
> > > > --
> > > > Ville Syrjälä
> > > > Intel
> >
> > --
> > Ville Syrjälä
> > Intel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v8] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color
2019-04-26 1:19 ` [PATCH v8] " Aditya Swarup
2019-04-26 10:14 ` Ville Syrjälä
2019-04-26 18:22 ` Aditya Swarup
@ 2019-04-29 8:56 ` Jani Nikula
2 siblings, 0 replies; 29+ messages in thread
From: Jani Nikula @ 2019-04-29 8:56 UTC (permalink / raw)
To: Aditya Swarup, intel-gfx
On Thu, 25 Apr 2019, Aditya Swarup <aditya.swarup@intel.com> wrote:
> From: Clinton Taylor <Clinton.A.Taylor@intel.com>
>
> v2: Fix commit msg to reflect why issue occurs(Jani)
> Set GCP_COLOR_INDICATION only when we set 10/12 bit deep color.
>
> Changing settings from 10/12 bit deep color to 8 bit(& vice versa)
> doesn't work correctly using xrandr max bpc property. When we
> connect a monitor which supports deep color, the highest deep color
> setting is selected; which sets GCP_COLOR_INDICATION. When we change
> the setting to 8 bit color, we still set GCP_COLOR_INDICATION which
> doesn't allow the switch back to 8 bit color.
>
> v3,4: Add comments & drop changes in intel_hdmi_compute_config(Ville)
> Since HSW+, GCP_COLOR_INDICATION is not required for 8bpc.
>
> Drop the changes in intel_hdmi_compute_config as desired_bpp
> is needed to change values for pipe_bpp based on bw_constrained flag.
>
> v5: Fix missing logical && in condition for setting GCP_COLOR_INDICATION.
>
> v6: Fix comment formatting (Ville)
>
> v7: Add reviewed by Ville
>
> v8: Set GCP_COLOR_INDICATION based on spec:
> For Gen 7.5 or later platforms, indicate color depth only for deep
> color modes. Bspec: 8135,7751,50524
>
> Pre DDI platforms, indicate color depth if deep color is supported
> by sink. Bspec: 7854
>
> Exception: CHERRYVIEW behaves like Pre DDI platforms.
> Bspec: 15975
>
> Check pipe_bpp is less than bpp * 3 in hdmi_deep_color_possible,
> to not set 12 bit deep color for every modeset. This fixes the issue
> where 12 bit color was selected even when user selected 10 bit.(Ville)
>
> Co-Developed-by: Aditya Swarup <aditya.swarup@intel.com>
> Co-Developed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index e1005d7b75fd..620bc89e2120 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -973,9 +973,18 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
>
> - /* Indicate color depth whenever the sink supports deep color */
> - if (hdmi_sink_is_deep_color(conn_state))
> - crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> + /* Indicate color depth whenever the sink supports deep color:
Please fix the comment formatting for multi-line comments:
/*
* First comment line.
* ...
* Last comment line.
*/
> + * For Gen 7.5 or later platforms, indicate color depth only for deep
> + * color modes.
> + * Pre DDI platforms, indicate color depth if deep color is supported
> + * by sink.
> + * Exception: CHERRYVIEW behaves like Pre DDI platforms.
> + */
> + if (hdmi_sink_is_deep_color(conn_state)) {
> + if(!HAS_DDI(dev_priv) || IS_CHERRYVIEW(dev_priv) ||
> + crtc_state->pipe_bpp > 24)
> + crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
> + }
>
> /* Enable default_phase whenever the display mode is suitably aligned */
> if (gcp_default_phase_possible(crtc_state->pipe_bpp,
> @@ -2172,7 +2181,7 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
> if (bpc == 10 && INTEL_GEN(dev_priv) < 11)
> return false;
>
> - if (crtc_state->pipe_bpp <= 8*3)
> + if (crtc_state->pipe_bpp < bpc*3)
> return false;
>
> if (!crtc_state->has_hdmi_sink)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2019-04-29 8:56 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03 6:22 [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
2019-04-03 7:01 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev3) Patchwork
2019-04-03 7:33 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-03 20:44 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-04 20:37 ` [PATCH v5] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Ville Syrjälä
2019-04-04 20:40 ` Ville Syrjälä
2019-04-05 5:55 ` [PATCH v6] " Aditya Swarup
2019-04-05 16:34 ` Clinton Taylor
2019-04-08 16:49 ` Ville Syrjälä
2019-04-05 6:46 ` ✗ Fi.CI.BAT: failure for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev4) Patchwork
2019-04-05 20:49 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
2019-04-05 22:29 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev5) Patchwork
2019-04-06 3:36 ` [PATCH v7] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color Aditya Swarup
2019-04-17 9:57 ` Jani Nikula
2019-04-25 20:44 ` Aditya Swarup
2019-04-26 10:12 ` Ville Syrjälä
2019-04-26 18:25 ` Aditya Swarup
2019-04-26 1:19 ` [PATCH v8] " Aditya Swarup
2019-04-26 10:14 ` Ville Syrjälä
2019-04-26 18:22 ` Aditya Swarup
2019-04-26 18:41 ` Ville Syrjälä
2019-04-26 18:53 ` Aditya Swarup
2019-04-26 19:06 ` Ville Syrjälä
2019-04-29 8:56 ` Jani Nikula
2019-04-06 4:08 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev6) Patchwork
2019-04-07 3:42 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-26 1:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color (rev7) Patchwork
2019-04-26 1:52 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-26 12:13 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.