From: Andrew Murray <andrew.murray@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>, Phil Blundell <pb@pbcl.net>,
libc-alpha@sourceware.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v3 2/7] arm64: HWCAP: add support for AT_HWCAP2
Date: Wed, 3 Apr 2019 10:29:52 +0100 [thread overview]
Message-ID: <20190403092951.GJ53702@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190403091118.GL3567@e103592.cambridge.arm.com>
On Wed, Apr 03, 2019 at 10:11:20AM +0100, Dave Martin wrote:
> On Wed, Apr 03, 2019 at 09:32:55AM +0100, Andrew Murray wrote:
> > On Tue, Apr 02, 2019 at 03:58:31PM +0100, Dave Martin wrote:
> > > On Mon, Apr 01, 2019 at 11:45:10AM +0100, Andrew Murray wrote:
>
> [...]
>
> > > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> > > > index aa4ec53281ce..6cc8aff83805 100644
> > > > --- a/drivers/clocksource/arm_arch_timer.c
> > > > +++ b/drivers/clocksource/arm_arch_timer.c
> > > > @@ -833,7 +833,11 @@ static void arch_timer_evtstrm_enable(int divider)
> > > > cntkctl |= (divider << ARCH_TIMER_EVT_TRIGGER_SHIFT)
> > > > | ARCH_TIMER_VIRT_EVT_EN;
> > > > arch_timer_set_cntkctl(cntkctl);
> > > > +#ifdef CONFIG_ARM64
> > > > + cpu_set_named_feature(EVTSTRM);
> > > > +#else
> > > > elf_hwcap |= HWCAP_EVTSTRM;
> > > > +#endif
> > >
> > > I wonder whether we can have a generic definition for this:
> > >
> > > #define cpu_set_named_feature(x) (elf_hwcap |= HWCAP_ ## x)
> >
> > You mean specific to arm32?
> >
> > I will do this, along with a cpu_get_named_feature - but I think I'd prefer
> > to do this in a separate series.
>
> Yes, we could do that. We could also do it more widely, but it's
> probably not worth the overhead of doing it.
I had considered this as well but also determined that it wouldn't give
much gain.
Thanks,
Andrew Murray
>
> [...]
>
> Cheers
> ---Dave
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
libc-alpha@sourceware.org, Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Phil Blundell <pb@pbcl.net>,
linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/7] arm64: HWCAP: add support for AT_HWCAP2
Date: Wed, 3 Apr 2019 10:29:52 +0100 [thread overview]
Message-ID: <20190403092951.GJ53702@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190403091118.GL3567@e103592.cambridge.arm.com>
On Wed, Apr 03, 2019 at 10:11:20AM +0100, Dave Martin wrote:
> On Wed, Apr 03, 2019 at 09:32:55AM +0100, Andrew Murray wrote:
> > On Tue, Apr 02, 2019 at 03:58:31PM +0100, Dave Martin wrote:
> > > On Mon, Apr 01, 2019 at 11:45:10AM +0100, Andrew Murray wrote:
>
> [...]
>
> > > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> > > > index aa4ec53281ce..6cc8aff83805 100644
> > > > --- a/drivers/clocksource/arm_arch_timer.c
> > > > +++ b/drivers/clocksource/arm_arch_timer.c
> > > > @@ -833,7 +833,11 @@ static void arch_timer_evtstrm_enable(int divider)
> > > > cntkctl |= (divider << ARCH_TIMER_EVT_TRIGGER_SHIFT)
> > > > | ARCH_TIMER_VIRT_EVT_EN;
> > > > arch_timer_set_cntkctl(cntkctl);
> > > > +#ifdef CONFIG_ARM64
> > > > + cpu_set_named_feature(EVTSTRM);
> > > > +#else
> > > > elf_hwcap |= HWCAP_EVTSTRM;
> > > > +#endif
> > >
> > > I wonder whether we can have a generic definition for this:
> > >
> > > #define cpu_set_named_feature(x) (elf_hwcap |= HWCAP_ ## x)
> >
> > You mean specific to arm32?
> >
> > I will do this, along with a cpu_get_named_feature - but I think I'd prefer
> > to do this in a separate series.
>
> Yes, we could do that. We could also do it more widely, but it's
> probably not worth the overhead of doing it.
I had considered this as well but also determined that it wouldn't give
much gain.
Thanks,
Andrew Murray
>
> [...]
>
> Cheers
> ---Dave
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-03 9:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:45 [PATCH v3 0/7] arm64: Initial support for CVADP Andrew Murray
2019-04-01 10:45 ` Andrew Murray
2019-04-01 10:45 ` [PATCH v3 1/7] arm64: Handle trapped DC CVADP Andrew Murray
2019-04-01 10:45 ` Andrew Murray
2019-04-01 10:45 ` [PATCH v3 2/7] arm64: HWCAP: add support for AT_HWCAP2 Andrew Murray
2019-04-01 10:45 ` Andrew Murray
2019-04-02 14:58 ` Dave Martin
2019-04-02 14:58 ` Dave Martin
2019-04-03 8:32 ` Andrew Murray
2019-04-03 8:32 ` Andrew Murray
2019-04-03 9:11 ` Dave Martin
2019-04-03 9:11 ` Dave Martin
2019-04-03 9:29 ` Andrew Murray [this message]
2019-04-03 9:29 ` Andrew Murray
2019-04-03 9:35 ` Dave Martin
2019-04-03 9:35 ` Dave Martin
2019-04-01 10:45 ` [PATCH v3 3/7] arm64: HWCAP: encapsulate elf_hwcap Andrew Murray
2019-04-01 10:45 ` Andrew Murray
2019-04-02 14:58 ` Dave Martin
2019-04-02 14:58 ` Dave Martin
2019-04-02 15:06 ` Andrew Murray
2019-04-02 15:06 ` Andrew Murray
2019-04-02 15:32 ` Suzuki K Poulose
2019-04-02 15:32 ` Suzuki K Poulose
2019-04-02 15:55 ` Dave Martin
2019-04-02 15:55 ` Dave Martin
2019-04-03 8:53 ` Andrew Murray
2019-04-03 8:53 ` Andrew Murray
2019-04-03 9:13 ` Dave Martin
2019-04-03 9:13 ` Dave Martin
2019-04-01 10:45 ` [PATCH v3 4/7] arm64: Expose DC CVADP to userspace Andrew Murray
2019-04-01 10:45 ` Andrew Murray
2019-04-01 10:45 ` [PATCH v3 5/7] arm64: add CVADP support to the cache maintenance helper Andrew Murray
2019-04-01 10:45 ` Andrew Murray
2019-04-01 10:45 ` [PATCH v3 6/7] arm64: Advertise ARM64_HAS_DCPODP cpu feature Andrew Murray
2019-04-01 10:45 ` Andrew Murray
2019-04-02 14:59 ` Dave Martin
2019-04-02 14:59 ` Dave Martin
2019-04-03 9:23 ` Andrew Murray
2019-04-03 9:23 ` Andrew Murray
2019-04-03 9:32 ` Dave Martin
2019-04-03 9:32 ` Dave Martin
2019-04-03 9:57 ` Andrew Murray
2019-04-03 9:57 ` Andrew Murray
2019-04-01 10:45 ` [PATCH v3 7/7] arm64: docs: document AT_HWCAP2 and unused AT_HWCAP bits Andrew Murray
2019-04-01 10:45 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403092951.GJ53702@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=Dave.Martin@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=catalin.marinas@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pb@pbcl.net \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.