print frequency debug only if dvb_frontend_debug is enables

print frequency debug only if dvb_frontend_debug is enables

[Peter Holik]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

Hi!

Every transponder switch from my vdr causes this debug message "frequency interval: tuner: ..., frontend: ..." in syslog.

I think this should only happen if dvb_frontend_debug parameter is set.

cu Peter

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dvb_frontend.c.diff --]
[-- Type: text/x-patch; name="dvb_frontend.c.diff", Size: 592 bytes --]

--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_frontend.c
@@ -917,8 +917,9 @@
 			 "DVB: adapter %i frontend %u frequency limits undefined - fix the driver\n",
 			 fe->dvb->num, fe->id);
 
-	dprintk("frequency interval: tuner: %u...%u, frontend: %u...%u",
-		tuner_min, tuner_max, frontend_min, frontend_max);
+	if (dvb_frontend_debug)
+		dprintk("frequency interval: tuner: %u...%u, frontend: %u...%u",
+			tuner_min, tuner_max, frontend_min, frontend_max);
 
 	/* If the standard is for satellite, convert frequencies to kHz */
 	switch (c->delivery_system) {

Re: print frequency debug only if dvb_frontend_debug is enables

[Sean Young]

On Thu, Mar 28, 2019 at 11:44:00AM +0100, Peter Holik wrote:
> Hi!
> 
> Every transponder switch from my vdr causes this debug message "frequency interval: tuner: ..., frontend: ..." in syslog.
> 
> I think this should only happen if dvb_frontend_debug parameter is set.
> 
> cu Peter

You need a Signed-off-by: line.

Please read

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

For how a patch should be submitted.

> --- a/drivers/media/dvb-core/dvb_frontend.c
> +++ b/drivers/media/dvb-core/dvb_frontend.c
> @@ -917,8 +917,9 @@
>  			 "DVB: adapter %i frontend %u frequency limits undefined - fix the driver\n",
>  			 fe->dvb->num, fe->id);
>  
> -	dprintk("frequency interval: tuner: %u...%u, frontend: %u...%u",
> -		tuner_min, tuner_max, frontend_min, frontend_max);
> +	if (dvb_frontend_debug)
> +		dprintk("frequency interval: tuner: %u...%u, frontend: %u...%u",
> +			tuner_min, tuner_max, frontend_min, frontend_max);

This should be replaced with dev_dbg(). Actually, all instances dprintk()
should be replaced with dev_dbg() and dvb_frontend_debug removed.
  
>  	/* If the standard is for satellite, convert frequencies to kHz */
>  	switch (c->delivery_system) {



Sean