All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: allow a PHY driver to define neither features nor get_features
Date: Wed, 3 Apr 2019 22:46:58 +0200	[thread overview]
Message-ID: <20190403204658.GF4592@lunn.ch> (raw)
In-Reply-To: <d177b061-a154-43d3-b20d-8ba7564772a8@gmail.com>

> @@ -2218,9 +2223,9 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner)
>  	/* Either the features are hard coded, or dynamically
>  	 * determine. It cannot be both or neither
>  	 */

Hi Heiner

The comment needs updating to match the code.

> -	if (WARN_ON((!new_driver->features && !new_driver->get_features) ||
> -		    (new_driver->features && new_driver->get_features))) {
> -		pr_err("%s: Driver features are missing\n", new_driver->name);
> +	if (WARN_ON(new_driver->features && new_driver->get_features)) {
> +		pr_err("%s: features and get_features must not both be set\n",
> +		       new_driver->name);
>  		return -EINVAL;

	Andrew

  reply	other threads:[~2019-04-03 20:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 18:17 [PATCH net-next 0/2] net: phy: use generic PHY ability readers if callback get_features isn't set Heiner Kallweit
2019-04-03 18:19 ` [PATCH net-next 1/2] net: phy: allow a PHY driver to define neither features nor get_features Heiner Kallweit
2019-04-03 20:46   ` Andrew Lunn [this message]
2019-04-03 20:59     ` Heiner Kallweit
2019-04-03 18:20 ` [PATCH net-next 2/2] net: phy: realtek: remove setting callback get_features and use phylib fallback Heiner Kallweit
2019-04-03 20:55   ` Andrew Lunn
2019-04-03 21:06     ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403204658.GF4592@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.