All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Force a full modeset when we force dsc enable
@ 2019-04-02 19:31 Manasi Navare
  2019-04-02 20:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 19+ messages in thread
From: Manasi Navare @ 2019-04-02 19:31 UTC (permalink / raw)
  To: igt-dev; +Cc: Manasi Navare, Anusha Srivatsa, Petri Latvala

DSC enable gets configured during compute_config and needs
a full modeset to force DSC.
Sometimes in between the tests, if the initial output is same as the
mode being set for DSC then it will not do a full modeset.
So we disable the output before forcing a mode with DSC enable.

Fixes: db19bccc1c22 ("test/kms_dp_dsc: Basic KMS test to validate VESA DSC on DP/eDP")
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
 tests/kms_dp_dsc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/kms_dp_dsc.c b/tests/kms_dp_dsc.c
index da93cd74..f3a61029 100644
--- a/tests/kms_dp_dsc.c
+++ b/tests/kms_dp_dsc.c
@@ -174,6 +174,11 @@ static void update_display(data_t *data, enum dsc_test_type test_type)
 				      &data->fb_test_pattern);
 		primary = igt_output_get_plane_type(data->output,
 						    DRM_PLANE_TYPE_PRIMARY);
+		/* Disable the output first */
+		igt_plane_set_fb(primary, NULL);
+		igt_output_set_pipe(data->output, PIPE_NONE);
+
+		/* Now set the output to the desired mode */
 		igt_plane_set_fb(primary, &data->fb_test_pattern);
 		igt_display_commit(&data->display);
 
@@ -187,7 +192,7 @@ static void update_display(data_t *data, enum dsc_test_type test_type)
 		clear_dp_dsc_enable(data);
 
 		igt_assert_f(enabled,
-			     "Default DSC enable failed on Connector: %s Pipe: %s",
+			     "\nDefault DSC enable failed on Connector: %s Pipe: %s",
 			     data->conn_name,
 			     kmstest_pipe_name(data->pipe));
 	} else {
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 19+ messages in thread
end of thread, other threads:[~2019-04-05 18:26 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 19:31 [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Force a full modeset when we force dsc enable Manasi Navare
2019-04-02 20:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-03  7:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-03 10:06 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-04-03 13:25 ` Imre Deak
2019-04-03 18:20   ` Manasi Navare
2019-04-03 19:33     ` Imre Deak
2019-04-03 20:17       ` Manasi Navare
2019-04-03 20:34         ` Imre Deak
2019-04-03 20:49           ` Manasi Navare
2019-04-03 21:42             ` Imre Deak
2019-04-03 22:48               ` Manasi Navare
2019-04-03 23:02                 ` Imre Deak
2019-04-03 23:11                   ` Manasi Navare
2019-04-03 23:15                     ` Imre Deak
2019-04-04 23:44                       ` Manasi Navare
2019-04-05 10:06                         ` Imre Deak
2019-04-05 18:28                           ` Manasi Navare
2019-04-03 17:38 ` Srivatsa, Anusha

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.