* [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage
@ 2019-04-04 4:01 Annaliese McDermond
2019-04-04 4:01 ` [PATCH 2/2] ASoC: tlv320aic32x4: Add Playback PowerTune Controls Annaliese McDermond
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Annaliese McDermond @ 2019-04-04 4:01 UTC (permalink / raw)
To: broonie, alsa-devel; +Cc: team
Add a switch for setting common mode voltage. This can allow
for higher drive levels on the amplifier outputs.
Signed-off-by: Annaliese McDermond <nh6z@nh6z.net>
---
sound/soc/codecs/tlv320aic32x4.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index aec86fd6ac15..77df2cbdf5f4 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -242,6 +242,12 @@ static DECLARE_TLV_DB_SCALE(tlv_driver_gain, -600, 100, 0);
/* -12dB min, 0.5dB steps */
static DECLARE_TLV_DB_SCALE(tlv_adc_vol, -1200, 50, 0);
+static const char * const lo_cm_text[] = {
+ "Full Chip", "1.65V",
+};
+
+static SOC_ENUM_SINGLE_DECL(lo_cm_enum, AIC32X4_CMMODE, 3, lo_cm_text);
+
static const struct snd_kcontrol_new aic32x4_snd_controls[] = {
SOC_DOUBLE_R_S_TLV("PCM Playback Volume", AIC32X4_LDACVOL,
AIC32X4_RDACVOL, 0, -0x7f, 0x30, 7, 0, tlv_pcm),
@@ -255,6 +261,7 @@ static const struct snd_kcontrol_new aic32x4_snd_controls[] = {
AIC32X4_HPRGAIN, 6, 0x01, 1),
SOC_DOUBLE_R("LO DAC Playback Switch", AIC32X4_LOLGAIN,
AIC32X4_LORGAIN, 6, 0x01, 1),
+ SOC_ENUM("LO Playback Common Mode Switch", lo_cm_enum),
SOC_DOUBLE_R("Mic PGA Switch", AIC32X4_LMICPGAVOL,
AIC32X4_RMICPGAVOL, 7, 0x01, 1),
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ASoC: tlv320aic32x4: Add Playback PowerTune Controls
2019-04-04 4:01 [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Annaliese McDermond
@ 2019-04-04 4:01 ` Annaliese McDermond
2019-04-04 13:58 ` Applied "ASoC: tlv320aic32x4: Add Playback PowerTune Controls" to the asoc tree Mark Brown
2019-04-04 5:43 ` [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Mark Brown
2019-04-04 13:58 ` Applied "ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage" to the asoc tree Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Annaliese McDermond @ 2019-04-04 4:01 UTC (permalink / raw)
To: broonie, alsa-devel; +Cc: team
PowerTune controls the power level of the chip. On playback this
indirectly controls things like the gain of the various output
amplifiers. This can allow for the decrease of output levels
from the codec. This adds controls for those power levels to
the driver.
Signed-off-by: Annaliese McDermond <nh6z@nh6z.net>
---
sound/soc/codecs/tlv320aic32x4.c | 9 +++++++++
sound/soc/codecs/tlv320aic32x4.h | 2 ++
2 files changed, 11 insertions(+)
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index 77df2cbdf5f4..6edee05ff9f0 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -248,9 +248,18 @@ static const char * const lo_cm_text[] = {
static SOC_ENUM_SINGLE_DECL(lo_cm_enum, AIC32X4_CMMODE, 3, lo_cm_text);
+static const char * const ptm_text[] = {
+ "P3", "P2", "P1",
+};
+
+static SOC_ENUM_SINGLE_DECL(l_ptm_enum, AIC32X4_LPLAYBACK, 2, ptm_text);
+static SOC_ENUM_SINGLE_DECL(r_ptm_enum, AIC32X4_RPLAYBACK, 2, ptm_text);
+
static const struct snd_kcontrol_new aic32x4_snd_controls[] = {
SOC_DOUBLE_R_S_TLV("PCM Playback Volume", AIC32X4_LDACVOL,
AIC32X4_RDACVOL, 0, -0x7f, 0x30, 7, 0, tlv_pcm),
+ SOC_ENUM("DAC Left Playback PowerTune Switch", l_ptm_enum),
+ SOC_ENUM("DAC Right Playback PowerTune Switch", r_ptm_enum),
SOC_DOUBLE_R_S_TLV("HP Driver Gain Volume", AIC32X4_HPLGAIN,
AIC32X4_HPRGAIN, 0, -0x6, 0x1d, 5, 0,
tlv_driver_gain),
diff --git a/sound/soc/codecs/tlv320aic32x4.h b/sound/soc/codecs/tlv320aic32x4.h
index 88205bc97198..40734211bc0e 100644
--- a/sound/soc/codecs/tlv320aic32x4.h
+++ b/sound/soc/codecs/tlv320aic32x4.h
@@ -78,6 +78,8 @@ int aic32x4_register_clocks(struct device *dev, const char *mclk_name);
#define AIC32X4_PWRCFG AIC32X4_REG(1, 1)
#define AIC32X4_LDOCTL AIC32X4_REG(1, 2)
+#define AIC32X4_LPLAYBACK AIC32X4_REG(1, 3)
+#define AIC32X4_RPLAYBACK AIC32X4_REG(1, 4)
#define AIC32X4_OUTPWRCTL AIC32X4_REG(1, 9)
#define AIC32X4_CMMODE AIC32X4_REG(1, 10)
#define AIC32X4_HPLROUTE AIC32X4_REG(1, 12)
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage
2019-04-04 4:01 [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Annaliese McDermond
2019-04-04 4:01 ` [PATCH 2/2] ASoC: tlv320aic32x4: Add Playback PowerTune Controls Annaliese McDermond
@ 2019-04-04 5:43 ` Mark Brown
2019-04-04 10:45 ` Annaliese McDermond
2019-04-04 13:58 ` Applied "ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage" to the asoc tree Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2019-04-04 5:43 UTC (permalink / raw)
To: Annaliese McDermond; +Cc: alsa-devel, team
[-- Attachment #1.1: Type: text/plain, Size: 290 bytes --]
On Wed, Apr 03, 2019 at 09:01:54PM -0700, Annaliese McDermond wrote:
> Add a switch for setting common mode voltage. This can allow
> for higher drive levels on the amplifier outputs.
Should this be runtime controllable or is this something that's likely
to be fixed by the board design?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage
2019-04-04 5:43 ` [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Mark Brown
@ 2019-04-04 10:45 ` Annaliese McDermond
0 siblings, 0 replies; 6+ messages in thread
From: Annaliese McDermond @ 2019-04-04 10:45 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, team
> On Apr 3, 2019, at 10:43 PM, Mark Brown <broonie@kernel.org> wrote:
>
>> On Wed, Apr 03, 2019 at 09:01:54PM -0700, Annaliese McDermond wrote:
>> Add a switch for setting common mode voltage. This can allow
>> for higher drive levels on the amplifier outputs.
>
> Should this be runtime controllable or is this something that's likely
> to be fixed by the board design?
For us, in our particular application, it’s really necessary at runtime. Our use
case is not that we are driving speakers, but the inputs of various amateur
radio units. Experience has shown us that the input characteristics of these
devices vary widely and require different levels of drive to function
correctly; a Motorola may need a lot of drive compared to an Icom that
requires almost none.
We could modify the board to have an outboard amplifier of some sort on
it, but that just moves the problem to another component. Or we could put
some sort of prescaling switchable resistors in the board, but this also adds
complexity that’s dubious.
I’ve thought about putting these in the DT, but it occurs to me that they are
really not board design dependent. The options are really there to control
power consumption on the chip. In our application that’s really not important.
For other applications I can see where that might be useful to change
dynamically at runtime depending on current conditions.
—
Annaliese McDermond
nh6z@nh6z.net
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Applied "ASoC: tlv320aic32x4: Add Playback PowerTune Controls" to the asoc tree
2019-04-04 4:01 ` [PATCH 2/2] ASoC: tlv320aic32x4: Add Playback PowerTune Controls Annaliese McDermond
@ 2019-04-04 13:58 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2019-04-04 13:58 UTC (permalink / raw)
To: Annaliese McDermond; +Cc: team, alsa-devel, broonie
The patch
ASoC: tlv320aic32x4: Add Playback PowerTune Controls
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From d3e6e374566e1154820a9a3dc82f7eef646fcf95 Mon Sep 17 00:00:00 2001
From: Annaliese McDermond <nh6z@nh6z.net>
Date: Wed, 3 Apr 2019 21:01:55 -0700
Subject: [PATCH] ASoC: tlv320aic32x4: Add Playback PowerTune Controls
PowerTune controls the power level of the chip. On playback this
indirectly controls things like the gain of the various output
amplifiers. This can allow for the decrease of output levels
from the codec. This adds controls for those power levels to
the driver.
Signed-off-by: Annaliese McDermond <nh6z@nh6z.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/tlv320aic32x4.c | 9 +++++++++
sound/soc/codecs/tlv320aic32x4.h | 2 ++
2 files changed, 11 insertions(+)
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index 77df2cbdf5f4..6edee05ff9f0 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -248,9 +248,18 @@ static const char * const lo_cm_text[] = {
static SOC_ENUM_SINGLE_DECL(lo_cm_enum, AIC32X4_CMMODE, 3, lo_cm_text);
+static const char * const ptm_text[] = {
+ "P3", "P2", "P1",
+};
+
+static SOC_ENUM_SINGLE_DECL(l_ptm_enum, AIC32X4_LPLAYBACK, 2, ptm_text);
+static SOC_ENUM_SINGLE_DECL(r_ptm_enum, AIC32X4_RPLAYBACK, 2, ptm_text);
+
static const struct snd_kcontrol_new aic32x4_snd_controls[] = {
SOC_DOUBLE_R_S_TLV("PCM Playback Volume", AIC32X4_LDACVOL,
AIC32X4_RDACVOL, 0, -0x7f, 0x30, 7, 0, tlv_pcm),
+ SOC_ENUM("DAC Left Playback PowerTune Switch", l_ptm_enum),
+ SOC_ENUM("DAC Right Playback PowerTune Switch", r_ptm_enum),
SOC_DOUBLE_R_S_TLV("HP Driver Gain Volume", AIC32X4_HPLGAIN,
AIC32X4_HPRGAIN, 0, -0x6, 0x1d, 5, 0,
tlv_driver_gain),
diff --git a/sound/soc/codecs/tlv320aic32x4.h b/sound/soc/codecs/tlv320aic32x4.h
index 88205bc97198..40734211bc0e 100644
--- a/sound/soc/codecs/tlv320aic32x4.h
+++ b/sound/soc/codecs/tlv320aic32x4.h
@@ -78,6 +78,8 @@ int aic32x4_register_clocks(struct device *dev, const char *mclk_name);
#define AIC32X4_PWRCFG AIC32X4_REG(1, 1)
#define AIC32X4_LDOCTL AIC32X4_REG(1, 2)
+#define AIC32X4_LPLAYBACK AIC32X4_REG(1, 3)
+#define AIC32X4_RPLAYBACK AIC32X4_REG(1, 4)
#define AIC32X4_OUTPWRCTL AIC32X4_REG(1, 9)
#define AIC32X4_CMMODE AIC32X4_REG(1, 10)
#define AIC32X4_HPLROUTE AIC32X4_REG(1, 12)
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Applied "ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage" to the asoc tree
2019-04-04 4:01 [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Annaliese McDermond
2019-04-04 4:01 ` [PATCH 2/2] ASoC: tlv320aic32x4: Add Playback PowerTune Controls Annaliese McDermond
2019-04-04 5:43 ` [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Mark Brown
@ 2019-04-04 13:58 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2019-04-04 13:58 UTC (permalink / raw)
To: Annaliese McDermond; +Cc: team, alsa-devel, broonie
The patch
ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 44ceee847e27c828f2f1ef4e400e6bc0c8d04de3 Mon Sep 17 00:00:00 2001
From: Annaliese McDermond <nh6z@nh6z.net>
Date: Wed, 3 Apr 2019 21:01:54 -0700
Subject: [PATCH] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode
Voltage
Add a switch for setting common mode voltage. This can allow
for higher drive levels on the amplifier outputs.
Signed-off-by: Annaliese McDermond <nh6z@nh6z.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/tlv320aic32x4.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index aec86fd6ac15..77df2cbdf5f4 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -242,6 +242,12 @@ static DECLARE_TLV_DB_SCALE(tlv_driver_gain, -600, 100, 0);
/* -12dB min, 0.5dB steps */
static DECLARE_TLV_DB_SCALE(tlv_adc_vol, -1200, 50, 0);
+static const char * const lo_cm_text[] = {
+ "Full Chip", "1.65V",
+};
+
+static SOC_ENUM_SINGLE_DECL(lo_cm_enum, AIC32X4_CMMODE, 3, lo_cm_text);
+
static const struct snd_kcontrol_new aic32x4_snd_controls[] = {
SOC_DOUBLE_R_S_TLV("PCM Playback Volume", AIC32X4_LDACVOL,
AIC32X4_RDACVOL, 0, -0x7f, 0x30, 7, 0, tlv_pcm),
@@ -255,6 +261,7 @@ static const struct snd_kcontrol_new aic32x4_snd_controls[] = {
AIC32X4_HPRGAIN, 6, 0x01, 1),
SOC_DOUBLE_R("LO DAC Playback Switch", AIC32X4_LOLGAIN,
AIC32X4_LORGAIN, 6, 0x01, 1),
+ SOC_ENUM("LO Playback Common Mode Switch", lo_cm_enum),
SOC_DOUBLE_R("Mic PGA Switch", AIC32X4_LMICPGAVOL,
AIC32X4_RMICPGAVOL, 7, 0x01, 1),
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-04 13:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 4:01 [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Annaliese McDermond
2019-04-04 4:01 ` [PATCH 2/2] ASoC: tlv320aic32x4: Add Playback PowerTune Controls Annaliese McDermond
2019-04-04 13:58 ` Applied "ASoC: tlv320aic32x4: Add Playback PowerTune Controls" to the asoc tree Mark Brown
2019-04-04 5:43 ` [PATCH 1/2] ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage Mark Brown
2019-04-04 10:45 ` Annaliese McDermond
2019-04-04 13:58 ` Applied "ASoC: tlv320aic32x4: Add Switch for Setting Common Mode Voltage" to the asoc tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.