* [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests
@ 2019-04-04 11:33 Daniel Vetter
2019-04-04 11:42 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-04-04 11:33 UTC (permalink / raw)
To: IGT development; +Cc: Peres, Martin, Daniel Vetter
Step 1 in debugging: Actually understand what's going wrong.
References: https://bugs.freedesktop.org/show_bug.cgi?id=102887
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: "Peres, Martin" <martin.peres@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_flip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index dfa5a69e8f28..7c2aa0c02a0e 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -681,7 +681,7 @@ static unsigned int run_test_step(struct test_output *o)
TEST_VBLANK_BLOCK, o->pipe, exp_seq,
0, &reply));
igt_assert(gettime_us() - start < 500);
- igt_assert(reply.sequence == exp_seq);
+ igt_assert_eq(reply.sequence, exp_seq);
igt_assert(timercmp(&reply.ts, &o->flip_state.last_ts, ==));
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests
2019-04-04 11:33 [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests Daniel Vetter
@ 2019-04-04 11:42 ` Chris Wilson
2019-04-24 8:28 ` Daniel Vetter
2019-04-04 13:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-05 4:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2019-04-04 11:42 UTC (permalink / raw)
To: Daniel Vetter, IGT development; +Cc: Daniel Vetter, Peres, Martin
Quoting Daniel Vetter (2019-04-04 12:33:00)
> Step 1 in debugging: Actually understand what's going wrong.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102887
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: "Peres, Martin" <martin.peres@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: Improve asserts for expired vblank tests
2019-04-04 11:33 [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests Daniel Vetter
2019-04-04 11:42 ` Chris Wilson
@ 2019-04-04 13:51 ` Patchwork
2019-04-05 4:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-04-04 13:51 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: tests/kms_flip: Improve asserts for expired vblank tests
URL : https://patchwork.freedesktop.org/series/59005/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5870 -> IGTPW_2786
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59005/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2786 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
- fi-icl-y: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3
* igt@prime_vgem@basic-fence-flip:
- fi-icl-y: NOTRUN -> SKIP [fdo#109294]
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- fi-ilk-650: DMESG-WARN [fdo#106387] -> PASS
- {fi-kbl-7567u}: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS
* igt@gem_exec_suspend@basic-s3:
- {fi-kbl-7567u}: DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602] -> PASS
* igt@gem_tiled_blits@basic:
- fi-icl-y: INCOMPLETE -> PASS
* igt@i915_module_load@reload-with-fault-injection:
- {fi-kbl-7567u}: DMESG-WARN [fdo#105602] / [fdo#108529] -> PASS +1
* igt@i915_pm_rpm@module-reload:
- {fi-kbl-7567u}: DMESG-WARN [fdo#108529] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@kms_busy@basic-flip-a:
- {fi-kbl-7567u}: SKIP [fdo#109271] / [fdo#109278] -> PASS +2
* igt@kms_chamelium@hdmi-edid-read:
- {fi-kbl-7567u}: FAIL [fdo#109569] -> PASS +1
* igt@kms_chamelium@hdmi-hpd-fast:
- {fi-kbl-7567u}: FAIL [fdo#109800] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- {fi-kbl-7567u}: DMESG-FAIL [fdo#105079] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@prime_vgem@basic-fence-flip:
- {fi-kbl-7567u}: SKIP [fdo#109271] -> PASS +4
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109569]: https://bugs.freedesktop.org/show_bug.cgi?id=109569
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#109800]: https://bugs.freedesktop.org/show_bug.cgi?id=109800
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (50 -> 45)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* IGT: IGT_4928 -> IGTPW_2786
CI_DRM_5870: 122dc43df57c9a03132314ddc78a6d60c714fa32 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2786: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2786/
IGT_4928: 014a6fa238322b497116b359cb92df1ce7fa8847 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2786/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip: Improve asserts for expired vblank tests
2019-04-04 11:33 [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests Daniel Vetter
2019-04-04 11:42 ` Chris Wilson
2019-04-04 13:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-05 4:27 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-04-05 4:27 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: tests/kms_flip: Improve asserts for expired vblank tests
URL : https://patchwork.freedesktop.org/series/59005/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5870_full -> IGTPW_2786_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59005/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2786_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_atomic_transition@4x-modeset-transitions:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222]
- shard-kbl: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: PASS -> DMESG-WARN [fdo#110222] +2
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> FAIL [fdo#108739] / [fdo#110321]
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-glk: PASS -> FAIL [fdo#103060]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +7
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: NOTRUN -> SKIP [fdo#109271]
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- shard-apl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: FAIL [fdo#108686] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#110222] -> PASS +1
- shard-kbl: DMESG-WARN [fdo#110222] -> PASS
- shard-snb: DMESG-WARN [fdo#110222] -> PASS
* igt@kms_cursor_edge_walk@pipe-a-64x64-left-edge:
- shard-snb: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_flip@modeset-vs-vblank-race:
- shard-kbl: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt:
- shard-snb: SKIP [fdo#109271] -> PASS +4
* igt@kms_plane_scaling@pipe-c-scaler-with-rotation:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-modeset:
- shard-kbl: FAIL [fdo#104894] -> PASS
- shard-apl: FAIL [fdo#104894] -> PASS
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (9 -> 5)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-glk-j5005 shard-iclb
Build changes
-------------
* IGT: IGT_4928 -> IGTPW_2786
* Piglit: piglit_4509 -> None
CI_DRM_5870: 122dc43df57c9a03132314ddc78a6d60c714fa32 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2786: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2786/
IGT_4928: 014a6fa238322b497116b359cb92df1ce7fa8847 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2786/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests
2019-04-04 11:42 ` Chris Wilson
@ 2019-04-24 8:28 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-04-24 8:28 UTC (permalink / raw)
To: Chris Wilson; +Cc: IGT development, Peres, Martin, Daniel Vetter
On Thu, Apr 04, 2019 at 12:42:31PM +0100, Chris Wilson wrote:
> Quoting Daniel Vetter (2019-04-04 12:33:00)
> > Step 1 in debugging: Actually understand what's going wrong.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=102887
> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > Cc: "Peres, Martin" <martin.peres@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks for your review, patch pushed.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-24 8:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 11:33 [igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests Daniel Vetter
2019-04-04 11:42 ` Chris Wilson
2019-04-24 8:28 ` Daniel Vetter
2019-04-04 13:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-05 4:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.