From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
Roland McGrath <roland@hack.frob.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-arch@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Dominik Brodowski <linux@dominikbrodowski.net>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Palmer Dabbelt <palmer@sifive.com>,
Will Drewry <wad@chromium.org>, Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH 4/6 v3] csky: Fix syscall_get_arguments() and syscall_set_arguments()
Date: Thu, 4 Apr 2019 17:02:01 +0300 [thread overview]
Message-ID: <20190404140200.GB4962@altlinux.org> (raw)
In-Reply-To: <20190401134421.121919570@goodmis.org>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On Mon, Apr 01, 2019 at 09:41:08AM -0400, Steven Rostedt wrote:
> From: "Dmitry V. Levin" <ldv@altlinux.org>
>
> C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1]
> fields of struct pt_regs.
>
> Due to an off-by-one bug and a bug in pointer arithmetic
> syscall_get_arguments() was reading orig_a0,regs[1..5] fields instead.
> Likewise, syscall_set_arguments() was writing orig_a0,regs[1..5] fields
> instead.
>
> Link: http://lkml.kernel.org/r/20190329171230.GB32456@altlinux.org
>
> Fixes: 4859bfca11c7d ("csky: System Call")
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Will Drewry <wad@chromium.org>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: stable@vger.kernel.org # v4.20+
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
According to
https://lore.kernel.org/lkml/20190330004949.GA15705@guoren-Inspiron-7460/
the following tags could be added to this patch:
Tested-by: Guo Ren <ren_guo@c-sky.com>
Acked-by: Guo Ren <ren_guo@c-sky.com>
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
Roland McGrath <roland@hack.frob.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-arch@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Dominik Brodowski <linux@dominikbrodowski.net>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Palmer Dabbelt <palmer@sifive.com>,
Will Drewry <wad@chromium.org>
Subject: Re: [PATCH 4/6 v3] csky: Fix syscall_get_arguments() and syscall_set_arguments()
Date: Thu, 4 Apr 2019 17:02:01 +0300 [thread overview]
Message-ID: <20190404140200.GB4962@altlinux.org> (raw)
In-Reply-To: <20190401134421.121919570@goodmis.org>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On Mon, Apr 01, 2019 at 09:41:08AM -0400, Steven Rostedt wrote:
> From: "Dmitry V. Levin" <ldv@altlinux.org>
>
> C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1]
> fields of struct pt_regs.
>
> Due to an off-by-one bug and a bug in pointer arithmetic
> syscall_get_arguments() was reading orig_a0,regs[1..5] fields instead.
> Likewise, syscall_set_arguments() was writing orig_a0,regs[1..5] fields
> instead.
>
> Link: http://lkml.kernel.org/r/20190329171230.GB32456@altlinux.org
>
> Fixes: 4859bfca11c7d ("csky: System Call")
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Will Drewry <wad@chromium.org>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: stable@vger.kernel.org # v4.20+
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
According to
https://lore.kernel.org/lkml/20190330004949.GA15705@guoren-Inspiron-7460/
the following tags could be added to this patch:
Tested-by: Guo Ren <ren_guo@c-sky.com>
Acked-by: Guo Ren <ren_guo@c-sky.com>
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2019-04-04 14:02 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 13:41 [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments() Steven Rostedt
2019-04-01 13:41 ` [PATCH 1/6 v3] ptrace: Remove maxargs from task_current_syscall() Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 7:52 ` Thomas Gleixner
2019-04-01 13:41 ` [PATCH 2/6 v3] tracing/syscalls: Pass in hardcoded 6 into syscall_get_arguments() Steven Rostedt
2019-04-01 13:41 ` [PATCH 3/6 v3] riscv: Fix syscall_get_arguments() and syscall_set_arguments() Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-04 14:02 ` Dmitry V. Levin
2019-04-04 14:02 ` Dmitry V. Levin
2019-04-04 14:02 ` Dmitry V. Levin
2019-04-04 14:26 ` Steven Rostedt
2019-04-04 14:26 ` Steven Rostedt
2019-04-04 14:26 ` Steven Rostedt
2019-04-04 23:29 ` Palmer Dabbelt
2019-04-04 23:29 ` Palmer Dabbelt
2019-04-01 13:41 ` [PATCH 4/6 v3] csky: " Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-04 14:02 ` Dmitry V. Levin [this message]
2019-04-04 14:02 ` Dmitry V. Levin
2019-04-04 14:28 ` Steven Rostedt
2019-04-04 14:28 ` Steven Rostedt
2019-04-01 13:41 ` [PATCH 5/6 v3] syscalls: Remove start and number from syscall_get_arguments() args Steven Rostedt
2019-04-01 13:41 ` [OpenRISC] " Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-03 22:51 ` Paul Burton
2019-04-03 22:51 ` [OpenRISC] " Paul Burton
2019-04-03 22:51 ` Paul Burton
2019-04-03 22:51 ` Paul Burton
2019-04-03 22:51 ` Paul Burton
2019-04-03 22:51 ` Paul Burton
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 7:52 ` [OpenRISC] " Thomas Gleixner
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 7:52 ` Thomas Gleixner
2019-04-04 18:17 ` Dmitry V. Levin
2019-04-04 18:17 ` [OpenRISC] " Dmitry V. Levin
2019-04-04 18:17 ` Dmitry V. Levin
2019-04-04 18:17 ` Dmitry V. Levin
2019-04-04 18:17 ` Dmitry V. Levin
2019-04-04 18:17 ` Dmitry V. Levin
2019-04-04 18:17 ` Dmitry V. Levin
2019-04-04 18:17 ` Dmitry V. Levin
2019-04-04 21:06 ` Steven Rostedt
2019-04-04 21:06 ` [OpenRISC] " Steven Rostedt
2019-04-04 21:06 ` Steven Rostedt
2019-04-04 21:06 ` Steven Rostedt
2019-04-04 21:06 ` Steven Rostedt
2019-04-04 21:06 ` Steven Rostedt
2019-04-04 21:06 ` Steven Rostedt
2019-04-04 21:06 ` Steven Rostedt
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` [OpenRISC] " Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-04 18:56 ` Max Filippov
2019-04-01 13:41 ` [PATCH 6/6 v3] syscalls: Remove start and number from syscall_set_arguments() args Steven Rostedt
2019-04-01 13:41 ` [OpenRISC] " Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-01 13:41 ` Steven Rostedt
2019-04-04 7:53 ` Thomas Gleixner
2019-04-04 7:53 ` [OpenRISC] " Thomas Gleixner
2019-04-04 7:53 ` Thomas Gleixner
2019-04-04 7:53 ` Thomas Gleixner
2019-04-04 7:53 ` Thomas Gleixner
2019-04-04 7:53 ` Thomas Gleixner
2019-04-04 7:53 ` Thomas Gleixner
2019-04-04 7:53 ` Thomas Gleixner
2019-04-04 18:18 ` Dmitry V. Levin
2019-04-04 18:18 ` [OpenRISC] " Dmitry V. Levin
2019-04-04 18:18 ` Dmitry V. Levin
2019-04-04 18:18 ` Dmitry V. Levin
2019-04-04 18:18 ` Dmitry V. Levin
2019-04-04 18:18 ` Dmitry V. Levin
2019-04-04 18:18 ` Dmitry V. Levin
2019-04-04 18:18 ` Dmitry V. Levin
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` [OpenRISC] " Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 18:55 ` Max Filippov
2019-04-04 13:28 ` [PATCH 0/6 v3] sycalls: Remove args i and n from syscall_get_arguments() Steven Rostedt
2019-04-05 1:24 ` Linus Torvalds
2019-04-05 1:24 ` Linus Torvalds
2019-04-05 14:07 ` Steven Rostedt
2019-04-05 14:07 ` Steven Rostedt
2019-04-05 8:58 ` Will Deacon
2019-04-05 8:58 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404140200.GB4962@altlinux.org \
--to=ldv@altlinux.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=ebiederm@xmission.com \
--cc=guoren@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=palmer@sifive.com \
--cc=peterz@infradead.org \
--cc=roland@hack.frob.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.