[Intel-wired-lan] [1/2] ixgbe: fix AF_XDP tx byte count

[Intel-wired-lan] [1/2] ixgbe: fix AF_XDP tx byte count

[Jeff Kirsher]

From: William Tu <u9012063@gmail.com>

The tx bytecount is done twice.  When running
'./xdpsock -t -N -i eth3' and 'ip -s link show dev eth3'
The avg packet size is 120 instead of 60. So remove the
extra one.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
index bfe95ce0bd7f..71b8474a9b4c 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
@@ -704,7 +704,6 @@ bool ixgbe_clean_xdp_tx_irq(struct ixgbe_q_vector *q_vector,
 			xsk_frames++;
 
 		tx_bi->xdpf = NULL;
-		total_bytes += tx_bi->bytecount;
 
 		tx_bi++;
 		tx_desc++;

[Intel-wired-lan] [2/2] ixgbe: fix AF_XDP tx packet count.

[Jeff Kirsher]

From: William Tu <u9012063@gmail.com>

The total_packets count at ixgbe_clean_xdp_tx_irq is
always zero when testing with xdpsock -t -N. Set the gso_segs
to 1 to make the tx packet count correct.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
index 71b8474a9b4c..1a60764fb39b 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c
@@ -640,6 +640,7 @@ static bool ixgbe_xmit_zc(struct ixgbe_ring *xdp_ring, unsigned int budget)
 		tx_bi = &xdp_ring->tx_buffer_info[xdp_ring->next_to_use];
 		tx_bi->bytecount = len;
 		tx_bi->xdpf = NULL;
+		tx_bi->gso_segs = 1;
 
 		tx_desc = IXGBE_TX_DESC(xdp_ring, xdp_ring->next_to_use);
 		tx_desc->read.buffer_addr = cpu_to_le64(dma);

[Intel-wired-lan] [1/2] ixgbe: fix AF_XDP tx byte count

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Thursday, April 4, 2019 9:37 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: William Tu <u9012063@gmail.com>
> Subject: [Intel-wired-lan] [1/2] ixgbe: fix AF_XDP tx byte count
> 
> From: William Tu <u9012063@gmail.com>
> 
> The tx bytecount is done twice.  When running './xdpsock -t -N -i eth3' and 'ip
> -s link show dev eth3'
> The avg packet size is 120 instead of 60. So remove the extra one.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 -
>  1 file changed, 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

[Intel-wired-lan] [2/2] ixgbe: fix AF_XDP tx packet count.

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Jeff Kirsher
> Sent: Thursday, April 4, 2019 9:37 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: William Tu <u9012063@gmail.com>
> Subject: [Intel-wired-lan] [2/2] ixgbe: fix AF_XDP tx packet count.
> 
> From: William Tu <u9012063@gmail.com>
> 
> The total_packets count at ixgbe_clean_xdp_tx_irq is always zero when
> testing with xdpsock -t -N. Set the gso_segs to 1 to make the tx packet count
> correct.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 1 +
>  1 file changed, 1 insertion(+)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>