All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/13] meson/gobject-introspection rework
@ 2019-04-05  6:37 Andreas Müller
  2019-04-05  6:37 ` [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson Andreas Müller
                   ` (13 more replies)
  0 siblings, 14 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

* Make meson builds aware of unrecognized config options.
* central auto-enable/disable gobject-introspection for meson builds + 
  unrecognized options are triggered for meson & autotools now
  
Note that native recipes are build gobject-introspection disabled (as before
when building with autotools)

Did test this series with my heavy-heavy-monster image but there might be
fallout if 'unknown-configure-option' in ERROR_QA is set but:

* It is better to be aware of options set wrongly (some were discovered already
  by this series)
* Patches for meta-gnome for packages not accepting gi on/off option are in the
  queue already
* glib-networking upgrade was done because it reintroduces on/off config option
  for gobject-introspection

Andreas Müller (13):
  insane.bbclass: Trigger unrecognzed configure option for meson
  gobject-introspection: auto-enable/-disable gobject-introspection for
    meson
  libmodulemd: use gobject-introspection.bbclass on/off mechanism
  gdk-pixbuf: use gobject-introspection.bbclass on/off mechanism
  json-glib: use gobject-introspection.bbclass on/off mechanism
  libdazzle: use gobject-introspection.bbclass on/off mechanism
  clutter-gtk-1.0: use gobject-introspection.bbclass on/off mechanism
  pango: use gobject-introspection.bbclass on/off mechanism
  at-spi2-core: use gobject-introspection.bbclass on/off mechanism
  atk: use gobject-introspection.bbclass on/off mechanism
  libsoup-2.4: use gobject-introspection.bbclass on/off mechanism
  glib-networking: upgrade 2.58.0 -> 2.60.1
  gst-plugins: move 'inherit gobject-introspection' to recipes
    supporting GI

 meta/classes/gobject-introspection.bbclass         | 14 ++++++++++++--
 meta/classes/insane.bbclass                        | 12 ++++++++----
 ...working_2.58.0.bb => glib-networking_2.60.1.bb} | 10 +++++-----
 .../libmodulemd/libmodulemd_git.bb                 | 11 +++--------
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.38.0.bb |  8 +-------
 meta/recipes-gnome/json-glib/json-glib_1.4.4.bb    |  5 -----
 meta/recipes-gnome/libdazzle/libdazzle_3.30.2.bb   |  6 +-----
 meta/recipes-graphics/clutter/clutter-gtk-1.0.inc  | 11 +----------
 meta/recipes-graphics/pango/pango_1.42.4.bb        | 10 +---------
 .../gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb   |  2 +-
 .../gstreamer/gstreamer1.0-plugins-base_1.14.4.bb  |  2 +-
 .../gstreamer/gstreamer1.0-plugins.inc             |  2 +-
 meta/recipes-support/atk/at-spi2-core_2.30.0.bb    | 10 ++++------
 meta/recipes-support/atk/atk_2.30.0.bb             |  8 --------
 meta/recipes-support/libsoup/libsoup-2.4_2.64.2.bb |  8 --------
 15 files changed, 39 insertions(+), 80 deletions(-)
 rename meta/recipes-core/glib-networking/{glib-networking_2.58.0.bb => glib-networking_2.60.1.bb} (71%)

-- 
2.20.1



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05 21:44   ` Khem Raj
  2019-04-05  6:37 ` [PATCH 02/13] gobject-introspection: auto-enable/-disable gobject-introspection " Andreas Müller
                   ` (12 subsequent siblings)
  13 siblings, 1 reply; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Tested with 'unknown-configure-option' in ERROR_QA:

For meson (glib-2.0-native):
1. add 'EXTRA_OEMESON_append = "-Dschnitzel=true -Dwurst=true"'
   | ERROR: glib-2.0-native-1_2.58.3-r0 do_configure: QA Issue: glib-2.0-native: configure was passed unrecognised options: schnitzel wurst [unknown-configure-option]
2. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" schnitzel"'
   | ERROR: glib-2.0-native-1_2.58.3-r0 do_configure: QA Issue: glib-2.0-native: configure was passed unrecognised options: wurst [unknown-configure-option]
3. change to 'UNKNOWN_CONFIGURE_WHITELIST_append=" schnitzel wurst"'
   => builds without issues

For autotools (readline-native):
1. add 'EXTRA_OECONF = "--with-schnitzel --with-wurst"'
   | ERROR: readline-native-8.0-r0 do_configure: QA Issue: readline-native: configure was passed unrecognised options: --with-wurst --with-schnitzel [unknown-configure-option]
2. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" --with-schnitzel"'
   | ERROR: readline-native-8.0-r0 do_configure: QA Issue: readline-native: configure was passed unrecognised options: --with-wurst [unknown-configure-option]
3. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" --with-schnitzel --with-wurst"'
   => builds without issues

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---

This is a resend

 meta/classes/insane.bbclass | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 37b8bb0032..c8d18c07f5 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1093,12 +1093,16 @@ Rerun configure task after fixing this."""
     ###########################################################################
     # Check unrecognised configure options (with a white list)
     ###########################################################################
-    if bb.data.inherits_class("autotools", d):
+    if bb.data.inherits_class("autotools", d) or bb.data.inherits_class("meson", d):
         bb.note("Checking configure output for unrecognised options")
         try:
-            flag = "WARNING: unrecognized options:"
-            log = os.path.join(d.getVar('B'), 'config.log')
-            output = subprocess.check_output(['grep', '-F', flag, log]).decode("utf-8").replace(', ', ' ')
+            if bb.data.inherits_class("autotools", d):
+                flag = "WARNING: unrecognized options:"
+                log = os.path.join(d.getVar('B'), 'config.log')
+            if bb.data.inherits_class("meson", d):
+                flag = "WARNING: Unknown options:"
+                log = os.path.join(d.getVar('T'), 'log.do_configure')
+            output = subprocess.check_output(['grep', '-F', flag, log]).decode("utf-8").replace(', ', ' ').replace('"', '')
             options = set()
             for line in output.splitlines():
                 options |= set(line.partition(flag)[2].split())
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 02/13] gobject-introspection: auto-enable/-disable gobject-introspection for meson
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
  2019-04-05  6:37 ` [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 03/13] libmodulemd: use gobject-introspection.bbclass on/off mechanism Andreas Müller
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

* the class sets defaults used most common which can be overriden by recipes
* UNKNOWN_CONFIGURE_WHITELIST was removed for autotools (and not added for meson)
  as suggested by Alexander Kanavin [1]

[1] http://lists.openembedded.org/pipermail/openembedded-core/2019-April/280716.html

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
V1 -> V2: Introduce GIR_MESON_OPTION as suggested by Alexander Kanavin
V2 -> V3: * Add GIR_MESON_ENABLE_FLAG / GIR_MESON_DISABLE_FLAG
          * remove UNKNOWN_CONFIGURE_WHITELIST_append

 meta/classes/gobject-introspection.bbclass | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/meta/classes/gobject-introspection.bbclass b/meta/classes/gobject-introspection.bbclass
index 4ceb0c68b1..504f75e28d 100644
--- a/meta/classes/gobject-introspection.bbclass
+++ b/meta/classes/gobject-introspection.bbclass
@@ -6,14 +6,24 @@
 # This also sets up autoconf-based recipes to build introspection data (or not),
 # depending on distro and machine features (see gobject-introspection-data class).
 inherit python3native gobject-introspection-data
+
+# meson: default option name to enable/disable introspection. This matches most
+# project's configuration. In doubts - check meson_options.txt in project's
+# source path.
+GIR_MESON_OPTION ?= 'introspection'
+GIR_MESON_ENABLE_FLAG ?= 'true'
+GIR_MESON_DISABLE_FLAG ?= 'false'
+
+# Auto enable/disable based on GI_DATA_ENABLED
 EXTRA_OECONF_prepend_class-target = "${@bb.utils.contains('GI_DATA_ENABLED', 'True', '--enable-introspection', '--disable-introspection', d)} "
+EXTRA_OEMESON_prepend_class-target = "-D${GIR_MESON_OPTION}=${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GIR_MESON_ENABLE_FLAG}', '${GIR_MESON_DISABLE_FLAG}', d)} "
 
 # When building native recipes, disable introspection, as it is not necessary,
 # pulls in additional dependencies, and makes build times longer
 EXTRA_OECONF_prepend_class-native = "--disable-introspection "
 EXTRA_OECONF_prepend_class-nativesdk = "--disable-introspection "
-
-UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
+EXTRA_OEMESON_prepend_class-native = "-D${GIR_MESON_OPTION}=${GIR_MESON_DISABLE_FLAG} "
+EXTRA_OEMESON_prepend_class-nativesdk = "-D${GIR_MESON_OPTION}=${GIR_MESON_DISABLE_FLAG} "
 
 # Generating introspection data depends on a combination of native and target
 # introspection tools, and qemu to run the target tools.
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 03/13] libmodulemd: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
  2019-04-05  6:37 ` [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson Andreas Müller
  2019-04-05  6:37 ` [PATCH 02/13] gobject-introspection: auto-enable/-disable gobject-introspection " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 04/13] gdk-pixbuf: " Andreas Müller
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-devtools/libmodulemd/libmodulemd_git.bb | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb b/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb
index 87e92114c8..84012e4193 100644
--- a/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb
+++ b/meta/recipes-devtools/libmodulemd/libmodulemd_git.bb
@@ -20,11 +20,6 @@ DEPENDS += "glib-2.0 libyaml glib-2.0-native"
 
 BBCLASSEXTEND = "native nativesdk"
 
-GI_ENABLE_FLAG = "-Dskip_introspection=false"
-GI_DISABLE_FLAG = "-Dskip_introspection=true"
-
-EXTRA_OEMESON_append_class-nativesdk = " ${GI_DISABLE_FLAG}"
-EXTRA_OEMESON_append_class-native = " ${GI_DISABLE_FLAG}"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
+GIR_MESON_OPTION = 'skip_introspection'
+GIR_MESON_ENABLE_FLAG = 'false'
+GIR_MESON_DISABLE_FLAG = 'true'
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 04/13] gdk-pixbuf: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (2 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 03/13] libmodulemd: use gobject-introspection.bbclass on/off mechanism Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 05/13] json-glib: " Andreas Müller
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.38.0.bb | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.38.0.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.38.0.bb
index c5de7a92a5..e423b99687 100644
--- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.38.0.bb
+++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.38.0.bb
@@ -37,13 +37,7 @@ inherit meson pkgconfig gettext pixbufcache ptest-gnome upstream-version-is-even
 GTKDOC_ENABLE_FLAG = "-Ddocs=true"
 GTKDOC_DISABLE_FLAG = "-Ddocs=false"
 
-GI_ENABLE_FLAG = "-Dgir=true"
-GI_DISABLE_FLAG = "-Dgir=false"
-
-EXTRA_OEMESON_append_class-nativesdk = " ${GI_DISABLE_FLAG}"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
+GIR_MESON_OPTION = 'gir'
 
 EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \
                                                                                      '${GTKDOC_DISABLE_FLAG}', d)} "
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 05/13] json-glib: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (3 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 04/13] gdk-pixbuf: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 06/13] libdazzle: " Andreas Müller
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-gnome/json-glib/json-glib_1.4.4.bb | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/meta/recipes-gnome/json-glib/json-glib_1.4.4.bb b/meta/recipes-gnome/json-glib/json-glib_1.4.4.bb
index 95f90569de..31c008db47 100644
--- a/meta/recipes-gnome/json-glib/json-glib_1.4.4.bb
+++ b/meta/recipes-gnome/json-glib/json-glib_1.4.4.bb
@@ -23,13 +23,8 @@ PACKAGECONFIG[manpages] = "-Dman=true,-Dman=false,libxslt-native xmlto-native"
 GTKDOC_ENABLE_FLAG = "-Ddocs=true"
 GTKDOC_DISABLE_FLAG = "-Ddocs=false"
 
-GI_ENABLE_FLAG = "-Dintrospection=true"
-GI_DISABLE_FLAG = "-Dintrospection=false"
-
 EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \
                                                                                     '${GTKDOC_DISABLE_FLAG}', d)} "
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                    '${GI_DISABLE_FLAG}', d)} "
 
 do_install_append() {
 	if ! ${@bb.utils.contains('PTEST_ENABLED', '1', 'true', 'false', d)}; then
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 06/13] libdazzle: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (4 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 05/13] json-glib: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 07/13] clutter-gtk-1.0: " Andreas Müller
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-gnome/libdazzle/libdazzle_3.30.2.bb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta/recipes-gnome/libdazzle/libdazzle_3.30.2.bb b/meta/recipes-gnome/libdazzle/libdazzle_3.30.2.bb
index 3779b15af9..c112857f2c 100644
--- a/meta/recipes-gnome/libdazzle/libdazzle_3.30.2.bb
+++ b/meta/recipes-gnome/libdazzle/libdazzle_3.30.2.bb
@@ -11,10 +11,6 @@ SRC_URI += " file://0001-Add-a-define-so-that-gir-compilation-succeeds.patch"
 SRC_URI[archive.md5sum] = "24e2e1b914a34f5b8868a9507d1f3c4c"
 SRC_URI[archive.sha256sum] = "78770eae9fa15ac5acb9c733d29459330b2540affbf72933119e36dbd90b36d5"
 
-GI_ENABLE_FLAG = "-Dwith_introspection=true"
-GI_DISABLE_FLAG = "-Dwith_introspection=false"
+GIR_MESON_OPTION = 'with_introspection'
 
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 07/13] clutter-gtk-1.0: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (5 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 06/13] libdazzle: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 08/13] pango: " Andreas Müller
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-graphics/clutter/clutter-gtk-1.0.inc | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/meta/recipes-graphics/clutter/clutter-gtk-1.0.inc b/meta/recipes-graphics/clutter/clutter-gtk-1.0.inc
index 4e82f56605..5f7daf8124 100644
--- a/meta/recipes-graphics/clutter/clutter-gtk-1.0.inc
+++ b/meta/recipes-graphics/clutter/clutter-gtk-1.0.inc
@@ -16,16 +16,7 @@ PACKAGES  =+ "${PN}-examples"
 GTKDOC_ENABLE_FLAG = "-Denable_docs=true"
 GTKDOC_DISABLE_FLAG = "-Denable_docs=false"
 
-GI_ENABLE_FLAG = "-Denable_gi=true"
-GI_DISABLE_FLAG = "-Denable_gi=false"
-
-EXTRA_OEMESON_append_class-nativesdk = " ${GI_DISABLE_FLAG}"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
-
 EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \
                                                                                      '${GTKDOC_DISABLE_FLAG}', d)} "
 
-
-
+GIR_MESON_OPTION = 'enable_gi'
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 08/13] pango: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (6 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 07/13] clutter-gtk-1.0: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 09/13] at-spi2-core: " Andreas Müller
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-graphics/pango/pango_1.42.4.bb | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/meta/recipes-graphics/pango/pango_1.42.4.bb b/meta/recipes-graphics/pango/pango_1.42.4.bb
index d3357f82de..f3be9f44e1 100644
--- a/meta/recipes-graphics/pango/pango_1.42.4.bb
+++ b/meta/recipes-graphics/pango/pango_1.42.4.bb
@@ -28,17 +28,9 @@ PACKAGECONFIG[x11] = ",,virtual/libx11 libxft"
 
 GTKDOC_ENABLE_FLAG = "-Denable_docs=true"
 GTKDOC_DISABLE_FLAG = "-Denable_docs=false"
-
-GI_ENABLE_FLAG = "-Dgir=true"
-GI_DISABLE_FLAG = "-Dgir=false"
-
-EXTRA_OEMESON_append_class-nativesdk = " ${GI_DISABLE_FLAG}"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
-
 EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \
                                                                                      '${GTKDOC_DISABLE_FLAG}', d)} "
+GIR_MESON_OPTION = 'gir'
 
 LEAD_SONAME = "libpango-1.0*"
 LIBV = "1.8.0"
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 09/13] at-spi2-core: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (7 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 08/13] pango: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 10/13] atk: " Andreas Müller
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-support/atk/at-spi2-core_2.30.0.bb | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/meta/recipes-support/atk/at-spi2-core_2.30.0.bb b/meta/recipes-support/atk/at-spi2-core_2.30.0.bb
index d0b567a5e5..06fb7195b6 100644
--- a/meta/recipes-support/atk/at-spi2-core_2.30.0.bb
+++ b/meta/recipes-support/atk/at-spi2-core_2.30.0.bb
@@ -24,15 +24,13 @@ EXTRA_OEMESON = " -Dsystemd_user_dir=${systemd_user_unitdir} \
 GTKDOC_ENABLE_FLAG = "-Denable_docs=true"
 GTKDOC_DISABLE_FLAG = "-Denable_docs=false"
 
-GI_ENABLE_FLAG = "-Denable-introspection=yes"
-GI_DISABLE_FLAG = "-Denable-introspection=no"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
-
 EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \
                                                                                      '${GTKDOC_DISABLE_FLAG}', d)} "
 
+GIR_MESON_OPTION = 'enable-introspection'
+GIR_MESON_ENABLE_FLAG = 'yes'
+GIR_MESON_DISABLE_FLAG = 'no'
+
 FILES_${PN} += "${datadir}/dbus-1/services/*.service \
                 ${datadir}/dbus-1/accessibility-services/*.service \
                 ${datadir}/defaults/at-spi2 \
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 10/13] atk: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (8 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 09/13] at-spi2-core: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 11/13] libsoup-2.4: " Andreas Müller
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-support/atk/atk_2.30.0.bb | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/meta/recipes-support/atk/atk_2.30.0.bb b/meta/recipes-support/atk/atk_2.30.0.bb
index 4e2dacbc4d..84fdb1510a 100644
--- a/meta/recipes-support/atk/atk_2.30.0.bb
+++ b/meta/recipes-support/atk/atk_2.30.0.bb
@@ -17,14 +17,6 @@ inherit gnomebase gtk-doc gettext upstream-version-is-even gobject-introspection
 GTKDOC_ENABLE_FLAG = "-Ddocs=true"
 GTKDOC_DISABLE_FLAG = "-Ddocs=false"
 
-GI_ENABLE_FLAG = "-Dintrospection=true"
-GI_DISABLE_FLAG = "-Dintrospection=false"
-
-EXTRA_OEMESON_append_class-nativesdk = " ${GI_DISABLE_FLAG}"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
-
 EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \
                                                                                      '${GTKDOC_DISABLE_FLAG}', d)} "
 
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 11/13] libsoup-2.4: use gobject-introspection.bbclass on/off mechanism
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (9 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 10/13] atk: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 12/13] glib-networking: upgrade 2.58.0 -> 2.60.1 Andreas Müller
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 meta/recipes-support/libsoup/libsoup-2.4_2.64.2.bb | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/meta/recipes-support/libsoup/libsoup-2.4_2.64.2.bb b/meta/recipes-support/libsoup/libsoup-2.4_2.64.2.bb
index ae7c1a6863..b095397ec2 100644
--- a/meta/recipes-support/libsoup/libsoup-2.4_2.64.2.bb
+++ b/meta/recipes-support/libsoup/libsoup-2.4_2.64.2.bb
@@ -29,14 +29,6 @@ EXTRA_OEMESON_append = " -Dvapi=false"
 GTKDOC_ENABLE_FLAG = "-Ddoc=true"
 GTKDOC_DISABLE_FLAG = "-Ddoc=false"
 
-GI_ENABLE_FLAG = "-Dintrospection=true"
-GI_DISABLE_FLAG = "-Dintrospection=false"
-
-EXTRA_OEMESON_append_class-nativesdk = " ${GI_DISABLE_FLAG}"
-
-EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GI_DATA_ENABLED', 'True', '${GI_ENABLE_FLAG}', \
-                                                                                       '${GI_DISABLE_FLAG}', d)} "
-
 EXTRA_OEMESON_append_class-target = " ${@bb.utils.contains('GTKDOC_ENABLED', 'True', '${GTKDOC_ENABLE_FLAG}', \
                                                                                      '${GTKDOC_DISABLE_FLAG}', d)} "
 
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 12/13] glib-networking: upgrade 2.58.0 -> 2.60.1
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (10 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 11/13] libsoup-2.4: " Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  6:37 ` [PATCH 13/13] gst-plugins: move 'inherit gobject-introspection' to recipes supporting GI Andreas Müller
  2019-04-05 12:18 ` [PATCH 00/13] meson/gobject-introspection rework Burton, Ross
  13 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

this version support gnutls option again - it was mandatory for 2.58.0

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 ...-networking_2.58.0.bb => glib-networking_2.60.1.bb} | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
 rename meta/recipes-core/glib-networking/{glib-networking_2.58.0.bb => glib-networking_2.60.1.bb} (71%)

diff --git a/meta/recipes-core/glib-networking/glib-networking_2.58.0.bb b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
similarity index 71%
rename from meta/recipes-core/glib-networking/glib-networking_2.58.0.bb
rename to meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
index f3190e1cae..09af229d69 100644
--- a/meta/recipes-core/glib-networking/glib-networking_2.58.0.bb
+++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
@@ -9,15 +9,15 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 SECTION = "libs"
 DEPENDS = "glib-2.0"
 
-SRC_URI[archive.md5sum] = "75b14b7e73a67753be9ce307751c661d"
-SRC_URI[archive.sha256sum] = "bdfa0255e031b8ee003cc283002536b77ee76450105f1dc6ab066b9bf4330068"
+SRC_URI[archive.md5sum] = "83321ffc3c336894b8a5bc18db3fe58d"
+SRC_URI[archive.sha256sum] = "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0af0d17b14435d92"
 
 PACKAGECONFIG ??= "gnutls"
 
-PACKAGECONFIG[gnutls] = "-Dgnutls=true,-Dgnutls=false,gnutls"
-PACKAGECONFIG[libproxy] = "-Dlibproxy_support=true,-Dlibproxy_support=false,libproxy"
+PACKAGECONFIG[gnutls] = "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
+PACKAGECONFIG[libproxy] = "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
 
-EXTRA_OEMESON = "-Dgnome_proxy_support=false"
+EXTRA_OEMESON = "-Dgnome_proxy=disabled"
 
 GNOMEBASEBUILDCLASS = "meson"
 inherit gnomebase gettext upstream-version-is-even gio-module-cache
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 13/13] gst-plugins: move 'inherit gobject-introspection' to recipes supporting GI
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (11 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 12/13] glib-networking: upgrade 2.58.0 -> 2.60.1 Andreas Müller
@ 2019-04-05  6:37 ` Andreas Müller
  2019-04-05  7:39   ` Alexander Kanavin
  2019-04-05 12:18 ` [PATCH 00/13] meson/gobject-introspection rework Burton, Ross
  13 siblings, 1 reply; 18+ messages in thread
From: Andreas Müller @ 2019-04-05  6:37 UTC (permalink / raw)
  To: openembedded-core, alex.kanavin

Now that whitelisting for unknown configure options was removed in
gobject-introspection.bbclass gstreamer1.0-plugins-ugly/-good start complaining

| ERROR: gstreamer1.0-plugins-ugly-1.14.4-r0 do_configure: QA Issue: gstreamer1.0-plugins-ugly: configure was passed unrecognised options: --enable-introspection [unknown-configure-option]
| ERROR: gstreamer1.0-plugins-good-1.14.4-r0 do_configure: QA Issue: gstreamer1.0-plugins-good: configure was passed unrecognised options: --enable-introspection [unknown-configure-option]

So let only those gst-plugin recipes inherit gobject-introspection whose sources
support GI.

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 .../gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb                | 2 +-
 .../gstreamer/gstreamer1.0-plugins-base_1.14.4.bb               | 2 +-
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
index 4987be865b..23d093d47c 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
@@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=73a5855a8119deb017f5f13cf327095d \
 
 DEPENDS += "gstreamer1.0-plugins-base"
 
-inherit gettext bluetooth
+inherit gettext bluetooth gobject-introspection
 
 PACKAGECONFIG ??= " \
     ${GSTREAMER_ORC} \
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
index 12c9bbce9d..f3e6daf564 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
@@ -28,7 +28,7 @@ S = "${WORKDIR}/gst-plugins-base-${PV}"
 
 DEPENDS += "iso-codes util-linux"
 
-inherit gettext
+inherit gettext gobject-introspection
 
 PACKAGES_DYNAMIC =+ "^libgst.*"
 
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
index 5906e4ad36..bc24b05fec 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
@@ -7,7 +7,7 @@ DEPENDS = "gstreamer1.0 glib-2.0-native"
 
 SRC_URI_append = " file://gtk-doc-tweaks.patch"
 
-inherit autotools pkgconfig upstream-version-is-even gobject-introspection gtk-doc
+inherit autotools pkgconfig upstream-version-is-even gtk-doc
 
 acpaths = "-I ${S}/common/m4 -I ${S}/m4"
 
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH 13/13] gst-plugins: move 'inherit gobject-introspection' to recipes supporting GI
  2019-04-05  6:37 ` [PATCH 13/13] gst-plugins: move 'inherit gobject-introspection' to recipes supporting GI Andreas Müller
@ 2019-04-05  7:39   ` Alexander Kanavin
  0 siblings, 0 replies; 18+ messages in thread
From: Alexander Kanavin @ 2019-04-05  7:39 UTC (permalink / raw)
  To: Andreas Müller; +Cc: openembedded-core

Thanks, looks good!

Alex

> On 5 Apr 2019, at 8.37, Andreas Müller <schnitzeltony@gmail.com> wrote:
> 
> Now that whitelisting for unknown configure options was removed in
> gobject-introspection.bbclass gstreamer1.0-plugins-ugly/-good start complaining
> 
> | ERROR: gstreamer1.0-plugins-ugly-1.14.4-r0 do_configure: QA Issue: gstreamer1.0-plugins-ugly: configure was passed unrecognised options: --enable-introspection [unknown-configure-option]
> | ERROR: gstreamer1.0-plugins-good-1.14.4-r0 do_configure: QA Issue: gstreamer1.0-plugins-good: configure was passed unrecognised options: --enable-introspection [unknown-configure-option]
> 
> So let only those gst-plugin recipes inherit gobject-introspection whose sources
> support GI.
> 
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
> .../gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb                | 2 +-
> .../gstreamer/gstreamer1.0-plugins-base_1.14.4.bb               | 2 +-
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc      | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
> index 4987be865b..23d093d47c 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
> @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=73a5855a8119deb017f5f13cf327095d \
> 
> DEPENDS += "gstreamer1.0-plugins-base"
> 
> -inherit gettext bluetooth
> +inherit gettext bluetooth gobject-introspection
> 
> PACKAGECONFIG ??= " \
>     ${GSTREAMER_ORC} \
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
> index 12c9bbce9d..f3e6daf564 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
> @@ -28,7 +28,7 @@ S = "${WORKDIR}/gst-plugins-base-${PV}"
> 
> DEPENDS += "iso-codes util-linux"
> 
> -inherit gettext
> +inherit gettext gobject-introspection
> 
> PACKAGES_DYNAMIC =+ "^libgst.*"
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> index 5906e4ad36..bc24b05fec 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> @@ -7,7 +7,7 @@ DEPENDS = "gstreamer1.0 glib-2.0-native"
> 
> SRC_URI_append = " file://gtk-doc-tweaks.patch"
> 
> -inherit autotools pkgconfig upstream-version-is-even gobject-introspection gtk-doc
> +inherit autotools pkgconfig upstream-version-is-even gtk-doc
> 
> acpaths = "-I ${S}/common/m4 -I ${S}/m4"
> 
> -- 
> 2.20.1
> 


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 00/13] meson/gobject-introspection rework
  2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
                   ` (12 preceding siblings ...)
  2019-04-05  6:37 ` [PATCH 13/13] gst-plugins: move 'inherit gobject-introspection' to recipes supporting GI Andreas Müller
@ 2019-04-05 12:18 ` Burton, Ross
  2019-04-05 13:21   ` Andreas Müller
  13 siblings, 1 reply; 18+ messages in thread
From: Burton, Ross @ 2019-04-05 12:18 UTC (permalink / raw)
  To: Andreas Müller; +Cc: OE-core

ERROR: gstreamer1.0-python-1.14.4-r0 do_configure: QA Issue:
gstreamer1.0-python: configure was passed unrecognised options:
--enable-introspection [unknown-configure-option]


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 00/13] meson/gobject-introspection rework
  2019-04-05 12:18 ` [PATCH 00/13] meson/gobject-introspection rework Burton, Ross
@ 2019-04-05 13:21   ` Andreas Müller
  0 siblings, 0 replies; 18+ messages in thread
From: Andreas Müller @ 2019-04-05 13:21 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

On Fri, Apr 5, 2019 at 2:18 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> ERROR: gstreamer1.0-python-1.14.4-r0 do_configure: QA Issue:
> gstreamer1.0-python: configure was passed unrecognised options:
> --enable-introspection [unknown-configure-option]

Seems my build did not include that. Need to test-build all inheriting
gobject-introspection. Will send a follow up tonight.

Andreas


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson
  2019-04-05  6:37 ` [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson Andreas Müller
@ 2019-04-05 21:44   ` Khem Raj
  0 siblings, 0 replies; 18+ messages in thread
From: Khem Raj @ 2019-04-05 21:44 UTC (permalink / raw)
  To: Andreas Müller; +Cc: Patches and discussions about the oe-core layer

On Thu, Apr 4, 2019 at 11:38 PM Andreas Müller <schnitzeltony@gmail.com> wrote:
>
> Tested with 'unknown-configure-option' in ERROR_QA:
>
> For meson (glib-2.0-native):
> 1. add 'EXTRA_OEMESON_append = "-Dschnitzel=true -Dwurst=true"'
>    | ERROR: glib-2.0-native-1_2.58.3-r0 do_configure: QA Issue: glib-2.0-native: configure was passed unrecognised options: schnitzel wurst [unknown-configure-option]
> 2. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" schnitzel"'
>    | ERROR: glib-2.0-native-1_2.58.3-r0 do_configure: QA Issue: glib-2.0-native: configure was passed unrecognised options: wurst [unknown-configure-option]
> 3. change to 'UNKNOWN_CONFIGURE_WHITELIST_append=" schnitzel wurst"'
>    => builds without issues
>
> For autotools (readline-native):
> 1. add 'EXTRA_OECONF = "--with-schnitzel --with-wurst"'
>    | ERROR: readline-native-8.0-r0 do_configure: QA Issue: readline-native: configure was passed unrecognised options: --with-wurst --with-schnitzel [unknown-configure-option]
> 2. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" --with-schnitzel"'
>    | ERROR: readline-native-8.0-r0 do_configure: QA Issue: readline-native: configure was passed unrecognised options: --with-wurst [unknown-configure-option]
> 3. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" --with-schnitzel --with-wurst"'
>    => builds without issues
>

thinking of Weisswurst with Bayerischer Süßer Senf
this patchset looks good :)


> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
>
> This is a resend
>
>  meta/classes/insane.bbclass | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 37b8bb0032..c8d18c07f5 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -1093,12 +1093,16 @@ Rerun configure task after fixing this."""
>      ###########################################################################
>      # Check unrecognised configure options (with a white list)
>      ###########################################################################
> -    if bb.data.inherits_class("autotools", d):
> +    if bb.data.inherits_class("autotools", d) or bb.data.inherits_class("meson", d):
>          bb.note("Checking configure output for unrecognised options")
>          try:
> -            flag = "WARNING: unrecognized options:"
> -            log = os.path.join(d.getVar('B'), 'config.log')
> -            output = subprocess.check_output(['grep', '-F', flag, log]).decode("utf-8").replace(', ', ' ')
> +            if bb.data.inherits_class("autotools", d):
> +                flag = "WARNING: unrecognized options:"
> +                log = os.path.join(d.getVar('B'), 'config.log')
> +            if bb.data.inherits_class("meson", d):
> +                flag = "WARNING: Unknown options:"
> +                log = os.path.join(d.getVar('T'), 'log.do_configure')
> +            output = subprocess.check_output(['grep', '-F', flag, log]).decode("utf-8").replace(', ', ' ').replace('"', '')
>              options = set()
>              for line in output.splitlines():
>                  options |= set(line.partition(flag)[2].split())
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2019-04-05 21:44 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-05  6:37 [PATCH 00/13] meson/gobject-introspection rework Andreas Müller
2019-04-05  6:37 ` [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson Andreas Müller
2019-04-05 21:44   ` Khem Raj
2019-04-05  6:37 ` [PATCH 02/13] gobject-introspection: auto-enable/-disable gobject-introspection " Andreas Müller
2019-04-05  6:37 ` [PATCH 03/13] libmodulemd: use gobject-introspection.bbclass on/off mechanism Andreas Müller
2019-04-05  6:37 ` [PATCH 04/13] gdk-pixbuf: " Andreas Müller
2019-04-05  6:37 ` [PATCH 05/13] json-glib: " Andreas Müller
2019-04-05  6:37 ` [PATCH 06/13] libdazzle: " Andreas Müller
2019-04-05  6:37 ` [PATCH 07/13] clutter-gtk-1.0: " Andreas Müller
2019-04-05  6:37 ` [PATCH 08/13] pango: " Andreas Müller
2019-04-05  6:37 ` [PATCH 09/13] at-spi2-core: " Andreas Müller
2019-04-05  6:37 ` [PATCH 10/13] atk: " Andreas Müller
2019-04-05  6:37 ` [PATCH 11/13] libsoup-2.4: " Andreas Müller
2019-04-05  6:37 ` [PATCH 12/13] glib-networking: upgrade 2.58.0 -> 2.60.1 Andreas Müller
2019-04-05  6:37 ` [PATCH 13/13] gst-plugins: move 'inherit gobject-introspection' to recipes supporting GI Andreas Müller
2019-04-05  7:39   ` Alexander Kanavin
2019-04-05 12:18 ` [PATCH 00/13] meson/gobject-introspection rework Burton, Ross
2019-04-05 13:21   ` Andreas Müller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.