* [igt-dev] [PATCH i-g-t] lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip
@ 2019-04-04 13:17 Arkadiusz Hiler
2019-04-04 14:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arkadiusz Hiler @ 2019-04-04 13:17 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
First, we set errno to 0 before doing select() to avoid random pollution
of the assert message with things like:
"Last errno: 25, Inappropriate ioctl for device"
Second, we log explicitly if we exceeded the timeout (ret == 0).
Third, if we fail the select() we log that with some explanation.
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
lib/igt_kms.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index a975ff14..f8b0dab2 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1504,9 +1504,17 @@ void kmstest_wait_for_pageflip(int fd)
FD_ZERO(&fds);
FD_SET(fd, &fds);
do {
+ errno = 0;
ret = select(fd + 1, &fds, NULL, NULL, &timeout);
} while (ret < 0 && errno == EINTR);
- igt_assert_eq(ret, 1);
+
+ igt_fail_on_f(ret == 0,
+ "Exceeded timeout (50ms) while waiting for a pageflip\n");
+
+ igt_assert_f(ret == 1,
+ "Waiting for pageflip failed with %d from select(drmfd)\n",
+ ret);
+
igt_assert(drmHandleEvent(fd, &evctx) == 0);
}
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip
2019-04-04 13:17 [igt-dev] [PATCH i-g-t] lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip Arkadiusz Hiler
@ 2019-04-04 14:32 ` Patchwork
2019-04-05 6:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-05 7:28 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-04 14:32 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip
URL : https://patchwork.freedesktop.org/series/59007/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5870 -> IGTPW_2788
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59007/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2788 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- fi-ilk-650: DMESG-WARN [fdo#106387] -> PASS
- {fi-kbl-7567u}: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS
* igt@gem_exec_suspend@basic-s3:
- {fi-kbl-7567u}: DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602] -> PASS
* igt@i915_module_load@reload-with-fault-injection:
- {fi-kbl-7567u}: DMESG-WARN [fdo#105602] / [fdo#108529] -> PASS +1
* igt@i915_pm_rpm@module-reload:
- {fi-kbl-7567u}: DMESG-WARN [fdo#108529] -> PASS
* igt@kms_busy@basic-flip-a:
- {fi-kbl-7567u}: SKIP [fdo#109271] / [fdo#109278] -> PASS +2
* igt@kms_chamelium@hdmi-edid-read:
- {fi-kbl-7567u}: FAIL [fdo#109569] -> PASS +1
* igt@kms_chamelium@hdmi-hpd-fast:
- {fi-kbl-7567u}: FAIL [fdo#109800] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- {fi-kbl-7567u}: DMESG-FAIL [fdo#105079] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
* igt@prime_vgem@basic-fence-flip:
- {fi-kbl-7567u}: SKIP [fdo#109271] -> PASS +4
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109569]: https://bugs.freedesktop.org/show_bug.cgi?id=109569
[fdo#109800]: https://bugs.freedesktop.org/show_bug.cgi?id=109800
Participating hosts (50 -> 44)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-y
Build changes
-------------
* IGT: IGT_4928 -> IGTPW_2788
CI_DRM_5870: 122dc43df57c9a03132314ddc78a6d60c714fa32 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2788: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2788/
IGT_4928: 014a6fa238322b497116b359cb92df1ce7fa8847 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2788/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip
2019-04-04 13:17 [igt-dev] [PATCH i-g-t] lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip Arkadiusz Hiler
2019-04-04 14:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-05 6:09 ` Patchwork
2019-04-05 7:28 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-05 6:09 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip
URL : https://patchwork.freedesktop.org/series/59007/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5870_full -> IGTPW_2788_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59007/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2788_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_atomic_transition@4x-modeset-transitions:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222] +2
- shard-kbl: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-snb: PASS -> DMESG-WARN [fdo#110222] +2
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> FAIL [fdo#108739] / [fdo#110321]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: PASS -> FAIL [fdo#105767]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +6
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: NOTRUN -> SKIP [fdo#109271]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: PASS -> DMESG-WARN [fdo#108566]
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@kms_cursor_edge_walk@pipe-a-64x64-left-edge:
- shard-snb: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_flip@modeset-vs-vblank-race:
- shard-kbl: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt:
- shard-snb: SKIP [fdo#109271] -> PASS +2
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS +1
* igt@kms_vblank@pipe-c-ts-continuation-modeset:
- shard-kbl: FAIL [fdo#104894] -> PASS
- shard-apl: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: FAIL [fdo#108686] -> INCOMPLETE [fdo#103540]
* igt@kms_lease@atomic_implicit_crtc:
- shard-snb: SKIP [fdo#109271] -> FAIL [fdo#110279]
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110279]: https://bugs.freedesktop.org/show_bug.cgi?id=110279
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
Participating hosts (9 -> 5)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-glk-j5005 shard-iclb
Build changes
-------------
* IGT: IGT_4928 -> IGTPW_2788
* Piglit: piglit_4509 -> None
CI_DRM_5870: 122dc43df57c9a03132314ddc78a6d60c714fa32 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2788: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2788/
IGT_4928: 014a6fa238322b497116b359cb92df1ce7fa8847 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2788/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip
2019-04-04 13:17 [igt-dev] [PATCH i-g-t] lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip Arkadiusz Hiler
2019-04-04 14:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-05 6:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-04-05 7:28 ` Arkadiusz Hiler
2 siblings, 0 replies; 4+ messages in thread
From: Arkadiusz Hiler @ 2019-04-05 7:28 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
On Thu, Apr 04, 2019 at 04:17:40PM +0300, Arkadiusz Hiler wrote:
> First, we set errno to 0 before doing select() to avoid random pollution
> of the assert message with things like:
> "Last errno: 25, Inappropriate ioctl for device"
>
> Second, we log explicitly if we exceeded the timeout (ret == 0).
>
> Third, if we fail the select() we log that with some explanation.
>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
cibuglog fitlers addjusted and the patch is applied with Petri's rb from IRC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-05 7:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 13:17 [igt-dev] [PATCH i-g-t] lib/igt_kms: Be more verbose about failure in kmstest_wait_for_pageflip Arkadiusz Hiler
2019-04-04 14:32 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-05 6:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-05 7:28 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.