All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: Mark Kanda <mark.kanda@oracle.com>
Cc: Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org, bhavesh.davda@oracle.com,
	Chris Kenna <chris.kenna@oracle.com>
Subject: Re: [Qemu-devel] [PATCH] e1000: Never increment the RX undersize count register
Date: Fri, 5 Apr 2019 12:31:05 +0200	[thread overview]
Message-ID: <20190405103105.c2ohp53bitfgamax@steredhat> (raw)
In-Reply-To: <1554391286-26981-1-git-send-email-mark.kanda@oracle.com>

On Thu, Apr 04, 2019 at 10:21:26AM -0500, Mark Kanda wrote:
> From: Chris Kenna <chris.kenna@oracle.com>
> 
> In situations where e1000 receives an undersized Ethernet frame,
> QEMU increments the emulated "Receive Undersize Count (RUC)"
> register when padding the frame.
> 
> This is incorrect because this an expected scenario (e.g. with
> VLAN tag stripping) and not an error. As such, QEMU should not
> increment the emulated RUC.
> 
> Fixes: 3b2743017749 ("e1000: Implementing various counters")
> 
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
> Signed-off-by: Chris Kenna <chris.kenna@oracle.com>
> ---
>  hw/net/e1000.c | 1 -
>  1 file changed, 1 deletion(-)

CCing Jason.

LGTM, if we don't discard it, we shouldn't increase the RUC counter.

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Garzarella <sgarzare@redhat.com>
To: Mark Kanda <mark.kanda@oracle.com>
Cc: Chris Kenna <chris.kenna@oracle.com>,
	Jason Wang <jasowang@redhat.com>,
	bhavesh.davda@oracle.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] e1000: Never increment the RX undersize count register
Date: Fri, 5 Apr 2019 12:31:05 +0200	[thread overview]
Message-ID: <20190405103105.c2ohp53bitfgamax@steredhat> (raw)
Message-ID: <20190405103105.vOYydNvOZuovOyMhpR7AU-5h0JkOhXeLJoPCxzBTOsc@z> (raw)
In-Reply-To: <1554391286-26981-1-git-send-email-mark.kanda@oracle.com>

On Thu, Apr 04, 2019 at 10:21:26AM -0500, Mark Kanda wrote:
> From: Chris Kenna <chris.kenna@oracle.com>
> 
> In situations where e1000 receives an undersized Ethernet frame,
> QEMU increments the emulated "Receive Undersize Count (RUC)"
> register when padding the frame.
> 
> This is incorrect because this an expected scenario (e.g. with
> VLAN tag stripping) and not an error. As such, QEMU should not
> increment the emulated RUC.
> 
> Fixes: 3b2743017749 ("e1000: Implementing various counters")
> 
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com>
> Signed-off-by: Chris Kenna <chris.kenna@oracle.com>
> ---
>  hw/net/e1000.c | 1 -
>  1 file changed, 1 deletion(-)

CCing Jason.

LGTM, if we don't discard it, we shouldn't increase the RUC counter.

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano


  reply	other threads:[~2019-04-05 10:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 15:21 [Qemu-devel] [PATCH] e1000: Never increment the RX undersize count register Mark Kanda
2019-04-05 10:31 ` Stefano Garzarella [this message]
2019-04-05 10:31   ` Stefano Garzarella
2019-04-15  3:29   ` Jason Wang
2019-04-15  3:29     ` Jason Wang
2019-04-15  3:35     ` Jason Wang
2019-04-15  3:35       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405103105.c2ohp53bitfgamax@steredhat \
    --to=sgarzare@redhat.com \
    --cc=bhavesh.davda@oracle.com \
    --cc=chris.kenna@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=mark.kanda@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.