All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] generic/504: fix hard coded fd number
@ 2019-04-08  2:38 Murphy Zhou
  0 siblings, 0 replies; only message in thread
From: Murphy Zhou @ 2019-04-08  2:38 UTC (permalink / raw)
  To: fstests; +Cc: Murphy Zhou

Bash supports file discriptor assignment in this way. So remove the hard
coded numbers. Also close this opened fd in cleanup.

Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---
 tests/generic/504 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/generic/504 b/tests/generic/504
index 21d86051..19c6a0e7 100755
--- a/tests/generic/504
+++ b/tests/generic/504
@@ -21,6 +21,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _cleanup()
 {
+	exec {test_fd}<&-
 	cd /
 	rm -f $tmp.*
 }
@@ -45,9 +46,9 @@ tf_inode=$(stat -c %i $testfile)
 echo inode $tf_inode >> $seqres.full
 
 # Create new fd by exec
-exec 9> $testfile
+exec {test_fd}> $testfile
 # flock locks the fd then exits, we should see the lock info even the owner is dead
-flock -x 9
+flock -x $test_fd
 cat /proc/locks >> $seqres.full
 
 # Checking
-- 
2.21.0

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-04-08  2:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08  2:38 [PATCH] generic/504: fix hard coded fd number Murphy Zhou

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.