From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms@verge.net.au>
Cc: linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Magnus Damm <magnus.damm@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH/RFC] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps
Date: Mon, 8 Apr 2019 12:56:20 +0200 [thread overview]
Message-ID: <20190408105620.GA4553@kunai> (raw)
In-Reply-To: <20190408094550.omzfxgsxalux7pxv@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
> > > + max-speed = <100>;
> >
> > What about adding a comment explaining this speed limit?
>
> Sure, if you think its worth highlighting in the dts as
> well as the changelog.
I think this will be helpful for people just getting a tarball of the
kernel and no further history of it. But just 2¢ here, nothing major...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms@verge.net.au>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps
Date: Mon, 8 Apr 2019 12:56:20 +0200 [thread overview]
Message-ID: <20190408105620.GA4553@kunai> (raw)
In-Reply-To: <20190408094550.omzfxgsxalux7pxv@verge.net.au>
[-- Attachment #1.1: Type: text/plain, Size: 337 bytes --]
> > > + max-speed = <100>;
> >
> > What about adding a comment explaining this speed limit?
>
> Sure, if you think its worth highlighting in the dts as
> well as the changelog.
I think this will be helpful for people just getting a tarball of the
kernel and no further history of it. But just 2¢ here, nothing major...
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-08 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:31 [PATCH/RFC] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps Simon Horman
2019-04-08 8:31 ` Simon Horman
2019-04-08 8:41 ` Wolfram Sang
2019-04-08 8:41 ` Wolfram Sang
2019-04-08 9:45 ` Simon Horman
2019-04-08 9:45 ` Simon Horman
2019-04-08 10:56 ` Wolfram Sang [this message]
2019-04-08 10:56 ` Wolfram Sang
2019-04-08 21:26 ` Andrew Lunn
2019-04-08 21:26 ` Andrew Lunn
2019-04-10 9:27 ` Simon Horman
2019-04-10 9:27 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408105620.GA4553@kunai \
--to=wsa@the-dreams.de \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.