* [PATCH] powerpc/mm/radix: Do slb preload only with hash translation mode
@ 2019-04-09 4:03 Aneesh Kumar K.V
2019-04-09 8:10 ` Nicholas Piggin
2019-04-21 14:19 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2019-04-09 4:03 UTC (permalink / raw)
To: npiggin, benh, paulus, mpe; +Cc: Aneesh Kumar K.V, linuxppc-dev
Add radix_enabled check to avoid slb preload with radix translation.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
Without this we result in kernel crash as we move hash related variables
out of mm_context_t
arch/powerpc/kernel/process.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index dd9e0d5386ee..f7b2e3b3db28 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -1729,7 +1729,8 @@ void start_thread(struct pt_regs *regs, unsigned long start, unsigned long sp)
unsigned long load_addr = regs->gpr[2]; /* saved by ELF_PLAT_INIT */
#ifdef CONFIG_PPC_BOOK3S_64
- preload_new_slb_context(start, sp);
+ if (!radix_enabled())
+ preload_new_slb_context(start, sp);
#endif
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/mm/radix: Do slb preload only with hash translation mode
2019-04-09 4:03 [PATCH] powerpc/mm/radix: Do slb preload only with hash translation mode Aneesh Kumar K.V
@ 2019-04-09 8:10 ` Nicholas Piggin
2019-04-21 14:19 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Nicholas Piggin @ 2019-04-09 8:10 UTC (permalink / raw)
To: Aneesh Kumar K.V, benh, mpe, paulus; +Cc: linuxppc-dev
Aneesh Kumar K.V's on April 9, 2019 2:03 pm:
> Add radix_enabled check to avoid slb preload with radix translation.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Acked-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>
> Without this we result in kernel crash as we move hash related variables
> out of mm_context_t
>
> arch/powerpc/kernel/process.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index dd9e0d5386ee..f7b2e3b3db28 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -1729,7 +1729,8 @@ void start_thread(struct pt_regs *regs, unsigned long start, unsigned long sp)
> unsigned long load_addr = regs->gpr[2]; /* saved by ELF_PLAT_INIT */
>
> #ifdef CONFIG_PPC_BOOK3S_64
> - preload_new_slb_context(start, sp);
> + if (!radix_enabled())
> + preload_new_slb_context(start, sp);
> #endif
> #endif
>
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: powerpc/mm/radix: Do slb preload only with hash translation mode
2019-04-09 4:03 [PATCH] powerpc/mm/radix: Do slb preload only with hash translation mode Aneesh Kumar K.V
2019-04-09 8:10 ` Nicholas Piggin
@ 2019-04-21 14:19 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-04-21 14:19 UTC (permalink / raw)
To: Aneesh Kumar K.V, npiggin, benh, paulus; +Cc: Aneesh Kumar K.V, linuxppc-dev
On Tue, 2019-04-09 at 04:03:28 UTC, "Aneesh Kumar K.V" wrote:
> Add radix_enabled check to avoid slb preload with radix translation.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Acked-by: Nicholas Piggin <npiggin@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f89bd8ba834e392ff614a7be9ee68c56
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-21 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 4:03 [PATCH] powerpc/mm/radix: Do slb preload only with hash translation mode Aneesh Kumar K.V
2019-04-09 8:10 ` Nicholas Piggin
2019-04-21 14:19 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.