[U-Boot] [PATCH 0/2] riscv: set preboot and increase kernel size

[U-Boot] [PATCH 0/2] riscv: set preboot and increase kernel size

[David Abdurachmanov]

The following two changes are used by Fedora/RISCV with 5.1-rc3+ kernel
using OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
Cc: rick at andestech.com
Cc: atish.patra at wdc.com
Cc: Anup.Patel at wdc.com 
Cc: lukas.auer at aisec.fraunhofer.de

David Abdurachmanov (2):
  riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M
  riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

 include/configs/qemu-riscv.h | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

-- 
2.20.1

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[David Abdurachmanov]

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above
the current threshold. Looking into HiKey, Dragonboards, etc. seems that
SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master)
with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
index 2588c5a0b2..22a5cd7365 100644
--- a/include/configs/qemu-riscv.h
+++ b/include/configs/qemu-riscv.h
@@ -15,7 +15,7 @@
 
 #define CONFIG_SYS_MALLOC_LEN		SZ_8M
 
-#define CONFIG_SYS_BOOTM_LEN		SZ_16M
+#define CONFIG_SYS_BOOTM_LEN		SZ_64M
 
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
 
@@ -41,11 +41,11 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
-	"kernel_addr_r=0x81000000\0" \
-	"fdt_addr_r=0x82000000\0" \
-	"scriptaddr=0x82100000\0" \
-	"pxefile_addr_r=0x82200000\0" \
-	"ramdisk_addr_r=0x82300000\0" \
+	"kernel_addr_r=0x84000000\0" \
+	"fdt_addr_r=0x88000000\0" \
+	"scriptaddr=0x88100000\0" \
+	"pxefile_addr_r=0x88200000\0" \
+	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
 #endif /* __CONFIG_H */
-- 
2.20.1

[U-Boot] [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

[David Abdurachmanov]

- Set fdt_addr variable, which is needed for extlinux to find FDT.
  Otherwise booting kernel using extlinux results in missing FDT.

- Also run fdt addr with FDT address so that fdt commands would
  work out of the box in U-Boot prompt.

This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using
OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
 include/configs/qemu-riscv.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
index 22a5cd7365..b7110edebc 100644
--- a/include/configs/qemu-riscv.h
+++ b/include/configs/qemu-riscv.h
@@ -48,4 +48,8 @@
 	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
+#define CONFIG_PREBOOT \
+	"setenv fdt_addr ${fdtcontroladdr};" \
+	"fdt addr ${fdtcontroladdr};"
+
 #endif /* __CONFIG_H */
-- 
2.20.1

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[Tom Rini]

On Tue, Apr 09, 2019 at 12:42:46PM +0200, David Abdurachmanov wrote:
> After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above
> the current threshold. Looking into HiKey, Dragonboards, etc. seems that
> SZ_64M is a popular option.
> 
> This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master)
> with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  include/configs/qemu-riscv.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> index 2588c5a0b2..22a5cd7365 100644
> --- a/include/configs/qemu-riscv.h
> +++ b/include/configs/qemu-riscv.h
> @@ -15,7 +15,7 @@
>  
>  #define CONFIG_SYS_MALLOC_LEN		SZ_8M
>  
> -#define CONFIG_SYS_BOOTM_LEN		SZ_16M
> +#define CONFIG_SYS_BOOTM_LEN		SZ_64M
>  
>  #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
>  
> @@ -41,11 +41,11 @@
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	"fdt_high=0xffffffffffffffff\0" \
>  	"initrd_high=0xffffffffffffffff\0" \
> -	"kernel_addr_r=0x81000000\0" \
> -	"fdt_addr_r=0x82000000\0" \
> -	"scriptaddr=0x82100000\0" \
> -	"pxefile_addr_r=0x82200000\0" \
> -	"ramdisk_addr_r=0x82300000\0" \
> +	"kernel_addr_r=0x84000000\0" \
> +	"fdt_addr_r=0x88000000\0" \
> +	"scriptaddr=0x88100000\0" \
> +	"pxefile_addr_r=0x88200000\0" \
> +	"ramdisk_addr_r=0x88300000\0" \

As a follow-up, I really dislike fdt_high/initrd_high being set such
that we disable relocation, that just leads to down the line
"kernel/initrd grew, was overwritten".  We should be using bootm_size to
define the area in memory that everything can reside in, so that U-Boot
can be smart about relocations.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190409/2334c9db/attachment.sig>

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[Anup Patel]

> -----Original Message-----
> From: David Abdurachmanov <david.abdurachmanov@gmail.com>
> Sent: Tuesday, April 9, 2019 4:13 PM
> To: rick at andestech.com; Atish Patra <Atish.Patra@wdc.com>; Anup Patel
> <Anup.Patel@wdc.com>; lukas.auer at aisec.fraunhofer.de; u-
> boot at lists.denx.de
> Cc: David Abdurachmanov <david.abdurachmanov@gmail.com>
> Subject: [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M
> 
> After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the
> current threshold. Looking into HiKey, Dragonboards, etc. seems that
> SZ_64M is a popular option.
> 
> This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0
> (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  include/configs/qemu-riscv.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> index 2588c5a0b2..22a5cd7365 100644
> --- a/include/configs/qemu-riscv.h
> +++ b/include/configs/qemu-riscv.h
> @@ -15,7 +15,7 @@
> 
>  #define CONFIG_SYS_MALLOC_LEN		SZ_8M
> 
> -#define CONFIG_SYS_BOOTM_LEN		SZ_16M
> +#define CONFIG_SYS_BOOTM_LEN		SZ_64M
> 
>  #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
> 
> @@ -41,11 +41,11 @@
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	"fdt_high=0xffffffffffffffff\0" \
>  	"initrd_high=0xffffffffffffffff\0" \
> -	"kernel_addr_r=0x81000000\0" \
> -	"fdt_addr_r=0x82000000\0" \
> -	"scriptaddr=0x82100000\0" \
> -	"pxefile_addr_r=0x82200000\0" \
> -	"ramdisk_addr_r=0x82300000\0" \
> +	"kernel_addr_r=0x84000000\0" \
> +	"fdt_addr_r=0x88000000\0" \
> +	"scriptaddr=0x88100000\0" \
> +	"pxefile_addr_r=0x88200000\0" \
> +	"ramdisk_addr_r=0x88300000\0" \
>  	BOOTENV
> 
>  #endif /* __CONFIG_H */
> --
> 2.20.1

Looks good to me.

Reviewed-by: Anup Patel <anup.patel@wdc.com>

Regards,
Anup

[U-Boot] [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

[Anup Patel]

> -----Original Message-----
> From: David Abdurachmanov <david.abdurachmanov@gmail.com>
> Sent: Tuesday, April 9, 2019 4:13 PM
> To: rick at andestech.com; Atish Patra <Atish.Patra@wdc.com>; Anup Patel
> <Anup.Patel@wdc.com>; lukas.auer at aisec.fraunhofer.de; u-
> boot at lists.denx.de
> Cc: David Abdurachmanov <david.abdurachmanov@gmail.com>
> Subject: [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables
> extlinux)
> 
> - Set fdt_addr variable, which is needed for extlinux to find FDT.
>   Otherwise booting kernel using extlinux results in missing FDT.
> 
> - Also run fdt addr with FDT address so that fdt commands would
>   work out of the box in U-Boot prompt.
> 
> This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using OpenSBI
> -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  include/configs/qemu-riscv.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> index 22a5cd7365..b7110edebc 100644
> --- a/include/configs/qemu-riscv.h
> +++ b/include/configs/qemu-riscv.h
> @@ -48,4 +48,8 @@
>  	"ramdisk_addr_r=0x88300000\0" \
>  	BOOTENV
> 
> +#define CONFIG_PREBOOT \
> +	"setenv fdt_addr ${fdtcontroladdr};" \
> +	"fdt addr ${fdtcontroladdr};"
> +
>  #endif /* __CONFIG_H */
> --
> 2.20.1

Looks good to me.

Reviewed-by: Anup Patel <anup.patel@wdc.com>

Regards,
Anup

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[Auer, Lukas]

+ Bin
[Please use get_maintainer or patman to include all maintainers on CC]

On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above
> the current threshold. Looking into HiKey, Dragonboards, etc. seems that
> SZ_64M is a popular option.
> 
> This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master)
> with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  include/configs/qemu-riscv.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> index 2588c5a0b2..22a5cd7365 100644
> --- a/include/configs/qemu-riscv.h
> +++ b/include/configs/qemu-riscv.h
> @@ -15,7 +15,7 @@
>  
>  #define CONFIG_SYS_MALLOC_LEN		SZ_8M
>  
> -#define CONFIG_SYS_BOOTM_LEN		SZ_16M
> +#define CONFIG_SYS_BOOTM_LEN		SZ_64M
>  
>  #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
>  
> @@ -41,11 +41,11 @@
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	"fdt_high=0xffffffffffffffff\0" \
>  	"initrd_high=0xffffffffffffffff\0" \
> -	"kernel_addr_r=0x81000000\0" \
> -	"fdt_addr_r=0x82000000\0" \
> -	"scriptaddr=0x82100000\0" \
> -	"pxefile_addr_r=0x82200000\0" \
> -	"ramdisk_addr_r=0x82300000\0" \
> +	"kernel_addr_r=0x84000000\0" \

Why are you also moving kernel_addr_r?

Thanks,
Lukas

> +	"fdt_addr_r=0x88000000\0" \
> +	"scriptaddr=0x88100000\0" \
> +	"pxefile_addr_r=0x88200000\0" \
> +	"ramdisk_addr_r=0x88300000\0" \
>  	BOOTENV
>  
>  #endif /* __CONFIG_H */

[U-Boot] [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

[Auer, Lukas]

+ Bin

On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> - Set fdt_addr variable, which is needed for extlinux to find FDT.
>   Otherwise booting kernel using extlinux results in missing FDT.
> 
> - Also run fdt addr with FDT address so that fdt commands would
>   work out of the box in U-Boot prompt.

While often useful to have, the fdt command is not used during a normal
boot. I think we should avoid calling commands, which are not normally
needed. Can you remove this from your patch?

Thanks,
Lukas

> 
> This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using
> OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  include/configs/qemu-riscv.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> index 22a5cd7365..b7110edebc 100644
> --- a/include/configs/qemu-riscv.h
> +++ b/include/configs/qemu-riscv.h
> @@ -48,4 +48,8 @@
>  	"ramdisk_addr_r=0x88300000\0" \
>  	BOOTENV
>  
> +#define CONFIG_PREBOOT \
> +	"setenv fdt_addr ${fdtcontroladdr};" \
> +	"fdt addr ${fdtcontroladdr};"
> +
>  #endif /* __CONFIG_H */

[U-Boot] [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

[David Abdurachmanov]

On Thu, Apr 11, 2019 at 2:41 PM Auer, Lukas
<lukas.auer@aisec.fraunhofer.de> wrote:
>
> + Bin
>
> On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> > - Set fdt_addr variable, which is needed for extlinux to find FDT.
> >   Otherwise booting kernel using extlinux results in missing FDT.
> >
> > - Also run fdt addr with FDT address so that fdt commands would
> >   work out of the box in U-Boot prompt.
>
> While often useful to have, the fdt command is not used during a normal
> boot. I think we should avoid calling commands, which are not normally
> needed. Can you remove this from your patch?

I borrowed idea from other boards, and I find it useful to have fdt working
out-of-the-box without trying to figure the correct variable which holds
address of FDT.

I can remove it from the patch, but I will probably keep adding it as Fedora
specific patch then.

>
> Thanks,
> Lukas
>
> >
> > This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using
> > OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > ---
> >  include/configs/qemu-riscv.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> > index 22a5cd7365..b7110edebc 100644
> > --- a/include/configs/qemu-riscv.h
> > +++ b/include/configs/qemu-riscv.h
> > @@ -48,4 +48,8 @@
> >       "ramdisk_addr_r=0x88300000\0" \
> >       BOOTENV
> >
> > +#define CONFIG_PREBOOT \
> > +     "setenv fdt_addr ${fdtcontroladdr};" \
> > +     "fdt addr ${fdtcontroladdr};"
> > +
> >  #endif /* __CONFIG_H */

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[David Abdurachmanov]

On Thu, Apr 11, 2019 at 2:40 PM Auer, Lukas
<lukas.auer@aisec.fraunhofer.de> wrote:
>
> + Bin
> [Please use get_maintainer or patman to include all maintainers on CC]

Thanks.

Hm.. get_maintainer and patman are not mentioned on wiki page:
"Patches and Feature Requests". It only mentions to CC people from:
http://www.denx.de/wiki/U-Boot/Custodians

>
> On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> > After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above
> > the current threshold. Looking into HiKey, Dragonboards, etc. seems that
> > SZ_64M is a popular option.
> >
> > This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master)
> > with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > ---
> >  include/configs/qemu-riscv.h | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> > index 2588c5a0b2..22a5cd7365 100644
> > --- a/include/configs/qemu-riscv.h
> > +++ b/include/configs/qemu-riscv.h
> > @@ -15,7 +15,7 @@
> >
> >  #define CONFIG_SYS_MALLOC_LEN                SZ_8M
> >
> > -#define CONFIG_SYS_BOOTM_LEN         SZ_16M
> > +#define CONFIG_SYS_BOOTM_LEN         SZ_64M
> >
> >  #define CONFIG_STANDALONE_LOAD_ADDR  0x80200000
> >
> > @@ -41,11 +41,11 @@
> >  #define CONFIG_EXTRA_ENV_SETTINGS \
> >       "fdt_high=0xffffffffffffffff\0" \
> >       "initrd_high=0xffffffffffffffff\0" \
> > -     "kernel_addr_r=0x81000000\0" \
> > -     "fdt_addr_r=0x82000000\0" \
> > -     "scriptaddr=0x82100000\0" \
> > -     "pxefile_addr_r=0x82200000\0" \
> > -     "ramdisk_addr_r=0x82300000\0" \
> > +     "kernel_addr_r=0x84000000\0" \
>
> Why are you also moving kernel_addr_r?

I think there two 16MB windows here for kernel:
- 0x80000000 - 0x81000000 (kernel_addr_r),  and kernel is loaded at 0x80200000
- 0x81000000 (kernel_addr_r) - 0x82000000 (fdt_addr_r)

From U-Boot documentation:

[..]
236 kernel_addr_r:
237
238   Mandatory. The location in RAM where the kernel will be loaded
to when
239   processing the kernel option in the extlinux.conf.
[..]

Thus I moved it to ensure that both windows are 64MB.

>
> Thanks,
> Lukas
>
> > +     "fdt_addr_r=0x88000000\0" \
> > +     "scriptaddr=0x88100000\0" \
> > +     "pxefile_addr_r=0x88200000\0" \
> > +     "ramdisk_addr_r=0x88300000\0" \
> >       BOOTENV
> >
> >  #endif /* __CONFIG_H */

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[Auer, Lukas]

On Thu, 2019-04-11 at 15:05 +0200, David Abdurachmanov wrote:
> On Thu, Apr 11, 2019 at 2:40 PM Auer, Lukas
> <lukas.auer@aisec.fraunhofer.de> wrote:
> > + Bin
> > [Please use get_maintainer or patman to include all maintainers on CC]
> 
> Thanks.
> 
> Hm.. get_maintainer and patman are not mentioned on wiki page:
> "Patches and Feature Requests". It only mentions to CC people from:
> http://www.denx.de/wiki/U-Boot/Custodians
> 

Hm, you are right, it's not really stated explicitly.

> > On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> > > After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above
> > > the current threshold. Looking into HiKey, Dragonboards, etc. seems that
> > > SZ_64M is a popular option.
> > > 
> > > This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master)
> > > with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> > > 
> > > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > > ---
> > >  include/configs/qemu-riscv.h | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> > > index 2588c5a0b2..22a5cd7365 100644
> > > --- a/include/configs/qemu-riscv.h
> > > +++ b/include/configs/qemu-riscv.h
> > > @@ -15,7 +15,7 @@
> > > 
> > >  #define CONFIG_SYS_MALLOC_LEN                SZ_8M
> > > 
> > > -#define CONFIG_SYS_BOOTM_LEN         SZ_16M
> > > +#define CONFIG_SYS_BOOTM_LEN         SZ_64M
> > > 
> > >  #define CONFIG_STANDALONE_LOAD_ADDR  0x80200000
> > > 
> > > @@ -41,11 +41,11 @@
> > >  #define CONFIG_EXTRA_ENV_SETTINGS \
> > >       "fdt_high=0xffffffffffffffff\0" \
> > >       "initrd_high=0xffffffffffffffff\0" \
> > > -     "kernel_addr_r=0x81000000\0" \
> > > -     "fdt_addr_r=0x82000000\0" \
> > > -     "scriptaddr=0x82100000\0" \
> > > -     "pxefile_addr_r=0x82200000\0" \
> > > -     "ramdisk_addr_r=0x82300000\0" \
> > > +     "kernel_addr_r=0x84000000\0" \
> > 
> > Why are you also moving kernel_addr_r?
> 
> I think there two 16MB windows here for kernel:
> - 0x80000000 - 0x81000000 (kernel_addr_r),  and kernel is loaded at 0x80200000
> - 0x81000000 (kernel_addr_r) - 0x82000000 (fdt_addr_r)
> 
> From U-Boot documentation:
> 
> [..]
> 236 kernel_addr_r:
> 237
> 238   Mandatory. The location in RAM where the kernel will be loaded
> to when
> 239   processing the kernel option in the extlinux.conf.
> [..]
> 
> Thus I moved it to ensure that both windows are 64MB.
> 

Ok you are right, that makes sense.

Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>

[U-Boot] [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

[Auer, Lukas]

On Thu, 2019-04-11 at 14:51 +0200, David Abdurachmanov wrote:
> On Thu, Apr 11, 2019 at 2:41 PM Auer, Lukas
> <lukas.auer@aisec.fraunhofer.de> wrote:
> > + Bin
> > 
> > On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> > > - Set fdt_addr variable, which is needed for extlinux to find FDT.
> > >   Otherwise booting kernel using extlinux results in missing FDT.
> > > 
> > > - Also run fdt addr with FDT address so that fdt commands would
> > >   work out of the box in U-Boot prompt.
> > 
> > While often useful to have, the fdt command is not used during a normal
> > boot. I think we should avoid calling commands, which are not normally
> > needed. Can you remove this from your patch?
> 
> I borrowed idea from other boards, and I find it useful to have fdt working
> out-of-the-box without trying to figure the correct variable which holds
> address of FDT.
> 
> I can remove it from the patch, but I will probably keep adding it as Fedora
> specific patch then.
> 

That makes sense. I would still tend towards removing it, but will wait
to see what everybody else thinks.

Other than that, the patch looks good to me.

Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>

> > Thanks,
> > Lukas
> > 
> > > This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using
> > > OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> > > 
> > > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > > ---
> > >  include/configs/qemu-riscv.h | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/include/configs/qemu-riscv.h b/include/configs/qemu-riscv.h
> > > index 22a5cd7365..b7110edebc 100644
> > > --- a/include/configs/qemu-riscv.h
> > > +++ b/include/configs/qemu-riscv.h
> > > @@ -48,4 +48,8 @@
> > >       "ramdisk_addr_r=0x88300000\0" \
> > >       BOOTENV
> > > 
> > > +#define CONFIG_PREBOOT \
> > > +     "setenv fdt_addr ${fdtcontroladdr};" \
> > > +     "fdt addr ${fdtcontroladdr};"
> > > +
> > >  #endif /* __CONFIG_H */

[U-Boot] [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

[Bin Meng]

On Fri, Apr 12, 2019 at 12:38 AM Auer, Lukas
<lukas.auer@aisec.fraunhofer.de> wrote:
>
> On Thu, 2019-04-11 at 14:51 +0200, David Abdurachmanov wrote:
> > On Thu, Apr 11, 2019 at 2:41 PM Auer, Lukas
> > <lukas.auer@aisec.fraunhofer.de> wrote:
> > > + Bin
> > >
> > > On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> > > > - Set fdt_addr variable, which is needed for extlinux to find FDT.
> > > >   Otherwise booting kernel using extlinux results in missing FDT.
> > > >
> > > > - Also run fdt addr with FDT address so that fdt commands would
> > > >   work out of the box in U-Boot prompt.
> > >
> > > While often useful to have, the fdt command is not used during a normal
> > > boot. I think we should avoid calling commands, which are not normally
> > > needed. Can you remove this from your patch?
> >
> > I borrowed idea from other boards, and I find it useful to have fdt working
> > out-of-the-box without trying to figure the correct variable which holds
> > address of FDT.
> >
> > I can remove it from the patch, but I will probably keep adding it as Fedora
> > specific patch then.
> >
>
> That makes sense. I would still tend towards removing it, but will wait
> to see what everybody else thinks.

Yes, I am inclined to not include "fdt addr ${fdtcontroladdr};" too.

>
> Other than that, the patch looks good to me.
>
> Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[Bin Meng]

On Tue, Apr 9, 2019 at 8:30 PM David Abdurachmanov
<david.abdurachmanov@gmail.com> wrote:
>
> After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above
> the current threshold. Looking into HiKey, Dragonboards, etc. seems that
> SZ_64M is a popular option.
>
> This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master)
> with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
>
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  include/configs/qemu-riscv.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

[Rick Chen]

> Subject: Re: [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables
> extlinux)
>
> On Fri, Apr 12, 2019 at 12:38 AM Auer, Lukas <lukas.auer@aisec.fraunhofer.de>
> wrote:
> >
> > On Thu, 2019-04-11 at 14:51 +0200, David Abdurachmanov wrote:
> > > On Thu, Apr 11, 2019 at 2:41 PM Auer, Lukas
> > > <lukas.auer@aisec.fraunhofer.de> wrote:
> > > > + Bin
> > > >
> > > > On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
> > > > - Set fdt_addr variable, which is needed for extlinux to find FDT.
> > > >   Otherwise booting kernel using extlinux results in missing FDT.
> > > >
> > > > - Also run fdt addr with FDT address so that fdt commands would
> > > >   work out of the box in U-Boot prompt.
> > >
> > > > While often useful to have, the fdt command is not used during a
> > > > normal boot. I think we should avoid calling commands, which are
> > > > not normally needed. Can you remove this from your patch?
> > >
> > > I borrowed idea from other boards, and I find it useful to have fdt
> > > working out-of-the-box without trying to figure the correct variable
> > > which holds address of FDT.
> > >
> > > I can remove it from the patch, but I will probably keep adding it
> > > as Fedora specific patch then.
> > >
> >
> > That makes sense. I would still tend towards removing it, but will
> > wait to see what everybody else thinks.
>
> Yes, I am inclined to not include "fdt addr ${fdtcontroladdr};" too.
>
> >
> > Other than that, the patch looks good to me.
> >
> > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot-riscv/master, thanks!

[U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

[Rick Chen]

> Subject: Re: [U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to
> SZ_64M
>
> On Tue, Apr 9, 2019 at 8:30 PM David Abdurachmanov
> <david.abdurachmanov@gmail.com> wrote:
> >
> > After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased
> > above the current threshold. Looking into HiKey, Dragonboards, etc.
> > seems that SZ_64M is a popular option.
> >
> > This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0
> > (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > ---
> >  include/configs/qemu-riscv.h | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot-riscv/master, thanks!