[igt-dev] [PATCH i-g-t 1/3] kms_flip: Make busy-flip test less strict.

[igt-dev] [PATCH i-g-t 1/3] kms_flip: Make busy-flip test less strict.

[Maarten Lankhorst]

Remove the -interruptible test, the test only tests that we get an
-EBUSY after doing a pageflip. Doing this interruptibly adds the
possibility the test will take too long from retrying.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_flip.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index dfa5a69e8f28..08f3bd29b8eb 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1575,6 +1575,13 @@ int main(int argc, char **argv)
 		    !(tests[i].flags & TEST_VBLANK_ABSOLUTE))
 			continue;
 
+		/*
+		 * -EBUSY needs to complete in a single vblank, skip them for
+		 * interruptible tests
+		 */
+		if (tests[i].flags & TEST_EBUSY)
+			continue;
+
 		igt_subtest_f( "%s-interruptible", tests[i].name)
 			run_test(tests[i].duration, tests[i].flags);
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/3] tests/kms_flip: Reduce runtime to 1s for busy-flip.

[Maarten Lankhorst]

We don't actually care about running this for 30 seconds, all we
care is that we get a -EBUSY if a flip is already queued.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_flip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 08f3bd29b8eb..e50c91ead12c 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1497,7 +1497,7 @@ int main(int argc, char **argv)
 		{ 30,  TEST_VBLANK | TEST_VBLANK_BLOCK | TEST_VBLANK_ABSOLUTE,
 					"blocking-absolute-wf_vblank" },
 		{ 10, TEST_FLIP | TEST_BASIC, "plain-flip" },
-		{ 30, TEST_FLIP | TEST_EBUSY , "busy-flip" },
+		{ 1, TEST_FLIP | TEST_EBUSY, "busy-flip" },
 		{ 30, TEST_FLIP | TEST_FENCE_STRESS , "flip-vs-fences" },
 		{ 30, TEST_FLIP | TEST_CHECK_TS, "plain-flip-ts-check" },
 		{ 30, TEST_FLIP | TEST_CHECK_TS | TEST_FB_RECREATE,
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/3] tests/kms_flip: Do not request event for flips we expect to fail.

[Maarten Lankhorst]

If we unexpectedly pass, we get a cryptic
(kms_flip:935) CRITICAL: Test assertion failure function set_flag, file kms_flip.c:271:
(kms_flip:935) CRITICAL: Failed assertion: !(*v & flag)
(kms_flip:935) CRITICAL: Last errno: 25, Inappropriate ioctl for device

Instead of a more descriptive assertion error, clear the request for
event to fix this.

This will change the error reported in bug #103257.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=103257
---
 tests/kms_flip.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index e50c91ead12c..f8f3581eed2b 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -692,7 +692,7 @@ static unsigned int run_test_step(struct test_output *o)
 	}
 
 	if (do_flip && (o->flags & TEST_EINVAL) && o->flip_state.count > 0)
-		igt_assert(do_page_flip(o, new_fb_id, true) == expected_einval);
+		igt_assert(do_page_flip(o, new_fb_id, false) == expected_einval);
 
 	if (do_vblank && (o->flags & TEST_EINVAL) && o->vblank_state.count > 0)
 		igt_assert(do_wait_for_vblank(o, o->pipe, target_seq, &vbl_reply)
@@ -765,7 +765,7 @@ static unsigned int run_test_step(struct test_output *o)
 	}
 
 	if (do_flip && (o->flags & TEST_EBUSY))
-		igt_assert(do_page_flip(o, new_fb_id, true) == -EBUSY);
+		igt_assert(do_page_flip(o, new_fb_id, false) == -EBUSY);
 
 	if (do_flip && (o->flags & TEST_RMFB))
 		recreate_fb(o);
@@ -806,7 +806,7 @@ static unsigned int run_test_step(struct test_output *o)
 			   == -EINVAL);
 
 	if (do_flip && (o->flags & TEST_EINVAL))
-		igt_assert(do_page_flip(o, new_fb_id, true) == expected_einval);
+		igt_assert(do_page_flip(o, new_fb_id, false) == expected_einval);
 
 	unhang_gpu(drm_fd, hang);
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_flip: Do not request event for flips we expect to fail.

[Chris Wilson]

Quoting Maarten Lankhorst (2019-04-10 12:19:31)
> If we unexpectedly pass, we get a cryptic
> (kms_flip:935) CRITICAL: Test assertion failure function set_flag, file kms_flip.c:271:
> (kms_flip:935) CRITICAL: Failed assertion: !(*v & flag)
> (kms_flip:935) CRITICAL: Last errno: 25, Inappropriate ioctl for device
> 
> Instead of a more descriptive assertion error, clear the request for
> event to fix this.
> 
> This will change the error reported in bug #103257.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=103257
> ---
>  tests/kms_flip.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index e50c91ead12c..f8f3581eed2b 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -692,7 +692,7 @@ static unsigned int run_test_step(struct test_output *o)
>         }
>  
>         if (do_flip && (o->flags & TEST_EINVAL) && o->flip_state.count > 0)
> -               igt_assert(do_page_flip(o, new_fb_id, true) == expected_einval);
> +               igt_assert(do_page_flip(o, new_fb_id, false) == expected_einval);

If you have an expected value, use igt_assert_eq() to print what was
returned instead.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] kms_flip: Make busy-flip test less strict.

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/3] kms_flip: Make busy-flip test less strict.
URL   : https://patchwork.freedesktop.org/series/59280/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5898 -> IGTPW_2836
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59280/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2836 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       PASS -> DMESG-WARN [fdo#108965]

  * igt@gem_exec_basic@gtt-bsd2:
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] +57

  * igt@gem_exec_basic@readonly-bsd2:
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] +76

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      PASS -> DMESG-FAIL [fdo#110235 ]

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]

  * igt@kms_busy@basic-flip-c:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

  * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
    - fi-glk-dsi:         PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
    - fi-blb-e6850:       NOTRUN -> SKIP [fdo#109271] +20

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-blb-e6850:       NOTRUN -> INCOMPLETE [fdo#107718]

  * igt@kms_psr@cursor_plane_move:
    - fi-skl-6260u:       NOTRUN -> SKIP [fdo#109271] +37

  * igt@runner@aborted:
    - fi-apl-guc:         NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@i915_selftest@live_hangcheck:
    - fi-bxt-dsi:         INCOMPLETE [fdo#103927] -> PASS

  
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (49 -> 43)
------------------------------

  Additional (3): fi-byt-clapper fi-skl-6260u fi-pnv-d510 
  Missing    (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-kefka fi-bdw-samus 


Build changes
-------------

    * IGT: IGT_4937 -> IGTPW_2836

  CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2836: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2836/
  IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

-igt@kms_flip@2x-busy-flip-interruptible
-igt@kms_flip@busy-flip-interruptible

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2836/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_flip: Do not request event for flips we expect to fail.

[Maarten Lankhorst]

Op 10-04-2019 om 13:24 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2019-04-10 12:19:31)
>> If we unexpectedly pass, we get a cryptic
>> (kms_flip:935) CRITICAL: Test assertion failure function set_flag, file kms_flip.c:271:
>> (kms_flip:935) CRITICAL: Failed assertion: !(*v & flag)
>> (kms_flip:935) CRITICAL: Last errno: 25, Inappropriate ioctl for device
>>
>> Instead of a more descriptive assertion error, clear the request for
>> event to fix this.
>>
>> This will change the error reported in bug #103257.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=103257
>> ---
>>  tests/kms_flip.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
>> index e50c91ead12c..f8f3581eed2b 100755
>> --- a/tests/kms_flip.c
>> +++ b/tests/kms_flip.c
>> @@ -692,7 +692,7 @@ static unsigned int run_test_step(struct test_output *o)
>>         }
>>  
>>         if (do_flip && (o->flags & TEST_EINVAL) && o->flip_state.count > 0)
>> -               igt_assert(do_page_flip(o, new_fb_id, true) == expected_einval);
>> +               igt_assert(do_page_flip(o, new_fb_id, false) == expected_einval);
> If you have an expected value, use igt_assert_eq() to print what was
> returned instead.
> -Chris

r-b with that fixed?

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_flip: Do not request event for flips we expect to fail.

[Chris Wilson]

Quoting Maarten Lankhorst (2019-04-10 13:44:23)
> Op 10-04-2019 om 13:24 schreef Chris Wilson:
> > Quoting Maarten Lankhorst (2019-04-10 12:19:31)
> >> If we unexpectedly pass, we get a cryptic
> >> (kms_flip:935) CRITICAL: Test assertion failure function set_flag, file kms_flip.c:271:
> >> (kms_flip:935) CRITICAL: Failed assertion: !(*v & flag)
> >> (kms_flip:935) CRITICAL: Last errno: 25, Inappropriate ioctl for device
> >>
> >> Instead of a more descriptive assertion error, clear the request for
> >> event to fix this.
> >>
> >> This will change the error reported in bug #103257.
> >>
> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> >> References: https://bugs.freedesktop.org/show_bug.cgi?id=103257
> >> ---
> >>  tests/kms_flip.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> >> index e50c91ead12c..f8f3581eed2b 100755
> >> --- a/tests/kms_flip.c
> >> +++ b/tests/kms_flip.c
> >> @@ -692,7 +692,7 @@ static unsigned int run_test_step(struct test_output *o)
> >>         }
> >>  
> >>         if (do_flip && (o->flags & TEST_EINVAL) && o->flip_state.count > 0)
> >> -               igt_assert(do_page_flip(o, new_fb_id, true) == expected_einval);
> >> +               igt_assert(do_page_flip(o, new_fb_id, false) == expected_einval);
> > If you have an expected value, use igt_assert_eq() to print what was
> > returned instead.
> > -Chris
> 
> r-b with that fixed?

Sure.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
for all 3, the other 2 looked harmless and sensible.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] kms_flip: Make busy-flip test less strict.

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/3] kms_flip: Make busy-flip test less strict.
URL   : https://patchwork.freedesktop.org/series/59280/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5898_full -> IGTPW_2836_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59280/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2836_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#108566] +2

  * igt@gem_eio@wait-10ms:
    - shard-apl:          PASS -> INCOMPLETE [fdo#103927]

  * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] +12

  * igt@gem_pread@stolen-snoop:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109277] +2

  * igt@gem_pwrite@huge-gtt-fbr:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109290]

  * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109308]

  * igt@i915_pm_rps@min-max-config-loaded:
    - shard-apl:          PASS -> FAIL [fdo#102250]
    - shard-glk:          PASS -> FAIL [fdo#102250]
    - shard-iclb:         NOTRUN -> FAIL [fdo#108059]

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          PASS -> DMESG-WARN [fdo#108566] +4

  * igt@kms_atomic_transition@3x-modeset-transitions:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3

  * igt@kms_atomic_transition@4x-modeset-transitions:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +16

  * igt@kms_busy@extended-pageflip-hang-oldfb-render-d:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109278] +7

  * igt@kms_chamelium@hdmi-cmp-nv61:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109284] +4

  * igt@kms_color@pipe-a-ctm-max:
    - shard-iclb:         NOTRUN -> FAIL [fdo#108147]

  * igt@kms_content_protection@legacy:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109300]
    - shard-apl:          NOTRUN -> FAIL [fdo#110321] / [fdo#110336]

  * igt@kms_cursor_crc@cursor-512x512-sliding:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109279]

  * igt@kms_cursor_crc@cursor-64x64-random:
    - shard-kbl:          PASS -> FAIL [fdo#103232]
    - shard-apl:          NOTRUN -> FAIL [fdo#103232]

  * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109274] +3

  * igt@kms_fbcon_fbt@psr:
    - shard-iclb:         NOTRUN -> FAIL [fdo#103833]

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-glk:          PASS -> FAIL [fdo#105363]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
    - shard-iclb:         NOTRUN -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
    - shard-iclb:         PASS -> FAIL [fdo#103167] +3

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109280] +24

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         NOTRUN -> FAIL [fdo#109247] +1

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] +79

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
    - shard-iclb:         NOTRUN -> FAIL [fdo#105682] / [fdo#109247]

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
    - shard-iclb:         PASS -> FAIL [fdo#109247] +11

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
    - shard-kbl:          NOTRUN -> SKIP [fdo#109271] +16

  * igt@kms_lease@cursor_implicit_plane:
    - shard-apl:          NOTRUN -> FAIL [fdo#110278]

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-e:
    - shard-apl:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
    - shard-glk:          NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
    - shard-apl:          NOTRUN -> FAIL [fdo#108145]

  * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
    - shard-glk:          NOTRUN -> FAIL [fdo#108145]

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         PASS -> FAIL [fdo#103166]

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109642]

  * igt@kms_psr@cursor_render:
    - shard-iclb:         PASS -> FAIL [fdo#107383] / [fdo#110215]

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         PASS -> SKIP [fdo#109441] +1

  * igt@kms_psr@psr2_primary_page_flip:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109441] +1

  * igt@kms_rotation_crc@bad-pixel-format:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109289] +1

  * igt@kms_setmode@basic:
    - shard-kbl:          PASS -> FAIL [fdo#99912]

  * igt@kms_sysfs_edid_timing:
    - shard-apl:          NOTRUN -> FAIL [fdo#100047]

  * igt@perf_pmu@busy-check-all-vecs0:
    - shard-snb:          NOTRUN -> SKIP [fdo#109271] +112

  * igt@prime_busy@wait-after-bsd2:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109276] +17

  * igt@prime_nv_api@nv_i915_import_twice_check_flink_name:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109291] +2

  * igt@tools_test@sysfs_l3_parity:
    - shard-hsw:          PASS -> SKIP [fdo#109271]

  * igt@v3d_mmap@mmap-bad-handle:
    - shard-iclb:         NOTRUN -> SKIP [fdo#109315]

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          SKIP [fdo#109271] -> PASS
    - shard-snb:          SKIP [fdo#109271] -> PASS

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         DMESG-WARN [fdo#109982] -> PASS

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-kbl:          INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-64x64-random:
    - shard-iclb:         INCOMPLETE [fdo#109960] -> PASS

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-glk:          FAIL [fdo#104873] -> PASS

  * igt@kms_cursor_legacy@cursor-vs-flip-legacy:
    - shard-hsw:          FAIL [fdo#103355] -> PASS

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          FAIL [fdo#105363] -> PASS

  * igt@kms_flip@flip-vs-suspend:
    - shard-apl:          DMESG-WARN [fdo#108566] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
    - shard-iclb:         FAIL [fdo#103167] / [fdo#109960] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-tilingchange:
    - shard-iclb:         FAIL [fdo#103167] -> PASS +3

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
    - shard-iclb:         FAIL [fdo#109247] -> PASS +10

  * igt@kms_plane@pixel-format-pipe-a-planes:
    - shard-glk:          SKIP [fdo#109271] -> PASS

  * igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
    - shard-glk:          SKIP [fdo#109271] / [fdo#109278] -> PASS

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         SKIP [fdo#109642] -> PASS

  * igt@kms_psr@cursor_blt:
    - shard-iclb:         FAIL [fdo#107383] / [fdo#110215] -> PASS

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         SKIP [fdo#109441] -> PASS +2

  * igt@perf_pmu@cpu-hotplug:
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
  [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#109960]: https://bugs.freedesktop.org/show_bug.cgi?id=109960
  [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
  [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
  [fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278
  [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
  [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

    * IGT: IGT_4937 -> IGTPW_2836
    * Piglit: piglit_4509 -> None

  CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2836: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2836/
  IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2836/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_flip: Do not request event for flips we expect to fail.

[Maarten Lankhorst]

Op 10-04-2019 om 14:50 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2019-04-10 13:44:23)
>> Op 10-04-2019 om 13:24 schreef Chris Wilson:
>>> Quoting Maarten Lankhorst (2019-04-10 12:19:31)
>>>> If we unexpectedly pass, we get a cryptic
>>>> (kms_flip:935) CRITICAL: Test assertion failure function set_flag, file kms_flip.c:271:
>>>> (kms_flip:935) CRITICAL: Failed assertion: !(*v & flag)
>>>> (kms_flip:935) CRITICAL: Last errno: 25, Inappropriate ioctl for device
>>>>
>>>> Instead of a more descriptive assertion error, clear the request for
>>>> event to fix this.
>>>>
>>>> This will change the error reported in bug #103257.
>>>>
>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>> References: https://bugs.freedesktop.org/show_bug.cgi?id=103257
>>>> ---
>>>>  tests/kms_flip.c | 6 +++---
>>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
>>>> index e50c91ead12c..f8f3581eed2b 100755
>>>> --- a/tests/kms_flip.c
>>>> +++ b/tests/kms_flip.c
>>>> @@ -692,7 +692,7 @@ static unsigned int run_test_step(struct test_output *o)
>>>>         }
>>>>  
>>>>         if (do_flip && (o->flags & TEST_EINVAL) && o->flip_state.count > 0)
>>>> -               igt_assert(do_page_flip(o, new_fb_id, true) == expected_einval);
>>>> +               igt_assert(do_page_flip(o, new_fb_id, false) == expected_einval);
>>> If you have an expected value, use igt_assert_eq() to print what was
>>> returned instead.
>>> -Chris
>> r-b with that fixed?
> Sure.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> for all 3, the other 2 looked harmless and sensible.
> -Chris

Thanks, pushed. :)

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev