* [igt-dev] [PATCH i-g-t v9 0/3] kms_atomic_transition improvements
@ 2019-04-10 11:32 Stanislav Lisovskiy
2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 1/3] igt/tests: Remove redundant alpha retry Stanislav Lisovskiy
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Stanislav Lisovskiy @ 2019-04-10 11:32 UTC (permalink / raw)
To: igt-dev
Cc: stanislav.lisovskiy, ville.syrjala, martin.peres, juha-pekka.heikkila
Fixed run_transition_test issue, which might happen when no changes
are done and wait_transition is called and made setup_parms function
tolerate if kernel can't afford having all sprite planes enabled
depending on current mode. Remove redundant condition nesting and code.
Stanislav Lisovskiy (3):
igt/tests: Remove redundant alpha retry
igt/tests/kms_atomic_transition: Skip transition, if no changes done
igt/tests/kms_atomic_transition: Tolerate if can't have all planes
tests/kms_atomic_transition.c | 115 ++++++++++++++++++++--------------
1 file changed, 67 insertions(+), 48 deletions(-)
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread* [igt-dev] [PATCH i-g-t v9 1/3] igt/tests: Remove redundant alpha retry 2019-04-10 11:32 [igt-dev] [PATCH i-g-t v9 0/3] kms_atomic_transition improvements Stanislav Lisovskiy @ 2019-04-10 11:32 ` Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 2/3] igt/tests/kms_atomic_transition: Skip transition, if no changes done Stanislav Lisovskiy ` (3 subsequent siblings) 4 siblings, 0 replies; 9+ messages in thread From: Stanislav Lisovskiy @ 2019-04-10 11:32 UTC (permalink / raw) To: igt-dev Cc: stanislav.lisovskiy, ville.syrjala, martin.peres, juha-pekka.heikkila Using igt_plane_has_format_mod allows to save time not doing redundant retry, knowing if plane supports alpha beforehand. v2: Remove unneeded assertion also. Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> --- tests/kms_atomic_transition.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c index 18f73317..6f16a928 100644 --- a/tests/kms_atomic_transition.c +++ b/tests/kms_atomic_transition.c @@ -232,6 +232,9 @@ static void setup_parms(igt_display_t *display, enum pipe pipe, parms[i].height = cursor_height; parms[i].mask = 1 << 1; } else { + if (!n_overlays) + alpha = igt_plane_has_format_mod(plane, + DRM_FORMAT_ARGB8888, LOCAL_DRM_FORMAT_MOD_NONE); parms[i].fb = sprite_fb; parms[i].mask = 1 << 2; @@ -272,7 +275,6 @@ static void setup_parms(igt_display_t *display, enum pipe pipe, * Pre gen9 not all sizes are supported, find the biggest possible * size that can be enabled on all sprite planes. */ -retry: prev_w = sprite_width = cursor_width; prev_h = sprite_height = cursor_height; @@ -290,16 +292,6 @@ retry: igt_assert(!is_atomic_check_failure_errno(ret)); if (is_atomic_check_plane_size_errno(ret)) { - if (cursor_width == sprite_width && - cursor_height == sprite_height) { - igt_assert_f(alpha, - "Cannot configure the test with all sprite planes enabled\n"); - - /* retry once with XRGB format. */ - alpha = false; - goto retry; - } - sprite_width = prev_w; sprite_height = prev_h; -- 2.17.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t v9 2/3] igt/tests/kms_atomic_transition: Skip transition, if no changes done 2019-04-10 11:32 [igt-dev] [PATCH i-g-t v9 0/3] kms_atomic_transition improvements Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 1/3] igt/tests: Remove redundant alpha retry Stanislav Lisovskiy @ 2019-04-10 11:32 ` Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes Stanislav Lisovskiy ` (2 subsequent siblings) 4 siblings, 0 replies; 9+ messages in thread From: Stanislav Lisovskiy @ 2019-04-10 11:32 UTC (permalink / raw) To: igt-dev Cc: stanislav.lisovskiy, ville.syrjala, martin.peres, juha-pekka.heikkila While fixing used amount of planes, discovered that if wm_setup_plane is called with specific parameter that gives parms[i].mask & mask == 0 for all used planes, then subsequent wait_transition fails in assertion on fd_completed. So added return value to wm_setup_plane, which would allow to determine, if we really need to wait for any transitions. v2: Fixed commit message, to properly describe a reasoning for wm_setup_plane changes. Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> --- tests/kms_atomic_transition.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c index 6f16a928..a59be38a 100644 --- a/tests/kms_atomic_transition.c +++ b/tests/kms_atomic_transition.c @@ -118,11 +118,12 @@ static void configure_fencing(igt_plane_t *plane) igt_assert_eq(ret, 0); } -static void +static int wm_setup_plane(igt_display_t *display, enum pipe pipe, uint32_t mask, struct plane_parms *parms, bool fencing) { igt_plane_t *plane; + int planes_set_up = 0; /* * Make sure these buffers are suited for display use @@ -133,8 +134,10 @@ wm_setup_plane(igt_display_t *display, enum pipe pipe, int i = plane->index; if (!mask || !(parms[i].mask & mask)) { - if (plane->values[IGT_PLANE_FB_ID]) + if (plane->values[IGT_PLANE_FB_ID]) { igt_plane_set_fb(plane, NULL); + planes_set_up++; + } continue; } @@ -144,7 +147,10 @@ wm_setup_plane(igt_display_t *display, enum pipe pipe, igt_plane_set_fb(plane, parms[i].fb); igt_fb_set_size(parms[i].fb, plane, parms[i].width, parms[i].height); igt_plane_set_size(plane, parms[i].width, parms[i].height); + + planes_set_up++; } + return planes_set_up; } static void ev_page_flip(int fd, unsigned seq, unsigned tv_sec, unsigned tv_usec, void *user_data) @@ -536,7 +542,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output igt_output_set_pipe(output, pipe); - wm_setup_plane(display, pipe, i, parms, fencing); + if (!wm_setup_plane(display, pipe, i, parms, fencing)) + continue; atomic_commit(display, pipe, flags, (void *)(unsigned long)i, fencing); wait_for_transition(display, pipe, nonblocking, fencing); @@ -544,7 +551,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output if (type == TRANSITION_MODESET_DISABLE) { igt_output_set_pipe(output, PIPE_NONE); - wm_setup_plane(display, pipe, 0, parms, fencing); + if (!wm_setup_plane(display, pipe, 0, parms, fencing)) + continue; atomic_commit(display, pipe, flags, (void *) 0UL, fencing); wait_for_transition(display, pipe, nonblocking, fencing); @@ -560,7 +568,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output n_enable_planes < pipe_obj->n_planes) continue; - wm_setup_plane(display, pipe, j, parms, fencing); + if (!wm_setup_plane(display, pipe, j, parms, fencing)) + continue; if (type >= TRANSITION_MODESET) igt_output_override_mode(output, &override_mode); @@ -568,7 +577,9 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output atomic_commit(display, pipe, flags, (void *)(unsigned long) j, fencing); wait_for_transition(display, pipe, nonblocking, fencing); - wm_setup_plane(display, pipe, i, parms, fencing); + if (!wm_setup_plane(display, pipe, i, parms, fencing)) + continue; + if (type >= TRANSITION_MODESET) igt_output_override_mode(output, NULL); -- 2.17.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes 2019-04-10 11:32 [igt-dev] [PATCH i-g-t v9 0/3] kms_atomic_transition improvements Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 1/3] igt/tests: Remove redundant alpha retry Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 2/3] igt/tests/kms_atomic_transition: Skip transition, if no changes done Stanislav Lisovskiy @ 2019-04-10 11:32 ` Stanislav Lisovskiy 2019-04-10 15:06 ` Maarten Lankhorst 2019-04-10 12:21 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_atomic_transition improvements (rev17) Patchwork 2019-04-10 16:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 4 siblings, 1 reply; 9+ messages in thread From: Stanislav Lisovskiy @ 2019-04-10 11:32 UTC (permalink / raw) To: igt-dev Cc: stanislav.lisovskiy, ville.syrjala, martin.peres, juha-pekka.heikkila With some upcoming changes i915 might not allow all sprite planes enabled, depending on available bandwidth limitation. Thus the test need to decrement amount of planes and try again, instead of panicking. v2: Removed excessive nested conditions, making code a bit more readable(hopefully). v3: Stopped using global n_planes variable as it might cause resources being unreleased. Using now parms[i].mask as a way to determine if plane has to be included into commit. v4: Removed unneeded n_overlays initialization. v5: Randomize which of sprite planes to remove if hitting resource limits. v6: Replace igt_warn with igt_info, to make IGT tests happier. v7: Removed unneeded retry logic, made plane random removal simplier. Great thanks to Maarten Lankhorst for suggestions. v8: Fail if we have less than 3 planes v9: Remove unneeded diffs Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> --- tests/kms_atomic_transition.c | 78 +++++++++++++++++++++-------------- 1 file changed, 47 insertions(+), 31 deletions(-) diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c index a59be38a..1540daa2 100644 --- a/tests/kms_atomic_transition.c +++ b/tests/kms_atomic_transition.c @@ -184,6 +184,9 @@ static void set_sprite_wh(igt_display_t *display, enum pipe pipe, plane->type == DRM_PLANE_TYPE_CURSOR) continue; + if (!parms[i].mask) + continue; + parms[i].width = w; parms[i].height = h; } @@ -287,7 +290,7 @@ static void setup_parms(igt_display_t *display, enum pipe pipe, max_sprite_width = (sprite_width == mode->hdisplay); max_sprite_height = (sprite_height == mode->vdisplay); - while (1) { + while (!max_sprite_width && !max_sprite_height) { int ret; set_sprite_wh(display, pipe, parms, sprite_fb, @@ -297,46 +300,60 @@ static void setup_parms(igt_display_t *display, enum pipe pipe, ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); igt_assert(!is_atomic_check_failure_errno(ret)); - if (is_atomic_check_plane_size_errno(ret)) { - sprite_width = prev_w; - sprite_height = prev_h; - - if (max_sprite_width && max_sprite_height) { - set_sprite_wh(display, pipe, parms, sprite_fb, - alpha, sprite_width, sprite_height); - break; - } - - if (!max_sprite_width) - max_sprite_width = true; - else - max_sprite_height = true; - } else { + if (!is_atomic_check_plane_size_errno(ret)) { prev_w = sprite_width; prev_h = sprite_height; - } - - if (!max_sprite_width) { - sprite_width *= 2; - + sprite_width *= max_sprite_width ? 1 : 2; if (sprite_width >= mode->hdisplay) { max_sprite_width = true; sprite_width = mode->hdisplay; } - } else if (!max_sprite_height) { - sprite_height *= 2; + sprite_height *= max_sprite_height ? 1 : 2; if (sprite_height >= mode->vdisplay) { max_sprite_height = true; sprite_height = mode->vdisplay; } - } else - /* Max sized sprites for all! */ - break; + continue; + } + + if (cursor_width == sprite_width && + cursor_height == sprite_height) { + igt_plane_t *removed_plane = NULL; + igt_assert_f(n_planes >= 3, "No planes left to proceed with!"); + if (n_overlays > 0) { + uint32_t plane_to_remove = hars_petruska_f54_1_random_unsafe_max(n_overlays); + removed_plane = &display->pipes[pipe].planes[overlays[plane_to_remove]]; + igt_plane_set_fb(removed_plane, NULL); + while (plane_to_remove < (n_overlays - 1)) { + overlays[plane_to_remove] = overlays[plane_to_remove + 1]; + plane_to_remove++; + } + n_overlays--; + } + if (removed_plane) { + parms[removed_plane->index].mask = 0; + igt_info("Removed plane %d\n", removed_plane->index); + } + n_planes--; + igt_info("Reduced available planes to %d\n", n_planes); + continue; + } + + sprite_width = prev_w; + sprite_height = prev_h; + + if (!max_sprite_width) + max_sprite_width = true; + else + max_sprite_height = true; } + set_sprite_wh(display, pipe, parms, sprite_fb, + alpha, sprite_width, sprite_height); + igt_info("Running test on pipe %s with resolution %dx%d and sprite size %dx%d alpha %i\n", kmstest_pipe_name(pipe), mode->hdisplay, mode->vdisplay, sprite_width, sprite_height, alpha); @@ -490,9 +507,6 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output plane->type == DRM_PLANE_TYPE_CURSOR) continue; - if (parms[i].width <= 512) - continue; - parms[i].width /= 2; ret = 1; igt_info("Reducing sprite %i to %ux%u\n", i - 1, parms[i].width, parms[i].height); @@ -517,8 +531,10 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output } /* force planes to be part of commit */ - for_each_plane_on_pipe(display, pipe, plane) - igt_plane_set_position(plane, 0, 0); + for_each_plane_on_pipe(display, pipe, plane) { + if (parms[plane->index].mask) + igt_plane_set_position(plane, 0, 0); + } igt_display_commit2(display, COMMIT_ATOMIC); -- 2.17.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes Stanislav Lisovskiy @ 2019-04-10 15:06 ` Maarten Lankhorst 2019-04-11 8:39 ` Maarten Lankhorst 0 siblings, 1 reply; 9+ messages in thread From: Maarten Lankhorst @ 2019-04-10 15:06 UTC (permalink / raw) To: Stanislav Lisovskiy, igt-dev Cc: ville.syrjala, martin.peres, juha-pekka.heikkila Op 10-04-2019 om 13:32 schreef Stanislav Lisovskiy: > With some upcoming changes i915 might not allow > all sprite planes enabled, depending on available > bandwidth limitation. Thus the test need to decrement > amount of planes and try again, instead of panicking. > > v2: Removed excessive nested conditions, making code a bit > more readable(hopefully). > > v3: Stopped using global n_planes variable as it might cause > resources being unreleased. > Using now parms[i].mask as a way to determine if plane > has to be included into commit. > > v4: Removed unneeded n_overlays initialization. > > v5: Randomize which of sprite planes to remove if hitting > resource limits. > > v6: Replace igt_warn with igt_info, to make IGT tests happier. > > v7: Removed unneeded retry logic, made plane random removal simplier. > Great thanks to Maarten Lankhorst for suggestions. > > v8: Fail if we have less than 3 planes > > v9: Remove unneeded diffs > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > --- > tests/kms_atomic_transition.c | 78 +++++++++++++++++++++-------------- > 1 file changed, 47 insertions(+), 31 deletions(-) Assuming CI is happy: Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes 2019-04-10 15:06 ` Maarten Lankhorst @ 2019-04-11 8:39 ` Maarten Lankhorst 2019-04-11 9:07 ` Lisovskiy, Stanislav 0 siblings, 1 reply; 9+ messages in thread From: Maarten Lankhorst @ 2019-04-11 8:39 UTC (permalink / raw) To: Stanislav Lisovskiy, igt-dev Cc: ville.syrjala, martin.peres, juha-pekka.heikkila Op 10-04-2019 om 17:06 schreef Maarten Lankhorst: > Op 10-04-2019 om 13:32 schreef Stanislav Lisovskiy: >> With some upcoming changes i915 might not allow >> all sprite planes enabled, depending on available >> bandwidth limitation. Thus the test need to decrement >> amount of planes and try again, instead of panicking. >> >> v2: Removed excessive nested conditions, making code a bit >> more readable(hopefully). >> >> v3: Stopped using global n_planes variable as it might cause >> resources being unreleased. >> Using now parms[i].mask as a way to determine if plane >> has to be included into commit. >> >> v4: Removed unneeded n_overlays initialization. >> >> v5: Randomize which of sprite planes to remove if hitting >> resource limits. >> >> v6: Replace igt_warn with igt_info, to make IGT tests happier. >> >> v7: Removed unneeded retry logic, made plane random removal simplier. >> Great thanks to Maarten Lankhorst for suggestions. >> >> v8: Fail if we have less than 3 planes >> >> v9: Remove unneeded diffs >> >> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> >> --- >> tests/kms_atomic_transition.c | 78 +++++++++++++++++++++-------------- >> 1 file changed, 47 insertions(+), 31 deletions(-) > Assuming CI is happy: > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Thanks, pushed. :) _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes 2019-04-11 8:39 ` Maarten Lankhorst @ 2019-04-11 9:07 ` Lisovskiy, Stanislav 0 siblings, 0 replies; 9+ messages in thread From: Lisovskiy, Stanislav @ 2019-04-11 9:07 UTC (permalink / raw) To: Maarten Lankhorst, igt-dev Cc: Syrjala, Ville, Peres, Martin, Heikkila, Juha-pekka Great, thanks for nice coding suggestions. Best Regards, Lisovskiy Stanislav Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ________________________________________ From: Maarten Lankhorst [maarten.lankhorst@linux.intel.com] Sent: Thursday, April 11, 2019 11:39 AM To: Lisovskiy, Stanislav; igt-dev@lists.freedesktop.org Cc: Syrjala, Ville; Peres, Martin; Heikkila, Juha-pekka Subject: Re: [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes Op 10-04-2019 om 17:06 schreef Maarten Lankhorst: > Op 10-04-2019 om 13:32 schreef Stanislav Lisovskiy: >> With some upcoming changes i915 might not allow >> all sprite planes enabled, depending on available >> bandwidth limitation. Thus the test need to decrement >> amount of planes and try again, instead of panicking. >> >> v2: Removed excessive nested conditions, making code a bit >> more readable(hopefully). >> >> v3: Stopped using global n_planes variable as it might cause >> resources being unreleased. >> Using now parms[i].mask as a way to determine if plane >> has to be included into commit. >> >> v4: Removed unneeded n_overlays initialization. >> >> v5: Randomize which of sprite planes to remove if hitting >> resource limits. >> >> v6: Replace igt_warn with igt_info, to make IGT tests happier. >> >> v7: Removed unneeded retry logic, made plane random removal simplier. >> Great thanks to Maarten Lankhorst for suggestions. >> >> v8: Fail if we have less than 3 planes >> >> v9: Remove unneeded diffs >> >> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> >> --- >> tests/kms_atomic_transition.c | 78 +++++++++++++++++++++-------------- >> 1 file changed, 47 insertions(+), 31 deletions(-) > Assuming CI is happy: > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Thanks, pushed. :) _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for kms_atomic_transition improvements (rev17) 2019-04-10 11:32 [igt-dev] [PATCH i-g-t v9 0/3] kms_atomic_transition improvements Stanislav Lisovskiy ` (2 preceding siblings ...) 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes Stanislav Lisovskiy @ 2019-04-10 12:21 ` Patchwork 2019-04-10 16:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 4 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2019-04-10 12:21 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: igt-dev == Series Details == Series: kms_atomic_transition improvements (rev17) URL : https://patchwork.freedesktop.org/series/58728/ State : success == Summary == CI Bug Log - changes from CI_DRM_5898 -> IGTPW_2837 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/58728/revisions/17/mbox/ Known issues ------------ Here are the changes found in IGTPW_2837 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_basic@gtt-bsd2: - fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57 * igt@gem_exec_basic@readonly-bsd2: - fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76 * igt@i915_selftest@live_execlists: - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720] * igt@kms_busy@basic-flip-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] - fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] - fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size: - fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133] * igt@kms_frontbuffer_tracking@basic: - fi-byt-clapper: NOTRUN -> FAIL [fdo#103167] * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48 * igt@kms_pipe_crc_basic@read-crc-pipe-b: - fi-byt-clapper: NOTRUN -> FAIL [fdo#107362] * igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence: - fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362] +1 * igt@kms_psr@cursor_plane_move: - fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +37 * igt@runner@aborted: - fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720] #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (49 -> 37) ------------------------------ Additional (3): fi-byt-clapper fi-skl-6260u fi-pnv-d510 Missing (15): fi-kbl-soraka fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-kbl-x1275 fi-bxt-j4205 fi-gdg-551 fi-icl-y fi-byt-n2820 fi-bdw-samus Build changes ------------- * IGT: IGT_4937 -> IGTPW_2837 CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2837: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2837/ IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2837/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for kms_atomic_transition improvements (rev17) 2019-04-10 11:32 [igt-dev] [PATCH i-g-t v9 0/3] kms_atomic_transition improvements Stanislav Lisovskiy ` (3 preceding siblings ...) 2019-04-10 12:21 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_atomic_transition improvements (rev17) Patchwork @ 2019-04-10 16:33 ` Patchwork 4 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2019-04-10 16:33 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: igt-dev == Series Details == Series: kms_atomic_transition improvements (rev17) URL : https://patchwork.freedesktop.org/series/58728/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5898_full -> IGTPW_2837_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_2837_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_2837_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/58728/revisions/17/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_2837_full: ### IGT changes ### #### Possible regressions #### * igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible: - shard-apl: PASS -> DMESG-WARN Known issues ------------ Here are the changes found in IGTPW_2837_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@bcs0-s3: - shard-apl: PASS -> DMESG-WARN [fdo#108566] +3 * igt@gem_eio@in-flight-suspend: - shard-kbl: PASS -> DMESG-WARN [fdo#108566] +2 * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-glk: NOTRUN -> SKIP [fdo#109271] +11 * igt@gem_pread@stolen-snoop: - shard-iclb: NOTRUN -> SKIP [fdo#109277] +2 * igt@gem_pwrite@huge-gtt-fbr: - shard-iclb: NOTRUN -> SKIP [fdo#109290] * igt@gem_tiled_swapping@non-threaded: - shard-iclb: PASS -> FAIL [fdo#108686] - shard-hsw: PASS -> FAIL [fdo#108686] * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp: - shard-iclb: NOTRUN -> SKIP [fdo#109308] * igt@i915_pm_rps@min-max-config-loaded: - shard-iclb: NOTRUN -> FAIL [fdo#108059] * igt@kms_atomic_transition@3x-modeset-transitions: - shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2 * igt@kms_atomic_transition@4x-modeset-transitions: - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +16 * igt@kms_busy@extended-pageflip-hang-oldfb-render-d: - shard-iclb: NOTRUN -> SKIP [fdo#109278] +7 * igt@kms_chamelium@hdmi-cmp-nv61: - shard-iclb: NOTRUN -> SKIP [fdo#109284] +4 * igt@kms_color@pipe-a-ctm-max: - shard-iclb: NOTRUN -> FAIL [fdo#108147] * igt@kms_content_protection@legacy: - shard-iclb: NOTRUN -> SKIP [fdo#109300] - shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336] * igt@kms_cursor_crc@cursor-256x256-suspend: - shard-hsw: PASS -> INCOMPLETE [fdo#103540] * igt@kms_cursor_crc@cursor-512x512-sliding: - shard-iclb: NOTRUN -> SKIP [fdo#109279] * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy: - shard-iclb: NOTRUN -> SKIP [fdo#109274] +4 * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: PASS -> FAIL [fdo#104873] * igt@kms_fbcon_fbt@psr: - shard-iclb: NOTRUN -> FAIL [fdo#103833] * igt@kms_flip@modeset-vs-vblank-race: - shard-glk: PASS -> FAIL [fdo#103060] * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render: - shard-iclb: PASS -> FAIL [fdo#103167] * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: - shard-iclb: NOTRUN -> SKIP [fdo#109280] +23 * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt: - shard-iclb: PASS -> FAIL [fdo#109247] +14 * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render: - shard-iclb: NOTRUN -> FAIL [fdo#109247] +1 * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move: - shard-apl: NOTRUN -> SKIP [fdo#109271] +85 * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc: - shard-iclb: NOTRUN -> FAIL [fdo#105682] / [fdo#109247] * igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt: - shard-kbl: NOTRUN -> SKIP [fdo#109271] +16 * igt@kms_lease@cursor_implicit_plane: - shard-apl: NOTRUN -> FAIL [fdo#110278] * igt@kms_pipe_crc_basic@hang-read-crc-pipe-e: - shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6 * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d: - shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1 * igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb: - shard-apl: NOTRUN -> FAIL [fdo#108145] +1 * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-glk: NOTRUN -> FAIL [fdo#108145] * igt@kms_psr2_su@frontbuffer: - shard-iclb: NOTRUN -> SKIP [fdo#109642] * igt@kms_psr@cursor_plane_onoff: - shard-iclb: NOTRUN -> FAIL [fdo#107383] / [fdo#110215] +1 * igt@kms_psr@psr2_no_drrs: - shard-iclb: PASS -> SKIP [fdo#109441] +1 * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: NOTRUN -> SKIP [fdo#109441] +1 * igt@kms_psr@sprite_plane_move: - shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +3 * igt@kms_rotation_crc@bad-pixel-format: - shard-iclb: NOTRUN -> SKIP [fdo#109289] +1 * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom: - shard-kbl: PASS -> DMESG-FAIL [fdo#105763] * igt@kms_rotation_crc@multiplane-rotation-cropping-top: - shard-kbl: PASS -> FAIL [fdo#109016] +1 * igt@kms_sysfs_edid_timing: - shard-apl: NOTRUN -> FAIL [fdo#100047] * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-kbl: PASS -> INCOMPLETE [fdo#103665] * igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm: - shard-apl: PASS -> FAIL [fdo#104894] - shard-kbl: PASS -> FAIL [fdo#104894] * igt@perf_pmu@busy-check-all-vecs0: - shard-snb: NOTRUN -> SKIP [fdo#109271] +112 * igt@prime_busy@wait-after-bsd2: - shard-iclb: NOTRUN -> SKIP [fdo#109276] +17 * igt@prime_nv_api@nv_i915_import_twice_check_flink_name: - shard-iclb: NOTRUN -> SKIP [fdo#109291] +3 * igt@v3d_mmap@mmap-bad-handle: - shard-iclb: NOTRUN -> SKIP [fdo#109315] #### Possible fixes #### * igt@gem_ctx_isolation@bcs0-s3: - shard-kbl: INCOMPLETE [fdo#103665] -> PASS * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-kbl: SKIP [fdo#109271] -> PASS * igt@i915_pm_rpm@i2c: - shard-iclb: DMESG-WARN [fdo#109982] -> PASS * igt@i915_pm_rpm@system-suspend-execbuf: - shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS * igt@i915_suspend@debugfs-reader: - shard-apl: DMESG-WARN [fdo#108566] -> PASS +4 * igt@kms_cursor_crc@cursor-128x128-random: - shard-apl: FAIL [fdo#103232] -> PASS * igt@kms_cursor_crc@cursor-64x64-random: - shard-iclb: INCOMPLETE [fdo#109960] -> PASS * igt@kms_cursor_legacy@cursor-vs-flip-legacy: - shard-hsw: FAIL [fdo#103355] -> PASS * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: FAIL [fdo#105363] -> PASS * igt@kms_frontbuffer_tracking@fbc-tilingchange: - shard-iclb: FAIL [fdo#103167] -> PASS * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite: - shard-iclb: FAIL [fdo#109247] -> PASS +11 * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping: - shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS +1 * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: SKIP [fdo#109441] -> PASS * igt@kms_psr@sprite_mmap_cpu: - shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +1 * igt@kms_setmode@basic: - shard-apl: FAIL [fdo#99912] -> PASS * igt@kms_sysfs_edid_timing: - shard-iclb: FAIL [fdo#100047] -> PASS * igt@perf_pmu@cpu-hotplug: - shard-apl: INCOMPLETE [fdo#103927] -> PASS [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047 [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873 [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763 [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016 [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109960]: https://bugs.freedesktop.org/show_bug.cgi?id=109960 [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982 [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215 [fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278 [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321 [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (10 -> 6) ------------------------------ Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 Build changes ------------- * IGT: IGT_4937 -> IGTPW_2837 * Piglit: piglit_4509 -> None CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2837: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2837/ IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2837/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-11 9:07 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-04-10 11:32 [igt-dev] [PATCH i-g-t v9 0/3] kms_atomic_transition improvements Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 1/3] igt/tests: Remove redundant alpha retry Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 2/3] igt/tests/kms_atomic_transition: Skip transition, if no changes done Stanislav Lisovskiy 2019-04-10 11:32 ` [igt-dev] [PATCH i-g-t v9 3/3] igt/tests/kms_atomic_transition: Tolerate if can't have all planes Stanislav Lisovskiy 2019-04-10 15:06 ` Maarten Lankhorst 2019-04-11 8:39 ` Maarten Lankhorst 2019-04-11 9:07 ` Lisovskiy, Stanislav 2019-04-10 12:21 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_atomic_transition improvements (rev17) Patchwork 2019-04-10 16:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.