From: Shawn Guo <shawnguo@kernel.org> To: Andrey Smirnov <andrew.smirnov@gmail.com> Cc: Lucas Stach <l.stach@pengutronix.de>, Angus Ainslie <angus@akkea.ca>, Chris Healy <cphealy@gmail.com>, Fabio Estevam <fabio.estevam@nxp.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 11 Apr 2019 10:30:09 +0800 [thread overview] Message-ID: <20190411023008.GK26817@dragon> (raw) In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> On Thu, Mar 28, 2019 at 11:49:16PM -0700, Andrey Smirnov wrote: > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" > clock to determine if it needs to configure the IP block as operating > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both > clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that > ratio is 1:1 which results in broken SDMA funtionality(this at least > breaks RAVE SP serdev driver on RDU2). Fix the code to specify > IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect > clock ratio. > > Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Since we have a fix in the dma driver, I dropped the Fixes tag here. Applied all, thanks. Shawn > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Cc: Angus Ainslie (Purism) <angus@akkea.ca> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/imx6qdl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 9f9aa6e7ed0e..354feba077b2 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -949,7 +949,7 @@ > compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; > reg = <0x020ec000 0x4000>; > interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clks IMX6QDL_CLK_SDMA>, > + clocks = <&clks IMX6QDL_CLK_IPG>, > <&clks IMX6QDL_CLK_SDMA>; > clock-names = "ipg", "ahb"; > #dma-cells = <3>; > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org> To: Andrey Smirnov <andrew.smirnov@gmail.com> Cc: Angus Ainslie <angus@akkea.ca>, linux-kernel@vger.kernel.org, Chris Healy <cphealy@gmail.com>, Fabio Estevam <fabio.estevam@nxp.com>, linux-arm-kernel@lists.infradead.org, Lucas Stach <l.stach@pengutronix.de> Subject: Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 11 Apr 2019 10:30:09 +0800 [thread overview] Message-ID: <20190411023008.GK26817@dragon> (raw) In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> On Thu, Mar 28, 2019 at 11:49:16PM -0700, Andrey Smirnov wrote: > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" > clock to determine if it needs to configure the IP block as operating > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both > clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that > ratio is 1:1 which results in broken SDMA funtionality(this at least > breaks RAVE SP serdev driver on RDU2). Fix the code to specify > IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect > clock ratio. > > Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Since we have a fix in the dma driver, I dropped the Fixes tag here. Applied all, thanks. Shawn > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > Cc: Angus Ainslie (Purism) <angus@akkea.ca> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/imx6qdl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 9f9aa6e7ed0e..354feba077b2 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -949,7 +949,7 @@ > compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; > reg = <0x020ec000 0x4000>; > interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clks IMX6QDL_CLK_SDMA>, > + clocks = <&clks IMX6QDL_CLK_IPG>, > <&clks IMX6QDL_CLK_SDMA>; > clock-names = "ipg", "ahb"; > #dma-cells = <3>; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-11 2:30 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-29 6:49 [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 2/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 3/9] ARM: dts: imx7d: Specify IMX7D_CLK_IPG " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 4/9] ARM: dts: imx6ul: Specify IMX6UL_CLK_IPG " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 5/9] ARM: dts: imx6sll: Specify IMX6SLL_CLK_IPG " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 6/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG as "ahb" " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 7/9] ARM: dts: imx53: Specify IMX5_CLK_IPG " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 8/9] ARM: dts: imx51: " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-03-29 6:49 ` [PATCH v3 9/9] ARM: dts: imx50: " Andrey Smirnov 2019-03-29 6:49 ` Andrey Smirnov 2019-04-10 18:47 ` [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" " Adam Ford 2019-04-10 18:47 ` Adam Ford 2019-04-11 2:30 ` Shawn Guo [this message] 2019-04-11 2:30 ` Shawn Guo 2019-04-20 12:14 ` Adam Ford 2019-04-20 12:14 ` Adam Ford 2019-04-20 13:33 ` Shawn Guo 2019-04-20 13:33 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190411023008.GK26817@dragon \ --to=shawnguo@kernel.org \ --cc=andrew.smirnov@gmail.com \ --cc=angus@akkea.ca \ --cc=cphealy@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.