[hubcap:for-next 20/22] fs/orangefs/file.c:574:5: sparse: symbol 'orangefs_file_open' was not declared. Should it be static?

[hubcap:for-next 20/22] fs/orangefs/file.c:574:5: sparse: symbol 'orangefs_file_open' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux for-next
head:   6055a739910e69f8f76120d48e7ae74a13b1fdda
commit: 9a959aaffd7090810eade53e4d960614405f57c6 [20/22] orangefs: remember count when reading.
reproduce:
        # apt-get install sparse
        git checkout 9a959aaffd7090810eade53e4d960614405f57c6
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

>> fs/orangefs/file.c:574:5: sparse: symbol 'orangefs_file_open' was not declared. Should it be static?
   fs/orangefs/file.c:580:5: sparse: symbol 'orangefs_flush' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH hubcap] orangefs: orangefs_file_open() can be static

[kbuild test robot]

Fixes: 9a959aaffd70 ("orangefs: remember count when reading.")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c
index d198af9..01d0db6 100644
--- a/fs/orangefs/file.c
+++ b/fs/orangefs/file.c
@@ -571,7 +571,7 @@ static int orangefs_lock(struct file *filp, int cmd, struct file_lock *fl)
 	return rc;
 }
 
-int orangefs_file_open(struct inode * inode, struct file *file)
+static int orangefs_file_open(struct inode * inode, struct file *file)
 {
 	file->private_data = NULL;
 	return generic_file_open(inode, file);

Re: [RFC PATCH hubcap] orangefs: orangefs_file_open() can be static

[Joe Perches]

On Thu, 2019-04-11 at 09:58 +0800, kbuild test robot wrote:
> Fixes: 9a959aaffd70 ("orangefs: remember count when reading.")

Making something static likely does not warrant a "Fixes:" tag

> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  file.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c
> index d198af9..01d0db6 100644
> --- a/fs/orangefs/file.c
> +++ b/fs/orangefs/file.c
> @@ -571,7 +571,7 @@ static int orangefs_lock(struct file *filp, int cmd, struct file_lock *fl)
>  	return rc;
>  }
>  
> -int orangefs_file_open(struct inode * inode, struct file *file)
> +static int orangefs_file_open(struct inode * inode, struct file *file)
>  {
>  	file->private_data = NULL;
>  	return generic_file_open(inode, file);