All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mq: add GPU node
@ 2019-04-04 16:52 ` Lucas Stach
  0 siblings, 0 replies; 14+ messages in thread
From: Lucas Stach @ 2019-04-04 16:52 UTC (permalink / raw)
  To: Shawn Guo
  Cc: devicetree, patchwork-lst, NXP Linux Team, kernel, Fabio Estevam,
	linux-arm-kernel

This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 4300781558f6..79d418b4f585 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -792,6 +792,28 @@
 			};
 		};
 
+		gpu: gpu@38000000 {
+			compatible = "vivante,gc";
+			reg = <0x38000000 0x40000>;
+			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
+			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
+			         <&clk IMX8MQ_CLK_GPU_AXI>,
+			         <&clk IMX8MQ_CLK_GPU_AHB>;
+			clock-names = "core", "shader", "bus", "reg";
+			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
+			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
+			                  <&clk IMX8MQ_CLK_GPU_AXI>,
+			                  <&clk IMX8MQ_CLK_GPU_AHB>;
+			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
+			                         <&clk IMX8MQ_GPU_PLL_OUT>,
+			                         <&clk IMX8MQ_GPU_PLL_OUT>,
+			                         <&clk IMX8MQ_GPU_PLL_OUT>;
+			assigned-clock-rates = <800000000>, <800000000>,
+			                       <800000000>, <800000000>;
+			power-domains = <&pgc_gpu>;
+		};
+
 		usb_dwc3_0: usb@38100000 {
 			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
 			reg = <0x38100000 0x10000>;
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH] arm64: dts: imx8mq: add GPU node
@ 2019-04-04 16:52 ` Lucas Stach
  0 siblings, 0 replies; 14+ messages in thread
From: Lucas Stach @ 2019-04-04 16:52 UTC (permalink / raw)
  To: Shawn Guo
  Cc: devicetree, patchwork-lst, NXP Linux Team, kernel, Fabio Estevam,
	linux-arm-kernel

This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 4300781558f6..79d418b4f585 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -792,6 +792,28 @@
 			};
 		};
 
+		gpu: gpu@38000000 {
+			compatible = "vivante,gc";
+			reg = <0x38000000 0x40000>;
+			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
+			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
+			         <&clk IMX8MQ_CLK_GPU_AXI>,
+			         <&clk IMX8MQ_CLK_GPU_AHB>;
+			clock-names = "core", "shader", "bus", "reg";
+			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
+			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
+			                  <&clk IMX8MQ_CLK_GPU_AXI>,
+			                  <&clk IMX8MQ_CLK_GPU_AHB>;
+			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
+			                         <&clk IMX8MQ_GPU_PLL_OUT>,
+			                         <&clk IMX8MQ_GPU_PLL_OUT>,
+			                         <&clk IMX8MQ_GPU_PLL_OUT>;
+			assigned-clock-rates = <800000000>, <800000000>,
+			                       <800000000>, <800000000>;
+			power-domains = <&pgc_gpu>;
+		};
+
 		usb_dwc3_0: usb@38100000 {
 			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
 			reg = <0x38100000 0x10000>;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
  2019-04-04 16:52 ` Lucas Stach
@ 2019-04-08 13:07   ` Guido Günther
  -1 siblings, 0 replies; 14+ messages in thread
From: Guido Günther @ 2019-04-08 13:07 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, Shawn Guo, patchwork-lst, NXP Linux Team, kernel,
	Fabio Estevam, linux-arm-kernel

Hi Lucas,
On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 4300781558f6..79d418b4f585 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -792,6 +792,28 @@
>  			};
>  		};
>  
> +		gpu: gpu@38000000 {
> +			compatible = "vivante,gc";
> +			reg = <0x38000000 0x40000>;
> +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> +			clock-names = "core", "shader", "bus", "reg";
> +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> +			assigned-clock-rates = <800000000>, <800000000>,
> +			                       <800000000>, <800000000>;
> +			power-domains = <&pgc_gpu>;
> +		};

Reviewed-by: Guido Günther <agx@sigxcpu.org>

Cheers,
 -- Guido


> +
>  		usb_dwc3_0: usb@38100000 {
>  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
>  			reg = <0x38100000 0x10000>;
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
@ 2019-04-08 13:07   ` Guido Günther
  0 siblings, 0 replies; 14+ messages in thread
From: Guido Günther @ 2019-04-08 13:07 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, Shawn Guo, patchwork-lst, NXP Linux Team, kernel,
	Fabio Estevam, linux-arm-kernel

Hi Lucas,
On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 4300781558f6..79d418b4f585 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -792,6 +792,28 @@
>  			};
>  		};
>  
> +		gpu: gpu@38000000 {
> +			compatible = "vivante,gc";
> +			reg = <0x38000000 0x40000>;
> +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> +			clock-names = "core", "shader", "bus", "reg";
> +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> +			assigned-clock-rates = <800000000>, <800000000>,
> +			                       <800000000>, <800000000>;
> +			power-domains = <&pgc_gpu>;
> +		};

Reviewed-by: Guido Günther <agx@sigxcpu.org>

Cheers,
 -- Guido


> +
>  		usb_dwc3_0: usb@38100000 {
>  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
>  			reg = <0x38100000 0x10000>;
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
  2019-04-08 13:07   ` Guido Günther
@ 2019-04-08 13:45     ` Guido Günther
  -1 siblings, 0 replies; 14+ messages in thread
From: Guido Günther @ 2019-04-08 13:45 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, Shawn Guo, patchwork-lst, NXP Linux Team, kernel,
	Fabio Estevam, linux-arm-kernel

Hi,
On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido Günther wrote:
> Hi Lucas,
> On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 4300781558f6..79d418b4f585 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -792,6 +792,28 @@
> >  			};
> >  		};
> >  
> > +		gpu: gpu@38000000 {
> > +			compatible = "vivante,gc";
> > +			reg = <0x38000000 0x40000>;
> > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > +			clock-names = "core", "shader", "bus", "reg";
> > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > +			assigned-clock-rates = <800000000>, <800000000>,
> > +			                       <800000000>, <800000000>;
> > +			power-domains = <&pgc_gpu>;
> > +		};
> 
> Reviewed-by: Guido Günther <agx@sigxcpu.org>

On a second thought should this have a

    status = "disabled";

Cheers,
 -- Guido


> 
> Cheers,
>  -- Guido
> 
> 
> > +
> >  		usb_dwc3_0: usb@38100000 {
> >  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> >  			reg = <0x38100000 0x10000>;
> > -- 
> > 2.20.1
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
@ 2019-04-08 13:45     ` Guido Günther
  0 siblings, 0 replies; 14+ messages in thread
From: Guido Günther @ 2019-04-08 13:45 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, Shawn Guo, patchwork-lst, NXP Linux Team, kernel,
	Fabio Estevam, linux-arm-kernel

Hi,
On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido Günther wrote:
> Hi Lucas,
> On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 4300781558f6..79d418b4f585 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -792,6 +792,28 @@
> >  			};
> >  		};
> >  
> > +		gpu: gpu@38000000 {
> > +			compatible = "vivante,gc";
> > +			reg = <0x38000000 0x40000>;
> > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > +			clock-names = "core", "shader", "bus", "reg";
> > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > +			assigned-clock-rates = <800000000>, <800000000>,
> > +			                       <800000000>, <800000000>;
> > +			power-domains = <&pgc_gpu>;
> > +		};
> 
> Reviewed-by: Guido Günther <agx@sigxcpu.org>

On a second thought should this have a

    status = "disabled";

Cheers,
 -- Guido


> 
> Cheers,
>  -- Guido
> 
> 
> > +
> >  		usb_dwc3_0: usb@38100000 {
> >  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> >  			reg = <0x38100000 0x10000>;
> > -- 
> > 2.20.1
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
* RE: [PATCH] arm64: dts: imx8mq: add GPU node
  2019-04-04 16:52 ` Lucas Stach
@ 2019-04-09  1:54   ` Aisheng Dong
  -1 siblings, 0 replies; 14+ messages in thread
From: Aisheng Dong @ 2019-04-09  1:54 UTC (permalink / raw)
  To: Lucas Stach, Shawn Guo
  Cc: devicetree, patchwork-lst, dl-linux-imx, kernel, Fabio Estevam,
	linux-arm-kernel

Hi Lucas,

> From: Lucas Stach [mailto:l.stach@pengutronix.de]
> Sent: Friday, April 5, 2019 12:52 AM
> 
> This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Just curious, does the driver already supports MX8QM GC7000L now?
If yes, we probably could help test it.

Regards
Dong Aisheng
 
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22
> ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 4300781558f6..79d418b4f585 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -792,6 +792,28 @@
>  			};
>  		};
> 
> +		gpu: gpu@38000000 {
> +			compatible = "vivante,gc";
> +			reg = <0x38000000 0x40000>;
> +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> +			clock-names = "core", "shader", "bus", "reg";
> +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> +			assigned-clock-rates = <800000000>, <800000000>,
> +			                       <800000000>, <800000000>;
> +			power-domains = <&pgc_gpu>;
> +		};
> +
>  		usb_dwc3_0: usb@38100000 {
>  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
>  			reg = <0x38100000 0x10000>;
> --
> 2.20.1

^ permalink raw reply	[flat|nested] 14+ messages in thread
* RE: [PATCH] arm64: dts: imx8mq: add GPU node
@ 2019-04-09  1:54   ` Aisheng Dong
  0 siblings, 0 replies; 14+ messages in thread
From: Aisheng Dong @ 2019-04-09  1:54 UTC (permalink / raw)
  To: Lucas Stach, Shawn Guo
  Cc: devicetree, patchwork-lst, dl-linux-imx, kernel, Fabio Estevam,
	linux-arm-kernel

Hi Lucas,

> From: Lucas Stach [mailto:l.stach@pengutronix.de]
> Sent: Friday, April 5, 2019 12:52 AM
> 
> This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Just curious, does the driver already supports MX8QM GC7000L now?
If yes, we probably could help test it.

Regards
Dong Aisheng
 
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22
> ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 4300781558f6..79d418b4f585 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -792,6 +792,28 @@
>  			};
>  		};
> 
> +		gpu: gpu@38000000 {
> +			compatible = "vivante,gc";
> +			reg = <0x38000000 0x40000>;
> +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> +			clock-names = "core", "shader", "bus", "reg";
> +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> +			assigned-clock-rates = <800000000>, <800000000>,
> +			                       <800000000>, <800000000>;
> +			power-domains = <&pgc_gpu>;
> +		};
> +
>  		usb_dwc3_0: usb@38100000 {
>  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
>  			reg = <0x38100000 0x10000>;
> --
> 2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
  2019-04-09  1:54   ` Aisheng Dong
  (?)
@ 2019-04-10 10:59   ` Lucas Stach
  -1 siblings, 0 replies; 14+ messages in thread
From: Lucas Stach @ 2019-04-10 10:59 UTC (permalink / raw)
  To: Aisheng Dong, Shawn Guo
  Cc: devicetree, patchwork-lst, dl-linux-imx, kernel, Fabio Estevam,
	linux-arm-kernel

Am Dienstag, den 09.04.2019, 01:54 +0000 schrieb Aisheng Dong:
> Hi Lucas,
> 
> > > > From: Lucas Stach [mailto:l.stach@pengutronix.de]
> > Sent: Friday, April 5, 2019 12:52 AM
> > 
> > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> 
> Just curious, does the driver already supports MX8QM GC7000L now?
> If yes, we probably could help test it.

The etnaviv kernel driver supports the i.MX8MQ GC7000 GPU. MX8QM will
require an addition to the HW database.

There are still some additions needed to the UAPI, to enable proper
support for the texture descriptor feature, which I hope to get around
to send out during this week. As those don't have an influence on the
DT nodes and things are running well in my setup, I figured the DT
patches are ready to be merged.

Regards,
Lucas

> Regards
> Dong Aisheng
>  
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22
> > ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 4300781558f6..79d418b4f585 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -792,6 +792,28 @@
> > > >  			};
> > > >  		};
> > 
> > > > > > +		gpu: gpu@38000000 {
> > > > +			compatible = "vivante,gc";
> > > > +			reg = <0x38000000 0x40000>;
> > > > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > > > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > > > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > +			clock-names = "core", "shader", "bus", "reg";
> > > > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > > > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > > > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > > > +			assigned-clock-rates = <800000000>, <800000000>,
> > > > +			                       <800000000>, <800000000>;
> > > > +			power-domains = <&pgc_gpu>;
> > > > +		};
> > +
> > > > > >  		usb_dwc3_0: usb@38100000 {
> > > >  			compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > > >  			reg = <0x38100000 0x10000>;
> > --
> > 2.20.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
  2019-04-08 13:45     ` Guido Günther
  (?)
@ 2019-04-10 13:02     ` Lucas Stach
  2019-04-11 18:47         ` Guido Günther
  -1 siblings, 1 reply; 14+ messages in thread
From: Lucas Stach @ 2019-04-10 13:02 UTC (permalink / raw)
  To: Guido Günther
  Cc: devicetree, Shawn Guo, patchwork-lst, NXP Linux Team, kernel,
	Fabio Estevam, linux-arm-kernel

Hi Guido,

Am Montag, den 08.04.2019, 15:45 +0200 schrieb Guido Günther:
> Hi,
> On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido Günther wrote:
> > Hi Lucas,
> > On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> > > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > > 
> > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> > >  1 file changed, 22 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > index 4300781558f6..79d418b4f585 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > @@ -792,6 +792,28 @@
> > > > > >  			};
> > > > > >  		};
> > >  
> > > > > > > > > +		gpu: gpu@38000000 {
> > > > > > +			compatible = "vivante,gc";
> > > > > > +			reg = <0x38000000 0x40000>;
> > > > > > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > > > > > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > > > > > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > > > > > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > +			clock-names = "core", "shader", "bus", "reg";
> > > > > > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > > > > > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > > > > > +			assigned-clock-rates = <800000000>, <800000000>,
> > > > > > +			                       <800000000>, <800000000>;
> > > > > > +			power-domains = <&pgc_gpu>;
> > > +		};
> > 
> > Reviewed-by: Guido Günther <agx@sigxcpu.org>
> 
> On a second thought should this have a
> 
>     status = "disabled";

I disagree. This is a SoC internal peripheral, that has no board level
dependencies other than the voltage rail being connected, so it's fine
to have the node enabled on all systems. This is consistent with what
we did on all previous i.MX SoC DTs.

Regards,
Lucas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
  2019-04-04 16:52 ` Lucas Stach
@ 2019-04-11  6:50   ` Shawn Guo
  -1 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2019-04-11  6:50 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, patchwork-lst, NXP Linux Team, kernel, Fabio Estevam,
	linux-arm-kernel

On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Applied, thanks.

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
@ 2019-04-11  6:50   ` Shawn Guo
  0 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2019-04-11  6:50 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, patchwork-lst, NXP Linux Team, kernel, Fabio Estevam,
	linux-arm-kernel

On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
  2019-04-10 13:02     ` Lucas Stach
@ 2019-04-11 18:47         ` Guido Günther
  0 siblings, 0 replies; 14+ messages in thread
From: Guido Günther @ 2019-04-11 18:47 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, Shawn Guo, patchwork-lst, NXP Linux Team, kernel,
	Fabio Estevam, linux-arm-kernel

Hi,
On Wed, Apr 10, 2019 at 03:02:12PM +0200, Lucas Stach wrote:
> Hi Guido,
> 
> Am Montag, den 08.04.2019, 15:45 +0200 schrieb Guido Günther:
> > Hi,
> > On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido Günther wrote:
> > > Hi Lucas,
> > > On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> > > > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > > > 
> > > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> > > >  1 file changed, 22 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > > index 4300781558f6..79d418b4f585 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > > @@ -792,6 +792,28 @@
> > > > > > >  			};
> > > > > > >  		};
> > > >  
> > > > > > > > > > +		gpu: gpu@38000000 {
> > > > > > > +			compatible = "vivante,gc";
> > > > > > > +			reg = <0x38000000 0x40000>;
> > > > > > > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > > > > > > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > > > > > > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > > +			clock-names = "core", "shader", "bus", "reg";
> > > > > > > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > > > > > > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > > > > > > +			assigned-clock-rates = <800000000>, <800000000>,
> > > > > > > +			                       <800000000>, <800000000>;
> > > > > > > +			power-domains = <&pgc_gpu>;
> > > > +		};
> > > 
> > > Reviewed-by: Guido Günther <agx@sigxcpu.org>
> > 
> > On a second thought should this have a
> > 
> >     status = "disabled";
> 
> I disagree. This is a SoC internal peripheral, that has no board level
> dependencies other than the voltage rail being connected, so it's fine
> to have the node enabled on all systems. This is consistent with what
> we did on all previous i.MX SoC DTs.

Makes sense.

Reviewed-by: Guido Günther <agx@sigxcpu.org> 
Cheers,
 -- Guido

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: add GPU node
@ 2019-04-11 18:47         ` Guido Günther
  0 siblings, 0 replies; 14+ messages in thread
From: Guido Günther @ 2019-04-11 18:47 UTC (permalink / raw)
  To: Lucas Stach
  Cc: devicetree, Shawn Guo, patchwork-lst, NXP Linux Team, kernel,
	Fabio Estevam, linux-arm-kernel

Hi,
On Wed, Apr 10, 2019 at 03:02:12PM +0200, Lucas Stach wrote:
> Hi Guido,
> 
> Am Montag, den 08.04.2019, 15:45 +0200 schrieb Guido Günther:
> > Hi,
> > On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido Günther wrote:
> > > Hi Lucas,
> > > On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> > > > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > > > 
> > > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> > > >  1 file changed, 22 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > > index 4300781558f6..79d418b4f585 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > > @@ -792,6 +792,28 @@
> > > > > > >  			};
> > > > > > >  		};
> > > >  
> > > > > > > > > > +		gpu: gpu@38000000 {
> > > > > > > +			compatible = "vivante,gc";
> > > > > > > +			reg = <0x38000000 0x40000>;
> > > > > > > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > > > > > > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > > > > > > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > > +			clock-names = "core", "shader", "bus", "reg";
> > > > > > > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > > > > > > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > > > > > > +			assigned-clock-rates = <800000000>, <800000000>,
> > > > > > > +			                       <800000000>, <800000000>;
> > > > > > > +			power-domains = <&pgc_gpu>;
> > > > +		};
> > > 
> > > Reviewed-by: Guido Günther <agx@sigxcpu.org>
> > 
> > On a second thought should this have a
> > 
> >     status = "disabled";
> 
> I disagree. This is a SoC internal peripheral, that has no board level
> dependencies other than the voltage rail being connected, so it's fine
> to have the node enabled on all systems. This is consistent with what
> we did on all previous i.MX SoC DTs.

Makes sense.

Reviewed-by: Guido Günther <agx@sigxcpu.org> 
Cheers,
 -- Guido

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-04-11 18:47 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 16:52 [PATCH] arm64: dts: imx8mq: add GPU node Lucas Stach
2019-04-04 16:52 ` Lucas Stach
2019-04-08 13:07 ` Guido Günther
2019-04-08 13:07   ` Guido Günther
2019-04-08 13:45   ` Guido Günther
2019-04-08 13:45     ` Guido Günther
2019-04-10 13:02     ` Lucas Stach
2019-04-11 18:47       ` Guido Günther
2019-04-11 18:47         ` Guido Günther
2019-04-09  1:54 ` Aisheng Dong
2019-04-09  1:54   ` Aisheng Dong
2019-04-10 10:59   ` Lucas Stach
2019-04-11  6:50 ` Shawn Guo
2019-04-11  6:50   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.