[virtio-dev] [PATCH] content: reserve device ID for virtio-pmem devices

[virtio-dev] [PATCH] content: reserve device ID for virtio-pmem devices

[Pankaj Gupta]

We need a device ID for virtio-pmem devices. As 25 is  
requested by audio device, so requesting next available(26).
Also, updated the previously requested github issue[1] for
voting.

[1] https://github.com/oasis-tcs/virtio-spec/issues/38

Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
 content.tex | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/content.tex b/content.tex
index 193b6e1..aef7476 100644
--- a/content.tex
+++ b/content.tex
@@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
 \hline
 24         &   Memory device \\
 \hline
+26         &   PMEM device \\
+\hline
 \end{tabular}
 
 Some of the devices above are unspecified by this document,
-- 
2.14.5


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH] content: reserve device ID for virtio-pmem devices

[Cornelia Huck]

On Fri, 12 Apr 2019 10:33:06 +0530
Pankaj Gupta <pagupta@redhat.com> wrote:

> We need a device ID for virtio-pmem devices. As 25 is  
> requested by audio device, so requesting next available(26).
> Also, updated the previously requested github issue[1] for
> voting.
> 
> [1] https://github.com/oasis-tcs/virtio-spec/issues/38
> 
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
>  content.tex | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/content.tex b/content.tex
> index 193b6e1..aef7476 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -2634,6 +2634,8 @@ \chapter{Device Types}\label{sec:Device Types}
>  \hline
>  24         &   Memory device \\
>  \hline
> +26         &   PMEM device \\
> +\hline
>  \end{tabular}
>  
>  Some of the devices above are unspecified by this document,

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH] content: reserve device ID for virtio-pmem devices

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

On Fri, Apr 12, 2019 at 10:33:06AM +0530, Pankaj Gupta wrote:
> We need a device ID for virtio-pmem devices. As 25 is  
> requested by audio device, so requesting next available(26).
> Also, updated the previously requested github issue[1] for
> voting.
> 
> [1] https://github.com/oasis-tcs/virtio-spec/issues/38
> 
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
>  content.tex | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [virtio-dev] Re: [PATCH] content: reserve device ID for virtio-pmem devices

[Pankaj Gupta]

Hi Stefan,

Thank you for the review. 

After sending this patch I realized device ID 26 is already requested
by virtio-fs. So, I sent a v2[1] with a request to reserve id 27.
Could you please review this.

[1]
[PATCH v2] content: reserve device ID for virtio-pmem devices


Thanks,
Pankaj 

> 
> On Fri, Apr 12, 2019 at 10:33:06AM +0530, Pankaj Gupta wrote:
> > We need a device ID for virtio-pmem devices. As 25 is
> > requested by audio device, so requesting next available(26).
> > Also, updated the previously requested github issue[1] for
> > voting.
> > 
> > [1] https://github.com/oasis-tcs/virtio-spec/issues/38
> > 
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> > ---
> >  content.tex | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org