* [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Test if pixel format supports rotation
@ 2019-04-12 11:07 Mika Kahola
2019-04-12 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mika Kahola @ 2019-04-12 11:07 UTC (permalink / raw)
To: igt-dev
Before actually do the commit with plane rotation, test if the pixel format
supports requested rotation. Kernel replies with -EINVAL when requested to do
rotation with the pixel format that is not supported. The patch uses this fact
to filter out unsupported pixel formats.
References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_plane_scaling.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index e843bf86..57092263 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -138,6 +138,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
igt_display_t *display = &d->display;
int width, height;
drmModeModeInfo *mode;
+ int errno;
cleanup_crtc(d);
@@ -158,7 +159,15 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
igt_plane_set_position(plane, 0, 0);
igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
igt_plane_set_rotation(plane, rot);
- igt_display_commit2(display, COMMIT_ATOMIC);
+
+ /*
+ * Test first, if pixel format supports rotation.
+ * We expect from kernel to return with -EINVAL
+ * if format is not supported.
+ */
+ errno = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
+ if (errno != -EINVAL)
+ igt_display_commit2(display, COMMIT_ATOMIC);
igt_plane_set_fb(plane, NULL);
igt_plane_set_position(plane, 0, 0);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Test if pixel format supports rotation
2019-04-12 11:07 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Test if pixel format supports rotation Mika Kahola
@ 2019-04-12 13:57 ` Patchwork
2019-04-12 14:54 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
2019-04-12 16:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-04-12 13:57 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane_scaling: Test if pixel format supports rotation
URL : https://patchwork.freedesktop.org/series/59391/
State : success
== Summary ==
CI Bug Log - changes from IGT_4945 -> IGTPW_2852
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59391/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2852 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_store@basic-bsd1:
- fi-kbl-r: NOTRUN -> SKIP [fdo#109271] +41
* igt@i915_module_load@reload:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
- fi-skl-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
* igt@kms_chamelium@dp-hpd-fast:
- fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +41
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] +1
#### Possible fixes ####
* igt@gem_ctx_switch@basic-default:
- {fi-icl-u2}: INCOMPLETE [fdo#108569] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (48 -> 42)
------------------------------
Additional (2): fi-skl-6700k2 fi-kbl-r
Missing (8): fi-kbl-soraka fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-hsw-4770 fi-gdg-551 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4945 -> IGTPW_2852
CI_DRM_5922: 849ac6dbff7f5073c3181c5eba07936fe3f576ec @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2852: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2852/
IGT_4945: a52cc643cfe6733465cfc9ccb3d21cbdc4fd7506 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2852/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Test if pixel format supports rotation
2019-04-12 11:07 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Test if pixel format supports rotation Mika Kahola
2019-04-12 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-12 14:54 ` Souza, Jose
2019-04-15 8:13 ` Kahola, Mika
2019-04-12 16:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Souza, Jose @ 2019-04-12 14:54 UTC (permalink / raw)
To: igt-dev, Kahola, Mika
[-- Attachment #1.1: Type: text/plain, Size: 2217 bytes --]
On Fri, 2019-04-12 at 14:07 +0300, Mika Kahola wrote:
> Before actually do the commit with plane rotation, test if the pixel
> format
> supports requested rotation. Kernel replies with -EINVAL when
> requested to do
> rotation with the pixel format that is not supported. The patch uses
> this fact
> to filter out unsupported pixel formats.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_plane_scaling.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index e843bf86..57092263 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -138,6 +138,7 @@ static void check_scaling_pipe_plane_rot(data_t
> *d, igt_plane_t *plane,
> igt_display_t *display = &d->display;
> int width, height;
> drmModeModeInfo *mode;
> + int errno;
>
> cleanup_crtc(d);
>
> @@ -158,7 +159,15 @@ static void check_scaling_pipe_plane_rot(data_t
> *d, igt_plane_t *plane,
> igt_plane_set_position(plane, 0, 0);
> igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> igt_plane_set_rotation(plane, rot);
> - igt_display_commit2(display, COMMIT_ATOMIC);
> +
> + /*
> + * Test first, if pixel format supports rotation.
> + * We expect from kernel to return with -EINVAL
> + * if format is not supported.
> + */
> + errno = igt_display_try_commit_atomic(display,
> DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> + if (errno != -EINVAL)
> + igt_display_commit2(display, COMMIT_ATOMIC);
This is going to cause the test to always pass, becoming useless.
It is already filtering out the know format and rotation combination
that should not work in the caller, if a combination is not covered it
should be added to those:
if (igt_fb_supported_format(format) && igt_plane_has_format_mod(plane,
format, tiling) && can_rotate(d, format))
check_scaling_pipe_plane_rot(d, plane, format, tiling, pipe,
output, rot);
>
> igt_plane_set_fb(plane, NULL);
> igt_plane_set_position(plane, 0, 0);
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: Test if pixel format supports rotation
2019-04-12 11:07 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Test if pixel format supports rotation Mika Kahola
2019-04-12 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-12 14:54 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
@ 2019-04-12 16:21 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-04-12 16:21 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: tests/kms_plane_scaling: Test if pixel format supports rotation
URL : https://patchwork.freedesktop.org/series/59391/
State : success
== Summary ==
CI Bug Log - changes from IGT_4945_full -> IGTPW_2852_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59391/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2852_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> SKIP [fdo#109313]
* igt@gem_pwrite@stolen-snoop:
- shard-iclb: NOTRUN -> SKIP [fdo#109277]
* igt@gem_userptr_blits@coherency-unsync:
- shard-iclb: NOTRUN -> SKIP [fdo#109290]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> SKIP [fdo#109506]
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] / [fdo#107807]
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: PASS -> FAIL [fdo#109660]
* igt@kms_busy@basic-flip-e:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_busy@extended-pageflip-hang-newfb-render-e:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +8
* igt@kms_busy@extended-pageflip-hang-oldfb-render-d:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +7
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +1
* igt@kms_color@pipe-a-degamma:
- shard-iclb: NOTRUN -> FAIL [fdo#104782]
* igt@kms_crtc_background_color:
- shard-iclb: NOTRUN -> SKIP [fdo#109305]
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-512x512-onscreen:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]
* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +2
* igt@kms_flip@2x-busy-flip:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +9
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_force_connector_basic@force-edid:
- shard-iclb: NOTRUN -> SKIP [fdo#109285] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-iclb: PASS -> FAIL [fdo#103167] +5
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +74
* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-apl: PASS -> DMESG-WARN [fdo#110376] +1
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> FAIL [fdo#109247]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#109247] +15
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +18
* igt@kms_frontbuffer_tracking@psr-slowdraw:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +107
* igt@kms_invalid_dotclock:
- shard-iclb: NOTRUN -> SKIP [fdo#109310]
* igt@kms_lease@cursor_implicit_plane:
- shard-iclb: NOTRUN -> FAIL [fdo#110278]
* igt@kms_lease@setcrtc_implicit_plane:
- shard-apl: NOTRUN -> FAIL [fdo#110281]
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-glk: PASS -> SKIP [fdo#109271]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +2
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +2
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr@primary_mmap_cpu:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +3
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: NOTRUN -> SKIP [fdo#109441]
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_sysfs_edid_timing:
- shard-iclb: NOTRUN -> FAIL [fdo#100047]
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +14
* igt@prime_nv_test@nv_write_i915_gtt_mmap_read:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +4
- shard-iclb: NOTRUN -> SKIP [fdo#109291]
* igt@tools_test@sysfs_l3_parity:
- shard-iclb: NOTRUN -> SKIP [fdo#109307]
* igt@v3d_mmap@mmap-bad-handle:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: FAIL [fdo#108686] -> PASS
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-iclb: INCOMPLETE [fdo#107713] / [fdo#108840] -> PASS
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +4
* igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge:
- shard-snb: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-snb: SKIP [fdo#109271] -> PASS +2
* igt@kms_fbcon_fbt@fbc:
- shard-iclb: DMESG-WARN [fdo#109593] -> PASS
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +3
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-glk: FAIL [fdo#103167] -> PASS
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- shard-iclb: FAIL [fdo#109247] -> PASS +15
* igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-iclb: FAIL [fdo#109052] -> PASS +2
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: SKIP [fdo#109642] -> PASS
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: SKIP [fdo#109441] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: DMESG-WARN [fdo#108566] -> PASS
* igt@perf_pmu@rc6:
- shard-kbl: SKIP [fdo#109271] -> PASS
* igt@testdisplay:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
- shard-apl: INCOMPLETE [fdo#103927] -> PASS +1
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109305]: https://bugs.freedesktop.org/show_bug.cgi?id=109305
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109310]: https://bugs.freedesktop.org/show_bug.cgi?id=109310
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110376]: https://bugs.freedesktop.org/show_bug.cgi?id=110376
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 6)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4945 -> IGTPW_2852
CI_DRM_5922: 849ac6dbff7f5073c3181c5eba07936fe3f576ec @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2852: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2852/
IGT_4945: a52cc643cfe6733465cfc9ccb3d21cbdc4fd7506 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2852/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Test if pixel format supports rotation
2019-04-12 14:54 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
@ 2019-04-15 8:13 ` Kahola, Mika
0 siblings, 0 replies; 5+ messages in thread
From: Kahola, Mika @ 2019-04-15 8:13 UTC (permalink / raw)
To: igt-dev, Souza, Jose
On Fri, 2019-04-12 at 07:54 -0700, Souza, Jose wrote:
> On Fri, 2019-04-12 at 14:07 +0300, Mika Kahola wrote:
> > Before actually do the commit with plane rotation, test if the
> > pixel
> > format
> > supports requested rotation. Kernel replies with -EINVAL when
> > requested to do
> > rotation with the pixel format that is not supported. The patch
> > uses
> > this fact
> > to filter out unsupported pixel formats.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > tests/kms_plane_scaling.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index e843bf86..57092263 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -138,6 +138,7 @@ static void check_scaling_pipe_plane_rot(data_t
> > *d, igt_plane_t *plane,
> > igt_display_t *display = &d->display;
> > int width, height;
> > drmModeModeInfo *mode;
> > + int errno;
> >
> > cleanup_crtc(d);
> >
> > @@ -158,7 +159,15 @@ static void
> > check_scaling_pipe_plane_rot(data_t
> > *d, igt_plane_t *plane,
> > igt_plane_set_position(plane, 0, 0);
> > igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> > igt_plane_set_rotation(plane, rot);
> > - igt_display_commit2(display, COMMIT_ATOMIC);
> > +
> > + /*
> > + * Test first, if pixel format supports rotation.
> > + * We expect from kernel to return with -EINVAL
> > + * if format is not supported.
> > + */
> > + errno = igt_display_try_commit_atomic(display,
> > DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> > + if (errno != -EINVAL)
> > + igt_display_commit2(display, COMMIT_ATOMIC);
>
> This is going to cause the test to always pass, becoming useless.
DRM_MODE_ATOMIC_TEST_ONLY is only used to filter out unsupported pixel
formats. On various checks the scaling can still fail with -ERANGE.
This is still tested with actual commit.
> It is already filtering out the know format and rotation combination
> that should not work in the caller, if a combination is not covered
> it
> should be added to those:
>
> if (igt_fb_supported_format(format) &&
> igt_plane_has_format_mod(plane,
> format, tiling) && can_rotate(d, format))
> check_scaling_pipe_plane_rot(d, plane, format, tiling, pipe,
> output, rot);
We have merged these patches that add igt_plane_has_format_mod() check.
Unfortunately, this wasn't able to filter out formats that doesn't
support rotation. That's why we need find another solution.
Cheers,
Mika
>
>
> >
> > igt_plane_set_fb(plane, NULL);
> > igt_plane_set_position(plane, 0, 0);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-15 8:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 11:07 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Test if pixel format supports rotation Mika Kahola
2019-04-12 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-12 14:54 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
2019-04-15 8:13 ` Kahola, Mika
2019-04-12 16:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.