All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
	alex.williamson@redhat.com, aik@ozlabs.ru
Subject: Re: [Qemu-devel] [PATCH for-4.1] vfio/common: Introduce vfio_set_irq_signaling helper
Date: Fri, 12 Apr 2019 13:31:11 +0200	[thread overview]
Message-ID: <20190412133111.028a9c6d.cohuck@redhat.com> (raw)
In-Reply-To: <20190409155831.18764-1-eric.auger@redhat.com>

On Tue,  9 Apr 2019 17:58:31 +0200
Eric Auger <eric.auger@redhat.com> wrote:

> The code used to assign an interrupt index/subindex to an
> eventfd is duplicated many times. Let's introduce an helper that
> allows to set/unset the signaling for an ACTION_TRIGGER or
> ACTION_UNMASK action.

I like that, and it looks like ccw can use the new function as well. (I
can do a patch on top.)

> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> 
> ---
> 
> This is a follow-up to
> [PATCH v2 0/2] vfio-pci: Introduce vfio_set_event_handler().
> It looks to me that introducing vfio_set_irq_signaling() has more
> benefits in term of code reduction and the helper abstraction
> looks cleaner.
> ---
>  hw/vfio/common.c              |  61 +++++++++
>  hw/vfio/pci.c                 | 224 ++++++++--------------------------
>  hw/vfio/platform.c            |  55 +++------
>  include/hw/vfio/vfio-common.h |   2 +
>  4 files changed, 134 insertions(+), 208 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qemu-devel@nongnu.org,
	eric.auger.pro@gmail.com
Subject: Re: [Qemu-devel] [PATCH for-4.1] vfio/common: Introduce vfio_set_irq_signaling helper
Date: Fri, 12 Apr 2019 13:31:11 +0200	[thread overview]
Message-ID: <20190412133111.028a9c6d.cohuck@redhat.com> (raw)
Message-ID: <20190412113111.bjk5WA218QrIQu7mr1XAPs3aRrlXHlmwdgu0NY6QHXI@z> (raw)
In-Reply-To: <20190409155831.18764-1-eric.auger@redhat.com>

On Tue,  9 Apr 2019 17:58:31 +0200
Eric Auger <eric.auger@redhat.com> wrote:

> The code used to assign an interrupt index/subindex to an
> eventfd is duplicated many times. Let's introduce an helper that
> allows to set/unset the signaling for an ACTION_TRIGGER or
> ACTION_UNMASK action.

I like that, and it looks like ccw can use the new function as well. (I
can do a patch on top.)

> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> 
> ---
> 
> This is a follow-up to
> [PATCH v2 0/2] vfio-pci: Introduce vfio_set_event_handler().
> It looks to me that introducing vfio_set_irq_signaling() has more
> benefits in term of code reduction and the helper abstraction
> looks cleaner.
> ---
>  hw/vfio/common.c              |  61 +++++++++
>  hw/vfio/pci.c                 | 224 ++++++++--------------------------
>  hw/vfio/platform.c            |  55 +++------
>  include/hw/vfio/vfio-common.h |   2 +
>  4 files changed, 134 insertions(+), 208 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


  reply	other threads:[~2019-04-12 11:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 15:58 [Qemu-devel] [PATCH for-4.1] vfio/common: Introduce vfio_set_irq_signaling helper Eric Auger
2019-04-12 11:31 ` Cornelia Huck [this message]
2019-04-12 11:31   ` Cornelia Huck
2019-04-23 15:11   ` Auger Eric
2019-05-15 22:52 ` Alex Williamson
2019-05-20 14:17   ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412133111.028a9c6d.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.