All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: shrink PHY settings array and add 200Gbps support
Date: Sat, 13 Apr 2019 19:07:30 +0200	[thread overview]
Message-ID: <20190413170730.GL17901@lunn.ch> (raw)
In-Reply-To: <2ef3d8a7-3cff-cea6-646a-4b2ed0834398@gmail.com>

On Sat, Apr 13, 2019 at 06:51:16PM +0200, Heiner Kallweit wrote:
> The definition of array settings[] is quite lengthy meanwhile. Add a
> macro to shrink the definition.
> 
> When doing this I saw that the new 200Gbps modes aren't supported
> in phylib yet. So add this. I think we need to document somewhere
> which places in phylib need to be touched if a new speed / mode is
> added.

Yes, maybe something like

BUILD_BUG_ON(__ETHTOOL_LINK_MODE_MASK_NBITS != 67);

in drivers/net/phy/phy-core.c with a comment explaining what should be
done?

	Andrew

  parent reply	other threads:[~2019-04-13 17:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-13 16:51 [PATCH net-next 0/2] net: phy: shrink PHY settings array and add 200Gbps support Heiner Kallweit
2019-04-13 16:52 ` [PATCH net-next 1/2] net: phy: shrink PHY settings array Heiner Kallweit
2019-04-13 17:14   ` Andrew Lunn
2019-04-13 17:28     ` Heiner Kallweit
2019-04-13 16:53 ` [PATCH net-next 2/2] net: phy: add 200Gbps support to phylib Heiner Kallweit
2019-04-13 17:14   ` Andrew Lunn
2019-04-13 17:07 ` Andrew Lunn [this message]
2019-04-13 17:26   ` [PATCH net-next 0/2] net: phy: shrink PHY settings array and add 200Gbps support Heiner Kallweit
2019-04-14 20:29 ` David Miller
2019-04-14 20:30   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190413170730.GL17901@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.