All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: shrink PHY settings array
Date: Sat, 13 Apr 2019 19:28:43 +0200	[thread overview]
Message-ID: <3701cb5f-a618-eb1e-34b8-93b58beae985@gmail.com> (raw)
In-Reply-To: <20190413171420.GM17901@lunn.ch>

On 13.04.2019 19:14, Andrew Lunn wrote:
>> +	PHY_SETTING( 100000, FULL, 100000baseCR4_Full		),
>> +	PHY_SETTING( 100000, FULL, 100000baseKR4_Full		),
>> +	PHY_SETTING( 100000, FULL, 100000baseLR4_ER4_Full	),
>> +	PHY_SETTING( 100000, FULL, 100000baseSR4_Full		),
>> +	PHY_SETTING(  56000, FULL,  56000baseCR4_Full	  	),
>> +	PHY_SETTING(  56000, FULL,  56000baseKR4_Full	  	),
>> +	PHY_SETTING(  56000, FULL,  56000baseLR4_Full	  	),
>> +	PHY_SETTING(  56000, FULL,  56000baseSR4_Full	  	),
>> +	PHY_SETTING(  50000, FULL,  50000baseCR2_Full		),
>> +	PHY_SETTING(  50000, FULL,  50000baseKR2_Full		),
>> +	PHY_SETTING(  50000, FULL,  50000baseSR2_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseCR4_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseKR4_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseLR4_Full		),
>> +	PHY_SETTING(  40000, FULL,  40000baseSR4_Full		),
>> +	PHY_SETTING(  20000, FULL,  20000baseKR2_Full		),
>> +	PHY_SETTING(  20000, FULL,  20000baseMLD2_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseCR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseER_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseKR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseKX4_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseLR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseLRM_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseR_FEC		),
>> +	PHY_SETTING(  10000, FULL,  10000baseSR_Full		),
>> +	PHY_SETTING(  10000, FULL,  10000baseT_Full		),
>> +	PHY_SETTING(   2500, FULL,  2500baseT_Full		),
>> +	PHY_SETTING(   2500, FULL,  2500baseX_Full		),
>> +	PHY_SETTING(   1000, FULL,  1000baseKX_Full		),
>> +	PHY_SETTING(   1000, FULL,  1000baseT_Full		),
>> +	PHY_SETTING(   1000, HALF,  1000baseT_Half		),
>> +	PHY_SETTING(   1000, FULL,  1000baseX_Full		),
>> +	PHY_SETTING(    100, FULL,   100baseT_Full		),
>> +	PHY_SETTING(    100, HALF,   100baseT_Half		),
>> +	PHY_SETTING(     10, FULL,    10baseT_Full		),
>> +	PHY_SETTING(     10, HALF,    10baseT_Half		),
> 
> I like the spaces here for the speed. I know i've missed counted the
> number of 0 and put entries in the wrong place. Maybe 2500base* and
> later could be indented by one more space, so that 'base' is always in
> the same column?
> 
Indeed, one space is missing for the modes <= 2500.

>     Andrew
> 
Heiner

  reply	other threads:[~2019-04-13 17:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-13 16:51 [PATCH net-next 0/2] net: phy: shrink PHY settings array and add 200Gbps support Heiner Kallweit
2019-04-13 16:52 ` [PATCH net-next 1/2] net: phy: shrink PHY settings array Heiner Kallweit
2019-04-13 17:14   ` Andrew Lunn
2019-04-13 17:28     ` Heiner Kallweit [this message]
2019-04-13 16:53 ` [PATCH net-next 2/2] net: phy: add 200Gbps support to phylib Heiner Kallweit
2019-04-13 17:14   ` Andrew Lunn
2019-04-13 17:07 ` [PATCH net-next 0/2] net: phy: shrink PHY settings array and add 200Gbps support Andrew Lunn
2019-04-13 17:26   ` Heiner Kallweit
2019-04-14 20:29 ` David Miller
2019-04-14 20:30   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3701cb5f-a618-eb1e-34b8-93b58beae985@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.