All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, liam.r.girdwood@linux.intel.com,
	jank@cadence.com, joe@perches.com,
	srinivas.kandagatla@linaro.org,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [alsa-devel] [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue
Date: Sun, 14 Apr 2019 15:50:07 +0530	[thread overview]
Message-ID: <20190414102007.GK28103@vkoul-mobl> (raw)
In-Reply-To: <s5hv9zjl2ya.wl-tiwai@suse.de>

On 12-04-19, 16:21, Takashi Iwai wrote:
> On Fri, 12 Apr 2019 16:18:41 +0200,
> Mark Brown wrote:
> > 
> > On Fri, Apr 12, 2019 at 09:07:41AM -0500, Pierre-Louis Bossart wrote:
> > 
> > >  config CODEC_XYX_SDW
> > > 	 tristate "XYZ SDW Codec"
> > >          depends on SOUNDWIRE
> > >          select REGMAP_SOUNDWIRE
> > 
> > That looks good.
> > 
> > >  config REGMAP_SOUNDWIRE
> > >          select SOUNDWIRE_BUS
> > 
> > > it'd follow the typical pattern seen in sound/soc/codecs/Kconfig:
> > 
> > IIRC the select here won't actually do anything.
> 
> I thought it'd do select SOUNDWIRE_BUS.  The depends-on here would be
> ignored instead.

yeah this all is bit complicated and should not be so. As Srini pointed
out, we have two symbols, SOUNDWIRE as a menuconfig item which enables
the subsystem and then SOUNDWIRE_BUS which compiles in the code.

Unfortunately I dont seem to recall the advantages of this approach so
it might be easier to drop SOUNDWIRE_BUS and then let codecs do select
REGMAP_SOUNDWIRE and depends on SOUNDWIRE

Thanks
-- 
~Vinod

  reply	other threads:[~2019-04-14 10:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 19:28 [PATCH 0/2] soundwire: fix Kconfig select/depend issues Pierre-Louis Bossart
2019-04-11 19:28 ` [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue Pierre-Louis Bossart
2019-04-12  8:38   ` Takashi Iwai
2019-04-12  8:46     ` Mark Brown
2019-04-12 14:07     ` [alsa-devel] " Pierre-Louis Bossart
2019-04-12 14:18       ` Mark Brown
2019-04-12 14:21         ` Takashi Iwai
2019-04-14 10:20           ` Vinod Koul [this message]
2019-04-11 19:28 ` [PATCH 2/2] soundwire: fix SOUNDWIRE_BUS option Pierre-Louis Bossart
2019-04-12 10:06 ` [PATCH 0/2] soundwire: fix Kconfig select/depend issues Srinivas Kandagatla
2019-04-12 14:17   ` [alsa-devel] " Pierre-Louis Bossart
2019-04-12 14:27     ` Mark Brown
2019-04-12 14:56       ` Pierre-Louis Bossart
2019-04-14 10:13 ` Vinod Koul
2019-04-15 12:50   ` [alsa-devel] " Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190414102007.GK28103@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=joe@perches.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rafael@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.