All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	broonie@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org,
	liam.r.girdwood@linux.intel.com, jank@cadence.com,
	joe@perches.com, srinivas.kandagatla@linaro.org,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [alsa-devel] [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue
Date: Fri, 12 Apr 2019 09:07:41 -0500	[thread overview]
Message-ID: <bd9a5c75-8519-b6ac-ca16-7fa93c706ead@linux.intel.com> (raw)
In-Reply-To: <s5ho95bpqis.wl-tiwai@suse.de>

Thanks for the reviews

>> The mechanism should be
>>
>> config CODEC_XYX_SDW
>>         depends on SOUNDWIRE
>>         select REGMAP_SOUNDWIRE
>>
>> config REGMAP_SOUNDWIRE
>>         depends on SOUNDWIRE
>>         select SOUNDWIRE_BUS
> 
> To be noted, in general you can't do put both depends-on and select.
> The select always wins.  So the depends-on in REGMAP_SOUNDWIRE is more
> or less moot.


ok. To double-check, the example below would be legit, yes?

  config CODEC_XYX_SDW
	 tristate "XYZ SDW Codec"
          depends on SOUNDWIRE
          select REGMAP_SOUNDWIRE

  config REGMAP_SOUNDWIRE
          select SOUNDWIRE_BUS

it'd follow the typical pattern seen in sound/soc/codecs/Kconfig:

config SND_SOC_CS4265
	tristate "Cirrus Logic CS4265 CODEC"
	depends on I2C
	select REGMAP_I2C

Thanks
-Pierre

  parent reply	other threads:[~2019-04-12 14:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 19:28 [PATCH 0/2] soundwire: fix Kconfig select/depend issues Pierre-Louis Bossart
2019-04-11 19:28 ` [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue Pierre-Louis Bossart
2019-04-12  8:38   ` Takashi Iwai
2019-04-12  8:46     ` Mark Brown
2019-04-12 14:07     ` Pierre-Louis Bossart [this message]
2019-04-12 14:18       ` [alsa-devel] " Mark Brown
2019-04-12 14:21         ` Takashi Iwai
2019-04-14 10:20           ` Vinod Koul
2019-04-11 19:28 ` [PATCH 2/2] soundwire: fix SOUNDWIRE_BUS option Pierre-Louis Bossart
2019-04-12 10:06 ` [PATCH 0/2] soundwire: fix Kconfig select/depend issues Srinivas Kandagatla
2019-04-12 14:17   ` [alsa-devel] " Pierre-Louis Bossart
2019-04-12 14:27     ` Mark Brown
2019-04-12 14:56       ` Pierre-Louis Bossart
2019-04-14 10:13 ` Vinod Koul
2019-04-15 12:50   ` [alsa-devel] " Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd9a5c75-8519-b6ac-ca16-7fa93c706ead@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=joe@perches.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.