All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: bugfix tqma7 soft reset issue
@ 2019-04-14 12:06 ` Bruno Thomsen
  0 siblings, 0 replies; 9+ messages in thread
From: Bruno Thomsen @ 2019-04-14 12:06 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: devicetree, laa, festevam, s.hauer, clemens.ml, Bruno Thomsen,
	ksc, robh+dt, linux-imx, kernel, shawnguo, Markus Niebel

Running reboot command on the TQMa7 board would just hang infinite
at the end of the system shutdown process.

Handling of i.MX7 errata e10574:
Watchdog: A watchdog timeout or software trigger will not reset the SOC.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
Reviewed-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
 arch/arm/boot/dts/imx7-tqma7.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
index 85fe461e5e67..896eff839d5e 100644
--- a/arch/arm/boot/dts/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
@@ -228,5 +228,12 @@
 };
 
 &wdog1 {
+	/*
+	 * Errata e10574:
+	 * WDOG reset needs to run with WDOG_RESET_B signal enabled.
+	 * X1-51 (WDOG1#) signal needs carrier board handling to reset
+	 * TQMa7 on X1-22 (RESET_IN#).
+	 */
+	fsl,ext-reset-output;
 	status = "okay";
 };
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: bugfix tqma7 soft reset issue
@ 2019-04-14 12:06 ` Bruno Thomsen
  0 siblings, 0 replies; 9+ messages in thread
From: Bruno Thomsen @ 2019-04-14 12:06 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: devicetree, laa, festevam, s.hauer, clemens.ml, Bruno Thomsen,
	ksc, robh+dt, linux-imx, kernel, shawnguo, Markus Niebel

Running reboot command on the TQMa7 board would just hang infinite
at the end of the system shutdown process.

Handling of i.MX7 errata e10574:
Watchdog: A watchdog timeout or software trigger will not reset the SOC.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
Reviewed-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
 arch/arm/boot/dts/imx7-tqma7.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
index 85fe461e5e67..896eff839d5e 100644
--- a/arch/arm/boot/dts/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
@@ -228,5 +228,12 @@
 };
 
 &wdog1 {
+	/*
+	 * Errata e10574:
+	 * WDOG reset needs to run with WDOG_RESET_B signal enabled.
+	 * X1-51 (WDOG1#) signal needs carrier board handling to reset
+	 * TQMa7 on X1-22 (RESET_IN#).
+	 */
+	fsl,ext-reset-output;
 	status = "okay";
 };
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: bugfix tqma7 soft reset issue
  2019-04-14 12:06 ` Bruno Thomsen
@ 2019-04-14 15:32   ` Fabio Estevam
  -1 siblings, 0 replies; 9+ messages in thread
From: Fabio Estevam @ 2019-04-14 15:32 UTC (permalink / raw)
  To: Bruno Thomsen
  Cc: Markus Niebel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, laa,
	Sascha Hauer, clemens.ml, ksc, Rob Herring, NXP Linux Team,
	Sascha Hauer, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Bruno,

On Sun, Apr 14, 2019 at 9:06 AM Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

>  &wdog1 {
> +       /*
> +        * Errata e10574:
> +        * WDOG reset needs to run with WDOG_RESET_B signal enabled.
> +        * X1-51 (WDOG1#) signal needs carrier board handling to reset
> +        * TQMa7 on X1-22 (RESET_IN#).
> +        */
> +       fsl,ext-reset-output;
>         status = "okay";

You should also add a pinctrl entry for the watchdog pin.

Please check arch/arm/boot/dts/imx7s-warp.dts for an example.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: bugfix tqma7 soft reset issue
@ 2019-04-14 15:32   ` Fabio Estevam
  0 siblings, 0 replies; 9+ messages in thread
From: Fabio Estevam @ 2019-04-14 15:32 UTC (permalink / raw)
  To: Bruno Thomsen
  Cc: Markus Niebel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, laa,
	Sascha Hauer, clemens.ml, ksc, Rob Herring, NXP Linux Team,
	Sascha Hauer, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Bruno,

On Sun, Apr 14, 2019 at 9:06 AM Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

>  &wdog1 {
> +       /*
> +        * Errata e10574:
> +        * WDOG reset needs to run with WDOG_RESET_B signal enabled.
> +        * X1-51 (WDOG1#) signal needs carrier board handling to reset
> +        * TQMa7 on X1-22 (RESET_IN#).
> +        */
> +       fsl,ext-reset-output;
>         status = "okay";

You should also add a pinctrl entry for the watchdog pin.

Please check arch/arm/boot/dts/imx7s-warp.dts for an example.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: bugfix tqma7 soft reset issue
  2019-04-14 15:32   ` Fabio Estevam
  (?)
@ 2019-04-14 16:10   ` Bruno Thomsen
  -1 siblings, 0 replies; 9+ messages in thread
From: Bruno Thomsen @ 2019-04-14 16:10 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Markus Niebel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Lars Alex Pedersen, Sascha Hauer, Clemens Koller, ksc,
	Rob Herring, NXP Linux Team, Sascha Hauer, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Fabio,

Den søn. 14. apr. 2019 kl. 17.32 skrev Fabio Estevam <festevam@gmail.com>:

> >  &wdog1 {
> > +       /*
> > +        * Errata e10574:
> > +        * WDOG reset needs to run with WDOG_RESET_B signal enabled.
> > +        * X1-51 (WDOG1#) signal needs carrier board handling to reset
> > +        * TQMa7 on X1-22 (RESET_IN#).
> > +        */
> > +       fsl,ext-reset-output;
> >         status = "okay";
>
> You should also add a pinctrl entry for the watchdog pin.

There is a pinctrl entry for the watchdog pin in imx7-mba7.dtsi file
almost identically to imx7s-warp.dts. There are technical 2 pins you can
use for the output, and this dtsi will be used for other product device
trees as well. Where the imx7-mba7.dtsi will only be used for the
development board.
I agree with you that the readability of this dtsi will improve,
and the next device tree I want to mainline also use this pin configuration.

 Bruno

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH v2] ARM: dts: bugfix tqma7 soft reset issue
  2019-04-14 12:06 ` Bruno Thomsen
@ 2019-04-16  9:08   ` Bruno Thomsen
  -1 siblings, 0 replies; 9+ messages in thread
From: Bruno Thomsen @ 2019-04-16  9:08 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: devicetree, laa, festevam, s.hauer, clemens.ml, bruno.thomsen,
	ksc, robh+dt, linux-imx, kernel, shawnguo, markus.niebel

Running reboot command on the TQMa7 board would just hang infinite
at the end of the system shutdown process.

Handling of i.MX7 errata e10574:
Watchdog: A watchdog timeout or software trigger will not reset the SOC.

Moved pinctrl from common mba7 to common tqma7 dtsi as it improves
readability of errata handling. Most integrators of this SoM will
likely use the development board as inspiration for handling this
SoC issue.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
v2:
Moved pinctrl from common development board to common SoM.
Removed Markus reviewed-by as he only acked the fsl,ext-reset-output part.

 arch/arm/boot/dts/imx7-mba7.dtsi  | 11 -----------
 arch/arm/boot/dts/imx7-tqma7.dtsi | 17 +++++++++++++++++
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi
index 578341b6848b..50abf18ad30b 100644
--- a/arch/arm/boot/dts/imx7-mba7.dtsi
+++ b/arch/arm/boot/dts/imx7-mba7.dtsi
@@ -472,12 +472,6 @@
 			MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5	0x59
 		>;
 	};
-
-	pinctrl_wdog1: wdog1grp {
-		fsl,pins = <
-			MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B	0x30
-		>;
-	};
 };
 
 &pwm1 {
@@ -554,8 +548,3 @@
 	no-1-8-v;
 	status = "okay";
 };
-
-&wdog1 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_wdog1>;
-};
diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
index 85fe461e5e67..9aaed85138cb 100644
--- a/arch/arm/boot/dts/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
@@ -209,6 +209,14 @@
 	};
 };
 
+&iomuxc_lpsr {
+	pinctrl_wdog1: wdog1grp {
+		fsl,pins = <
+			MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B	0x30
+		>;
+	};
+};
+
 &sdma {
 	status = "okay";
 };
@@ -228,5 +236,14 @@
 };
 
 &wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog1>;
+	/*
+	 * Errata e10574:
+	 * WDOG reset needs to run with WDOG_RESET_B signal enabled.
+	 * X1-51 (WDOG1#) signal needs carrier board handling to reset
+	 * TQMa7 on X1-22 (RESET_IN#).
+	 */
+	fsl,ext-reset-output;
 	status = "okay";
 };
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH v2] ARM: dts: bugfix tqma7 soft reset issue
@ 2019-04-16  9:08   ` Bruno Thomsen
  0 siblings, 0 replies; 9+ messages in thread
From: Bruno Thomsen @ 2019-04-16  9:08 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: devicetree, laa, festevam, s.hauer, clemens.ml, bruno.thomsen,
	ksc, robh+dt, linux-imx, kernel, shawnguo, markus.niebel

Running reboot command on the TQMa7 board would just hang infinite
at the end of the system shutdown process.

Handling of i.MX7 errata e10574:
Watchdog: A watchdog timeout or software trigger will not reset the SOC.

Moved pinctrl from common mba7 to common tqma7 dtsi as it improves
readability of errata handling. Most integrators of this SoM will
likely use the development board as inspiration for handling this
SoC issue.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
v2:
Moved pinctrl from common development board to common SoM.
Removed Markus reviewed-by as he only acked the fsl,ext-reset-output part.

 arch/arm/boot/dts/imx7-mba7.dtsi  | 11 -----------
 arch/arm/boot/dts/imx7-tqma7.dtsi | 17 +++++++++++++++++
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi
index 578341b6848b..50abf18ad30b 100644
--- a/arch/arm/boot/dts/imx7-mba7.dtsi
+++ b/arch/arm/boot/dts/imx7-mba7.dtsi
@@ -472,12 +472,6 @@
 			MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5	0x59
 		>;
 	};
-
-	pinctrl_wdog1: wdog1grp {
-		fsl,pins = <
-			MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B	0x30
-		>;
-	};
 };
 
 &pwm1 {
@@ -554,8 +548,3 @@
 	no-1-8-v;
 	status = "okay";
 };
-
-&wdog1 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_wdog1>;
-};
diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
index 85fe461e5e67..9aaed85138cb 100644
--- a/arch/arm/boot/dts/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
@@ -209,6 +209,14 @@
 	};
 };
 
+&iomuxc_lpsr {
+	pinctrl_wdog1: wdog1grp {
+		fsl,pins = <
+			MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B	0x30
+		>;
+	};
+};
+
 &sdma {
 	status = "okay";
 };
@@ -228,5 +236,14 @@
 };
 
 &wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog1>;
+	/*
+	 * Errata e10574:
+	 * WDOG reset needs to run with WDOG_RESET_B signal enabled.
+	 * X1-51 (WDOG1#) signal needs carrier board handling to reset
+	 * TQMa7 on X1-22 (RESET_IN#).
+	 */
+	fsl,ext-reset-output;
 	status = "okay";
 };
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: dts: bugfix tqma7 soft reset issue
  2019-04-16  9:08   ` Bruno Thomsen
@ 2019-04-22  0:52     ` Shawn Guo
  -1 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2019-04-22  0:52 UTC (permalink / raw)
  To: Bruno Thomsen
  Cc: markus.niebel, devicetree, laa, s.hauer, clemens.ml, ksc,
	robh+dt, linux-imx, kernel, festevam, linux-arm-kernel

On Tue, Apr 16, 2019 at 11:08:05AM +0200, Bruno Thomsen wrote:
> Running reboot command on the TQMa7 board would just hang infinite
> at the end of the system shutdown process.
> 
> Handling of i.MX7 errata e10574:
> Watchdog: A watchdog timeout or software trigger will not reset the SOC.
> 
> Moved pinctrl from common mba7 to common tqma7 dtsi as it improves
> readability of errata handling. Most integrators of this SoM will
> likely use the development board as inspiration for handling this
> SoC issue.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: dts: bugfix tqma7 soft reset issue
@ 2019-04-22  0:52     ` Shawn Guo
  0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2019-04-22  0:52 UTC (permalink / raw)
  To: Bruno Thomsen
  Cc: markus.niebel, devicetree, laa, s.hauer, clemens.ml, ksc,
	robh+dt, linux-imx, kernel, festevam, linux-arm-kernel

On Tue, Apr 16, 2019 at 11:08:05AM +0200, Bruno Thomsen wrote:
> Running reboot command on the TQMa7 board would just hang infinite
> at the end of the system shutdown process.
> 
> Handling of i.MX7 errata e10574:
> Watchdog: A watchdog timeout or software trigger will not reset the SOC.
> 
> Moved pinctrl from common mba7 to common tqma7 dtsi as it improves
> readability of errata handling. Most integrators of this SoM will
> likely use the development board as inspiration for handling this
> SoC issue.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-22  0:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-14 12:06 [PATCH] ARM: dts: bugfix tqma7 soft reset issue Bruno Thomsen
2019-04-14 12:06 ` Bruno Thomsen
2019-04-14 15:32 ` Fabio Estevam
2019-04-14 15:32   ` Fabio Estevam
2019-04-14 16:10   ` Bruno Thomsen
2019-04-16  9:08 ` [PATCH v2] " Bruno Thomsen
2019-04-16  9:08   ` Bruno Thomsen
2019-04-22  0:52   ` Shawn Guo
2019-04-22  0:52     ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.