[PATCH 0/2] drm/exynos: clean up logs

[PATCH 0/2] drm/exynos: clean up logs

[Inki Dae]

Just clean up logs from exynos drm driver.

Inki Dae (2):
  drm/fimd: use DRM_ERROR instead of DRM_INFO in error case
  drm/exynos: remove unnecessary messages

 drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 --
 drivers/gpu/drm/exynos/exynos_drm_fimd.c      | 8 +++-----
 2 files changed, 3 insertions(+), 7 deletions(-)

-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

[Inki Dae]

This patch makes error messages to be printed out using DRM_ERROR
instead of DRM_INFO.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 786a8ee..78427ec 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -400,7 +400,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
 	u32 clkdiv;
 
 	if (mode->clock == 0) {
-		DRM_INFO("Mode has zero clock value.\n");
+		DRM_ERROR("Mode has zero clock value.\n");
 		return -EINVAL;
 	}
 
@@ -416,7 +416,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
 
 	lcd_rate = clk_get_rate(ctx->lcd_clk);
 	if (2 * lcd_rate < ideal_clk) {
-		DRM_INFO("sclk_fimd clock too low(%lu) for requested pixel clock(%lu)\n",
+		DRM_ERROR("sclk_fimd clock too low(%lu) for requested pixel clock(%lu)\n",
 			 lcd_rate, ideal_clk);
 		return -EINVAL;
 	}
@@ -424,7 +424,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
 	/* Find the clock divider value that gets us closest to ideal_clk */
 	clkdiv = DIV_ROUND_CLOSEST(lcd_rate, ideal_clk);
 	if (clkdiv >= 0x200) {
-		DRM_INFO("requested pixel clock(%lu) too low\n", ideal_clk);
+		DRM_ERROR("requested pixel clock(%lu) too low\n", ideal_clk);
 		return -EINVAL;
 	}
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/exynos: remove unnecessary messages

[Inki Dae]

This patch removes unnecessary messages from fimd_clear_channels
and decon_clear_channels functions which print out just function
name.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 --
 drivers/gpu/drm/exynos/exynos_drm_fimd.c      | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index 5b4e0e8..ba52180 100644
--- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
@@ -561,8 +561,6 @@ static void decon_clear_channels(struct exynos_drm_crtc *crtc)
 	struct decon_context *ctx = crtc->ctx;
 	int win, i, ret;
 
-	DRM_DEBUG_KMS("%s\n", __FILE__);
-
 	for (i = 0; i < ARRAY_SIZE(decon_clks_name); i++) {
 		ret = clk_prepare_enable(ctx->clks[i]);
 		if (ret < 0)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 78427ec..ffb686a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -350,8 +350,6 @@ static void fimd_clear_channels(struct exynos_drm_crtc *crtc)
 	struct fimd_context *ctx = crtc->ctx;
 	unsigned int win, ch_enabled = 0;
 
-	DRM_DEBUG_KMS("%s\n", __FILE__);
-
 	/* Hardware is in unknown state, so ensure it gets enabled properly */
 	pm_runtime_get_sync(ctx->dev);
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

[Sam Ravnborg]

Hi Inki

On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote:
> This patch makes error messages to be printed out using DRM_ERROR
> instead of DRM_INFO.
> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 786a8ee..78427ec 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -400,7 +400,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
>  	u32 clkdiv;
>  
>  	if (mode->clock == 0) {
> -		DRM_INFO("Mode has zero clock value.\n");
> +		DRM_ERROR("Mode has zero clock value.\n");

To give the logs a more precise info on where is comes from you
could consider to use:

		DRM_DEV_ERROR(ctx->dev, "Mode has zero clock value.\n");

Likewise below.


	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

[Inki Dae]

Hi Sam,

19. 4. 15. 오후 12:17에 Sam Ravnborg 이(가) 쓴 글:
> Hi Inki
> 
> On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote:
>> This patch makes error messages to be printed out using DRM_ERROR
>> instead of DRM_INFO.
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> index 786a8ee..78427ec 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> @@ -400,7 +400,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
>>  	u32 clkdiv;
>>  
>>  	if (mode->clock == 0) {
>> -		DRM_INFO("Mode has zero clock value.\n");
>> +		DRM_ERROR("Mode has zero clock value.\n");
> 
> To give the logs a more precise info on where is comes from you
> could consider to use:
> 
> 		DRM_DEV_ERROR(ctx->dev, "Mode has zero clock value.\n");

Thanks for comment and looks better. :)
This patch corrects the use of log macro so I will make and push a new patch - which changes all existing DRM_ERROR macros to DRM_DEV_ERROR - on top of this patch series.

Thanks,
Inki Dae

> 
> Likewise below.
> 
> 
> 	Sam
> 
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

[Ville Syrjälä]

On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote:
> This patch makes error messages to be printed out using DRM_ERROR
> instead of DRM_INFO.
> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 786a8ee..78427ec 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -400,7 +400,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
>  	u32 clkdiv;
>  
>  	if (mode->clock == 0) {
> -		DRM_INFO("Mode has zero clock value.\n");
> +		DRM_ERROR("Mode has zero clock value.\n");
>  		return -EINVAL;
>  	}

This seems like it should likely have been caught by
drm_mode_convert_to_umode()->...->drm_mode_validate_basic().

>  
> @@ -416,7 +416,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
>  
>  	lcd_rate = clk_get_rate(ctx->lcd_clk);
>  	if (2 * lcd_rate < ideal_clk) {
> -		DRM_INFO("sclk_fimd clock too low(%lu) for requested pixel clock(%lu)\n",
> +		DRM_ERROR("sclk_fimd clock too low(%lu) for requested pixel clock(%lu)\n",
>  			 lcd_rate, ideal_clk);

These look like they could user triggerable, in which case they should
be debug messages instead.

>  		return -EINVAL;
>  	}
> @@ -424,7 +424,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
>  	/* Find the clock divider value that gets us closest to ideal_clk */
>  	clkdiv = DIV_ROUND_CLOSEST(lcd_rate, ideal_clk);
>  	if (clkdiv >= 0x200) {
> -		DRM_INFO("requested pixel clock(%lu) too low\n", ideal_clk);
> +		DRM_ERROR("requested pixel clock(%lu) too low\n", ideal_clk);
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel