All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Murphy Zhou <xzhou@redhat.com>
Cc: fstests@vger.kernel.org, bcodding@redhat.com, yieli@redhat.com,
	bxue@redhat.com
Subject: Re: [PATCH] generic/294: skip on NFS
Date: Mon, 15 Apr 2019 12:03:09 +0800	[thread overview]
Message-ID: <20190415040309.GN2824@desktop> (raw)
In-Reply-To: <20190304025008.11986-1-xzhou@redhat.com>

On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote:
> Because NFS handles this differently, returning different values.
> Details:
> http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
> 
> Signed-off-by: Murphy Zhou <xzhou@redhat.com>

Sorry for the so long delay.. 

> ---
>  tests/generic/294 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/294 b/tests/generic/294
> index b74579ac..f7e763a3 100755
> --- a/tests/generic/294
> +++ b/tests/generic/294
> @@ -27,6 +27,7 @@ _cleanup()
>  . ./common/filter
>  
>  # real QA test starts here
> +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"

I think it's better to filter the output of NFS to follow the golden
output, so when NFS changes behavior, filter fails and we could know
that from test failure.

Thanks,
Eryu

>  
>  # Modify as appropriate.
>  _supported_fs generic
> -- 
> 2.21.0
> 

  parent reply	other threads:[~2019-04-15  4:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04  2:50 [PATCH] generic/294: skip on NFS Murphy Zhou
2019-04-08  2:27 ` Murphy Zhou
2019-04-15  4:03 ` Eryu Guan [this message]
2019-04-16  8:11   ` Murphy Zhou
2019-04-16  8:14   ` [PATCH v2] generic/294: add golden output for nfs Murphy Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190415040309.GN2824@desktop \
    --to=guaneryu@gmail.com \
    --cc=bcodding@redhat.com \
    --cc=bxue@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=xzhou@redhat.com \
    --cc=yieli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.