All of lore.kernel.org
 help / color / mirror / Atom feed
From: Murphy Zhou <xzhou@redhat.com>
To: guaneryu@gmail.com, fstests@vger.kernel.org
Cc: bcodding@redhat.com, Murphy Zhou <xzhou@redhat.com>
Subject: [PATCH v2] generic/294: add golden output for nfs
Date: Tue, 16 Apr 2019 16:14:57 +0800	[thread overview]
Message-ID: <20190416081457.10442-1-xzhou@redhat.com> (raw)
In-Reply-To: <20190415040309.GN2824@desktop>

Because NFS handles this differently, returning different values.
Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---

v2:
   add a new golden output for nfs instead of _notrun.

 tests/generic/294         | 7 +++++++
 tests/generic/294.out.nfs | 5 +++++
 2 files changed, 12 insertions(+)
 create mode 100644 tests/generic/294.out.nfs

diff --git a/tests/generic/294 b/tests/generic/294
index b74579ac..a355c612 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -7,6 +7,7 @@
 # Tests for EEXIST (not EROFS) for inode creations, if
 # we ask to create an already-existing entity on an RO filesystem
 #
+seqfull=$0
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
 echo "QA output created by $seq"
@@ -27,6 +28,12 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+# link correct .out file
+if [ $FSTYP == "nfs" ]; then
+	rm -f $seqfull.out
+	ln -sf $seq.out.nfs $seqfull.out
+fi
+
 
 # Modify as appropriate.
 _supported_fs generic
diff --git a/tests/generic/294.out.nfs b/tests/generic/294.out.nfs
new file mode 100644
index 00000000..71ebeecd
--- /dev/null
+++ b/tests/generic/294.out.nfs
@@ -0,0 +1,5 @@
+QA output created by 294
+mknod: 'SCRATCH_MNT/294.test/testnode': Read-only file system
+mkdir: cannot create directory 'SCRATCH_MNT/294.test/testdir': Read-only file system
+touch: cannot touch 'SCRATCH_MNT/294.test/testtarget': Read-only file system
+ln: creating symbolic link 'SCRATCH_MNT/294.test/testlink': File exists
-- 
2.21.0

      parent reply	other threads:[~2019-04-16  8:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04  2:50 [PATCH] generic/294: skip on NFS Murphy Zhou
2019-04-08  2:27 ` Murphy Zhou
2019-04-15  4:03 ` Eryu Guan
2019-04-16  8:11   ` Murphy Zhou
2019-04-16  8:14   ` Murphy Zhou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416081457.10442-1-xzhou@redhat.com \
    --to=xzhou@redhat.com \
    --cc=bcodding@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.