[meta-multimedia][PATCH 1/2] mycroft: Update the systemd service to ensure we are ready to start

[meta-multimedia][PATCH 1/2] mycroft: Update the systemd service to ensure we are ready to start

[Alistair Francis]

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 .../recipes-multimedia/mycroft/files/mycroft.service         | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
index 04cf43620..28729f6b1 100644
--- a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
+++ b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
@@ -1,10 +1,11 @@
 [Unit]
 Description=Mycroft
-DefaultDependencies=no
-After=mycroft-setup
+RequiresMountsFor=/var
+After=mycroft-setup.service
 
 [Service]
 Type=forking
+WorkingDirectory=@LIBDIR@/mycroft
 ExecStartPre=mkdir -p /var/log/mycroft
 ExecStart=@LIBDIR@/mycroft/start-mycroft.sh all
 ExecStop=@LIBDIR@/mycroft/stop-mycroft.sh all
-- 
2.21.0

[meta-multimedia][PATCH 2/2] mycroft: Bump from 19.2.2 to 19.2.3

[Alistair Francis]

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 .../mycroft/{mycroft_19.2.2.bb => mycroft_19.2.3.bb}         | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 rename meta-multimedia/recipes-multimedia/mycroft/{mycroft_19.2.2.bb => mycroft_19.2.3.bb} (96%)

diff --git a/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.2.bb b/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb
similarity index 96%
rename from meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.2.bb
rename to meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb
index c8ae53468..becd0bf79 100644
--- a/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.2.bb
+++ b/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb
@@ -6,7 +6,7 @@ SECTION = "multimedia"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE.md;md5=79aa497b11564d1d419ee889e7b498f6"
 
-SRCREV = "6706c377820912f83c1838d9eb32950ca9e39ec7"
+SRCREV = "4b45db34ecd95b62ef2b66a8e5180c66ca791a21"
 SRC_URI = "git://github.com/MycroftAI/mycroft-core.git;branch=master \
            file://0001-Remove-python-venv.patch \
            file://0002-pip-requirements-Remove-ones-installed-by-OE.patch \
@@ -63,9 +63,10 @@ RDEPENDS_${PN} += "python3-pip \
                    python3-xxhash \
                  "
 
-# Mycroft uses Alsa and PulseAudio
+# Mycroft uses Alsa, PulseAudio and Flac
 RDEPENDS_${PN} += "alsa-oss alsa-utils alsa-plugins alsa-tools"
 RDEPENDS_${PN} += "pulseaudio pulseaudio-misc pulseaudio-server"
+RDEPENDS_${PN} += "flac"
 
 # Mycroft can do this itself on the target, but it's quicker to do it here
 RDEPENDS_${PN} += "mimic"
-- 
2.21.0

Re: [meta-multimedia][PATCH 1/2] mycroft: Update the systemd service to ensure we are ready to start

[Khem Raj]

On Mon, Apr 15, 2019 at 11:53 AM Alistair Francis <Alistair.Francis@wdc.com>
wrote:

> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  .../recipes-multimedia/mycroft/files/mycroft.service         | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git
> a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> index 04cf43620..28729f6b1 100644
> --- a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> +++ b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> @@ -1,10 +1,11 @@
>  [Unit]
>  Description=Mycroft
> -DefaultDependencies=no
> -After=mycroft-setup
> +RequiresMountsFor=/var


Does this mean it should be a separate mount point

>
> +After=mycroft-setup.service
>
>  [Service]
>  Type=forking
> +WorkingDirectory=@LIBDIR@/mycroft
>  ExecStartPre=mkdir -p /var/log/mycroft
>  ExecStart=@LIBDIR@/mycroft/start-mycroft.sh all
>  ExecStop=@LIBDIR@/mycroft/stop-mycroft.sh all
> --
> 2.21.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-multimedia][PATCH 1/2] mycroft: Update the systemd service to ensure we are ready to start

[Alistair Francis]

On Mon, Apr 15, 2019 at 1:00 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Apr 15, 2019 at 11:53 AM Alistair Francis <Alistair.Francis@wdc.com>
> wrote:
>
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> >  .../recipes-multimedia/mycroft/files/mycroft.service         | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > index 04cf43620..28729f6b1 100644
> > --- a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > +++ b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > @@ -1,10 +1,11 @@
> >  [Unit]
> >  Description=Mycroft
> > -DefaultDependencies=no
> > -After=mycroft-setup
> > +RequiresMountsFor=/var
>
>
> Does this mean it should be a separate mount point

I'm not sure what you mean. We just need to ensure that /var is
accessible before starting.

Alistair

>
> >
> > +After=mycroft-setup.service
> >
> >  [Service]
> >  Type=forking
> > +WorkingDirectory=@LIBDIR@/mycroft
> >  ExecStartPre=mkdir -p /var/log/mycroft
> >  ExecStart=@LIBDIR@/mycroft/start-mycroft.sh all
> >  ExecStop=@LIBDIR@/mycroft/stop-mycroft.sh all
> > --
> > 2.21.0
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-multimedia][PATCH 1/2] mycroft: Update the systemd service to ensure we are ready to start

[Khem Raj]

On Mon, Apr 15, 2019 at 1:24 PM Alistair Francis <alistair23@gmail.com> wrote:
>
> On Mon, Apr 15, 2019 at 1:00 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Mon, Apr 15, 2019 at 11:53 AM Alistair Francis <Alistair.Francis@wdc.com>
> > wrote:
> >
> > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > > ---
> > >  .../recipes-multimedia/mycroft/files/mycroft.service         | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > > a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > > b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > > index 04cf43620..28729f6b1 100644
> > > --- a/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > > +++ b/meta-multimedia/recipes-multimedia/mycroft/files/mycroft.service
> > > @@ -1,10 +1,11 @@
> > >  [Unit]
> > >  Description=Mycroft
> > > -DefaultDependencies=no
> > > -After=mycroft-setup
> > > +RequiresMountsFor=/var
> >
> >
> > Does this mean it should be a separate mount point
>
> I'm not sure what you mean. We just need to ensure that /var is
> accessible before starting.
>

I guess, I found it for myself that all mount units required to access
the specified path will be added to After= and Requires=
field. So this would work in cases where /var is a separate mount or
simply a directory under / so this seems to be fine.

> Alistair
>
> >
> > >
> > > +After=mycroft-setup.service
> > >
> > >  [Service]
> > >  Type=forking
> > > +WorkingDirectory=@LIBDIR@/mycroft
> > >  ExecStartPre=mkdir -p /var/log/mycroft
> > >  ExecStart=@LIBDIR@/mycroft/start-mycroft.sh all
> > >  ExecStop=@LIBDIR@/mycroft/stop-mycroft.sh all
> > > --
> > > 2.21.0
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel