* [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
@ 2019-04-15 17:28 Deepak Singh Rawat
2019-04-16 7:42 ` Daniel Vetter
0 siblings, 1 reply; 8+ messages in thread
From: Deepak Singh Rawat @ 2019-04-15 17:28 UTC (permalink / raw)
To: dri-devel; +Cc: Deepak Singh Rawat, Linux-graphics-maintainer
Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
user-space, so no point exposing it otherwise.
Signed-off-by: Deepak Rawat <drawat@vmware.com>
Fixes: d3b21767821e ("drm: Add a new plane property to send damage during plane update")
---
drivers/gpu/drm/drm_mode_config.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
index 4a1c2023ccf0..1a346ae1599d 100644
--- a/drivers/gpu/drm/drm_mode_config.c
+++ b/drivers/gpu/drm/drm_mode_config.c
@@ -297,8 +297,9 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
return -ENOMEM;
dev->mode_config.prop_crtc_id = prop;
- prop = drm_property_create(dev, DRM_MODE_PROP_BLOB, "FB_DAMAGE_CLIPS",
- 0);
+ prop = drm_property_create(dev,
+ DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
+ "FB_DAMAGE_CLIPS", 0);
if (!prop)
return -ENOMEM;
dev->mode_config.prop_fb_damage_clips = prop;
--
2.21.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
2019-04-15 17:28 [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only Deepak Singh Rawat
@ 2019-04-16 7:42 ` Daniel Vetter
2019-04-16 16:21 ` Deepak Singh Rawat
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-04-16 7:42 UTC (permalink / raw)
To: Deepak Singh Rawat; +Cc: Linux-graphics-maintainer, dri-devel
On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat wrote:
> Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
> user-space, so no point exposing it otherwise.
>
> Signed-off-by: Deepak Rawat <drawat@vmware.com>
> Fixes: d3b21767821e ("drm: Add a new plane property to send damage during plane update")
Makes sense, probably good if we add Cc: stable@vger.kernel.org too
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
btw, want drm-misc commit rights to push this? Assuming you'd then push
vmware drm patches in general ofc. See
https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_mode_config.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index 4a1c2023ccf0..1a346ae1599d 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
> @@ -297,8 +297,9 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
> return -ENOMEM;
> dev->mode_config.prop_crtc_id = prop;
>
> - prop = drm_property_create(dev, DRM_MODE_PROP_BLOB, "FB_DAMAGE_CLIPS",
> - 0);
> + prop = drm_property_create(dev,
> + DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> + "FB_DAMAGE_CLIPS", 0);
> if (!prop)
> return -ENOMEM;
> dev->mode_config.prop_fb_damage_clips = prop;
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
2019-04-16 7:42 ` Daniel Vetter
@ 2019-04-16 16:21 ` Deepak Singh Rawat
2019-04-16 18:15 ` Daniel Vetter
0 siblings, 1 reply; 8+ messages in thread
From: Deepak Singh Rawat @ 2019-04-16 16:21 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Linux-graphics-maintainer, dri-devel
On Tue, 2019-04-16 at 09:42 +0200, Daniel Vetter wrote:
> On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat wrote:
> > Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
> > user-space, so no point exposing it otherwise.
> >
> > Signed-off-by: Deepak Rawat <drawat@vmware.com>
> > Fixes: d3b21767821e ("drm: Add a new plane property to send damage
> > during plane update")
>
> Makes sense, probably good if we add Cc: stable@vger.kernel.org too
Hi Daniel, thanks for the review. Sure.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> btw, want drm-misc commit rights to push this? Assuming you'd then
> push
> vmware drm patches in general ofc. See
Yes I think it would be a good idea if I can have drm-mics commit
rights. I think for occasional vmwgfx patches it would be ideal for us
to use drm-mics on the other hand if had some major changes better to
follow pull request way.
How to apply for drm-mics commit rights?
>
>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=PMdonBtvx%2B2bMweQJTRu1b7IjmL0lSd2KKSIBV1ngTk%3D&reserved=0
>
> Cheers, Daniel
>
> > ---
> > drivers/gpu/drm/drm_mode_config.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_mode_config.c
> > b/drivers/gpu/drm/drm_mode_config.c
> > index 4a1c2023ccf0..1a346ae1599d 100644
> > --- a/drivers/gpu/drm/drm_mode_config.c
> > +++ b/drivers/gpu/drm/drm_mode_config.c
> > @@ -297,8 +297,9 @@ static int
> > drm_mode_create_standard_properties(struct drm_device *dev)
> > return -ENOMEM;
> > dev->mode_config.prop_crtc_id = prop;
> >
> > - prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
> > "FB_DAMAGE_CLIPS",
> > - 0);
> > + prop = drm_property_create(dev,
> > + DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> > + "FB_DAMAGE_CLIPS", 0);
> > if (!prop)
> > return -ENOMEM;
> > dev->mode_config.prop_fb_damage_clips = prop;
> > --
> > 2.21.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=QJCrLbtFUv7%2FiRAYOb2R%2Bab4w3l5CWae2K7t9Ya6dZw%3D&reserved=0
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
2019-04-16 16:21 ` Deepak Singh Rawat
@ 2019-04-16 18:15 ` Daniel Vetter
2019-04-16 18:28 ` Deepak Singh Rawat
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-04-16 18:15 UTC (permalink / raw)
To: Deepak Singh Rawat; +Cc: Linux-graphics-maintainer, dri-devel
On Tue, Apr 16, 2019 at 6:21 PM Deepak Singh Rawat <drawat@vmware.com> wrote:
>
> On Tue, 2019-04-16 at 09:42 +0200, Daniel Vetter wrote:
> > On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat wrote:
> > > Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
> > > user-space, so no point exposing it otherwise.
> > >
> > > Signed-off-by: Deepak Rawat <drawat@vmware.com>
> > > Fixes: d3b21767821e ("drm: Add a new plane property to send damage
> > > during plane update")
> >
> > Makes sense, probably good if we add Cc: stable@vger.kernel.org too
>
> Hi Daniel, thanks for the review. Sure.
>
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > btw, want drm-misc commit rights to push this? Assuming you'd then
> > push
> > vmware drm patches in general ofc. See
>
> Yes I think it would be a good idea if I can have drm-mics commit
> rights. I think for occasional vmwgfx patches it would be ideal for us
> to use drm-mics on the other hand if had some major changes better to
> follow pull request way.
>
> How to apply for drm-mics commit rights?
https://www.freedesktop.org/wiki/AccountRequests/
you need an ssh account for drm-misc. Reply with the bug report here
and I'll ack - drm-misc maintainers already acked.
-Daniel
>
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=PMdonBtvx%2B2bMweQJTRu1b7IjmL0lSd2KKSIBV1ngTk%3D&reserved=0
> >
> > Cheers, Daniel
> >
> > > ---
> > > drivers/gpu/drm/drm_mode_config.c | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_mode_config.c
> > > b/drivers/gpu/drm/drm_mode_config.c
> > > index 4a1c2023ccf0..1a346ae1599d 100644
> > > --- a/drivers/gpu/drm/drm_mode_config.c
> > > +++ b/drivers/gpu/drm/drm_mode_config.c
> > > @@ -297,8 +297,9 @@ static int
> > > drm_mode_create_standard_properties(struct drm_device *dev)
> > > return -ENOMEM;
> > > dev->mode_config.prop_crtc_id = prop;
> > >
> > > - prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
> > > "FB_DAMAGE_CLIPS",
> > > - 0);
> > > + prop = drm_property_create(dev,
> > > + DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> > > + "FB_DAMAGE_CLIPS", 0);
> > > if (!prop)
> > > return -ENOMEM;
> > > dev->mode_config.prop_fb_damage_clips = prop;
> > > --
> > > 2.21.0
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=QJCrLbtFUv7%2FiRAYOb2R%2Bab4w3l5CWae2K7t9Ya6dZw%3D&reserved=0
> >
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
2019-04-16 18:15 ` Daniel Vetter
@ 2019-04-16 18:28 ` Deepak Singh Rawat
2019-04-16 19:27 ` Daniel Vetter
0 siblings, 1 reply; 8+ messages in thread
From: Deepak Singh Rawat @ 2019-04-16 18:28 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Linux-graphics-maintainer, dri-devel
On Tue, 2019-04-16 at 20:15 +0200, Daniel Vetter wrote:
> On Tue, Apr 16, 2019 at 6:21 PM Deepak Singh Rawat <drawat@vmware.com
> > wrote:
> >
> > On Tue, 2019-04-16 at 09:42 +0200, Daniel Vetter wrote:
> > > On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat
> > > wrote:
> > > > Plane property "FB_DAMAGE_CLIPS" can only be used by atomic
> > > > aware
> > > > user-space, so no point exposing it otherwise.
> > > >
> > > > Signed-off-by: Deepak Rawat <drawat@vmware.com>
> > > > Fixes: d3b21767821e ("drm: Add a new plane property to send
> > > > damage
> > > > during plane update")
> > >
> > > Makes sense, probably good if we add Cc: stable@vger.kernel.org
> > > too
> >
> > Hi Daniel, thanks for the review. Sure.
> >
> > >
> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > >
> > > btw, want drm-misc commit rights to push this? Assuming you'd
> > > then
> > > push
> > > vmware drm patches in general ofc. See
> >
> > Yes I think it would be a good idea if I can have drm-mics commit
> > rights. I think for occasional vmwgfx patches it would be ideal for
> > us
> > to use drm-mics on the other hand if had some major changes better
> > to
> > follow pull request way.
> >
> > How to apply for drm-mics commit rights?
>
>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.freedesktop.org%2Fwiki%2FAccountRequests%2F&data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&sdata=T4RrZ7vdhhu3t0sn2jhU2axEVl7cr5x2JgOgJzVoEl8%3D&reserved=0
>
> you need an ssh account for drm-misc. Reply with the bug report here
> and I'll ack - drm-misc maintainers already acked.
> -Daniel
If you mean ssh on annarchy.freedesktop.org, I already have one with
username - drawat
>
> >
> > >
> > >
> >
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&sdata=ZLOBkqM%2BFVKlutvu4u3kFyW8b%2FKp2fV5UFtfaW0wVZc%3D&reserved=0
> > >
> > > Cheers, Daniel
> > >
> > > > ---
> > > > drivers/gpu/drm/drm_mode_config.c | 5 +++--
> > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/drm_mode_config.c
> > > > b/drivers/gpu/drm/drm_mode_config.c
> > > > index 4a1c2023ccf0..1a346ae1599d 100644
> > > > --- a/drivers/gpu/drm/drm_mode_config.c
> > > > +++ b/drivers/gpu/drm/drm_mode_config.c
> > > > @@ -297,8 +297,9 @@ static int
> > > > drm_mode_create_standard_properties(struct drm_device *dev)
> > > > return -ENOMEM;
> > > > dev->mode_config.prop_crtc_id = prop;
> > > >
> > > > - prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
> > > > "FB_DAMAGE_CLIPS",
> > > > - 0);
> > > > + prop = drm_property_create(dev,
> > > > + DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> > > > + "FB_DAMAGE_CLIPS", 0);
> > > > if (!prop)
> > > > return -ENOMEM;
> > > > dev->mode_config.prop_fb_damage_clips = prop;
> > > > --
> > > > 2.21.0
> > > >
> > > > _______________________________________________
> > > > dri-devel mailing list
> > > > dri-devel@lists.freedesktop.org
> > > >
> >
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&sdata=6zQnD6klo9k3%2FvVP0mOUQeuwgoSZ3q7o0OChNNaoG%2BQ%3D&reserved=0
> > >
> > >
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
2019-04-16 18:28 ` Deepak Singh Rawat
@ 2019-04-16 19:27 ` Daniel Vetter
2019-04-16 22:34 ` Deepak Singh Rawat
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-04-16 19:27 UTC (permalink / raw)
To: Deepak Singh Rawat; +Cc: Linux-graphics-maintainer, dri-devel
On Tue, Apr 16, 2019 at 8:28 PM Deepak Singh Rawat <drawat@vmware.com> wrote:
>
> On Tue, 2019-04-16 at 20:15 +0200, Daniel Vetter wrote:
> > On Tue, Apr 16, 2019 at 6:21 PM Deepak Singh Rawat <drawat@vmware.com
> > > wrote:
> > >
> > > On Tue, 2019-04-16 at 09:42 +0200, Daniel Vetter wrote:
> > > > On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat
> > > > wrote:
> > > > > Plane property "FB_DAMAGE_CLIPS" can only be used by atomic
> > > > > aware
> > > > > user-space, so no point exposing it otherwise.
> > > > >
> > > > > Signed-off-by: Deepak Rawat <drawat@vmware.com>
> > > > > Fixes: d3b21767821e ("drm: Add a new plane property to send
> > > > > damage
> > > > > during plane update")
> > > >
> > > > Makes sense, probably good if we add Cc: stable@vger.kernel.org
> > > > too
> > >
> > > Hi Daniel, thanks for the review. Sure.
> > >
> > > >
> > > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > >
> > > > btw, want drm-misc commit rights to push this? Assuming you'd
> > > > then
> > > > push
> > > > vmware drm patches in general ofc. See
> > >
> > > Yes I think it would be a good idea if I can have drm-mics commit
> > > rights. I think for occasional vmwgfx patches it would be ideal for
> > > us
> > > to use drm-mics on the other hand if had some major changes better
> > > to
> > > follow pull request way.
> > >
> > > How to apply for drm-mics commit rights?
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.freedesktop.org%2Fwiki%2FAccountRequests%2F&data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&sdata=T4RrZ7vdhhu3t0sn2jhU2axEVl7cr5x2JgOgJzVoEl8%3D&reserved=0
> >
> > you need an ssh account for drm-misc. Reply with the bug report here
> > and I'll ack - drm-misc maintainers already acked.
> > -Daniel
>
> If you mean ssh on annarchy.freedesktop.org, I already have one with
> username - drawat
You're added. Please check out the dim toturial and pls ask any
questions here or on irc or wherever - drm(-misc) maintainers are
happy to help out.
-Daniel
>
> >
> > >
> > > >
> > > >
> > >
> > >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&sdata=ZLOBkqM%2BFVKlutvu4u3kFyW8b%2FKp2fV5UFtfaW0wVZc%3D&reserved=0
> > > >
> > > > Cheers, Daniel
> > > >
> > > > > ---
> > > > > drivers/gpu/drm/drm_mode_config.c | 5 +++--
> > > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/drm_mode_config.c
> > > > > b/drivers/gpu/drm/drm_mode_config.c
> > > > > index 4a1c2023ccf0..1a346ae1599d 100644
> > > > > --- a/drivers/gpu/drm/drm_mode_config.c
> > > > > +++ b/drivers/gpu/drm/drm_mode_config.c
> > > > > @@ -297,8 +297,9 @@ static int
> > > > > drm_mode_create_standard_properties(struct drm_device *dev)
> > > > > return -ENOMEM;
> > > > > dev->mode_config.prop_crtc_id = prop;
> > > > >
> > > > > - prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
> > > > > "FB_DAMAGE_CLIPS",
> > > > > - 0);
> > > > > + prop = drm_property_create(dev,
> > > > > + DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> > > > > + "FB_DAMAGE_CLIPS", 0);
> > > > > if (!prop)
> > > > > return -ENOMEM;
> > > > > dev->mode_config.prop_fb_damage_clips = prop;
> > > > > --
> > > > > 2.21.0
> > > > >
> > > > > _______________________________________________
> > > > > dri-devel mailing list
> > > > > dri-devel@lists.freedesktop.org
> > > > >
> > >
> > >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&sdata=6zQnD6klo9k3%2FvVP0mOUQeuwgoSZ3q7o0OChNNaoG%2BQ%3D&reserved=0
> > > >
> > > >
> >
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
2019-04-16 19:27 ` Daniel Vetter
@ 2019-04-16 22:34 ` Deepak Singh Rawat
2019-04-17 7:07 ` Daniel Vetter
0 siblings, 1 reply; 8+ messages in thread
From: Deepak Singh Rawat @ 2019-04-16 22:34 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Linux-graphics-maintainer, dri-devel
> >
> > If you mean ssh on annarchy.freedesktop.org, I already have one
> > with
> > username - drawat
>
> You're added. Please check out the dim toturial and pls ask any
> questions here or on irc or wherever - drm(-misc) maintainers are
> happy to help out.
> -Daniel
>
Hi I followed the instruction at
https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
and submitted my patch, I see that drm-tip has a lot of commits with
myself as author(https://cgit.freedesktop.org/drm/drm-tip/log/). Is
this expected? Or did I messed up something.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
2019-04-16 22:34 ` Deepak Singh Rawat
@ 2019-04-17 7:07 ` Daniel Vetter
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-04-17 7:07 UTC (permalink / raw)
To: Deepak Singh Rawat; +Cc: Linux-graphics-maintainer, dri-devel
On Wed, Apr 17, 2019 at 12:35 AM Deepak Singh Rawat <drawat@vmware.com> wrote:
>
>
> > >
> > > If you mean ssh on annarchy.freedesktop.org, I already have one
> > > with
> > > username - drawat
> >
> > You're added. Please check out the dim toturial and pls ask any
> > questions here or on irc or wherever - drm(-misc) maintainers are
> > happy to help out.
> > -Daniel
> >
>
> Hi I followed the instruction at
> https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
> and submitted my patch, I see that drm-tip has a lot of commits with
> myself as author(https://cgit.freedesktop.org/drm/drm-tip/log/). Is
> this expected? Or did I messed up something.
Every time one of the branches managed by dim is pushed, dim also
rebuilds drm-tip. Which means all the merge commits will be authored
by you. drm-tip is only used for integration testing, it never lands
anywhere. If you look now, all the top commits are already by someone
else - whoever pushed last.
tldr; looks all good.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-17 7:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 17:28 [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only Deepak Singh Rawat
2019-04-16 7:42 ` Daniel Vetter
2019-04-16 16:21 ` Deepak Singh Rawat
2019-04-16 18:15 ` Daniel Vetter
2019-04-16 18:28 ` Deepak Singh Rawat
2019-04-16 19:27 ` Daniel Vetter
2019-04-16 22:34 ` Deepak Singh Rawat
2019-04-17 7:07 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.