* [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission
@ 2019-04-16 8:46 Chris Wilson
2019-04-16 9:24 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-04-16 8:46 UTC (permalink / raw)
To: intel-gfx
When resubmitting the spinner, fill in the expected offset so that we
are not tempted to relocate it across contexts (as the spinner must
point back to itself for the MI_BB_START to work). In this case, these
should work correctly as they are reusing the same active vma, but for
pedagogy we should dtrt.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
tests/i915/gem_exec_schedule.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index 29653ae24..6f3f52d20 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -223,12 +223,9 @@ static void independent(int fd, unsigned int engine)
if (spin == NULL) {
spin = __igt_spin_batch_new(fd, .engine = other);
} else {
- struct drm_i915_gem_exec_object2 obj = {
- .handle = spin->handle,
- };
struct drm_i915_gem_execbuffer2 eb = {
.buffer_count = 1,
- .buffers_ptr = to_user_pointer(&obj),
+ .buffers_ptr = to_user_pointer(&spin->obj[1]),
.flags = other,
};
gem_execbuf(fd, &eb);
@@ -621,12 +618,9 @@ static igt_spin_t *__noise(int fd, uint32_t ctx, int prio, igt_spin_t *spin)
.ctx = ctx,
.engine = other);
} else {
- struct drm_i915_gem_exec_object2 obj = {
- .handle = spin->handle,
- };
struct drm_i915_gem_execbuffer2 eb = {
.buffer_count = 1,
- .buffers_ptr = to_user_pointer(&obj),
+ .buffers_ptr = to_user_pointer(&spin->obj[1]),
.rsvd1 = ctx,
.flags = other,
};
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission
2019-04-16 8:46 [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission Chris Wilson
@ 2019-04-16 9:24 ` Patchwork
2019-04-16 11:40 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-16 13:27 ` [PATCH i-g-t] " Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-16 9:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission
URL : https://patchwork.freedesktop.org/series/59564/
State : success
== Summary ==
CI Bug Log - changes from IGT_4949 -> IGTPW_2862
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59564/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2862 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-whl-u: NOTRUN -> SKIP [fdo#109271] +41
* igt@debugfs_test@read_all_entries:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927]
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-whl-u: NOTRUN -> FAIL [fdo#103375] +1
* igt@kms_psr@cursor_plane_move:
- fi-whl-u: NOTRUN -> FAIL [fdo#107383] +3
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: FAIL [fdo#103167] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (49 -> 38)
------------------------------
Additional (1): fi-whl-u
Missing (12): fi-kbl-soraka fi-ilk-m540 fi-byt-j1900 fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-icl-y fi-bdw-samus fi-byt-clapper fi-skl-6700k2
Build changes
-------------
* IGT: IGT_4949 -> IGTPW_2862
CI_DRM_5936: 0ad14bd30d830a1a355040b29bfafbe6623d84f0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2862: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2862/
IGT_4949: 2bd82477a9ee6aa308e0f1045df4901f766683ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2862/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission
2019-04-16 8:46 [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission Chris Wilson
2019-04-16 9:24 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-04-16 11:40 ` Patchwork
2019-04-16 13:27 ` [PATCH i-g-t] " Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-16 11:40 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission
URL : https://patchwork.freedesktop.org/series/59564/
State : success
== Summary ==
CI Bug Log - changes from IGT_4949_full -> IGTPW_2862_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59564/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2862_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mocs_settings@mocs-reset-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +2
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540] +1
* igt@gen3_render_mixed_blits:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +24
* igt@i915_pm_lpsp@edp-native:
- shard-iclb: NOTRUN -> SKIP [fdo#109301]
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@dpms-lpsp:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +12
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@kms_busy@extended-pageflip-hang-newfb-render-d:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_chamelium@hdmi-cmp-planes-random:
- shard-iclb: NOTRUN -> SKIP [fdo#109284]
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336]
* igt@kms_cursor_crc@cursor-512x512-suspend:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +2
* igt@kms_cursor_legacy@pipe-a-forked-move:
- shard-apl: PASS -> DMESG-WARN [fdo#110376] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-iclb: PASS -> FAIL [fdo#103167] / [fdo#110378]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +5
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: PASS -> FAIL [fdo#109247] +15
* igt@kms_frontbuffer_tracking@psr-slowdraw:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +90
* igt@kms_pipe_crc_basic@read-crc-pipe-f:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +4
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: NOTRUN -> SKIP [fdo#109441]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: PASS -> SKIP [fdo#109441] +4
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-e:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@v3d_get_bo_offset@get-bad-handle:
- shard-iclb: NOTRUN -> SKIP [fdo#109315]
#### Possible fixes ####
* igt@gem_exec_reloc@basic-write-read:
- shard-iclb: INCOMPLETE [fdo#107713] -> PASS
* igt@gem_workarounds@suspend-resume:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +8
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: SKIP [fdo#109271] -> PASS
* igt@kms_fbcon_fbt@psr-suspend:
- shard-iclb: FAIL [fdo#103833] -> PASS
* igt@kms_flip@nonexisting-fb-interruptible:
- shard-kbl: SKIP [fdo#109271] -> PASS
* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-iclb: FAIL [fdo#103167] -> PASS +6
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: FAIL [fdo#103167] / [fdo#110378] -> PASS
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
- shard-iclb: FAIL [fdo#109247] -> PASS +14
* igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_psr@primary_render:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: SKIP [fdo#109441] -> PASS
* igt@testdisplay:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109301]: https://bugs.freedesktop.org/show_bug.cgi?id=109301
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#110376]: https://bugs.freedesktop.org/show_bug.cgi?id=110376
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 6)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4949 -> IGTPW_2862
CI_DRM_5936: 0ad14bd30d830a1a355040b29bfafbe6623d84f0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2862: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2862/
IGT_4949: 2bd82477a9ee6aa308e0f1045df4901f766683ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2862/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission
2019-04-16 8:46 [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission Chris Wilson
2019-04-16 9:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-16 11:40 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-04-16 13:27 ` Mika Kuoppala
2 siblings, 0 replies; 4+ messages in thread
From: Mika Kuoppala @ 2019-04-16 13:27 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> When resubmitting the spinner, fill in the expected offset so that we
> are not tempted to relocate it across contexts (as the spinner must
> point back to itself for the MI_BB_START to work). In this case, these
> should work correctly as they are reusing the same active vma, but for
> pedagogy we should dtrt.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> tests/i915/gem_exec_schedule.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index 29653ae24..6f3f52d20 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -223,12 +223,9 @@ static void independent(int fd, unsigned int engine)
> if (spin == NULL) {
> spin = __igt_spin_batch_new(fd, .engine = other);
> } else {
> - struct drm_i915_gem_exec_object2 obj = {
> - .handle = spin->handle,
> - };
> struct drm_i915_gem_execbuffer2 eb = {
> .buffer_count = 1,
> - .buffers_ptr = to_user_pointer(&obj),
> + .buffers_ptr = to_user_pointer(&spin->obj[1]),
> .flags = other,
> };
> gem_execbuf(fd, &eb);
> @@ -621,12 +618,9 @@ static igt_spin_t *__noise(int fd, uint32_t ctx, int prio, igt_spin_t *spin)
> .ctx = ctx,
> .engine = other);
> } else {
> - struct drm_i915_gem_exec_object2 obj = {
> - .handle = spin->handle,
> - };
> struct drm_i915_gem_execbuffer2 eb = {
> .buffer_count = 1,
> - .buffers_ptr = to_user_pointer(&obj),
> + .buffers_ptr = to_user_pointer(&spin->obj[1]),
> .rsvd1 = ctx,
> .flags = other,
> };
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-16 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16 8:46 [PATCH i-g-t] i915/gem_exec_schedule: Fill in obj.offset for spinner resubmission Chris Wilson
2019-04-16 9:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-16 11:40 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-16 13:27 ` [PATCH i-g-t] " Mika Kuoppala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.