[PATCH] kernel/workqueue: Verify alloc_workqueue() argument list consistency

[PATCH] kernel/workqueue: Verify alloc_workqueue() argument list consistency

[Bart Van Assche]

This patch avoids that gcc reports the following warning when building
with W=1:

kernel/workqueue.c:4250:2: warning: function alloc_workqueue might be a candidate for gnu_printf format attribute [-Wsuggest-attribute=format]
  vsnprintf(wq->name, sizeof(wq->name), fmt, args);

Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Fixes: 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for workqueues")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 include/linux/workqueue.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index d59525fca4d3..30737b5183c0 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -404,6 +404,7 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
  * RETURNS:
  * Pointer to the allocated workqueue on success, %NULL on failure.
  */
+__printf(1, 4)
 struct workqueue_struct *alloc_workqueue(const char *fmt,
 					 unsigned int flags,
 					 int max_active, ...);
-- 
2.21.0.155.ge902e9bcae20

Re: [PATCH] kernel/workqueue: Verify alloc_workqueue() argument list consistency

[Bart Van Assche]

On Tue, 2019-03-19 at 10:40 -0700, Bart Van Assche wrote:
> This patch avoids that gcc reports the following warning when building
> with W=1:
> 
> kernel/workqueue.c:4250:2: warning: function alloc_workqueue might be a candidate for gnu_printf format attribute [-Wsuggest-attribute=format]
>   vsnprintf(wq->name, sizeof(wq->name), fmt, args);
> 
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Fixes: 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for workqueues")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  include/linux/workqueue.h | 1 
>  1 file changed, 1 insertion()
> 
> diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
> index d59525fca4d3..30737b5183c0 100644
> --- a/include/linux/workqueue.h
> ﯦﾊ眥맗뾖⧮쟼⢮䪮竧ꇣ为 ,7 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
>   * RETURNS:
>   * Pointer to the allocated workqueue on success, %NULL on failure.
>   */
> __printf(1, 4)
>  struct workqueue_struct *alloc_workqueue(const char *fmt,
>  					 unsigned int flags,
>  					 int max_active, ...);

Ping?

Bart.

Re: [PATCH] kernel/workqueue: Verify alloc_workqueue() argument list consistency

[Alexander Duyck]

On Mon, 2019-04-15 at 10:09 -0700, Bart Van Assche wrote:
> On Tue, 2019-03-19 at 10:40 -0700, Bart Van Assche wrote:
> > This patch avoids that gcc reports the following warning when building
> > with W=1:
> > 
> > kernel/workqueue.c:4250:2: warning: function alloc_workqueue might be a candidate for gnu_printf format attribute [-Wsuggest-attribute=format]
> >   vsnprintf(wq->name, sizeof(wq->name), fmt, args);
> > 
> > Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> > Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Fixes: 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for workqueues")
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > ---
> >  include/linux/workqueue.h | 1 
> >  1 file changed, 1 insertion()
> > 
> > diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
> > index d59525fca4d3..30737b5183c0 100644
> > --- a/include/linux/workqueue.h
> > ﯦﾊ眥맗뾖⧮쟼⢮䪮竧ꇣ为 ,7 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
> >   * RETURNS:
> >   * Pointer to the allocated workqueue on success, %NULL on failure.
> >   */
> > __printf(1, 4)
> >  struct workqueue_struct *alloc_workqueue(const char *fmt,
> >  					 unsigned int flags,
> >  					 int max_active, ...);
> 
> Ping?
> 
> Bart.

I'm not sure if your Cc list is really the right people to be reviewing
the patch. Wouldn't it make more sense to Cc the people who were on the
original patch that you are now fixing?

Re: [PATCH] kernel/workqueue: Verify alloc_workqueue() argument list consistency

[Tejun Heo]

On Tue, Mar 19, 2019 at 10:40:47AM -0700, Bart Van Assche wrote:
> This patch avoids that gcc reports the following warning when building
> with W=1:
> 
> kernel/workqueue.c:4250:2: warning: function alloc_workqueue might be a candidate for gnu_printf format attribute [-Wsuggest-attribute=format]
>   vsnprintf(wq->name, sizeof(wq->name), fmt, args);
> 
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Fixes: 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for workqueues")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Applied to wq/for-5.2.

Thanks.

-- 
tejun