* [PATCH 1/1] parted: change device manager check in ptest
@ 2019-04-16 21:34 Joe Slater
0 siblings, 0 replies; 6+ messages in thread
From: Joe Slater @ 2019-04-16 21:34 UTC (permalink / raw)
To: openembedded-core
t6001-psep should check for device manager the same way as
other ptests for parted -- look for an environment variable.
Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
meta/recipes-extended/parted/files/dm_check.patch | 22 ++++++++++++++++++++++
meta/recipes-extended/parted/parted_3.2.bb | 1 +
2 files changed, 23 insertions(+)
create mode 100644 meta/recipes-extended/parted/files/dm_check.patch
diff --git a/meta/recipes-extended/parted/files/dm_check.patch b/meta/recipes-extended/parted/files/dm_check.patch
new file mode 100644
index 0000000..bc0e95f
--- /dev/null
+++ b/meta/recipes-extended/parted/files/dm_check.patch
@@ -0,0 +1,22 @@
+parted: change check for device-manager
+
+Other ptests use this method.
+
+Upstream-Status: Pending
+
+Signed-off-by: Joe Slater <joe.slater@windriver.com>
+
+
+--- a/tests/t6001-psep.sh
++++ b/tests/t6001-psep.sh
+@@ -19,7 +19,9 @@
+ . "${srcdir=.}/init.sh"; path_prepend_ ../parted
+
+ require_root_
+-(dmsetup --help) > /dev/null 2>&1 || skip_test_ "No dmsetup installed"
++
++test "x$ENABLE_DEVICE_MAPPER" = xyes \
++ || skip_ "no device-mapper support"
+
+ # Device maps names - should be random to not conflict with existing ones on
+ # the system
diff --git a/meta/recipes-extended/parted/parted_3.2.bb b/meta/recipes-extended/parted/parted_3.2.bb
index 6189fd2..131e14b 100644
--- a/meta/recipes-extended/parted/parted_3.2.bb
+++ b/meta/recipes-extended/parted/parted_3.2.bb
@@ -19,6 +19,7 @@ SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
file://run-ptest \
file://Makefile \
file://0001-libparted-Use-read-only-when-probing-devices-on-linu.patch \
+ file://dm_check.patch \
"
SRC_URI[md5sum] = "0247b6a7b314f8edeb618159fa95f9cb"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] parted: change device manager check in ptest
2019-06-19 22:56 ` Slater, Joseph
@ 2019-06-19 23:01 ` richard.purdie
0 siblings, 0 replies; 6+ messages in thread
From: richard.purdie @ 2019-06-19 23:01 UTC (permalink / raw)
To: Slater, Joseph, openembedded-core
On Wed, 2019-06-19 at 22:56 +0000, Slater, Joseph wrote:
> Hm, I searched for parted development, and it looks like the last
> release was five years ago. We could have a long wait for this ptest
> fix.
They do still appear to be merging patches though:
http://git.savannah.gnu.org/cgit/parted.git/log/
so at least worth sending and then we can mark it as Submitted.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] parted: change device manager check in ptest
2019-06-19 21:56 ` Slater, Joseph
@ 2019-06-19 22:56 ` Slater, Joseph
2019-06-19 23:01 ` richard.purdie
0 siblings, 1 reply; 6+ messages in thread
From: Slater, Joseph @ 2019-06-19 22:56 UTC (permalink / raw)
To: Richard Purdie, openembedded-core
Hm, I searched for parted development, and it looks like the last release was five years ago. We could have a long wait for this ptest fix.
Joe
________________________________________
From: openembedded-core-bounces@lists.openembedded.org [openembedded-core-bounces@lists.openembedded.org] on behalf of Slater, Joseph [joe.slater@windriver.com]
Sent: Wednesday, June 19, 2019 2:56 PM
To: Richard Purdie; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [oe-core][PATCH 1/1] parted: change device manager check in ptest
I will send a patch upstream. Joe
________________________________________
From: Richard Purdie [richard.purdie@linuxfoundation.org]
Sent: Wednesday, June 19, 2019 2:39 PM
To: Slater, Joseph; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [oe-core][PATCH 1/1] parted: change device manager check in ptest
On Wed, 2019-06-19 at 14:26 -0700, Joe Slater wrote:
> t6001-psep should check for device manager the same way as
> other ptests for parted -- look for an environment variable.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
> meta/recipes-extended/parted/files/dm_check.patch | 22
> ++++++++++++++++++++++
> meta/recipes-extended/parted/parted_3.2.bb | 1 +
> 2 files changed, 23 insertions(+)
> create mode 100644 meta/recipes-extended/parted/files/dm_check.patch
>
> diff --git a/meta/recipes-extended/parted/files/dm_check.patch
> b/meta/recipes-extended/parted/files/dm_check.patch
> new file mode 100644
> index 0000000..bc0e95f
> --- /dev/null
> +++ b/meta/recipes-extended/parted/files/dm_check.patch
> @@ -0,0 +1,22 @@
> +parted: change check for device-manager
> +
> +Other ptests use this method.
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Joe Slater <joe.slater@windriver.com>
This sounds like something which should be an obvious/easy fix for
upstream, any chance we can submit it?
I'm hoping we can get our patch load down a bit so pushing obvious
things to upstream is good...
Cheers,
Richard
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] parted: change device manager check in ptest
2019-06-19 21:39 ` Richard Purdie
@ 2019-06-19 21:56 ` Slater, Joseph
2019-06-19 22:56 ` Slater, Joseph
0 siblings, 1 reply; 6+ messages in thread
From: Slater, Joseph @ 2019-06-19 21:56 UTC (permalink / raw)
To: Richard Purdie, openembedded-core
I will send a patch upstream. Joe
________________________________________
From: Richard Purdie [richard.purdie@linuxfoundation.org]
Sent: Wednesday, June 19, 2019 2:39 PM
To: Slater, Joseph; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [oe-core][PATCH 1/1] parted: change device manager check in ptest
On Wed, 2019-06-19 at 14:26 -0700, Joe Slater wrote:
> t6001-psep should check for device manager the same way as
> other ptests for parted -- look for an environment variable.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
> meta/recipes-extended/parted/files/dm_check.patch | 22
> ++++++++++++++++++++++
> meta/recipes-extended/parted/parted_3.2.bb | 1 +
> 2 files changed, 23 insertions(+)
> create mode 100644 meta/recipes-extended/parted/files/dm_check.patch
>
> diff --git a/meta/recipes-extended/parted/files/dm_check.patch
> b/meta/recipes-extended/parted/files/dm_check.patch
> new file mode 100644
> index 0000000..bc0e95f
> --- /dev/null
> +++ b/meta/recipes-extended/parted/files/dm_check.patch
> @@ -0,0 +1,22 @@
> +parted: change check for device-manager
> +
> +Other ptests use this method.
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Joe Slater <joe.slater@windriver.com>
This sounds like something which should be an obvious/easy fix for
upstream, any chance we can submit it?
I'm hoping we can get our patch load down a bit so pushing obvious
things to upstream is good...
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] parted: change device manager check in ptest
2019-06-19 21:26 Joe Slater
@ 2019-06-19 21:39 ` Richard Purdie
2019-06-19 21:56 ` Slater, Joseph
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2019-06-19 21:39 UTC (permalink / raw)
To: Joe Slater, openembedded-core
On Wed, 2019-06-19 at 14:26 -0700, Joe Slater wrote:
> t6001-psep should check for device manager the same way as
> other ptests for parted -- look for an environment variable.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
> meta/recipes-extended/parted/files/dm_check.patch | 22
> ++++++++++++++++++++++
> meta/recipes-extended/parted/parted_3.2.bb | 1 +
> 2 files changed, 23 insertions(+)
> create mode 100644 meta/recipes-extended/parted/files/dm_check.patch
>
> diff --git a/meta/recipes-extended/parted/files/dm_check.patch
> b/meta/recipes-extended/parted/files/dm_check.patch
> new file mode 100644
> index 0000000..bc0e95f
> --- /dev/null
> +++ b/meta/recipes-extended/parted/files/dm_check.patch
> @@ -0,0 +1,22 @@
> +parted: change check for device-manager
> +
> +Other ptests use this method.
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Joe Slater <joe.slater@windriver.com>
This sounds like something which should be an obvious/easy fix for
upstream, any chance we can submit it?
I'm hoping we can get our patch load down a bit so pushing obvious
things to upstream is good...
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] parted: change device manager check in ptest
@ 2019-06-19 21:26 Joe Slater
2019-06-19 21:39 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Joe Slater @ 2019-06-19 21:26 UTC (permalink / raw)
To: openembedded-core
t6001-psep should check for device manager the same way as
other ptests for parted -- look for an environment variable.
Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
meta/recipes-extended/parted/files/dm_check.patch | 22 ++++++++++++++++++++++
meta/recipes-extended/parted/parted_3.2.bb | 1 +
2 files changed, 23 insertions(+)
create mode 100644 meta/recipes-extended/parted/files/dm_check.patch
diff --git a/meta/recipes-extended/parted/files/dm_check.patch b/meta/recipes-extended/parted/files/dm_check.patch
new file mode 100644
index 0000000..bc0e95f
--- /dev/null
+++ b/meta/recipes-extended/parted/files/dm_check.patch
@@ -0,0 +1,22 @@
+parted: change check for device-manager
+
+Other ptests use this method.
+
+Upstream-Status: Pending
+
+Signed-off-by: Joe Slater <joe.slater@windriver.com>
+
+
+--- a/tests/t6001-psep.sh
++++ b/tests/t6001-psep.sh
+@@ -19,7 +19,9 @@
+ . "${srcdir=.}/init.sh"; path_prepend_ ../parted
+
+ require_root_
+-(dmsetup --help) > /dev/null 2>&1 || skip_test_ "No dmsetup installed"
++
++test "x$ENABLE_DEVICE_MAPPER" = xyes \
++ || skip_ "no device-mapper support"
+
+ # Device maps names - should be random to not conflict with existing ones on
+ # the system
diff --git a/meta/recipes-extended/parted/parted_3.2.bb b/meta/recipes-extended/parted/parted_3.2.bb
index 6189fd2..131e14b 100644
--- a/meta/recipes-extended/parted/parted_3.2.bb
+++ b/meta/recipes-extended/parted/parted_3.2.bb
@@ -19,6 +19,7 @@ SRC_URI = "${GNU_MIRROR}/parted/parted-${PV}.tar.xz \
file://run-ptest \
file://Makefile \
file://0001-libparted-Use-read-only-when-probing-devices-on-linu.patch \
+ file://dm_check.patch \
"
SRC_URI[md5sum] = "0247b6a7b314f8edeb618159fa95f9cb"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-19 23:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16 21:34 [PATCH 1/1] parted: change device manager check in ptest Joe Slater
2019-06-19 21:26 Joe Slater
2019-06-19 21:39 ` Richard Purdie
2019-06-19 21:56 ` Slater, Joseph
2019-06-19 22:56 ` Slater, Joseph
2019-06-19 23:01 ` richard.purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.