* [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected
@ 2019-04-18 13:25 Gwan-gyeong Mun
2019-04-18 14:18 ` ✗ Fi.CI.BAT: failure for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev2) Patchwork
2019-04-18 16:33 ` [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected Jani Nikula
0 siblings, 2 replies; 4+ messages in thread
From: Gwan-gyeong Mun @ 2019-04-18 13:25 UTC (permalink / raw)
To: intel-gfx; +Cc: daniel.vetter, dri-devel
The hotplug detection routine of drm_helper_hpd_irq_event() can detect
changing of status of connector, but it can not detect changing of
properties of the connector.
e.g. changing of edid while suspend/resume, changing of dp lanes in dp aux.
Following scenario explains one of them; A detection of changing of edid.
1) plug display device to a connector
2) system suspend
3) unplug 1)'s display device and plug the other display device to a
connector
4) system resume
To solve explained cases, It fires off KMS hotplug events if
drm_helper_probe_detect() says the connector is connected.
Testcase: igt/kms_chamelium/hdmi-edid-change-during-hibernate
Testcase: igt/kms_chamelium/hdmi-edid-change-during-suspend
Testcase: igt/kms_chamelium/dp-edid-change-during-hibernate
Testcase: igt/kms_chamelium/dp-edid-change-during-suspend
v2: Remove suggested-by line (danvet)
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Link: https://lists.freedesktop.org/archives/dri-devel/2019-April/214572.html
---
drivers/gpu/drm/drm_probe_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 6fd08e04b323..081a849104f2 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -780,7 +780,8 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
connector->name,
drm_get_connector_status_name(old_status),
drm_get_connector_status_name(connector->status));
- if (old_status != connector->status)
+ if (old_status != connector->status ||
+ connector->status == connector_status_connected)
changed = true;
}
drm_connector_list_iter_end(&conn_iter);
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev2)
2019-04-18 13:25 [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected Gwan-gyeong Mun
@ 2019-04-18 14:18 ` Patchwork
2019-04-18 16:33 ` [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected Jani Nikula
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-04-18 14:18 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: intel-gfx
== Series Details ==
Series: drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev2)
URL : https://patchwork.freedesktop.org/series/59691/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5952 -> Patchwork_12833
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12833 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_12833, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59691/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12833:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-byt-j1900: PASS -> DMESG-WARN
* igt@runner@aborted:
- fi-byt-j1900: NOTRUN -> FAIL
Known issues
------------
Here are the changes found in Patchwork_12833 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +50
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +52
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-y: PASS -> DMESG-WARN [fdo#109638]
* igt@i915_module_load@reload:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_module_load@reload-with-fault-injection:
- fi-bsw-n3050: PASS -> DMESG-WARN [fdo#107732]
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: PASS -> INCOMPLETE [fdo#108602] / [fdo#108744]
* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +51
* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-edid-read:
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] +46
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614] / [fdo#107814]
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@runner@aborted:
- fi-skl-iommu: NOTRUN -> FAIL [fdo#104108] / [fdo#108602]
- fi-bsw-n3050: NOTRUN -> FAIL [fdo#110446]
- fi-icl-dsi: NOTRUN -> FAIL [fdo#109593]
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109638]: https://bugs.freedesktop.org/show_bug.cgi?id=109638
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[fdo#110446]: https://bugs.freedesktop.org/show_bug.cgi?id=110446
Participating hosts (44 -> 44)
------------------------------
Additional (5): fi-hsw-peppy fi-icl-dsi fi-bsw-kefka fi-byt-n2820 fi-byt-clapper
Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5952 -> Patchwork_12833
CI_DRM_5952: 65305a057be0e155321a0765a3a24115063f3a32 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4956: 1d921615b0b706f25c856aa0eb096f274380c199 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12833: 7999ff634db78467fc5368f6a5b789f04afe803a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7999ff634db7 drm: Fire off KMS hotplug events if probe detect says the connector is connected
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12833/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected
2019-04-18 13:25 [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected Gwan-gyeong Mun
2019-04-18 14:18 ` ✗ Fi.CI.BAT: failure for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev2) Patchwork
@ 2019-04-18 16:33 ` Jani Nikula
2019-04-20 14:43 ` Mun, Gwan-gyeong
1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2019-04-18 16:33 UTC (permalink / raw)
To: Gwan-gyeong Mun, intel-gfx; +Cc: daniel.vetter, dri-devel
On Thu, 18 Apr 2019, Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> wrote:
> The hotplug detection routine of drm_helper_hpd_irq_event() can detect
> changing of status of connector, but it can not detect changing of
> properties of the connector.
> e.g. changing of edid while suspend/resume, changing of dp lanes in dp aux.
>
> Following scenario explains one of them; A detection of changing of edid.
>
> 1) plug display device to a connector
> 2) system suspend
> 3) unplug 1)'s display device and plug the other display device to a
> connector
> 4) system resume
>
> To solve explained cases, It fires off KMS hotplug events if
> drm_helper_probe_detect() says the connector is connected.
>
> Testcase: igt/kms_chamelium/hdmi-edid-change-during-hibernate
> Testcase: igt/kms_chamelium/hdmi-edid-change-during-suspend
> Testcase: igt/kms_chamelium/dp-edid-change-during-hibernate
> Testcase: igt/kms_chamelium/dp-edid-change-during-suspend
>
> v2: Remove suggested-by line (danvet)
> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Link: https://lists.freedesktop.org/archives/dri-devel/2019-April/214572.html
Link: is something added by our tooling (dim), not to be added
yourself. It points at the patch at patchwork using the message-id of
the patch email.
If you want to refer to some other work, please use References: tag.
BR,
Jani.
> ---
> drivers/gpu/drm/drm_probe_helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
> index 6fd08e04b323..081a849104f2 100644
> --- a/drivers/gpu/drm/drm_probe_helper.c
> +++ b/drivers/gpu/drm/drm_probe_helper.c
> @@ -780,7 +780,8 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
> connector->name,
> drm_get_connector_status_name(old_status),
> drm_get_connector_status_name(connector->status));
> - if (old_status != connector->status)
> + if (old_status != connector->status ||
> + connector->status == connector_status_connected)
> changed = true;
> }
> drm_connector_list_iter_end(&conn_iter);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected
2019-04-18 16:33 ` [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected Jani Nikula
@ 2019-04-20 14:43 ` Mun, Gwan-gyeong
0 siblings, 0 replies; 4+ messages in thread
From: Mun, Gwan-gyeong @ 2019-04-20 14:43 UTC (permalink / raw)
To: Jani Nikula; +Cc: daniel.vetter, intel-gfx, dri-devel
On Thu, Apr 18, 2019 at 7:33 PM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Thu, 18 Apr 2019, Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> wrote:
> > The hotplug detection routine of drm_helper_hpd_irq_event() can detect
> > changing of status of connector, but it can not detect changing of
> > properties of the connector.
> > e.g. changing of edid while suspend/resume, changing of dp lanes in dp aux.
> >
> > Following scenario explains one of them; A detection of changing of edid.
> >
> > 1) plug display device to a connector
> > 2) system suspend
> > 3) unplug 1)'s display device and plug the other display device to a
> > connector
> > 4) system resume
> >
> > To solve explained cases, It fires off KMS hotplug events if
> > drm_helper_probe_detect() says the connector is connected.
> >
> > Testcase: igt/kms_chamelium/hdmi-edid-change-during-hibernate
> > Testcase: igt/kms_chamelium/hdmi-edid-change-during-suspend
> > Testcase: igt/kms_chamelium/dp-edid-change-during-hibernate
> > Testcase: igt/kms_chamelium/dp-edid-change-during-suspend
> >
> > v2: Remove suggested-by line (danvet)
> > Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> > Link: https://lists.freedesktop.org/archives/dri-devel/2019-April/214572.html
>
> Link: is something added by our tooling (dim), not to be added
> yourself. It points at the patch at patchwork using the message-id of
> the patch email.
>
> If you want to refer to some other work, please use References: tag.
>
> BR,
> Jani.
>
>
Hi,
Sorry for misusing of that. I didn't know that.
I'll replace Link to References and resend the patch as soon as possible.
Thank you for letting me know that.
Br,
G.G.
> > ---
> > drivers/gpu/drm/drm_probe_helper.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
> > index 6fd08e04b323..081a849104f2 100644
> > --- a/drivers/gpu/drm/drm_probe_helper.c
> > +++ b/drivers/gpu/drm/drm_probe_helper.c
> > @@ -780,7 +780,8 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
> > connector->name,
> > drm_get_connector_status_name(old_status),
> > drm_get_connector_status_name(connector->status));
> > - if (old_status != connector->status)
> > + if (old_status != connector->status ||
> > + connector->status == connector_status_connected)
> > changed = true;
> > }
> > drm_connector_list_iter_end(&conn_iter);
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Gwan-gyeong Mun
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-20 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18 13:25 [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected Gwan-gyeong Mun
2019-04-18 14:18 ` ✗ Fi.CI.BAT: failure for drm: Fire off KMS hotplug events if probe detect says the connector is connected (rev2) Patchwork
2019-04-18 16:33 ` [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected Jani Nikula
2019-04-20 14:43 ` Mun, Gwan-gyeong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.