From: Thomas Huth <thuth@redhat.com> To: yang.zhong@intel.com, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, pbonzini@redhat.com Cc: Beniamino Galvani <b.galvani@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Antony Pavlov <antonynpavlov@gmail.com>, Peter Chubb <peter.chubb@nicta.com.au>, qemu-block@nongnu.org, Cedric Le Goater <clg@kaod.org>, "Michael S. Tsirkin" <mst@redhat.com>, Andrew Jeffery <andrew@aj.id.au>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, Rob Herring <robh@kernel.org>, qemu-arm@nongnu.org, Andrzej Zaborowski <balrogg@gmail.com>, John Snow <jsnow@redhat.com>, Joel Stanley <joel@jms.id.au>, "Edgar E . Iglesias" <edgar.iglesias@gmail.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Philippe Mathieu-Daude <f4bug@amsat.org>, Alistair Francis <alistair@alistair23.me>, Subbaraya Sundeep <sundeep.lkml@gmail.com>, Gerd Hoffmann <kraxel@redhat.com> Subject: [Qemu-devel] [PATCH for-QEMU-4.1 v5 01/29] hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs Date: Thu, 18 Apr 2019 20:00:29 +0200 [thread overview] Message-ID: <20190418180057.3593-2-thuth@redhat.com> (raw) In-Reply-To: <20190418180057.3593-1-thuth@redhat.com> Some machines have an AHCI adapter, but no PCI. To be able to compile hw/ide/ahci.c without CONFIG_PCI, we still need the two functions msi_enabled() and msi_notify() for linking. This is required for the new Kconfig-like build system, if a user wants to compile a QEMU binary with just one machine that has AHCI, but no PCI, like the ARM "cubieboard" for example. Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/pci/pci-stub.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index b941a0e842..c04a5df651 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -53,3 +53,14 @@ uint16_t pci_requester_id(PCIDevice *dev) g_assert(false); return 0; } + +/* Required by ahci.c */ +bool msi_enabled(const PCIDevice *dev) +{ + return false; +} + +void msi_notify(PCIDevice *dev, unsigned int vector) +{ + g_assert_not_reached(); +} -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com> To: yang.zhong@intel.com, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, pbonzini@redhat.com Cc: "Michael S. Tsirkin" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Edgar E . Iglesias" <edgar.iglesias@gmail.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Rob Herring <robh@kernel.org>, qemu-block@nongnu.org, Andrey Smirnov <andrew.smirnov@gmail.com>, Joel Stanley <joel@jms.id.au>, Antony Pavlov <antonynpavlov@gmail.com>, Alistair Francis <alistair@alistair23.me>, Beniamino Galvani <b.galvani@gmail.com>, qemu-arm@nongnu.org, Peter Chubb <peter.chubb@nicta.com.au>, Cedric Le Goater <clg@kaod.org>, John Snow <jsnow@redhat.com>, Andrew Jeffery <andrew@aj.id.au>, Philippe Mathieu-Daude <f4bug@amsat.org>, Subbaraya Sundeep <sundeep.lkml@gmail.com>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Jan Kiszka <jan.kiszka@web.de> Subject: [Qemu-devel] [PATCH for-QEMU-4.1 v5 01/29] hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs Date: Thu, 18 Apr 2019 20:00:29 +0200 [thread overview] Message-ID: <20190418180057.3593-2-thuth@redhat.com> (raw) Message-ID: <20190418180029.ybZXvwlhFo2aTCsuq88yY7m6Wm2Rmrn4j31RdYpFtJY@z> (raw) In-Reply-To: <20190418180057.3593-1-thuth@redhat.com> Some machines have an AHCI adapter, but no PCI. To be able to compile hw/ide/ahci.c without CONFIG_PCI, we still need the two functions msi_enabled() and msi_notify() for linking. This is required for the new Kconfig-like build system, if a user wants to compile a QEMU binary with just one machine that has AHCI, but no PCI, like the ARM "cubieboard" for example. Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/pci/pci-stub.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index b941a0e842..c04a5df651 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -53,3 +53,14 @@ uint16_t pci_requester_id(PCIDevice *dev) g_assert(false); return 0; } + +/* Required by ahci.c */ +bool msi_enabled(const PCIDevice *dev) +{ + return false; +} + +void msi_notify(PCIDevice *dev, unsigned int vector) +{ + g_assert_not_reached(); +} -- 2.21.0
next prev parent reply other threads:[~2019-04-18 18:01 UTC|newest] Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-18 18:00 [Qemu-devel] [PATCH for-QEMU-4.1 v5 00/29] Kconfig dependencies for ARM machines Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-18 18:00 ` Thomas Huth [this message] 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 01/29] hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs Thomas Huth 2019-04-25 14:06 ` Philippe Mathieu-Daudé 2019-04-25 14:06 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 02/29] hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-20 10:31 ` Philippe Mathieu-Daudé 2019-04-20 10:31 ` Philippe Mathieu-Daudé 2019-04-25 13:19 ` Philippe Mathieu-Daudé 2019-04-25 13:19 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 03/29] hw/usb/hcd-ohci: Move PCI-related code into a separate file Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 04/29] hw/arm: Express dependencies of the exynos machines with Kconfig Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 14:23 ` Philippe Mathieu-Daudé 2019-04-25 14:23 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 05/29] hw/arm: Express dependencies of the highbank " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 14:25 ` Philippe Mathieu-Daudé 2019-04-25 14:25 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 06/29] hw/arm: Express dependencies of integratorcp " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 14:14 ` Philippe Mathieu-Daudé 2019-04-25 14:14 ` Philippe Mathieu-Daudé 2019-04-25 14:22 ` Philippe Mathieu-Daudé 2019-04-25 14:22 ` Philippe Mathieu-Daudé 2019-04-25 14:29 ` Thomas Huth 2019-04-25 14:29 ` Thomas Huth 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 07/29] hw/arm: Express dependencies of the fsl-imx31 machine " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-19 3:58 ` Chubb, Peter (Data61, Kensington NSW) 2019-04-19 3:58 ` Chubb, Peter (Data61, Kensington NSW) 2019-04-25 14:27 ` Philippe Mathieu-Daudé 2019-04-25 14:27 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 08/29] hw/arm: Express dependencies of musicpal " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 16:05 ` Philippe Mathieu-Daudé 2019-04-25 16:05 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 09/29] hw/arm: Express dependencies of the OMAP machines " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 22:41 ` Philippe Mathieu-Daudé 2019-04-25 22:41 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 10/29] hw/arm: Express dependencies of stellaris " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 21:41 ` Philippe Mathieu-Daudé 2019-04-25 21:41 ` Philippe Mathieu-Daudé 2019-04-29 19:25 ` Thomas Huth 2019-04-29 19:25 ` Thomas Huth 2019-04-29 20:56 ` Philippe Mathieu-Daudé 2019-04-29 20:56 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 11/29] hw/arm: Express dependencies of realview, versatile and vexpress " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 22:28 ` Philippe Mathieu-Daudé 2019-04-25 22:28 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 12/29] hw/arm: Express dependencies of the PXA2xx machines " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 16:03 ` Philippe Mathieu-Daudé 2019-04-25 16:03 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 13/29] hw/arm: Express dependencies of xilinx-zynq " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-19 21:09 ` Alistair Francis 2019-04-19 21:09 ` Alistair Francis 2019-04-25 16:17 ` Philippe Mathieu-Daudé 2019-04-25 16:17 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 14/29] hw/arm: Express dependencies of collie " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 15:58 ` Philippe Mathieu-Daudé 2019-04-25 15:58 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 15/29] hw/arm: Express dependencies of the aspeed boards " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-19 8:12 ` Cédric Le Goater 2019-04-19 8:12 ` Cédric Le Goater 2019-04-25 16:25 ` Philippe Mathieu-Daudé 2019-04-25 16:25 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 16/29] hw/arm: Express dependencies of the virt machine " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 15:53 ` Philippe Mathieu-Daudé 2019-04-25 15:53 ` Philippe Mathieu-Daudé 2019-04-29 15:34 ` Thomas Huth 2019-04-29 15:34 ` Thomas Huth 2019-04-29 15:53 ` Peter Maydell 2019-04-29 15:53 ` Peter Maydell 2019-04-29 16:02 ` Thomas Huth 2019-04-29 16:02 ` Thomas Huth 2019-04-29 16:06 ` Philippe Mathieu-Daudé 2019-04-29 16:06 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 17/29] hw/arm: Express dependencies of netduino / stm32f2xx " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 21:27 ` Philippe Mathieu-Daudé 2019-04-25 21:27 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 18/29] hw/arm: Express dependencies of allwinner / cubieboard " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 15:57 ` Philippe Mathieu-Daudé 2019-04-25 15:57 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 19/29] hw/arm: Express dependencies of the MPS2 boards " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 21:53 ` Philippe Mathieu-Daudé 2019-04-25 21:53 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 20/29] hw/arm: Express dependencies of the raspi machines " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-19 21:12 ` Alistair Francis 2019-04-19 21:12 ` Alistair Francis 2019-04-25 15:54 ` Philippe Mathieu-Daudé 2019-04-25 15:54 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 21/29] hw/arm: Express dependencies of canon-a1100 " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 22/29] hw/arm: Express dependencies of sabrelite " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 16:43 ` Philippe Mathieu-Daudé 2019-04-25 16:43 ` Philippe Mathieu-Daudé 2019-04-29 16:11 ` Thomas Huth 2019-04-29 16:11 ` Thomas Huth 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 23/29] hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-20 10:52 ` Philippe Mathieu-Daudé 2019-04-20 10:52 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 24/29] hw/arm: Express dependencies for remaining IMX boards " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 16:13 ` Philippe Mathieu-Daudé 2019-04-25 16:13 ` Philippe Mathieu-Daudé 2019-04-25 16:28 ` Philippe Mathieu-Daudé 2019-04-25 16:28 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 25/29] hw/arm: Express dependencies of the microbit / nrf51 machine " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-19 21:13 ` Alistair Francis 2019-04-19 21:13 ` Alistair Francis 2019-04-25 21:27 ` Philippe Mathieu-Daudé 2019-04-25 21:27 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 26/29] hw/arm: Express dependencies of the ZynqMP zcu102 " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-19 21:12 ` Alistair Francis 2019-04-19 21:12 ` Alistair Francis 2019-04-25 16:23 ` Philippe Mathieu-Daudé 2019-04-25 16:23 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 27/29] hw/arm: Express dependencies of the xlnx-versal-virt " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 16:15 ` Philippe Mathieu-Daudé 2019-04-25 16:15 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 28/29] hw/arm: Express dependencies of the musca machines " Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 21:51 ` Philippe Mathieu-Daudé 2019-04-25 21:51 ` Philippe Mathieu-Daudé 2019-04-18 18:00 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 29/29] hw/arm: Remove hard-enablement of the remaining PCI devices Thomas Huth 2019-04-18 18:00 ` Thomas Huth 2019-04-25 22:51 ` [Qemu-devel] [PATCH for-QEMU-4.1 v5 00/29] Kconfig dependencies for ARM machines Philippe Mathieu-Daudé 2019-04-25 22:51 ` Philippe Mathieu-Daudé
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190418180057.3593-2-thuth@redhat.com \ --to=thuth@redhat.com \ --cc=alistair@alistair23.me \ --cc=andrew.smirnov@gmail.com \ --cc=andrew@aj.id.au \ --cc=antonynpavlov@gmail.com \ --cc=b.galvani@gmail.com \ --cc=balrogg@gmail.com \ --cc=clg@kaod.org \ --cc=edgar.iglesias@gmail.com \ --cc=f4bug@amsat.org \ --cc=i.mitsyanko@gmail.com \ --cc=jan.kiszka@web.de \ --cc=jcd@tribudubois.net \ --cc=joel@jms.id.au \ --cc=jsnow@redhat.com \ --cc=kraxel@redhat.com \ --cc=marcel.apfelbaum@gmail.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.chubb@nicta.com.au \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=robh@kernel.org \ --cc=sundeep.lkml@gmail.com \ --cc=yang.zhong@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.