From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: <bbrezillon@kernel.org>, <richard@nod.at>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <marek.vasut@gmail.com>,
<paul@crapouillou.net>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH -next] mtd: rawnand: ingenic: Add missing MODULE_* information
Date: Thu, 18 Apr 2019 18:14:15 +0200 [thread overview]
Message-ID: <20190418181415.221b5c0a@xps13> (raw)
In-Reply-To: <20190404104711.23560-1-yuehaibing@huawei.com>
Hi Yue,
Yue Haibing <yuehaibing@huawei.com> wrote on Thu, 4 Apr 2019 18:47:11
+0800:
> From: YueHaibing <yuehaibing@huawei.com>
>
> gcc warning this:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/raw/ingenic/ingenic_ecc.o
>
> Add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 9df5741a577e ("mtd: rawnand: ingenic: Separate top-level and SoC specific code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> index 7b07a6a..77e996e 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> @@ -158,3 +158,8 @@ int ingenic_ecc_probe(struct platform_device *pdev)
> return 0;
> }
> EXPORT_SYMBOL(ingenic_ecc_probe);
> +
> +MODULE_AUTHOR("Alex Smith <alex@alex-smith.me.uk>");
> +MODULE_AUTHOR("Harvey Hunt <harveyhuntnexus@gmail.com>");
> +MODULE_DESCRIPTION("Ingenic ECC common driver");
> +MODULE_LICENSE("GPL v2");
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
branch nand/next.
Thanks,
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: bbrezillon@kernel.org, richard@nod.at,
linux-kernel@vger.kernel.org, paul@crapouillou.net,
marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH -next] mtd: rawnand: ingenic: Add missing MODULE_* information
Date: Thu, 18 Apr 2019 18:14:15 +0200 [thread overview]
Message-ID: <20190418181415.221b5c0a@xps13> (raw)
In-Reply-To: <20190404104711.23560-1-yuehaibing@huawei.com>
Hi Yue,
Yue Haibing <yuehaibing@huawei.com> wrote on Thu, 4 Apr 2019 18:47:11
+0800:
> From: YueHaibing <yuehaibing@huawei.com>
>
> gcc warning this:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/raw/ingenic/ingenic_ecc.o
>
> Add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 9df5741a577e ("mtd: rawnand: ingenic: Separate top-level and SoC specific code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> index 7b07a6a..77e996e 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c
> @@ -158,3 +158,8 @@ int ingenic_ecc_probe(struct platform_device *pdev)
> return 0;
> }
> EXPORT_SYMBOL(ingenic_ecc_probe);
> +
> +MODULE_AUTHOR("Alex Smith <alex@alex-smith.me.uk>");
> +MODULE_AUTHOR("Harvey Hunt <harveyhuntnexus@gmail.com>");
> +MODULE_DESCRIPTION("Ingenic ECC common driver");
> +MODULE_LICENSE("GPL v2");
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
branch nand/next.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-04-18 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 10:47 [PATCH -next] mtd: rawnand: ingenic: Add missing MODULE_* information Yue Haibing
2019-04-04 10:47 ` Yue Haibing
2019-04-18 16:14 ` Miquel Raynal [this message]
2019-04-18 16:14 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418181415.221b5c0a@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.