* [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")
@ 2019-04-17 22:16 Taras Kondratiuk
2019-04-18 13:46 ` Sasha Levin
0 siblings, 1 reply; 4+ messages in thread
From: Taras Kondratiuk @ 2019-04-17 22:16 UTC (permalink / raw)
To: stable; +Cc: Miklos Szeredi, Amir Goldstein, xe-linux-external
Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
patch has a few follow up fixes in upstream that also have to be applied
to 4.4:
d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2
The first patch should fix v4.4.156 regression reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=201633.
Rest of stable kernels (4.9+) already have these followup fixes.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")
2019-04-17 22:16 [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter") Taras Kondratiuk
@ 2019-04-18 13:46 ` Sasha Levin
2019-04-18 18:19 ` Taras Kondratiuk
0 siblings, 1 reply; 4+ messages in thread
From: Sasha Levin @ 2019-04-18 13:46 UTC (permalink / raw)
To: Taras Kondratiuk
Cc: stable, Miklos Szeredi, Amir Goldstein, xe-linux-external
On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote:
>Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
>the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
>patch has a few follow up fixes in upstream that also have to be applied
>to 4.4:
>d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
>8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2
The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96
and 51f8f3c4e225.
I've queued up d0e13f5bbe4b for 4.4.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")
2019-04-18 13:46 ` Sasha Levin
@ 2019-04-18 18:19 ` Taras Kondratiuk
2019-04-18 19:18 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Taras Kondratiuk @ 2019-04-18 18:19 UTC (permalink / raw)
To: Sasha Levin; +Cc: stable, Miklos Szeredi, Amir Goldstein, xe-linux-external
Quoting Sasha Levin (2019-04-18 06:46:12)
> On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote:
> >Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
> >the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
> >patch has a few follow up fixes in upstream that also have to be applied
> >to 4.4:
> >d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
> >8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2
>
> The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96
> and 51f8f3c4e225.
The context is slightly modified by 51f8f3c4e225, but it looks
irrelevant. The fix should be still valid, because err value can be set
to PTR_ERR(mnt) above and when prepare_creds() fails ovl_fill_super()
will return a random value of mnt pointer instead of a proper error
code.
>
> I've queued up d0e13f5bbe4b for 4.4.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter")
2019-04-18 18:19 ` Taras Kondratiuk
@ 2019-04-18 19:18 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-04-18 19:18 UTC (permalink / raw)
To: Taras Kondratiuk
Cc: Sasha Levin, stable, Miklos Szeredi, Amir Goldstein, xe-linux-external
On Thu, Apr 18, 2019 at 11:19:32AM -0700, Taras Kondratiuk wrote:
> Quoting Sasha Levin (2019-04-18 06:46:12)
> > On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote:
> > >Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from
> > >the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the
> > >patch has a few follow up fixes in upstream that also have to be applied
> > >to 4.4:
> > >d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4
> > >8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2
> >
> > The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96
> > and 51f8f3c4e225.
>
> The context is slightly modified by 51f8f3c4e225, but it looks
> irrelevant. The fix should be still valid, because err value can be set
> to PTR_ERR(mnt) above and when prepare_creds() fails ovl_fill_super()
> will return a random value of mnt pointer instead of a proper error
> code.
Can you provide a working backport please, so that it can be applied?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-19 18:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 22:16 [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter") Taras Kondratiuk
2019-04-18 13:46 ` Sasha Levin
2019-04-18 18:19 ` Taras Kondratiuk
2019-04-18 19:18 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.