All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: l.stach@pengutronix.de, peng.fan@nxp.com, shawnguo@kernel.org,
	srinivas.kandagatla@linaro.org, leonard.crestez@nxp.com
Cc: aisheng.dong@nxp.com, abel.vesa@nxp.com, anson.huang@nxp.com,
	linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com,
	Bryan O'Donoghue <pure.logic@nexus-software.ie>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] nvmem: imx-ocotp: Ensure the RELAX field is non-zero
Date: Fri, 19 Apr 2019 11:03:26 +0100	[thread overview]
Message-ID: <20190419100327.31483-6-pure.logic@nexus-software.ie> (raw)
In-Reply-To: <20190419100327.31483-1-pure.logic@nexus-software.ie>

The RELAX field of the OCOTP block quote "specifies the time to add to all
default timing parameters other than the Tpgm and Trd. It is given in
number of ipg_clk periods".

On the i.MX8MM the calculation for the RELAX value is turning out to be
zero which is not a problem for programming OTP values but, does
subsequently mess up reloading the OTP shadow registers.

This patch ensures the RELAX field is at least one ipg_clk cycle, which
seems like a pretty obvious floor to place on a value such as this.

Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
---
 drivers/nvmem/imx-ocotp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index 840d939f792b..458586295518 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -191,6 +191,8 @@ static void imx_ocotp_set_imx6_timing(struct ocotp_priv *priv)
 	clk_rate = clk_get_rate(priv->clk);
 
 	relax = clk_rate / (1000000000 / DEF_RELAX) - 1;
+	if (!relax)
+		relax = 1;
 	strobe_prog = clk_rate / (1000000000 / 10000) + 2 * (DEF_RELAX + 1) - 1;
 	strobe_read = clk_rate / (1000000000 / 40) + 2 * (DEF_RELAX + 1) - 1;
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-04-19 10:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19 10:03 [PATCH 0/6] Add i.MX8MM support Bryan O'Donoghue
2019-04-19 10:03 ` [PATCH 1/6] nvmem: imx-ocotp: Allow selection of OCOTP for imx8 processors Bryan O'Donoghue
2019-04-19 10:03 ` [PATCH 2/6] nvmem: imx-ocotp: Fix i.MX OC-OTP naming prompt Bryan O'Donoghue
2019-04-19 10:03 ` [PATCH 3/6] nvmem: imx-ocotp: Add i.MX8MM support Bryan O'Donoghue
2019-04-19 10:32   ` Leonard Crestez
2019-04-19 11:48     ` Bryan O'Donoghue
2019-04-19 16:45       ` Bryan O'Donoghue
2019-04-19 10:03 ` [PATCH 4/6] nvmem: imx-ocotp: Ensure WAIT bits are preserved when setting timing Bryan O'Donoghue
2019-04-19 10:03 ` Bryan O'Donoghue [this message]
2019-04-19 10:03 ` [PATCH 6/6] dt-bindings: imx-ocotp: Add i.MX8MM support Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419100327.31483-6-pure.logic@nexus-software.ie \
    --to=pure.logic@nexus-software.ie \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=peng.fan@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.