* [bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
@ 2019-04-19 16:14 rjmccabe3701
0 siblings, 0 replies; 2+ messages in thread
From: rjmccabe3701 @ 2019-04-19 16:14 UTC (permalink / raw)
To: netdev; +Cc: robert.mccabe, robertjmccabe, McCabe, Robert J
From: "McCabe, Robert J" <Robert.McCabe@rockwellcollins.com>
The BPF_PROG_LOAD condition for kernel version <= 5.1 is
log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
Signed-off-by: rjmccabe3701 <robert.mccabe@rockwellcollins.com>
---
tools/lib/bpf/bpf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index bc30783d1403..62d67caa7aea 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -92,7 +92,7 @@ struct bpf_load_program_attr {
#define MAPS_RELAX_COMPAT 0x01
/* Recommend log buffer size */
-#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
+#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */
LIBBPF_API int
bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr,
char *log_buf, size_t log_buf_sz);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
@ 2019-04-19 16:21 rjmccabe3701
0 siblings, 0 replies; 2+ messages in thread
From: rjmccabe3701 @ 2019-04-19 16:21 UTC (permalink / raw)
To: netdev; +Cc: robert.mccabe, robertjmccabe, McCabe, Robert J
From: "McCabe, Robert J" <Robert.McCabe@rockwellcollins.com>
The BPF_PROG_LOAD condition for kernel version <= 5.1 is
log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
Signed-off-by: rjmccabe3701 <robert.mccabe@rockwellcollins.com>
---
tools/lib/bpf/bpf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index bc30783d1403..62d67caa7aea 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -92,7 +92,7 @@ struct bpf_load_program_attr {
#define MAPS_RELAX_COMPAT 0x01
/* Recommend log buffer size */
-#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
+#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */
LIBBPF_API int
bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr,
char *log_buf, size_t log_buf_sz);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-19 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 16:14 [bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error rjmccabe3701
2019-04-19 16:21 rjmccabe3701
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.