All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] fuse: document fuse_fsync_in.fsync_flags
@ 2019-04-19 21:42 asomers
  2019-04-19 21:42 ` [PATCH 2/3] fuse: fix changelog entry for protocol 7.12 asomers
  2019-04-19 21:42 ` [PATCH 3/3] fuse: fix changelog entry for protocol 7.9 asomers
  0 siblings, 2 replies; 3+ messages in thread
From: asomers @ 2019-04-19 21:42 UTC (permalink / raw)
  To: Miklos Szeredi, linux-fsdevel, Nikolaus; +Cc: Alan Somers

From: Alan Somers <asomers@FreeBSD.org>

The FUSE_FSYNC_DATASYNC flag was introduced by commit b6aeadeda22a as a
magic number.  No new values have been added to fsync_flags since.

Signed-off-by: Alan Somers <asomers@FreeBSD.org>
---
 fs/fuse/file.c            | 2 +-
 include/uapi/linux/fuse.h | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 06096b60f1df..6d8dd7035912 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -462,7 +462,7 @@ int fuse_fsync_common(struct file *file, loff_t start, loff_t end,
 
 	memset(&inarg, 0, sizeof(inarg));
 	inarg.fh = ff->fh;
-	inarg.fsync_flags = datasync ? 1 : 0;
+	inarg.fsync_flags = datasync ? FUSE_FSYNC_FDATASYNC : 0;
 	args.in.h.opcode = opcode;
 	args.in.h.nodeid = get_node_id(inode);
 	args.in.numargs = 1;
diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h
index 2ac598614a8f..e4ceeb406eb3 100644
--- a/include/uapi/linux/fuse.h
+++ b/include/uapi/linux/fuse.h
@@ -353,6 +353,13 @@ struct fuse_file_lock {
  */
 #define FUSE_POLL_SCHEDULE_NOTIFY (1 << 0)
 
+/**
+ * Fsync flags
+ *
+ * FUSE_FSYNC_FDATASYNC: Sync data only, not metadata
+ */
+#define FUSE_FSYNC_FDATASYNC	(1 << 0)
+
 enum fuse_opcode {
 	FUSE_LOOKUP		= 1,
 	FUSE_FORGET		= 2,  /* no reply */
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/3] fuse: fix changelog entry for protocol 7.12
  2019-04-19 21:42 [PATCH 1/3] fuse: document fuse_fsync_in.fsync_flags asomers
@ 2019-04-19 21:42 ` asomers
  2019-04-19 21:42 ` [PATCH 3/3] fuse: fix changelog entry for protocol 7.9 asomers
  1 sibling, 0 replies; 3+ messages in thread
From: asomers @ 2019-04-19 21:42 UTC (permalink / raw)
  To: Miklos Szeredi, linux-fsdevel, Nikolaus; +Cc: Alan Somers

From: Alan Somers <asomers@FreeBSD.org>

This was a mistake in the comment in commit e0a43ddcc08c.

Signed-off-by: Alan Somers <asomers@FreeBSD.org>
---
 include/uapi/linux/fuse.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h
index e4ceeb406eb3..6457036a5960 100644
--- a/include/uapi/linux/fuse.h
+++ b/include/uapi/linux/fuse.h
@@ -54,7 +54,7 @@
  *  - add POLL message and NOTIFY_POLL notification
  *
  * 7.12
- *  - add umask flag to input argument of open, mknod and mkdir
+ *  - add umask flag to input argument of create, mknod and mkdir
  *  - add notification messages for invalidation of inodes and
  *    directory entries
  *
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 3/3] fuse: fix changelog entry for protocol 7.9
  2019-04-19 21:42 [PATCH 1/3] fuse: document fuse_fsync_in.fsync_flags asomers
  2019-04-19 21:42 ` [PATCH 2/3] fuse: fix changelog entry for protocol 7.12 asomers
@ 2019-04-19 21:42 ` asomers
  1 sibling, 0 replies; 3+ messages in thread
From: asomers @ 2019-04-19 21:42 UTC (permalink / raw)
  To: Miklos Szeredi, linux-fsdevel, Nikolaus; +Cc: Alan Somers

From: Alan Somers <asomers@FreeBSD.org>

Retroactively add changelog entry for the atime and mtime "now" flags.
This was an oversight in commit 17637cbaba592

Signed-off-by: Alan Somers <asomers@FreeBSD.org>
---
 include/uapi/linux/fuse.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h
index 6457036a5960..35f556d1d5d2 100644
--- a/include/uapi/linux/fuse.h
+++ b/include/uapi/linux/fuse.h
@@ -44,6 +44,7 @@
  *  - add lock_owner field to fuse_setattr_in, fuse_read_in and fuse_write_in
  *  - add blksize field to fuse_attr
  *  - add file flags field to fuse_read_in and fuse_write_in
+ *  - Add ATIME_NOW and MTIME_NOW flags to fuse_setattr_in
  *
  * 7.10
  *  - add nonseekable open flag
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-19 21:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 21:42 [PATCH 1/3] fuse: document fuse_fsync_in.fsync_flags asomers
2019-04-19 21:42 ` [PATCH 2/3] fuse: fix changelog entry for protocol 7.12 asomers
2019-04-19 21:42 ` [PATCH 3/3] fuse: fix changelog entry for protocol 7.9 asomers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.