* [Buildroot] [PATCH 1/2] package/neon: add NLS dependencies
@ 2019-04-20 10:25 Fabrice Fontaine
2019-04-20 10:25 ` [Buildroot] [PATCH 2/2] package/davfs2: add optional dependency on iconv and NLS Fabrice Fontaine
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2019-04-20 10:25 UTC (permalink / raw)
To: buildroot
neon checks for bind_textdomain_codeset
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/neon/neon.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/neon/neon.mk b/package/neon/neon.mk
index 1b8eb368c2..6b9e90d8d6 100644
--- a/package/neon/neon.mk
+++ b/package/neon/neon.mk
@@ -11,7 +11,7 @@ NEON_LICENSE_FILES = src/COPYING.LIB test/COPYING README
NEON_INSTALL_STAGING = YES
NEON_CONF_OPTS = --without-gssapi --disable-rpath
NEON_CONFIG_SCRIPTS = neon-config
-NEON_DEPENDENCIES = host-pkgconf
+NEON_DEPENDENCIES = host-pkgconf $(TARGET_NLS_DEPENDENCIES)
ifeq ($(BR2_PACKAGE_NEON_ZLIB),y)
NEON_CONF_OPTS += --with-zlib=$(STAGING_DIR)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] package/davfs2: add optional dependency on iconv and NLS
2019-04-20 10:25 [Buildroot] [PATCH 1/2] package/neon: add NLS dependencies Fabrice Fontaine
@ 2019-04-20 10:25 ` Fabrice Fontaine
2019-04-22 20:30 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2019-04-20 10:25 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/ac2c39a7300fbdd069ac5504148ccb2b065fbf8e
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/davfs2/0002-fix-iconv.patch | 48 +++++++++++++++++++++++++++++
package/davfs2/davfs2.mk | 8 +++--
2 files changed, 54 insertions(+), 2 deletions(-)
create mode 100644 package/davfs2/0002-fix-iconv.patch
diff --git a/package/davfs2/0002-fix-iconv.patch b/package/davfs2/0002-fix-iconv.patch
new file mode 100644
index 0000000000..f2bae8f8e9
--- /dev/null
+++ b/package/davfs2/0002-fix-iconv.patch
@@ -0,0 +1,48 @@
+webdav.c: fix iconv calls
+
+Replace HAVE_ICONV_H by HAVE_ICONV to fix build with iconv indeed
+HAVE_ICONV_H is never set as AC_CHECK_HEADERS is not called to check for
+iconv.h
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://savannah.nongnu.org/bugs/index.php?56178]
+
+diff -Naurp davfs2-1.5.4-orig/src/webdav.c davfs2-1.5.4/src/webdav.c
+--- davfs2-1.5.4-orig/src/webdav.c 2019-04-20 12:12:38.252599230 +0200
++++ davfs2-1.5.4/src/webdav.c 2019-04-20 12:13:33.012925300 +0200
+@@ -25,7 +25,7 @@
+ #ifdef HAVE_FCNTL_H
+ #include <fcntl.h>
+ #endif
+-#ifdef HAVE_ICONV_H
++#ifdef HAVE_ICONV
+ #include <iconv.h>
+ #endif
+ #ifdef HAVE_LANGINFO_H
+@@ -231,7 +231,7 @@ static int initialized;
+ Needed by ssl_verify() which may be called at any time. */
+ static int have_terminal;
+
+-#ifdef HAVE_ICONV_H
++#ifdef HAVE_ICONV
+ /* Handle to convert character encoding from utf-8 to LC_CTYPE.
+ If NULL no conversion is done. */
+ static iconv_t from_utf_8;
+@@ -264,7 +264,7 @@ static char **cookie_list;
+ /* Private function prototypes and inline functions */
+ /*==================================================*/
+
+-#ifdef HAVE_ICONV_H
++#ifdef HAVE_ICONV
+ static void
+ convert(char **s, iconv_t conv);
+ #endif
+@@ -337,7 +337,7 @@ dav_init_webdav(const dav_args *args)
+ if (args->neon_debug & ~NE_DBG_HTTPPLAIN)
+ syslog(LOG_MAKEPRI(LOG_DAEMON, LOG_DEBUG), "Initializing webdav");
+
+-#ifdef HAVE_ICONV_H
++#ifdef HAVE_ICONV
+ char *lc_charset = nl_langinfo(CODESET);
+ if (lc_charset && strcasecmp(lc_charset, "UTF-8") != 0) {
+ from_utf_8 = iconv_open(lc_charset, "UTF-8");
diff --git a/package/davfs2/davfs2.mk b/package/davfs2/davfs2.mk
index c1f8477f8b..f2b2fdbe41 100644
--- a/package/davfs2/davfs2.mk
+++ b/package/davfs2/davfs2.mk
@@ -9,9 +9,13 @@ DAVFS2_SITE = http://download.savannah.nongnu.org/releases/davfs2
DAVFS2_LICENSE = GPL-3.0+
DAVFS2_LICENSE_FILES = COPYING
-DAVFS2_DEPENDENCIES = neon
+DAVFS2_DEPENDENCIES = \
+ neon \
+ $(if $(BR2_PACKAGE_LIBICONV),libiconv) \
+ $(TARGET_NLS_DEPENDENCIES)
DAVFS2_CONF_ENV += \
- ac_cv_path_NEON_CONFIG=$(STAGING_DIR)/usr/bin/neon-config
+ ac_cv_path_NEON_CONFIG=$(STAGING_DIR)/usr/bin/neon-config \
+ LIBS=$(TARGET_NLS_LIBS)
$(eval $(autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] package/davfs2: add optional dependency on iconv and NLS
2019-04-20 10:25 ` [Buildroot] [PATCH 2/2] package/davfs2: add optional dependency on iconv and NLS Fabrice Fontaine
@ 2019-04-22 20:30 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-04-22 20:30 UTC (permalink / raw)
To: buildroot
On Sat, 20 Apr 2019 12:25:28 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/ac2c39a7300fbdd069ac5504148ccb2b065fbf8e
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/davfs2/0002-fix-iconv.patch | 48 +++++++++++++++++++++++++++++
> package/davfs2/davfs2.mk | 8 +++--
> 2 files changed, 54 insertions(+), 2 deletions(-)
> create mode 100644 package/davfs2/0002-fix-iconv.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-22 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-20 10:25 [Buildroot] [PATCH 1/2] package/neon: add NLS dependencies Fabrice Fontaine
2019-04-20 10:25 ` [Buildroot] [PATCH 2/2] package/davfs2: add optional dependency on iconv and NLS Fabrice Fontaine
2019-04-22 20:30 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.