* [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
@ 2019-04-22 20:08 ` Thomas Petazzoni
2019-04-22 20:30 ` Yann E. MORIN
2019-04-26 13:01 ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage Thomas Petazzoni
` (5 subsequent siblings)
6 siblings, 2 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2019-04-22 20:08 UTC (permalink / raw)
To: buildroot
In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
LINUX_BUILD_CMDS"), we changed LINUX_BUILD_CMDS to essentially do:
make all $(LINUX_TARGET_NAME)
Unfortunately, it turns out that it breaks the build of a number of
defconfigs, with errors such as:
fixdep: error opening file: arch/xtensa/boot/lib/.inftrees.o.d: No such file or directory
Calling "all" and "$(LINUX_TARGET_NAME)" as separate make invocations
avoids this problem, and fixes the build of several defconfigs.
Fixes:
ts7680_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339583
qemu_xtensa_lx60_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339553
roseapplepi_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339564
qemu_xtensa_lx60_nommu_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339554
qemu_ppc64_e5500_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339539
freescale_t2080_qds_rdb_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339455
arcturus_ucp1020_defconfig
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339399
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
linux/linux.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/linux/linux.mk b/linux/linux.mk
index 1eac3287ab..dca3d63cd9 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -444,7 +444,8 @@ define LINUX_BUILD_CMDS
$(foreach dts,$(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_DTS_PATH)), \
cp -f $(dts) $(LINUX_ARCH_PATH)/boot/dts/
)
- $(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all $(LINUX_TARGET_NAME)
+ $(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all
+ $(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_TARGET_NAME)
$(LINUX_BUILD_DTB)
$(LINUX_APPEND_DTB)
endef
--
2.20.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets
2019-04-22 20:08 ` [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets Thomas Petazzoni
@ 2019-04-22 20:30 ` Yann E. MORIN
2019-04-26 13:01 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Yann E. MORIN @ 2019-04-22 20:30 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
> In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), we changed LINUX_BUILD_CMDS to essentially do:
>
> make all $(LINUX_TARGET_NAME)
>
> Unfortunately, it turns out that it breaks the build of a number of
> defconfigs, with errors such as:
>
> fixdep: error opening file: arch/xtensa/boot/lib/.inftrees.o.d: No such file or directory
>
> Calling "all" and "$(LINUX_TARGET_NAME)" as separate make invocations
> avoids this problem, and fixes the build of several defconfigs.
[--SNIP--]
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 1eac3287ab..dca3d63cd9 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -444,7 +444,8 @@ define LINUX_BUILD_CMDS
> $(foreach dts,$(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_DTS_PATH)), \
> cp -f $(dts) $(LINUX_ARCH_PATH)/boot/dts/
> )
> - $(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all $(LINUX_TARGET_NAME)
> + $(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) all
Usually, it is not necessary to specify the 'all' target, as this is the
default. So, I would just drop it.
I don't have a striong feeling either way, though, and I can see value
in aving an explicit 'all' call.
However, What I'd like to see added is a comment that states we can't
have a single call:
# Having 'all' and '$(LINUX_TARGET_NAME)' in the same call is not parallel-safe
(so that we do not try to "simplify" it back in the future.)
Otherwise:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> + $(LINUX_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_TARGET_NAME)
> $(LINUX_BUILD_DTB)
> $(LINUX_APPEND_DTB)
> endef
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets
2019-04-22 20:08 ` [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets Thomas Petazzoni
2019-04-22 20:30 ` Yann E. MORIN
@ 2019-04-26 13:01 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Peter Korsgaard @ 2019-04-26 13:01 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> In commit ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), we changed LINUX_BUILD_CMDS to essentially do:
> make all $(LINUX_TARGET_NAME)
> Unfortunately, it turns out that it breaks the build of a number of
> defconfigs, with errors such as:
> fixdep: error opening file: arch/xtensa/boot/lib/.inftrees.o.d: No such file or directory
> Calling "all" and "$(LINUX_TARGET_NAME)" as separate make invocations
> avoids this problem, and fixes the build of several defconfigs.
> Fixes:
> ts7680_defconfig
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339583
> qemu_xtensa_lx60_defconfig
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339553
> roseapplepi_defconfig
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339564
> qemu_xtensa_lx60_nommu_defconfig
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339554
> qemu_ppc64_e5500_defconfig
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339539
> freescale_t2080_qds_rdb_defconfig
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339455
> arcturus_ucp1020_defconfig
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339399
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
2019-04-22 20:08 ` [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets Thomas Petazzoni
@ 2019-04-22 20:08 ` Thomas Petazzoni
2019-04-22 20:35 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: " Thomas Petazzoni
` (4 subsequent siblings)
6 siblings, 2 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2019-04-22 20:08 UTC (permalink / raw)
To: buildroot
Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
LINUX_BUILD_CMDS"), the Linux kernel build for beaglebone_defconfig
builds more things, including some .itb files, which require mkimage
with FIT support.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339433
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
configs/beaglebone_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configs/beaglebone_defconfig b/configs/beaglebone_defconfig
index 2d9fba57dd..b4f152fd69 100644
--- a/configs/beaglebone_defconfig
+++ b/configs/beaglebone_defconfig
@@ -26,3 +26,5 @@ BR2_TARGET_UBOOT_SPL_NAME="MLO"
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
+BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y
--
2.20.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage Thomas Petazzoni
@ 2019-04-22 20:35 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Yann E. MORIN @ 2019-04-22 20:35 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for beaglebone_defconfig
> builds more things, including some .itb files, which require mkimage
> with FIT support.
>
> Fixes:
>
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339433
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> configs/beaglebone_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/beaglebone_defconfig b/configs/beaglebone_defconfig
> index 2d9fba57dd..b4f152fd69 100644
> --- a/configs/beaglebone_defconfig
> +++ b/configs/beaglebone_defconfig
> @@ -26,3 +26,5 @@ BR2_TARGET_UBOOT_SPL_NAME="MLO"
> BR2_PACKAGE_HOST_DOSFSTOOLS=y
> BR2_PACKAGE_HOST_GENIMAGE=y
> BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> +BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage Thomas Petazzoni
2019-04-22 20:35 ` Yann E. MORIN
@ 2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Peter Korsgaard @ 2019-04-26 13:02 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for beaglebone_defconfig
> builds more things, including some .itb files, which require mkimage
> with FIT support.
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339433
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: kernel build needs mkimage
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
2019-04-22 20:08 ` [Buildroot] [PATCH 1/5] linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets Thomas Petazzoni
2019-04-22 20:08 ` [Buildroot] [PATCH 2/5] configs/beaglebone: kernel build needs mkimage Thomas Petazzoni
@ 2019-04-22 20:08 ` Thomas Petazzoni
2019-04-22 20:36 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: " Thomas Petazzoni
` (3 subsequent siblings)
6 siblings, 2 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2019-04-22 20:08 UTC (permalink / raw)
To: buildroot
Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
LINUX_BUILD_CMDS"), the Linux kernel build for
qemu_nios2_10m50_defconfig builds an image format that needs mkimage.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339537
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
configs/qemu_nios2_10m50_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/qemu_nios2_10m50_defconfig b/configs/qemu_nios2_10m50_defconfig
index d7e7c335a3..c07abc3715 100644
--- a/configs/qemu_nios2_10m50_defconfig
+++ b/configs/qemu_nios2_10m50_defconfig
@@ -8,3 +8,6 @@ BR2_TARGET_ROOTFS_INITRAMFS=y
# Linux headers same as kernel, a 4.19 series
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
--
2.20.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: " Thomas Petazzoni
@ 2019-04-22 20:36 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Yann E. MORIN @ 2019-04-22 20:36 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for
> qemu_nios2_10m50_defconfig builds an image format that needs mkimage.
>
> Fixes:
>
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339537
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> configs/qemu_nios2_10m50_defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configs/qemu_nios2_10m50_defconfig b/configs/qemu_nios2_10m50_defconfig
> index d7e7c335a3..c07abc3715 100644
> --- a/configs/qemu_nios2_10m50_defconfig
> +++ b/configs/qemu_nios2_10m50_defconfig
> @@ -8,3 +8,6 @@ BR2_TARGET_ROOTFS_INITRAMFS=y
>
> # Linux headers same as kernel, a 4.19 series
> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
> +
> +# Kernel needs mkimage
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: " Thomas Petazzoni
2019-04-22 20:36 ` Yann E. MORIN
@ 2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Peter Korsgaard @ 2019-04-26 13:02 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for
> qemu_nios2_10m50_defconfig builds an image format that needs mkimage.
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339537
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: kernel build needs mkimage
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
` (2 preceding siblings ...)
2019-04-22 20:08 ` [Buildroot] [PATCH 3/5] configs/qemu_nios2_10m50: " Thomas Petazzoni
@ 2019-04-22 20:08 ` Thomas Petazzoni
2019-04-22 20:36 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
2019-04-22 20:08 ` [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: " Thomas Petazzoni
` (2 subsequent siblings)
6 siblings, 2 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2019-04-22 20:08 UTC (permalink / raw)
To: buildroot
Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
LINUX_BUILD_CMDS"), the Linux kernel build for
qemu_ppc_mpc8544ds_defconfig builds an image format that needs
mkimage.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339543
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
configs/qemu_ppc_mpc8544ds_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/qemu_ppc_mpc8544ds_defconfig b/configs/qemu_ppc_mpc8544ds_defconfig
index d6ebef7561..98985b7b76 100644
--- a/configs/qemu_ppc_mpc8544ds_defconfig
+++ b/configs/qemu_ppc_mpc8544ds_defconfig
@@ -23,3 +23,6 @@ BR2_LINUX_KERNEL_VMLINUX=y
# Serial port config
BR2_TARGET_GENERIC_GETTY=y
BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
--
2.20.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: " Thomas Petazzoni
@ 2019-04-22 20:36 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Yann E. MORIN @ 2019-04-22 20:36 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for
> qemu_ppc_mpc8544ds_defconfig builds an image format that needs
> mkimage.
>
> Fixes:
>
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339543
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> configs/qemu_ppc_mpc8544ds_defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configs/qemu_ppc_mpc8544ds_defconfig b/configs/qemu_ppc_mpc8544ds_defconfig
> index d6ebef7561..98985b7b76 100644
> --- a/configs/qemu_ppc_mpc8544ds_defconfig
> +++ b/configs/qemu_ppc_mpc8544ds_defconfig
> @@ -23,3 +23,6 @@ BR2_LINUX_KERNEL_VMLINUX=y
> # Serial port config
> BR2_TARGET_GENERIC_GETTY=y
> BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
> +
> +# Kernel needs mkimage
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: " Thomas Petazzoni
2019-04-22 20:36 ` Yann E. MORIN
@ 2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Peter Korsgaard @ 2019-04-26 13:02 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for
> qemu_ppc_mpc8544ds_defconfig builds an image format that needs
> mkimage.
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339543
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: kernel build needs mkimage
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
` (3 preceding siblings ...)
2019-04-22 20:08 ` [Buildroot] [PATCH 4/5] configs/qemu_ppc_mpc8544ds: " Thomas Petazzoni
@ 2019-04-22 20:08 ` Thomas Petazzoni
2019-04-22 20:37 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
2019-04-22 20:34 ` [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Yann E. MORIN
2019-04-24 20:47 ` Thomas Petazzoni
6 siblings, 2 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2019-04-22 20:08 UTC (permalink / raw)
To: buildroot
Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
LINUX_BUILD_CMDS"), the Linux kernel build for
qemu_ppc_virtex_ml507_defconfig builds an image format that needs
mkimage.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/199339544
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
configs/qemu_ppc_virtex_ml507_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/qemu_ppc_virtex_ml507_defconfig b/configs/qemu_ppc_virtex_ml507_defconfig
index c71465dd56..eddaf3558a 100644
--- a/configs/qemu_ppc_virtex_ml507_defconfig
+++ b/configs/qemu_ppc_virtex_ml507_defconfig
@@ -21,3 +21,6 @@ BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/ppc-virtex-ml507/linux.config"
BR2_LINUX_KERNEL_VMLINUX=y
BR2_LINUX_KERNEL_DTS_SUPPORT=y
BR2_LINUX_KERNEL_INTREE_DTS_NAME="virtex440-ml507"
+
+# Kernel needs mkimage
+BR2_PACKAGE_HOST_UBOOT_TOOLS=y
--
2.20.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: " Thomas Petazzoni
@ 2019-04-22 20:37 ` Yann E. MORIN
2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Yann E. MORIN @ 2019-04-22 20:37 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for
> qemu_ppc_virtex_ml507_defconfig builds an image format that needs
> mkimage.
>
> Fixes:
>
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339544
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> configs/qemu_ppc_virtex_ml507_defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configs/qemu_ppc_virtex_ml507_defconfig b/configs/qemu_ppc_virtex_ml507_defconfig
> index c71465dd56..eddaf3558a 100644
> --- a/configs/qemu_ppc_virtex_ml507_defconfig
> +++ b/configs/qemu_ppc_virtex_ml507_defconfig
> @@ -21,3 +21,6 @@ BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/ppc-virtex-ml507/linux.config"
> BR2_LINUX_KERNEL_VMLINUX=y
> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> BR2_LINUX_KERNEL_INTREE_DTS_NAME="virtex440-ml507"
> +
> +# Kernel needs mkimage
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: kernel build needs mkimage
2019-04-22 20:08 ` [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: " Thomas Petazzoni
2019-04-22 20:37 ` Yann E. MORIN
@ 2019-04-26 13:02 ` Peter Korsgaard
1 sibling, 0 replies; 18+ messages in thread
From: Peter Korsgaard @ 2019-04-26 13:02 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Following ffbe46a5295ce4e0442728f2ad3e19afa7eaa8ed ("linux: simplify
> LINUX_BUILD_CMDS"), the Linux kernel build for
> qemu_ppc_virtex_ml507_defconfig builds an image format that needs
> mkimage.
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/199339544
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
` (4 preceding siblings ...)
2019-04-22 20:08 ` [Buildroot] [PATCH 5/5] configs/qemu_ppc_virtex_ml507: " Thomas Petazzoni
@ 2019-04-22 20:34 ` Yann E. MORIN
2019-04-24 20:47 ` Thomas Petazzoni
6 siblings, 0 replies; 18+ messages in thread
From: Yann E. MORIN @ 2019-04-22 20:34 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2019-04-22 22:08 +0200, Thomas Petazzoni spake thusly:
> - Due to calling "make all", a little bit more might get built, and
> sometimes this "little bit more" needs mkimage, so we add
> host-uboot-tools to the defconfig. This is enough as linux/linux.mk
> automatically adds host-uboot-tools to its dependency if it's
> enabled. I hesitated with adding an explicit
> BR2_LINUX_KERNEL_NEEDS_HOST_UBOOT_TOOLS option, let me know if this
> sounds better or if the proposed solution in this patch series is
> good enough.
Ithink the NEEDS_FOO options are only interesting when the host package
does not have a kconfig option of its own.
In this case, I think it is correct to do as you did.
If linux did not have a conditional dependency on host-uboot-tools, then
it should be added, rather than add a NEEDS_HOST_UBOOT_TOOLS.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification
2019-04-22 20:08 [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Thomas Petazzoni
` (5 preceding siblings ...)
2019-04-22 20:34 ` [Buildroot] [PATCH 0/5] Fix fallouts from LINUX_BUILD_CMDS simplification Yann E. MORIN
@ 2019-04-24 20:47 ` Thomas Petazzoni
6 siblings, 0 replies; 18+ messages in thread
From: Thomas Petazzoni @ 2019-04-24 20:47 UTC (permalink / raw)
To: buildroot
On Mon, 22 Apr 2019 22:08:24 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Thomas Petazzoni (5):
> linux: split calling "all" and "$(LINUX_TARGET_NAME)" targets
> configs/beaglebone: kernel build needs mkimage
> configs/qemu_nios2_10m50: kernel build needs mkimage
> configs/qemu_ppc_mpc8544ds: kernel build needs mkimage
> configs/qemu_ppc_virtex_ml507: kernel build needs mkimage
I've applied the series, after adding a comment in linux.mk in PATCH
1/5, as suggested by Yann.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 18+ messages in thread