[pci:pci/hotplug 4/5] include/linux/pci_hotplug.h:145:1: error: expected identifier or '(' before '{' token

[pci:pci/hotplug 4/5] include/linux/pci_hotplug.h:145:1: error: expected identifier or '(' before '{' token

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3294 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
head:   d98ba96a72ca1a1dd9d2f3a321e64bac3d94bd39
commit: 93395b9ebeb0cfee5e5c617ec44d249d19439126 [4/5] PCI / ACPI: Remove the need for 'struct hotplug_params'
config: xtensa-common_defconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 93395b9ebeb0cfee5e5c617ec44d249d19439126
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


All errors (new ones prefixed by >>):

   In file included from drivers/pci/pci.c:30:
>> include/linux/pci_hotplug.h:145:1: error: expected identifier or '(' before '{' token
    {
    ^

vim +145 include/linux/pci_hotplug.h

e22b73501 drivers/pci/hotplug/pci_hotplug.h Kenji Kaneshige   2006-05-02  132  
783c49fc5 drivers/pci/hotplug/pci_hotplug.h Kristen Accardi   2006-03-03  133  #ifdef CONFIG_ACPI
8b48463f8 include/linux/pci_hotplug.h       Lv Zheng          2013-12-03  134  #include <linux/acpi.h>
93395b9eb include/linux/pci_hotplug.h       Alexandru Gagniuc 2019-04-19  135  int pci_acpi_program_hp_params(struct pci_dev *dev,
93395b9eb include/linux/pci_hotplug.h       Alexandru Gagniuc 2019-04-19  136  			       const struct hotplug_program_ops *hp_ops);
5352a44a5 include/linux/pci_hotplug.h       Mika Westerberg   2018-05-23  137  bool pciehp_is_native(struct pci_dev *bridge);
6f77fa494 include/linux/pci_hotplug.h       Mika Westerberg   2018-05-23  138  int acpi_get_hp_hw_control_from_firmware(struct pci_dev *bridge);
90cc0c3cc include/linux/pci_hotplug.h       Mika Westerberg   2018-05-31  139  bool shpchp_is_native(struct pci_dev *bridge);
e8c331e96 include/linux/pci_hotplug.h       Kenji Kaneshige   2008-12-17  140  int acpi_pci_check_ejectable(struct pci_bus *pbus, acpi_handle handle);
7f5386693 include/linux/pci_hotplug.h       Alex Chiang       2009-09-10  141  int acpi_pci_detect_ejectable(acpi_handle handle);
8838400db include/linux/pci_hotplug.h       Bjorn Helgaas     2009-09-14  142  #else
93395b9eb include/linux/pci_hotplug.h       Alexandru Gagniuc 2019-04-19  143  int pci_acpi_program_hp_params(struct pci_dev *dev,
93395b9eb include/linux/pci_hotplug.h       Alexandru Gagniuc 2019-04-19  144  			       const struct hotplug_program_ops *hp_ops);
8838400db include/linux/pci_hotplug.h       Bjorn Helgaas     2009-09-14 @145  {
8838400db include/linux/pci_hotplug.h       Bjorn Helgaas     2009-09-14  146  	return -ENODEV;
8838400db include/linux/pci_hotplug.h       Bjorn Helgaas     2009-09-14  147  }
96a621e01 include/linux/pci_hotplug.h       Mika Westerberg   2018-05-24  148  

:::::: The code at line 145 was first introduced by commit
:::::: 8838400db5193c37588813c2eb1249b821781950 PCI hotplug: add pci_configure_slot()

:::::: TO: Bjorn Helgaas <bjorn.helgaas@hp.com>
:::::: CC: Jesse Barnes <jbarnes@virtuousgeek.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 10630 bytes --]

Re: [pci:pci/hotplug 4/5] include/linux/pci_hotplug.h:145:1: error: expected identifier or '(' before '{' token

[Bjorn Helgaas]

On Tue, Apr 23, 2019 at 05:19:48AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head:   d98ba96a72ca1a1dd9d2f3a321e64bac3d94bd39
> commit: 93395b9ebeb0cfee5e5c617ec44d249d19439126 [4/5] PCI / ACPI: Remove the need for 'struct hotplug_params'
> config: xtensa-common_defconfig (attached as .config)
> compiler: xtensa-linux-gcc (GCC) 8.1.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 93395b9ebeb0cfee5e5c617ec44d249d19439126
>         # save the attached .config to linux build tree
>         GCC_VERSION=8.1.0 make.cross ARCH=xtensa 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/pci/pci.c:30:
> >> include/linux/pci_hotplug.h:145:1: error: expected identifier or '(' before '{' token
>     {
>     ^

I fixed this and updated the pci/hotplug branch.

Bjorn