[PATCH] rcu/tree_exp: cleanup initialized but not used rdp

[PATCH] rcu/tree_exp: cleanup initialized but not used rdp

[Jiang Biao]

rdp is initialized but never used in synchronize_rcu_expedited(),
just remove it.

Signed-off-by: Jiang Biao <benbjiang@tencent.com>
---
 kernel/rcu/tree_exp.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
index 4c2a0189e748..5772612379e4 100644
--- a/kernel/rcu/tree_exp.h
+++ b/kernel/rcu/tree_exp.h
@@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
  */
 void synchronize_rcu_expedited(void)
 {
-	struct rcu_data *rdp;
 	struct rcu_exp_work rew;
 	struct rcu_node *rnp;
 	unsigned long s;
@@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
 	}
 
 	/* Wait for expedited grace period to complete. */
-	rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
 	rnp = rcu_get_root();
 	wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
 		   sync_exp_work_done(s));
-- 
2.17.2 (Apple Git-113)

Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp

[Paul E. McKenney]

On Tue, Apr 23, 2019 at 09:21:55AM +0800, Jiang Biao wrote:
> rdp is initialized but never used in synchronize_rcu_expedited(),
> just remove it.
> 
> Signed-off-by: Jiang Biao <benbjiang@tencent.com>

I queued and pushed both patches for testing and review, good eyes,
thank you!  I reworded the subject and commit logs, so could you please
check to make sure that I didn't mess anything up?

							Thanx, Paul

> ---
>  kernel/rcu/tree_exp.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> index 4c2a0189e748..5772612379e4 100644
> --- a/kernel/rcu/tree_exp.h
> +++ b/kernel/rcu/tree_exp.h
> @@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
>   */
>  void synchronize_rcu_expedited(void)
>  {
> -	struct rcu_data *rdp;
>  	struct rcu_exp_work rew;
>  	struct rcu_node *rnp;
>  	unsigned long s;
> @@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
>  	}
>  
>  	/* Wait for expedited grace period to complete. */
> -	rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
>  	rnp = rcu_get_root();
>  	wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
>  		   sync_exp_work_done(s));
> -- 
> 2.17.2 (Apple Git-113)
> 

Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp(Internet mail)

[benbjiang(蒋彪)]

> 在 2019年4月23日，下午4:06，Paul E. McKenney <paulmck@linux.ibm.com> 写道：
> 
> On Tue, Apr 23, 2019 at 09:21:55AM +0800, Jiang Biao wrote:
>> rdp is initialized but never used in synchronize_rcu_expedited(),
>> just remove it.
>> 
>> Signed-off-by: Jiang Biao <benbjiang@tencent.com>
> 
> I queued and pushed both patches for testing and review, good eyes,
> thank you!  I reworded the subject and commit logs, so could you please
> check to make sure that I didn't mess anything up?
> 
> 							Thanx, Paul
> 
Already checked, everything’s good to me. Thanks a lot.
Jiang,

>> ---
>> kernel/rcu/tree_exp.h | 2 --
>> 1 file changed, 2 deletions(-)
>> 
>> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
>> index 4c2a0189e748..5772612379e4 100644
>> --- a/kernel/rcu/tree_exp.h
>> +++ b/kernel/rcu/tree_exp.h
>> @@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
>>  */
>> void synchronize_rcu_expedited(void)
>> {
>> -	struct rcu_data *rdp;
>> 	struct rcu_exp_work rew;
>> 	struct rcu_node *rnp;
>> 	unsigned long s;
>> @@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
>> 	}
>> 
>> 	/* Wait for expedited grace period to complete. */
>> -	rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
>> 	rnp = rcu_get_root();
>> 	wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
>> 		   sync_exp_work_done(s));
>> -- 
>> 2.17.2 (Apple Git-113)
>> 
> 
>