From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
dsahern@gmail.com
Subject: Re: [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices
Date: Tue, 23 Apr 2019 08:31:08 +0200 [thread overview]
Message-ID: <20190423063108.GB2677@nanopsycho.orion> (raw)
In-Reply-To: <20190422122338.3e1049a4@cakuba.netronome.com>
Mon, Apr 22, 2019 at 09:23:38PM CEST, jakub.kicinski@netronome.com wrote:
>On Sat, 20 Apr 2019 12:29:14 +0200, Jiri Pirko wrote:
>> - err = ida_alloc(&nsim_bus_dev_ids, GFP_KERNEL);
>> + err = ida_alloc_range(&nsim_bus_dev_ids,
>> + id == ~0 ? 0 : id, id, GFP_KERNEL);
>
>#define for ~0 ?
Sure, but this is remove in patch 15. Is it necessary?
next prev parent reply other threads:[~2019-04-23 6:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 10:29 [patch net-next v2 00/16] netdevsim: impement proper device model Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 01/16] netdevsim: move device registration on bus to be done earlier in init Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 02/16] netdevsim: create devlink instance per netdevsim instance Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 03/16] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 04/16] netdevsim: put netdevsim bus code into separate file Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 05/16] netdevsim: move device registration and related code to bus.c Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 06/16] netdevsim: add stub netdevsim driver implementation Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 07/16] netdevsim: use ida for bus device ids Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 08/16] netdevsim: add bus attributes to add new and delete devices Jiri Pirko
2019-04-22 19:23 ` Jakub Kicinski
2019-04-23 6:29 ` Jiri Pirko
2019-04-23 17:06 ` Jakub Kicinski
2019-04-23 19:09 ` Jiri Pirko
2019-04-22 19:23 ` Jakub Kicinski
2019-04-23 6:31 ` Jiri Pirko [this message]
2019-04-23 17:08 ` Jakub Kicinski
2019-04-20 10:29 ` [patch net-next v2 09/16] netdevsim: rename dev_init/exit() functions and make them independent on ns Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 10/16] netdevsim: merge sdev into dev Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 11/16] netdevsim: generate random switch id instead of using dev id Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 12/16] netdevsim: change debugfs tree topology Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 13/16] netdevsim: implement dev probe/remove skeleton with port initialization Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 14/16] netdevsim: extend device attrs to support port addition and deletion Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 15/16] netdevsim: move netdev creation/destruction to dev probe Jiri Pirko
2019-04-22 19:31 ` Jakub Kicinski
2019-04-23 7:20 ` Jiri Pirko
2019-04-23 17:05 ` Jakub Kicinski
2019-04-23 19:14 ` Jiri Pirko
2019-04-20 10:29 ` [patch net-next v2 16/16] netdevsim: implement ndo_get_devlink_port Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423063108.GB2677@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.