[igt-dev] [PATCH i-g-t] tests/intel-ci: blacklist audio tests

[igt-dev] [PATCH i-g-t] tests/intel-ci: blacklist audio tests

[Simon Ser]

We don't have the required audio splitters installed in CI.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---

This should fix https://bugs.freedesktop.org/show_bug.cgi?id=110499

 tests/intel-ci/blacklist.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index fb182663..1451c0ed 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -108,3 +108,7 @@ igt@i915_suspend@shrink
 igt@.*@.*pipe-d-.*
 igt@.*@.*pipe-e-.*
 igt@.*@.*pipe-f-.*
+###############################################
+# audio: HW not available in CI
+###############################################
+igt@audio@.*
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Chris Wilson]

Before asserting that the HDMI audio loopback works after resume, first
require it to be present before suspend -- as not all machines are setup
with the right HDMI audio capture.

More strictly, one would expect that an audio capture device setup
before suspend will remain functional after resume. An exercise left for
the reader.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110499
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Simon Ser <simon.ser@intel.com>
Cc: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
---
 tests/audio.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/tests/audio.c b/tests/audio.c
index 560876a33..28d18fb29 100644
--- a/tests/audio.c
+++ b/tests/audio.c
@@ -94,7 +94,7 @@ static int input_callback(void *data, short *buffer, int frames)
 	return 0;
 }
 
-static void test_integrity(const char *device_name)
+static bool test_integrity(const char *device_name)
 {
 	struct test_data data;
 	int sampling_rate;
@@ -150,39 +150,35 @@ static void test_integrity(const char *device_name)
 		data.streak = 0;
 
 		ret = alsa_run(data.alsa, RUN_TIMEOUT);
-		igt_assert(ret > 0);
 
 		audio_signal_clean(data.signal);
 		free(data.signal);
 
 		alsa_close_output(data.alsa);
 
-		run = true;
+		run = ret > 0;
 	}
 
-	/* Make sure we tested at least one frequency */
-	igt_assert(run);
-
 	alsa_close_input(data.alsa);
 	free(data.alsa);
+
+	return run;
 }
 
 static void test_suspend_resume_integrity(const char *device_name,
 					  enum igt_suspend_state state,
 					  enum igt_suspend_test test)
 {
-	test_integrity(device_name);
+	/* Make sure we tested at least one frequency */
+	igt_require(test_integrity(device_name));
 
 	igt_system_suspend_autoresume(state, test);
 
-	test_integrity(device_name);
+	igt_assert(test_integrity(device_name));
 }
 
 igt_main
 {
-	igt_subtest("hdmi-integrity")
-		test_integrity("HDMI");
-
 	igt_subtest("hdmi-integrity-after-suspend")
 		test_suspend_resume_integrity("HDMI", SUSPEND_STATE_MEM,
 					      SUSPEND_TEST_NONE);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/intel-ci: blacklist audio tests (rev2)

[Patchwork]

== Series Details ==

Series: tests/intel-ci: blacklist audio tests (rev2)
URL   : https://patchwork.freedesktop.org/series/59817/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5968 -> IGTPW_2899
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59817/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2899 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235 ])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         [PASS][3] -> [INCOMPLETE][4] ([fdo#103927] / [fdo#109720])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/fi-apl-guc/igt@i915_selftest@live_execlists.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/fi-apl-guc/igt@i915_selftest@live_execlists.html

  
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
  [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 


Participating hosts (49 -> 28)
------------------------------

  Missing    (21): fi-kbl-soraka fi-skl-6770hq fi-icl-u2 fi-skl-6260u fi-icl-u3 fi-icl-y fi-blb-e6850 fi-byt-n2820 fi-skl-6600u fi-bwr-2160 fi-kbl-7500u fi-hsw-4770 fi-skl-6700k2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-whl-u fi-skl-iommu fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_4959 -> IGTPW_2899

  CI_DRM_5968: e705fe50400bcbc1df7d3e09891eb4b4c9bf2e4f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2899: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/
  IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

-igt@audio@hdmi-integrity

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Chris Wilson]

Quoting Chris Wilson (2019-04-23 09:09:46)
> Before asserting that the HDMI audio loopback works after resume, first
> require it to be present before suspend -- as not all machines are setup
> with the right HDMI audio capture.
> 
> More strictly, one would expect that an audio capture device setup
> before suspend will remain functional after resume. An exercise left for
> the reader.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110499
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Simon Ser <simon.ser@intel.com>
> Cc: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  tests/audio.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/audio.c b/tests/audio.c
> index 560876a33..28d18fb29 100644
> --- a/tests/audio.c
> +++ b/tests/audio.c
> @@ -94,7 +94,7 @@ static int input_callback(void *data, short *buffer, int frames)
>         return 0;
>  }
>  
> -static void test_integrity(const char *device_name)
> +static bool test_integrity(const char *device_name)
>  {
>         struct test_data data;
>         int sampling_rate;
> @@ -150,39 +150,35 @@ static void test_integrity(const char *device_name)
>                 data.streak = 0;
>  
>                 ret = alsa_run(data.alsa, RUN_TIMEOUT);
> -               igt_assert(ret > 0);
>  
>                 audio_signal_clean(data.signal);
>                 free(data.signal);
>  
>                 alsa_close_output(data.alsa);
>  
> -               run = true;
> +               run = ret > 0;

Should be 
	run |= ret > 0;
as we want any available device.

It could also break after the first success, but that feels like too
much of a change to swallow in one go.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Chris Wilson]

Before asserting that the HDMI audio loopback works after resume, first
require it to be present before suspend -- as not all machines are setup
with the right HDMI audio capture.

More strictly, one would expect that an audio capture device setup
before suspend will remain functional after resume. An exercise left for
the reader.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110499
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Simon Ser <simon.ser@intel.com>
Cc: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
---
 tests/audio.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/tests/audio.c b/tests/audio.c
index 560876a33..842ea22fb 100644
--- a/tests/audio.c
+++ b/tests/audio.c
@@ -94,7 +94,7 @@ static int input_callback(void *data, short *buffer, int frames)
 	return 0;
 }
 
-static void test_integrity(const char *device_name)
+static bool test_integrity(const char *device_name)
 {
 	struct test_data data;
 	int sampling_rate;
@@ -150,39 +150,35 @@ static void test_integrity(const char *device_name)
 		data.streak = 0;
 
 		ret = alsa_run(data.alsa, RUN_TIMEOUT);
-		igt_assert(ret > 0);
 
 		audio_signal_clean(data.signal);
 		free(data.signal);
 
 		alsa_close_output(data.alsa);
 
-		run = true;
+		run |= ret > 0;
 	}
 
-	/* Make sure we tested at least one frequency */
-	igt_assert(run);
-
 	alsa_close_input(data.alsa);
 	free(data.alsa);
+
+	return run;
 }
 
 static void test_suspend_resume_integrity(const char *device_name,
 					  enum igt_suspend_state state,
 					  enum igt_suspend_test test)
 {
-	test_integrity(device_name);
+	/* Make sure we tested at least one frequency */
+	igt_require(test_integrity(device_name));
 
 	igt_system_suspend_autoresume(state, test);
 
-	test_integrity(device_name);
+	igt_assert(test_integrity(device_name));
 }
 
 igt_main
 {
-	igt_subtest("hdmi-integrity")
-		test_integrity("HDMI");
-
 	igt_subtest("hdmi-integrity-after-suspend")
 		test_suspend_resume_integrity("HDMI", SUSPEND_STATE_MEM,
 					      SUSPEND_TEST_NONE);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/intel-ci: blacklist audio tests (rev3)

[Patchwork]

== Series Details ==

Series: tests/intel-ci: blacklist audio tests (rev3)
URL   : https://patchwork.freedesktop.org/series/59817/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5969 -> IGTPW_2900
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59817/revisions/3/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2900 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-gfx:
    - fi-skl-6700k2:      NOTRUN -> [SKIP][1] ([fdo#109271]) +41 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-skl-6700k2/igt@amdgpu/amd_basic@cs-gfx.html

  * igt@amdgpu/amd_cs_nop@sync-fork-compute0:
    - fi-icl-u3:          NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-icl-u3/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html

  * igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
    - fi-skl-6600u:       NOTRUN -> [SKIP][3] ([fdo#109271]) +41 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-skl-6600u/igt@amdgpu/amd_cs_nop@sync-fork-gfx0.html

  * igt@gem_exec_basic@basic-bsd2:
    - fi-icl-u3:          NOTRUN -> [SKIP][4] ([fdo#109276]) +7 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-icl-u3/igt@gem_exec_basic@basic-bsd2.html

  * igt@gem_exec_basic@gtt-bsd1:
    - fi-bxt-j4205:       NOTRUN -> [SKIP][5] ([fdo#109271]) +47 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-bxt-j4205/igt@gem_exec_basic@gtt-bsd1.html

  * igt@gem_exec_parse@basic-rejected:
    - fi-icl-u3:          NOTRUN -> [SKIP][6] ([fdo#109289]) +1 similar issue
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-icl-u3/igt@gem_exec_parse@basic-rejected.html

  * igt@gem_exec_store@basic-bsd2:
    - fi-hsw-4770:        NOTRUN -> [SKIP][7] ([fdo#109271]) +41 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-hsw-4770/igt@gem_exec_store@basic-bsd2.html

  * igt@gem_mmap_gtt@basic-write-cpu-read-gtt:
    - fi-apl-guc:         NOTRUN -> [SKIP][8] ([fdo#109271]) +46 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-apl-guc/igt@gem_mmap_gtt@basic-write-cpu-read-gtt.html

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-icl-y:           [PASS][9] -> [INCOMPLETE][10] ([fdo#107713])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5969/fi-icl-y/igt@i915_module_load@reload-with-fault-injection.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-icl-y/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         NOTRUN -> [INCOMPLETE][11] ([fdo#103927] / [fdo#109720])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-apl-guc/igt@i915_selftest@live_execlists.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-icl-u3:          NOTRUN -> [SKIP][12] ([fdo#109284]) +8 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-icl-u3/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_force_connector_basic@force-connector-state:
    - fi-kbl-7567u:       NOTRUN -> [SKIP][13] ([fdo#109271]) +33 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-kbl-7567u/igt@kms_force_connector_basic@force-connector-state.html

  * igt@kms_force_connector_basic@force-edid:
    - fi-icl-u3:          NOTRUN -> [SKIP][14] ([fdo#109285]) +3 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-icl-u3/igt@kms_force_connector_basic@force-edid.html

  * igt@kms_psr@primary_page_flip:
    - fi-skl-lmem:        NOTRUN -> [SKIP][15] ([fdo#109271]) +37 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-skl-lmem/igt@kms_psr@primary_page_flip.html

  * igt@runner@aborted:
    - fi-apl-guc:         NOTRUN -> [FAIL][16] ([fdo#108622] / [fdo#109720])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/fi-apl-guc/igt@runner@aborted.html

  
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (30 -> 23)
------------------------------

  Additional (8): fi-kbl-7567u fi-apl-guc fi-hsw-4770 fi-bxt-j4205 fi-icl-u3 fi-skl-6700k2 fi-skl-lmem fi-skl-6600u 
  Missing    (15): fi-kbl-soraka fi-hsw-4770r fi-ilk-m540 fi-skl-gvtdvm fi-hsw-4200u fi-skl-guc fi-bsw-cyan fi-bwr-2160 fi-kbl-guc fi-ctg-p8600 fi-kbl-8809g fi-ivb-3770 fi-pnv-d510 fi-bdw-samus fi-kbl-r 


Build changes
-------------

  * IGT: IGT_4959 -> IGTPW_2900

  CI_DRM_5969: 37a2fe0146d5491debdf7e73f2c1e9c72d9a1bec @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2900: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/
  IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

-igt@audio@hdmi-integrity

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2900/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/intel-ci: blacklist audio tests (rev2)

[Patchwork]

== Series Details ==

Series: tests/intel-ci: blacklist audio tests (rev2)
URL   : https://patchwork.freedesktop.org/series/59817/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5968_full -> IGTPW_2899_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59817/revisions/2/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2899_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@audio@hdmi-integrity-after-suspend}:
    - shard-iclb:         [FAIL][1] ([fdo#110499]) -> [SKIP][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb4/igt@audio@hdmi-integrity-after-suspend.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb1/igt@audio@hdmi-integrity-after-suspend.html

  
Known issues
------------

  Here are the changes found in IGTPW_2899_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_auth@unauth-vs-render:
    - shard-apl:          NOTRUN -> [FAIL][3] ([fdo#110467])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-apl4/igt@core_auth@unauth-vs-render.html

  * igt@gem_exec_params@no-blt:
    - shard-iclb:         NOTRUN -> [SKIP][4] ([fdo#109283])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb7/igt@gem_exec_params@no-blt.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [PASS][5] -> [FAIL][6] ([fdo#108686])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb4/igt@gem_tiled_swapping@non-threaded.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb5/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +5 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-apl4/igt@gem_workarounds@suspend-resume.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-apl4/igt@gem_workarounds@suspend-resume.html
    - shard-kbl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#108566])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-kbl7/igt@gem_workarounds@suspend-resume.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-kbl5/igt@gem_workarounds@suspend-resume.html

  * igt@i915_pm_lpsp@edp-native:
    - shard-iclb:         NOTRUN -> [SKIP][11] ([fdo#109301])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb1/igt@i915_pm_lpsp@edp-native.html

  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking:
    - shard-apl:          NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#109278]) +4 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-apl1/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking.html

  * igt@kms_busy@extended-modeset-hang-oldfb-render-e:
    - shard-kbl:          NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#109278]) +2 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-kbl7/igt@kms_busy@extended-modeset-hang-oldfb-render-e.html

  * igt@kms_busy@extended-pageflip-hang-oldfb-render-d:
    - shard-iclb:         NOTRUN -> [SKIP][14] ([fdo#109278]) +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb6/igt@kms_busy@extended-pageflip-hang-oldfb-render-d.html

  * igt@kms_color@pipe-b-degamma:
    - shard-iclb:         NOTRUN -> [FAIL][15] ([fdo#104782])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb3/igt@kms_color@pipe-b-degamma.html

  * igt@kms_content_protection@atomic:
    - shard-iclb:         NOTRUN -> [SKIP][16] ([fdo#109300])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb7/igt@kms_content_protection@atomic.html

  * igt@kms_cursor_crc@cursor-512x512-onscreen:
    - shard-iclb:         NOTRUN -> [SKIP][17] ([fdo#109279])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb7/igt@kms_cursor_crc@cursor-512x512-onscreen.html

  * igt@kms_cursor_edge_walk@pipe-c-128x128-bottom-edge:
    - shard-snb:          NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#109278]) +17 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-snb6/igt@kms_cursor_edge_walk@pipe-c-128x128-bottom-edge.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-iclb:         NOTRUN -> [SKIP][19] ([fdo#109274]) +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
    - shard-iclb:         [PASS][20] -> [FAIL][21] ([fdo#103167]) +10 similar issues
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move:
    - shard-apl:          NOTRUN -> [SKIP][22] ([fdo#109271]) +49 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-apl4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc:
    - shard-iclb:         NOTRUN -> [SKIP][23] ([fdo#109280]) +6 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc.html

  * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
    - shard-glk:          [PASS][24] -> [SKIP][25] ([fdo#109271])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-glk9/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-glk7/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
    - shard-kbl:          NOTRUN -> [FAIL][26] ([fdo#108145])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
    - shard-apl:          NOTRUN -> [FAIL][27] ([fdo#108145])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         [PASS][28] -> [SKIP][29] ([fdo#109441]) +2 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html

  * igt@kms_psr@psr2_primary_blt:
    - shard-iclb:         NOTRUN -> [SKIP][30] ([fdo#109441])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb5/igt@kms_psr@psr2_primary_blt.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][31] -> [FAIL][32] ([fdo#99912])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-apl1/igt@kms_setmode@basic.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-apl2/igt@kms_setmode@basic.html

  * igt@perf_pmu@busy-double-start-vecs0:
    - shard-snb:          NOTRUN -> [SKIP][33] ([fdo#109271]) +98 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-snb7/igt@perf_pmu@busy-double-start-vecs0.html

  * igt@perf_pmu@busy-start-vcs1:
    - shard-iclb:         NOTRUN -> [SKIP][34] ([fdo#109276]) +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb7/igt@perf_pmu@busy-start-vcs1.html

  * igt@prime_nv_pcopy@test2:
    - shard-iclb:         NOTRUN -> [SKIP][35] ([fdo#109291])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb4/igt@prime_nv_pcopy@test2.html

  * igt@prime_nv_pcopy@test3_4:
    - shard-kbl:          NOTRUN -> [SKIP][36] ([fdo#109271]) +17 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-kbl7/igt@prime_nv_pcopy@test3_4.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-apl:          [DMESG-WARN][37] ([fdo#108566]) -> [PASS][38] +5 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-apl8/igt@gem_ctx_isolation@rcs0-s3.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-apl4/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_eio@reset-stress:
    - shard-snb:          [FAIL][39] ([fdo#109661]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-snb5/igt@gem_eio@reset-stress.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-snb7/igt@gem_eio@reset-stress.html

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         [FAIL][41] ([fdo#104097]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb5/igt@i915_pm_rpm@i2c.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb5/igt@i915_pm_rpm@i2c.html

  * igt@kms_atomic_interruptible@universal-setplane-primary:
    - shard-snb:          [SKIP][43] ([fdo#109271]) -> [PASS][44] +4 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-snb6/igt@kms_atomic_interruptible@universal-setplane-primary.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-snb6/igt@kms_atomic_interruptible@universal-setplane-primary.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
    - shard-glk:          [FAIL][45] ([fdo#103167]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render:
    - shard-iclb:         [FAIL][47] ([fdo#103167]) -> [PASS][48] +2 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render.html

  * igt@kms_plane@pixel-format-pipe-a-planes:
    - shard-glk:          [SKIP][49] ([fdo#109271]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-glk7/igt@kms_plane@pixel-format-pipe-a-planes.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-glk9/igt@kms_plane@pixel-format-pipe-a-planes.html

  * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
    - shard-glk:          [SKIP][51] ([fdo#109271] / [fdo#109278]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-glk7/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [SKIP][53] ([fdo#109642]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb1/igt@kms_psr2_su@page_flip.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb2/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][55] ([fdo#109441]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          [FAIL][57] ([fdo#109016]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-kbl7/igt@kms_rotation_crc@multiplane-rotation.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
    - shard-kbl:          [DMESG-FAIL][59] ([fdo#105763]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-kbl7/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-kbl6/igt@kms_rotation_crc@multiplane-rotation-cropping-bottom.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [FAIL][61] ([fdo#100047]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-iclb2/igt@kms_sysfs_edid_timing.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-iclb1/igt@kms_sysfs_edid_timing.html

  
#### Warnings ####

  * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing:
    - shard-snb:          [SKIP][63] ([fdo#109271]) -> [SKIP][64] ([fdo#109271] / [fdo#109278]) +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5968/shard-snb6/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/shard-snb5/igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109301]: https://bugs.freedesktop.org/show_bug.cgi?id=109301
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
  [fdo#110467]: https://bugs.freedesktop.org/show_bug.cgi?id=110467
  [fdo#110499]: https://bugs.freedesktop.org/show_bug.cgi?id=110499
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_4959 -> IGTPW_2899
  * Piglit: piglit_4509 -> None

  CI_DRM_5968: e705fe50400bcbc1df7d3e09891eb4b4c9bf2e4f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2899: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/
  IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2899/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Ser, Simon]

On Tue, 2019-04-23 at 09:09 +0100, Chris Wilson wrote:
> Before asserting that the HDMI audio loopback works after resume, first
> require it to be present before suspend -- as not all machines are setup
> with the right HDMI audio capture.
> 
> More strictly, one would expect that an audio capture device setup
> before suspend will remain functional after resume. An exercise left for
> the reader.

What if audio works without suspend, but breaks with suspend? That new
test makes it less easy to understand whether audio works at all or if
it breaks because of suspend.

Side note, I wouldn't bother too much with patches since all the audio
tests will get replaced by Chamelium audio tests (see my
"tests/kms_chamelium: add dp-audio test" series).

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110499
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Simon Ser <simon.ser@intel.com>
> Cc: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  tests/audio.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/audio.c b/tests/audio.c
> index 560876a33..28d18fb29 100644
> --- a/tests/audio.c
> +++ b/tests/audio.c
> @@ -94,7 +94,7 @@ static int input_callback(void *data, short *buffer, int frames)
>  	return 0;
>  }
>  
> -static void test_integrity(const char *device_name)
> +static bool test_integrity(const char *device_name)
>  {
>  	struct test_data data;
>  	int sampling_rate;
> @@ -150,39 +150,35 @@ static void test_integrity(const char *device_name)
>  		data.streak = 0;
>  
>  		ret = alsa_run(data.alsa, RUN_TIMEOUT);
> -		igt_assert(ret > 0);
>  
>  		audio_signal_clean(data.signal);
>  		free(data.signal);
>  
>  		alsa_close_output(data.alsa);
>  
> -		run = true;
> +		run = ret > 0;
>  	}
>  
> -	/* Make sure we tested at least one frequency */
> -	igt_assert(run);
> -
>  	alsa_close_input(data.alsa);
>  	free(data.alsa);
> +
> +	return run;
>  }
>  
>  static void test_suspend_resume_integrity(const char *device_name,
>  					  enum igt_suspend_state state,
>  					  enum igt_suspend_test test)
>  {
> -	test_integrity(device_name);
> +	/* Make sure we tested at least one frequency */
> +	igt_require(test_integrity(device_name));
>  
>  	igt_system_suspend_autoresume(state, test);
>  
> -	test_integrity(device_name);
> +	igt_assert(test_integrity(device_name));
>  }
>  
>  igt_main
>  {
> -	igt_subtest("hdmi-integrity")
> -		test_integrity("HDMI");
> -
>  	igt_subtest("hdmi-integrity-after-suspend")
>  		test_suspend_resume_integrity("HDMI", SUSPEND_STATE_MEM,
>  					      SUSPEND_TEST_NONE);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Chris Wilson]

Quoting Ser, Simon (2019-04-23 12:45:05)
> On Tue, 2019-04-23 at 09:09 +0100, Chris Wilson wrote:
> > Before asserting that the HDMI audio loopback works after resume, first
> > require it to be present before suspend -- as not all machines are setup
> > with the right HDMI audio capture.
> > 
> > More strictly, one would expect that an audio capture device setup
> > before suspend will remain functional after resume. An exercise left for
> > the reader.
> 
> What if audio works without suspend, but breaks with suspend? That new
> test makes it less easy to understand whether audio works at all or if
> it breaks because of suspend.

That's the test; whether audio continues to work across suspend. It's
the original test, not a new one.

What the igt didn't (and still doesn't) do correctly is verify it has a
working setup; for now we just assume that the driver is fine if igt_alsa
fails. Turns a broken test from "DRIVER FAIL" to skip.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Ser, Simon]

On Tue, 2019-04-23 at 13:00 +0100, Chris Wilson wrote:
> Quoting Ser, Simon (2019-04-23 12:45:05)
> > On Tue, 2019-04-23 at 09:09 +0100, Chris Wilson wrote:
> > > Before asserting that the HDMI audio loopback works after resume, first
> > > require it to be present before suspend -- as not all machines are setup
> > > with the right HDMI audio capture.
> > > 
> > > More strictly, one would expect that an audio capture device setup
> > > before suspend will remain functional after resume. An exercise left for
> > > the reader.
> > 
> > What if audio works without suspend, but breaks with suspend? That new
> > test makes it less easy to understand whether audio works at all or if
> > it breaks because of suspend.
> 
> That's the test; whether audio continues to work across suspend. It's
> the original test, not a new one.
> 
> What the igt didn't (and still doesn't) do correctly is verify it has a
> working setup; for now we just assume that the driver is fine if igt_alsa
> fails. Turns a broken test from "DRIVER FAIL" to skip.

Oh, I mixed up igt_assert and igt_require again.

This patch does remove the hdmi-integrity test entirely though. We
probably want to keep it (or rather: we'd probably want to keep it if
it wasn't being removed in a patch that'll soon be merged).
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Jani Nikula]

On Tue, 23 Apr 2019, "Ser, Simon" <simon.ser@intel.com> wrote:
> Oh, I mixed up igt_assert and igt_require again.

Don't worry, I still have to look it up every time.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] audio: Avoid test_integrity failing if there's no HW support

[Ser, Simon]

On Tue, 2019-04-23 at 13:09 +0000, Ser, Simon wrote:
> On Tue, 2019-04-23 at 13:00 +0100, Chris Wilson wrote:
> > Quoting Ser, Simon (2019-04-23 12:45:05)
> > > On Tue, 2019-04-23 at 09:09 +0100, Chris Wilson wrote:
> > > > Before asserting that the HDMI audio loopback works after
> > > > resume, first
> > > > require it to be present before suspend -- as not all machines
> > > > are setup
> > > > with the right HDMI audio capture.
> > > > 
> > > > More strictly, one would expect that an audio capture device
> > > > setup
> > > > before suspend will remain functional after resume. An exercise
> > > > left for
> > > > the reader.
> > > 
> > > What if audio works without suspend, but breaks with suspend?
> > > That new
> > > test makes it less easy to understand whether audio works at all
> > > or if
> > > it breaks because of suspend.
> > 
> > That's the test; whether audio continues to work across suspend.
> > It's
> > the original test, not a new one.
> > 
> > What the igt didn't (and still doesn't) do correctly is verify it
> > has a
> > working setup; for now we just assume that the driver is fine if
> > igt_alsa
> > fails. Turns a broken test from "DRIVER FAIL" to skip.
> 
> Oh, I mixed up igt_assert and igt_require again.
> 
> This patch does remove the hdmi-integrity test entirely though. We
> probably want to keep it (or rather: we'd probably want to keep it if
> it wasn't being removed in a patch that'll soon be merged).

Old audio tests have now been removed from master. This patch is no
longer applicable.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev